From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA5B8A034E; Thu, 7 Nov 2019 15:08:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 739AC1BED5; Thu, 7 Nov 2019 15:08:02 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70050.outbound.protection.outlook.com [40.107.7.50]) by dpdk.org (Postfix) with ESMTP id B29C62BF4 for ; Thu, 7 Nov 2019 15:08:00 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DoTRFabelAjo/7/+2KexliT4MG6Kl9k+jf+ivvEWYa5I05aLlnRHMSucDXVTAsel7xjJl7K/2FA+Xbk0IKGdSvPVwa5peQqOTaEeRSsT10ddesvFOG/r3bc/IbfqnMEce6CPsqBKeRq7ycMBqx320m46vD2GYo2mE2M3xIKjUgIjbtJ3ZO/WZca1plJrX6i9LJV7rCMflOYXjxKy5TWUHwJ8tiMYbggpewYnEKMbD+QdI8Lx8F2IIIQshOGgS9awmsyPr13yz/l72VeVXnAFWl/lmrvw3Jru21ekOcGb/vAHfNxljWRL7yBpEnTa14SRADCBKZ+gN5VnxBW9M5kjGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=grrW5s3VvNzjmHPL2bPHHVy951DyMpEyi0ESsxuN9w4=; b=geqj/DoUOFbWfu1f0sKgYxqSNtt7BthpbP2/UHKVkLHgMCXjN5EqWXpCq4kR4lcnCi/pqvoHllapO3RP+2Ux0yHOMT2mRkErC+xMh8q58BsUzcWjAyeDpEp0NK3VqxtiNb8jO9XmiQKMQPAQYHNFMm7o8jYORktmDCkVYoL/QS2rdmTCqPPDboK3+sMhrI/hV0uAkJ/j2VKBNUHR85wKA96HZEd2uQU2N0FBrGzyo3+apd1wx+l+q1VrMAdfpuLPQ3hwsklxAZFCiCn6DfjYWFRC/YuyNaJaw3y2B859am5G8+X/4v83kxemdsCem7zmf8M7oI+UNJIUJHsd9ek+nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=grrW5s3VvNzjmHPL2bPHHVy951DyMpEyi0ESsxuN9w4=; b=QlMezlhzUk66bME2acT0e1PBG7Ngn4K9n5ZW2ojbSR4DEfAOA1aZu2urp9QWUkfwGB2KUliATObFQvGF2PBD/ZpSl3oKlcYUQyubOdrXEXEQZOONcrnEsAH+KJimnLjP4d4pj6ygklPAjiYFGpv56xv5O59LI6KVjGKc2Gq2/ps= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3297.eurprd05.prod.outlook.com (10.170.125.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.23; Thu, 7 Nov 2019 14:07:59 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::9940:94f2:db23:aa2c]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::9940:94f2:db23:aa2c%4]) with mapi id 15.20.2408.028; Thu, 7 Nov 2019 14:07:59 +0000 From: Slava Ovsiienko To: Dekel Peled , Matan Azrad , Shahaf Shuler , Ori Kam CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: allow jump to group lower than current Thread-Index: AQHVlV9SSpEfDMtEwUizt8Av0WUbkqd/vqoA Date: Thu, 7 Nov 2019 14:07:59 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.67.35.250] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: a818c96d-50a5-4f7d-0d6f-08d7638be56e x-ms-traffictypediagnostic: AM4PR05MB3297:|AM4PR05MB3297: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2512; x-forefront-prvs: 0214EB3F68 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(376002)(39830400003)(396003)(136003)(13464003)(189003)(199004)(33656002)(99286004)(110136005)(5660300002)(66066001)(316002)(52536014)(76116006)(66946007)(71200400001)(66476007)(66556008)(64756008)(66446008)(6506007)(186003)(26005)(71190400001)(102836004)(53546011)(7696005)(76176011)(14444005)(256004)(476003)(11346002)(446003)(486006)(6116002)(3846002)(74316002)(7736002)(478600001)(14454004)(305945005)(6636002)(25786009)(81166006)(6246003)(4326008)(8676002)(81156014)(86362001)(6436002)(55016002)(8936002)(229853002)(2906002)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3297; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kyUrq3K1DlmCzXUbUhhnYfjfpI61Z4ToGdQLgjJkIxrjMvPiTLeON/LOXofzcskzD+Qe/DkUSUTl+LNbICk5qC+NUkd5b/2bIZ2N+qiQrr3L3Z6E37wMQhmv8YamoGi4a6SDrN25Y9/9e2rriWx3Lf2hzSCUWXjhi7wORCBT0fGrHYWax3T6pm6hqamSmTluLIzo7biJwK0holZ13WKDpi9ITQJW3acHC1naMtwFwQUpS6LQdvA8+KvXrXCAgWwtzrUscgM8camp7R1q6sq5Ly7olHuvLQGvXOGfQtoRqOxXXpJ0s4P04IghK32CTi2SwIH9HuURxrelJpsVcpduWplnUZ/z5GpNzDNkMx6O8QQL8o5ujPF1PWrQfsZXcpnt0ZwZ5gPuYnhqTFcqK3bBDZBbJOpGQTktz4SmPdfa5STRcdsLegUNPjydJpoEd0na Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: a818c96d-50a5-4f7d-0d6f-08d7638be56e X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2019 14:07:59.6033 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eOncfwzcvN8El6zSzQLjweHQCHJjn2kCL/TfP2L087DzGMjdQQYxqReF1H5g7EO6dAZW08GHPpo1igVs9sSwX5OnJHSSCtODKOGT/OgIVdw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3297 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: allow jump to group lower than current X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dekel Peled > Sent: Thursday, November 7, 2019 13:34 > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; > Ori Kam > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: allow jump to group lower than current >=20 > In current implementation, jump action is allowed only if target group is > higher than the current flow group, >=20 > This patch updates function flow_dv_validate_action_jump() to allow jump > action if target group is higher or lower than the current flow group. > Target group equal to current flow group is still rejected. >=20 > Signed-off-by: Dekel Peled > --- > drivers/net/mlx5/mlx5_flow_dv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index 42c265f..3ad3df9 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -2514,10 +2514,10 @@ struct field_modify_info modify_tcp[] =3D { > return rte_flow_error_set(error, EINVAL, >=20 > RTE_FLOW_ERROR_TYPE_ATTR_GROUP, NULL, > "target group index out of range"); > - if (attributes->group >=3D target_group) > + if (attributes->group =3D=3D target_group) > return rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, > NULL, > - "target group must be higher than" > + "target group must be other than" > " the current flow group"); > return 0; > } > -- > 1.8.3.1 Acked-by: Viacheslav Ovsiienko