From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A9AEA04A5; Wed, 17 Jun 2020 21:55:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E37EB1252; Wed, 17 Jun 2020 21:54:59 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062.outbound.protection.outlook.com [40.107.22.62]) by dpdk.org (Postfix) with ESMTP id D15B91023; Wed, 17 Jun 2020 21:54:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jp5U8+thc1GEvsD41hwk8SgW1YH9M7HGZYF1KcdOr3zQRRHqJOa2LcYO99CBnk4SCPm/xnpRxtdsOsparmlI90v3H3IItJddWU6jbovynfDiP7RMde8apzTDCxTzZgdEwIeqgqXMq7NMvWeoJn2//bc7g3rUy5j4hH+pOmhRWrPDSwOe1n4GxPVh15KDA0PCAIuF1H+C5TlZhdezqMvXbsjEjXY5zl9xUMsrPVzUEcGvoiiTdI1qMmUvBYUHmY3Orp6sUGxSMR+IwJuZ1REPFCCsjDoGNLrAcUbOZjc/qFqrM+OJyRhHy4KwOTQo+2Mpf0DK7LmNDi30vKs0JLqO+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=88L/49QHvjdnudrye/v06zIpLCCEdbvAgnZ2KU9c5N4=; b=hvXFEZqvk0YBuNoMUGi23yZvnZM3LzJk2CNMHoF9DhX4sY8dR+k6rNLDNVOgo77qC/PtCQ+pCJ+GitrfAMWSRjCycrsaxYSsH47CqaeAg2Jz0eSab0fz+HqWC1/VbVPGphe8b3xUR95yqH1SwyWCWQErofbSgcxIi7hwho5hQcmZ2I5ZOtZrXo9ZrIusixJet9OTQXT/dA0RGMFZw4h/WP+jDR8ogL/ZOZAyfCUssGBwET9uX9aOg5YU/PfnFbxixuoM0lKw8mGR96fMu4twSl4/BB0n3CR/2JQRYC1B8cRzPs9nbY+Gnb4XT/9RkUyoPkDGA/GcpI5fkhQOZDnNCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=88L/49QHvjdnudrye/v06zIpLCCEdbvAgnZ2KU9c5N4=; b=Tz7r12gSKUao8RO9uBE1zNafHUAn5dB6NcNbjnTbQDyXMEB9bMR2xFR+78EnLoWugYHSXvQ+8c331BmNVB3shcs6qFZPHGBNDiwyTa8sXn7ON8jL1gKC/d9L2+nOfMrBf/0/xP4i0SS6ukkpt4Vk8H0BdONGQM4PJjavD4D4WT8= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (2603:10a6:205:8::26) by AM4PR05MB3139.eurprd05.prod.outlook.com (2603:10a6:205:11::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.22; Wed, 17 Jun 2020 19:54:58 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::bdf0:88a3:3a39:4be4]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::bdf0:88a3:3a39:4be4%7]) with mapi id 15.20.3088.028; Wed, 17 Jun 2020 19:54:57 +0000 From: Slava Ovsiienko To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , Matan Azrad , Shahaf Shuler , Bing Zhao , Jack Min Thread-Topic: [PATCH] net/mlx5: remove redundant newline Thread-Index: AQHWRK61gM8TWwk5fk2K5XmnfC7leqjdONnQ Date: Wed, 17 Jun 2020 19:54:57 +0000 Message-ID: References: <20200617135325.9998-1-david.marchand@redhat.com> In-Reply-To: <20200617135325.9998-1-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d776c1b6-92ff-4b9b-4f2d-08d812f85032 x-ms-traffictypediagnostic: AM4PR05MB3139: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:849; x-forefront-prvs: 04371797A5 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 81SLflfZnXbaOpvcBfZ9NoOXYpklNib3ZkF7n5VmtH/dQbcEWp1TsL7dIxlAJYH4yx+r3TgBx3GGGq0VC1M9iGaFaT1rzPp8CAJqXXYUQCXzRxmvdbq3Gm2PX8p+v93Ei6DwUftVQzJyvIy0V5tZ3cwNG4pQTqeEEqwNr+CLXX6h+rXr4swCRerSxlYHEyufsNFzzVfP9B9PQJcv9XnDY69KlKrYY7wGT9ZSgKPfIE00F4jSPiD6zYlDb3WdqWkHp2VBlkQUvBzCNeW4y7lsEkphWVIiXjmUgO23lww6QrdDNTYFDXG03KMx82Hmfb93W9ym530sG1zpiY5BqPyqww== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM4PR05MB3265.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(366004)(346002)(39860400002)(136003)(376002)(107886003)(5660300002)(66556008)(66946007)(64756008)(76116006)(66476007)(66446008)(4326008)(71200400001)(53546011)(9686003)(55016002)(186003)(6506007)(26005)(33656002)(86362001)(2906002)(7696005)(83380400001)(52536014)(8676002)(316002)(54906003)(110136005)(8936002)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 6lWJjDrSyL6vxi3YAfM/CCjmMfGyT+ICNo813LB8WKNPTAvp+lkQmdovyIFMtmgHcEk1iJaXlECsCXqzqUYNqpm882118/Ownokhs7tqTaHhqoKRn9Tg0XsOtT7SftMD1We7z4LJVJvmldssLAr0bUR474UiYRr8viBRCt3jltBxeI4YJIDFsfjz9yAEVZ93qOH0JyRuTKtbsI4LGXRVDVKAI6iJshSsehQ4HigJSuxBRQ0cZGxcxOyK540QCPnJ6JinUMG7V5LelIi7jClwRJ7h/cEMaPh2Z1G5k3NvS66ijEIPCGQb3k7iLXPABcYj7cTHmMj7d3ZURzZooCewMOsb+6i/ReJNJ63pe+V4T2Uiiu9++sctaV8BgJ/WBI4sgLK17ieUNjzzCr7So5V3Ck8F8MbX07SZ6FHTkjnu+ZCniL+CvQfDGrQml6gJ1xPNBOGtRXmf0tMug55VslM6Mo8PxXg08qymyH1bZWTmB4M= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d776c1b6-92ff-4b9b-4f2d-08d812f85032 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2020 19:54:57.7799 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hrlTsrvyhVf/BhnQbc9QZ13LCUVSPLnTBYqIzNgc0kLosK/zygzPGhW4SmP1PgKdiQ+YrTkDIdxxzlGXQSv/wFD907SmNYoKSGI+ZKlJydA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3139 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: remove redundant newline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: David Marchand > Sent: Wednesday, June 17, 2020 16:53 > To: dev@dpdk.org > Cc: stable@dpdk.org; Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; > Bing Zhao ; Jack Min > Subject: [PATCH] net/mlx5: remove redundant newline >=20 > The DRV_LOG macro already appends a newline. >=20 > Fixes: 46287eacc1b1 ("net/mlx5: introduce hash list") > Fixes: 860897d2895a ("net/mlx5: reorganize flow tables with hash list") > Fixes: e484e4032332 ("net/mlx5: optimize tag traversal with hash list") > Fixes: 6801116688fe ("net/mlx5: fix multiple flow table hash list") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5.c | 6 +++--- > drivers/net/mlx5/mlx5_utils.c | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index > 95a0f337fe..fe7ed4899a 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -1062,7 +1062,7 @@ mlx5_alloc_table_hash_list(struct mlx5_priv *priv) > snprintf(s, sizeof(s), "%s_flow_table", priv->sh->ibdev_name); > sh->flow_tbls =3D mlx5_hlist_create(s, > MLX5_FLOW_TABLE_HLIST_ARRAY_SIZE); > if (!sh->flow_tbls) { > - DRV_LOG(ERR, "flow tables with hash creation failed.\n"); > + DRV_LOG(ERR, "flow tables with hash creation failed."); > err =3D ENOMEM; > return err; > } > @@ -1146,7 +1146,7 @@ mlx5_alloc_shared_dr(struct mlx5_priv *priv) > if (!sh->flow_tbls) > err =3D mlx5_alloc_table_hash_list(priv); > else > - DRV_LOG(DEBUG, "sh->flow_tbls[%p] already created, > reuse\n", > + DRV_LOG(DEBUG, "sh->flow_tbls[%p] already created, > reuse", > (void *)sh->flow_tbls); > if (err) > return err; > @@ -1154,7 +1154,7 @@ mlx5_alloc_shared_dr(struct mlx5_priv *priv) > snprintf(s, sizeof(s), "%s_tags", sh->ibdev_name); > sh->tag_table =3D mlx5_hlist_create(s, > MLX5_TAGS_HLIST_ARRAY_SIZE); > if (!sh->tag_table) { > - DRV_LOG(ERR, "tags with hash creation failed.\n"); > + DRV_LOG(ERR, "tags with hash creation failed."); > err =3D ENOMEM; > goto error; > } > diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.= c > index d29fbcbc83..6f3ba7ca49 100644 > --- a/drivers/net/mlx5/mlx5_utils.c > +++ b/drivers/net/mlx5/mlx5_utils.c > @@ -20,7 +20,7 @@ mlx5_hlist_create(const char *name, uint32_t size) > if (!rte_is_power_of_2(size)) { > act_size =3D rte_align32pow2(size); > DRV_LOG(WARNING, "Size 0x%" PRIX32 " is not power of 2, > will " > - "be aligned to 0x%" PRIX32 ".\n", size, act_size); > + "be aligned to 0x%" PRIX32 ".", size, act_size); > } else { > act_size =3D size; > } > @@ -29,7 +29,7 @@ mlx5_hlist_create(const char *name, uint32_t size) > /* Using zmalloc, then no need to initialize the heads. */ > h =3D rte_zmalloc(name, alloc_size, RTE_CACHE_LINE_SIZE); > if (!h) { > - DRV_LOG(ERR, "No memory for hash list %s creation\n", > + DRV_LOG(ERR, "No memory for hash list %s creation", > name ? name : "None"); > return NULL; > } > @@ -37,7 +37,7 @@ mlx5_hlist_create(const char *name, uint32_t size) > snprintf(h->name, MLX5_HLIST_NAMESIZE, "%s", name); > h->table_sz =3D act_size; > h->mask =3D act_size - 1; > - DRV_LOG(DEBUG, "Hash list with %s size 0x%" PRIX32 " is > created.\n", > + DRV_LOG(DEBUG, "Hash list with %s size 0x%" PRIX32 " is created.", > h->name, act_size); > return h; > } > -- > 2.23.0