From: Ori Kam <orika@mellanox.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Suanming Mou <suanmingm@mellanox.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Shahaf Shuler <shahafs@mellanox.com>,
Matan Azrad <matan@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>
Subject: Re: [dpdk-dev] [RFC] ethdev: add IPv4/IPv6 DSCP rewrite action
Date: Tue, 10 Dec 2019 19:48:17 +0000 [thread overview]
Message-ID: <AM4PR05MB342507BA68A3A182F91A7466DB5B0@AM4PR05MB3425.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20191210103133.12ec7fe7@shemminger-XPS-13-9360>
Hi Stephen,
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Tuesday, December 10, 2019 8:32 PM
> To: Andrew Rybchenko <arybchenko@solarflare.com>
> Cc: Suanming Mou <suanmingm@mellanox.com>; Adrien Mazarguil
> <adrien.mazarguil@6wind.com>; John McNamara
> <john.mcnamara@intel.com>; Marko Kovacevic
> <marko.kovacevic@intel.com>; Thomas Monjalon <thomas@monjalon.net>;
> Ferruh Yigit <ferruh.yigit@intel.com>; dev@dpdk.org; Shahaf Shuler
> <shahafs@mellanox.com>; Ori Kam <orika@mellanox.com>; Matan Azrad
> <matan@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>
> Subject: Re: [dpdk-dev] [RFC] ethdev: add IPv4/IPv6 DSCP rewrite action
>
> On Tue, 10 Dec 2019 10:33:28 +0300
> Andrew Rybchenko <arybchenko@solarflare.com> wrote:
>
> > > For some overlay network, such as VXLAN, the DSCP field in the new
> outer
> > > IP header after VXLAN decapsulation may need to be updated
> accordingly.
> > >
> > > This commit introduce the DSCP modify action for IPv4 and IPv6.
> > >
> > > Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
> >
> > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> >
> > as usual it requires testpmd support and a driver which
> > supports it (I understand that it may be omitted in RFC).
>
> And it requires documentation and a software implementation in the flow
> classifier.
>
Why in the flow classifier?
I don't remember any new code that was added to rte_flow was also added to flow classifier.
>
> Plus you conveniently exclude defining what happens to reserved bits.
> "What ever our hardware does is correct" is not a useful answer.
> You need to be precise and limited in what is allowed to make this usable.
>
The action does just what it says nothing more and nothing less.
It just modify the DSCP value with a value given by the application.
Reserved bits are not touched.
> Sorry, to be so negative. This feature is fine in itself and a useful
> incremental improvement. But nobody has stepped up to address the
> usability
> of rte_flow.
I'm sorry but I don't understand your comment,
According to my knowledge more and more applications are using rte_flow, and each new feature that is added is based on some
customer need.
Thanks,
Ori
next prev parent reply other threads:[~2019-12-10 19:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 5:23 Suanming Mou
2019-12-10 7:33 ` Andrew Rybchenko
2019-12-10 8:55 ` Suanming Mou
2019-12-10 18:32 ` Stephen Hemminger
2019-12-10 18:31 ` Stephen Hemminger
2019-12-10 19:48 ` Ori Kam [this message]
2019-12-11 1:36 ` Suanming Mou
2019-12-10 9:27 ` [dpdk-dev] [RFC v2] " Suanming Mou
2019-12-16 3:42 ` [dpdk-dev] [RFC v3 1/2] " Suanming Mou
2019-12-16 3:42 ` [dpdk-dev] [RFC v3 2/2] net/mlx5: " Suanming Mou
2019-12-16 7:49 ` [dpdk-dev] [RFC v3 1/2] ethdev: " Ori Kam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR05MB342507BA68A3A182F91A7466DB5B0@AM4PR05MB3425.eurprd05.prod.outlook.com \
--to=orika@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=matan@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=stephen@networkplumber.org \
--cc=suanmingm@mellanox.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).