From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70791A04F0; Tue, 10 Dec 2019 20:48:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8BA9C37A2; Tue, 10 Dec 2019 20:48:20 +0100 (CET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50082.outbound.protection.outlook.com [40.107.5.82]) by dpdk.org (Postfix) with ESMTP id D444291 for ; Tue, 10 Dec 2019 20:48:18 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XxjwCT25qMtyggj8hfPc/+6PUHCvaxKMNm56lr5q0mpT2f07jxCwAC71cdHVBpr/UnhTZ84Zf7coirfehy26FgNZ0AoW93N0pQHc4/oqDbBsvj1d8OZsr+j6D/THpwjGM07lfwYZg22Z4XOYO0v33kEow4pw6OnUPBWgV5XzYtTO/OwDuR+Ot4rp5vwyGgzWMFMbv+EhCTUgoeexFCXiYeCoitpYbwN2DdwCdKGl7zeESpGCQrNtlI7WMr6DvwG6wD2nQLcPEQrVqaUmTMAZz8qtAwOrBdpwl8OfWsZ9RyUXjqpl7C+/5rl+QdLCksPOVsUj8O/uCp56NYDswO8uNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mX3v0Pe2Mf1N87M49AxdN1hpQu+L5/BFezrkCKpHy+Q=; b=VnoP0VsoBwNlceTuD7hYgyuxeph1P6PJFqRt/ZJyZ1BVfX6dxuOz0A+1UK3O1BFa5b4GQIHHSyT605MYQVkK0eHOsJ/f7tTaQZNsMRZ+ft0nSmYYUKjqS1As3VctRldlykZVzUohiV/z2/MZK56DicboyuGg8+kBZ4NlbYuOOGuBR/beCcNdY4qXA14TtS7xKEOxu2ASBPWkFtg9zma/5N//ud9uRFsrERLJxjagrn6xy7GdXGOif0oMrQMH6o65rX5+9mZE9CN7RW/xu/7dJ7gzz/YpnTkb1TAu/vwRNxyF9qY0jHIGg+v7oVV7PMuM+bpLk1tunGmUGOd3EviPww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mX3v0Pe2Mf1N87M49AxdN1hpQu+L5/BFezrkCKpHy+Q=; b=kgSJjX0ft57joj+y7k2HRjkZpRE4r2CwjW3aQJuLLJxzlZNvgylMpvhvPqddB9Eqij7wY2H8W/QJDTyH9kc7FMNgk03bi7cg+rbEkdpmU7rD51Pgt1rfIOIAZlbiekxpcv/Oix/N3CeFR4X+rhcRSCDfRNwDAscG7b6+stC1WQs= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by AM4PR05MB3249.eurprd05.prod.outlook.com (10.171.188.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2516.17; Tue, 10 Dec 2019 19:48:17 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::d877:95ed:5f94:a4a]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::d877:95ed:5f94:a4a%3]) with mapi id 15.20.2516.018; Tue, 10 Dec 2019 19:48:17 +0000 From: Ori Kam To: Stephen Hemminger , Andrew Rybchenko CC: Suanming Mou , Adrien Mazarguil , John McNamara , Marko Kovacevic , Thomas Monjalon , Ferruh Yigit , "dev@dpdk.org" , Shahaf Shuler , Matan Azrad , Slava Ovsiienko Thread-Topic: [dpdk-dev] [RFC] ethdev: add IPv4/IPv6 DSCP rewrite action Thread-Index: AQHVrxnrUYBnoJLiekykR2bVP5arIaey+gYAgAC33oCAABD1YA== Date: Tue, 10 Dec 2019 19:48:17 +0000 Message-ID: References: <1575955386-6672-1-git-send-email-suanmingm@mellanox.com> <322fb1d5-c629-5f67-59d4-c38df67f0c9b@solarflare.com> <20191210103133.12ec7fe7@shemminger-XPS-13-9360> In-Reply-To: <20191210103133.12ec7fe7@shemminger-XPS-13-9360> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [185.175.35.255] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 617eb4e9-3666-496c-eeec-08d77da9e6f4 x-ms-traffictypediagnostic: AM4PR05MB3249:|AM4PR05MB3249: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-forefront-prvs: 02475B2A01 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(346002)(366004)(376002)(136003)(396003)(199004)(189003)(13464003)(66476007)(33656002)(66446008)(71200400001)(66946007)(8676002)(81166006)(8936002)(81156014)(64756008)(9686003)(7696005)(186003)(66556008)(4326008)(76116006)(2906002)(86362001)(5660300002)(52536014)(316002)(6506007)(478600001)(55016002)(54906003)(107886003)(110136005)(53546011)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3249; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1L3G4RSJfYOA9KYHM5cC++SIj2Ri/ZlS1bncEnWRtUrZ1ng0uWSf4WHxxFcm0BttZj+7le5q918cGFbdG5snhTg4mKoayTKJiwcadUtc4lUKf3KxZjAN68Vbnak3T4cq0LrhMuK7kpVNLwvAMTkn6rl4TVJxcEU0m7VGF65HOuX8ibPwOB5Cr1vPuvF+w0GktwhvD92FF8u4DEbEXgHQhC0wXcUK2Qhl7Zcf+4TxM3e/wpwgOAKLzuBZApGYnQykH5WpRd1TAPOrrpWZCyhoFI0wUlztnMkrVmakTjGZIuE/y4h2F9XzUc+OoCTW5B3sYCdak3PVKZIIdww5CJ3yJs22/YmTTHhew+cIT8Q0BPK3qQCN6luKklP4kBG/dN9GNqidyiy6YFmXcP4JU6nQbSAk06H1GkGhleZsdXY74m4efSPhBdGQZfODoCF0p8QkfX5VvlRZOL5A8bSC0KiG0n/ikTQD2/qTMYfSFPF5q60XfXIDgZnC69RmnboUKcn5 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 617eb4e9-3666-496c-eeec-08d77da9e6f4 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2019 19:48:17.2771 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w30bp8AdnRzNDFfUWhLuZ1/Ml3y6VCrGpwqAOlsHAWZV8/GFBYugYuw0Lw2udufRpqjMO86P759lLrdZ7ZdkmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3249 Subject: Re: [dpdk-dev] [RFC] ethdev: add IPv4/IPv6 DSCP rewrite action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen, > -----Original Message----- > From: Stephen Hemminger > Sent: Tuesday, December 10, 2019 8:32 PM > To: Andrew Rybchenko > Cc: Suanming Mou ; Adrien Mazarguil > ; John McNamara > ; Marko Kovacevic > ; Thomas Monjalon ; > Ferruh Yigit ; dev@dpdk.org; Shahaf Shuler > ; Ori Kam ; Matan Azrad > ; Slava Ovsiienko > Subject: Re: [dpdk-dev] [RFC] ethdev: add IPv4/IPv6 DSCP rewrite action >=20 > On Tue, 10 Dec 2019 10:33:28 +0300 > Andrew Rybchenko wrote: >=20 > > > For some overlay network, such as VXLAN, the DSCP field in the new > outer > > > IP header after VXLAN decapsulation may need to be updated > accordingly. > > > > > > This commit introduce the DSCP modify action for IPv4 and IPv6. > > > > > > Signed-off-by: Suanming Mou > > > > Acked-by: Andrew Rybchenko > > > > as usual it requires testpmd support and a driver which > > supports it (I understand that it may be omitted in RFC). >=20 > And it requires documentation and a software implementation in the flow > classifier. >=20 Why in the flow classifier? I don't remember any new code that was added to rte_flow was also added to = flow classifier. >=20 > Plus you conveniently exclude defining what happens to reserved bits. > "What ever our hardware does is correct" is not a useful answer. > You need to be precise and limited in what is allowed to make this usable= . >=20 The action does just what it says nothing more and nothing less.=20 It just modify the DSCP value with a value given by the application. Reserved bits are not touched. > Sorry, to be so negative. This feature is fine in itself and a useful > incremental improvement. But nobody has stepped up to address the > usability > of rte_flow. I'm sorry but I don't understand your comment,=20 According to my knowledge more and more applications are using rte_flow, an= d each new feature that is added is based on some=20 customer need.=20 Thanks, Ori