From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3FDEA04C2; Mon, 25 Nov 2019 08:50:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 115462BCE; Mon, 25 Nov 2019 08:50:31 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150089.outbound.protection.outlook.com [40.107.15.89]) by dpdk.org (Postfix) with ESMTP id 263C02952 for ; Mon, 25 Nov 2019 08:50:30 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H0z1LQMpajThsz8fFtaXe92P1PshXo6/Mln/9pDZwzwN9yPuw8tu03PyVF0TnPw8uAwPWK6mRn/OIZFBPZd0xAaWSimtfhapAknSgNH69AITZkFPWhB/tsfy5BZaE9gcoQqXkHGUCilWe1Ok4DNQTc4qI6b8ed1rQf5K826ayhx7ZqZ5B2hIm09SnsHt08Gdeg2nx/GeRvZXey9puOoYYK9yrbK+iz1r+ZtvQ9OKYNdYDTZ10tuF93n7wXqAcyyukmIJv3prqs4mZYRD7JRLQlk6tLoAJf9r7HaBVDBkI5g8FQ872DosUVNIQyLkx86ji0Qnqky+FazuHM/zTjbInA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kRz18O91OkkE/TX9idespgoCcmYXpHpDfVnuKw9Y9rU=; b=k6cIgOKjWJ5+8Bug1NMHSYmuxlWmI6dG1Gl6QMBGMJ9q52/OQwlYqKPeTPIZmszBg36jzk3AR/TSdClRbe09iNjPgmL5S6DF2P7donhfDZOZSsRJrmzhuhxJGh5ZFgZZHqD1Bz1Wm81/Z8Ek/EZe/OvA/bMvlgKLHg6iOfx1tUgA6epkgNn65Ien3us4qLyNQfx1Ajm84r/tQANQzcIw1uvKZ26hbjMJXIi3M2r7KX59TxJXYxR2HH0HytrfzaFYXwGeEGDE+xYJtuDDjyEbzMycfOgj5A04uTkPNbF32eYflApkbQpZSqc9MtJpUKAnBdokiRGEnzMl9sRjtbRF8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kRz18O91OkkE/TX9idespgoCcmYXpHpDfVnuKw9Y9rU=; b=VsRVeCaKorSNL/f+LOe6SrjAbkr7V7fr7sKhY6OuRawEvv7lkhfKXx4BfBlRre44qMXIvUKzY3WTpsJ51nSxyKOijVB/yMzSpnqA8FRdXhbgmuHOd4snV8aBPQLjPyyIcfCPBhfChPUdiUqRCupWYp+i3Cr7EyhPRdt3WQlfu8Q= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by AM4PR05MB3508.eurprd05.prod.outlook.com (10.171.190.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.19; Mon, 25 Nov 2019 07:50:29 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::d877:95ed:5f94:a4a]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::d877:95ed:5f94:a4a%3]) with mapi id 15.20.2474.023; Mon, 25 Nov 2019 07:50:28 +0000 From: Ori Kam To: Bing Zhao , Slava Ovsiienko , Raslan Darawsheh , Matan Azrad CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: support more than 16 modify actions Thread-Index: AQHVoc9f7S3KJQM4cU6R6OjUoDTpl6ebheaQ Date: Mon, 25 Nov 2019 07:50:28 +0000 Message-ID: References: <1574493996-48427-1-git-send-email-bingz@mellanox.com> In-Reply-To: <1574493996-48427-1-git-send-email-bingz@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [185.175.35.255] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f6d589eb-bb39-4134-966c-08d7717c23f5 x-ms-traffictypediagnostic: AM4PR05MB3508:|AM4PR05MB3508: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3513; x-forefront-prvs: 0232B30BBC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(396003)(136003)(39860400002)(376002)(13464003)(189003)(199004)(446003)(11346002)(6246003)(99286004)(6506007)(66946007)(14444005)(256004)(4326008)(76176011)(316002)(110136005)(7696005)(71190400001)(86362001)(71200400001)(53546011)(6636002)(25786009)(66476007)(74316002)(66556008)(9686003)(76116006)(66446008)(64756008)(478600001)(6116002)(7736002)(3846002)(229853002)(55016002)(66066001)(8936002)(30864003)(5660300002)(305945005)(6436002)(81166006)(8676002)(81156014)(186003)(26005)(102836004)(14454004)(52536014)(33656002)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3508; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KiMdh9OOal8isuwXYK8FYrhSMvDrS25z/2BjjIMiwSUPdqfY5J/Javfo79ZOhKLyfWzHhdNSr0vnFrWX2ZBCLDpP7BTQT0zfyIlBxz3Gg0o1/w5aF01Ybz7H5Zx51IPd6YLUICOIBso8Us5UBWt+7uumsN8F7lMGzCWNzDzixYIkKQQ88CfRdgIc9CCZNwxZKOUZ5mvgEPWEG//V88ojOnJrwugm1RDht0TQbJg4J6iRVQk1frfpn3/ubsyYrK1RcTUnSz/cpUJ/cB18I/RXxjc3p9oQ2dryv6/s7UTY8oi1ZFYmOslQuo4vkvchkl1SUX+3EYQv9jNI+Ftu0U+zLraZocGnUaXNlkGR/XVXO+VW/U9qkCq20T6kluxptnzghnH84ts+8vWUv9X1q48QaC+vD+UdX2gYrlThJTZTbrCfY8Dm131SGU8nZwrFREyq Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6d589eb-bb39-4134-966c-08d7717c23f5 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2019 07:50:28.8046 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KDOe4kmOxvctd/bRZ/WlSLw5gWIb8CX56hRpnjv/tRCSr7hNrVtdaMRM6Zt8zMsozLVqgCul/UMGBmavdldxQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3508 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: support more than 16 modify actions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Bing Zhao > Sent: Saturday, November 23, 2019 9:27 AM > To: Ori Kam ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: support more than 16 modify actions >=20 > In the root table, there is some limitation of total number of header > modify actions, 16 or 8 for each. But in other tables, there is no > such strict limitation. In an IPv6 case, the IP fields modifying > will occupy more actions than that in IPv4, so the total support > number should be increased in order to support as many actions as > possible for IPv6 + TCP packet. > And in the meanwhile, the memory consumption should also be taken > into consideration because sometimes only several actions are needed. > The root table checking could also be done in low layer driver and > the error code will be returned if the actions are not supported. >=20 > Signed-off-by: Bing Zhao > --- > drivers/net/mlx5/mlx5_flow.h | 15 +++--- > drivers/net/mlx5/mlx5_flow_dv.c | 104 ++++++++++++++++++++++--------- > --------- > 2 files changed, 66 insertions(+), 53 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h > index 3fff5dd..0ad0fc1 100644 > --- a/drivers/net/mlx5/mlx5_flow.h > +++ b/drivers/net/mlx5/mlx5_flow.h > @@ -370,11 +370,14 @@ struct mlx5_flow_dv_tag_resource { >=20 > /* > * Number of modification commands. > - * If extensive metadata registers are supported > - * the maximal actions amount is 16 and 8 otherwise. > + * If extensive metadata registers are supported, the maximal actions > amount is > + * 16 and 8 otherwise on root table. The validation could also be done i= n the > + * lower driver layer. > + * On non-root table, there is no limitation, but 32 is enough right now= . > */ > -#define MLX5_MODIFY_NUM 16 > -#define MLX5_MODIFY_NUM_NO_MREG 8 > +#define MLX5_MAX_MODIFY_NUM 32 > +#define MLX5_ROOT_TBL_MODIFY_NUM 16 > +#define MLX5_ROOT_TBL_MODIFY_NUM_NO_MREG 8 >=20 > /* Modify resource structure */ > struct mlx5_flow_dv_modify_hdr_resource { > @@ -385,9 +388,9 @@ struct mlx5_flow_dv_modify_hdr_resource { > /**< Verbs modify header action object. */ > uint8_t ft_type; /**< Flow table type, Rx or Tx. */ > uint32_t actions_num; /**< Number of modification actions. */ > - struct mlx5_modification_cmd actions[MLX5_MODIFY_NUM]; > - /**< Modification actions. */ > uint64_t flags; /**< Flags for RDMA API. */ > + struct mlx5_modification_cmd actions[]; > + /**< Modification actions. */ > }; >=20 > /* Jump action resource structure. */ > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index 02f20fb..75d28bd 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -356,7 +356,7 @@ struct field_modify_info modify_tcp[] =3D { > uint32_t mask; > uint32_t data; >=20 > - if (i >=3D MLX5_MODIFY_NUM) > + if (i >=3D MLX5_MAX_MODIFY_NUM) > return rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, NULL, > "too many items to modify"); > @@ -397,11 +397,11 @@ struct field_modify_info modify_tcp[] =3D { > ++i; > ++field; > } while (field->size); > - resource->actions_num =3D i; > - if (!resource->actions_num) > + if (resource->actions_num =3D=3D i) > return rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, > NULL, > "invalid modification flow item"); > + resource->actions_num =3D i; > return 0; > } >=20 > @@ -562,7 +562,7 @@ struct field_modify_info modify_tcp[] =3D { > struct mlx5_modification_cmd *actions =3D &resource->actions[i]; > struct field_modify_info *field =3D modify_vlan_out_first_vid; >=20 > - if (i >=3D MLX5_MODIFY_NUM) > + if (i >=3D MLX5_MAX_MODIFY_NUM) > return rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, NULL, > "too many items to modify"); > @@ -895,7 +895,7 @@ struct field_modify_info modify_tcp[] =3D { > struct mlx5_modification_cmd *actions =3D resource->actions; > uint32_t i =3D resource->actions_num; >=20 > - if (i >=3D MLX5_MODIFY_NUM) > + if (i >=3D MLX5_MAX_MODIFY_NUM) > return rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, > NULL, > "too many items to modify"); > @@ -907,10 +907,6 @@ struct field_modify_info modify_tcp[] =3D { > actions[i].data1 =3D rte_cpu_to_be_32(conf->data); > ++i; > resource->actions_num =3D i; > - if (!resource->actions_num) > - return rte_flow_error_set(error, EINVAL, > - RTE_FLOW_ERROR_TYPE_ACTION, > NULL, > - "invalid modification flow item"); > return 0; > } >=20 > @@ -2241,7 +2237,6 @@ struct field_modify_info modify_tcp[] =3D { > domain =3D sh->rx_domain; > else > domain =3D sh->tx_domain; > - > /* Lookup a matching resource from cache. */ > LIST_FOREACH(cache_resource, &sh->encaps_decaps, next) { > if (resource->reformat_type =3D=3D cache_resource- > >reformat_type && > @@ -3352,21 +3347,27 @@ struct field_modify_info modify_tcp[] =3D { > * > * @param dev > * Pointer to rte_eth_dev structure. > + * @param flags > + * Flags bits to check if root level. > * > * @return > * Max number of modify header actions device can support. > */ > static unsigned int > -flow_dv_modify_hdr_action_max(struct rte_eth_dev *dev) > +flow_dv_modify_hdr_action_max(struct rte_eth_dev *dev, uint64_t flags) > { > /* > * There's no way to directly query the max cap. Although it has to be > * acquried by iterative trial, it is a safe assumption that more > * actions are supported by FW if extensive metadata register is > - * supported. > + * supported. (Only in the root table) > */ > - return mlx5_flow_ext_mreg_supported(dev) ? > MLX5_MODIFY_NUM : > - > MLX5_MODIFY_NUM_NO_MREG; > + if (!(flags & MLX5DV_DR_ACTION_FLAGS_ROOT_LEVEL)) > + return MLX5_MAX_MODIFY_NUM; > + else > + return mlx5_flow_ext_mreg_supported(dev) ? > + MLX5_ROOT_TBL_MODIFY_NUM : > + > MLX5_ROOT_TBL_MODIFY_NUM_NO_MREG; > } >=20 > /** > @@ -3451,8 +3452,12 @@ struct field_modify_info modify_tcp[] =3D { > struct mlx5_ibv_shared *sh =3D priv->sh; > struct mlx5_flow_dv_modify_hdr_resource *cache_resource; > struct mlx5dv_dr_domain *ns; > + uint32_t actions_len; >=20 > - if (resource->actions_num > > flow_dv_modify_hdr_action_max(dev)) > + resource->flags =3D > + dev_flow->group ? 0 : > MLX5DV_DR_ACTION_FLAGS_ROOT_LEVEL; > + if (resource->actions_num > flow_dv_modify_hdr_action_max(dev, > + resource->flags)) > return rte_flow_error_set(error, EOVERFLOW, > RTE_FLOW_ERROR_TYPE_ACTION, > NULL, > "too many modify header items"); > @@ -3462,17 +3467,15 @@ struct field_modify_info modify_tcp[] =3D { > ns =3D sh->tx_domain; > else > ns =3D sh->rx_domain; > - resource->flags =3D > - dev_flow->group ? 0 : > MLX5DV_DR_ACTION_FLAGS_ROOT_LEVEL; > /* Lookup a matching resource from cache. */ > + actions_len =3D resource->actions_num * sizeof(resource->actions[0]); > LIST_FOREACH(cache_resource, &sh->modify_cmds, next) { > if (resource->ft_type =3D=3D cache_resource->ft_type && > resource->actions_num =3D=3D cache_resource->actions_num > && > resource->flags =3D=3D cache_resource->flags && > !memcmp((const void *)resource->actions, > (const void *)cache_resource->actions, > - (resource->actions_num * > - sizeof(resource->actions[0])))) { > + actions_len)) { > DRV_LOG(DEBUG, "modify-header resource %p: > refcnt %d++", > (void *)cache_resource, > rte_atomic32_read(&cache_resource- > >refcnt)); > @@ -3482,18 +3485,18 @@ struct field_modify_info modify_tcp[] =3D { > } > } > /* Register new modify-header resource. */ > - cache_resource =3D rte_calloc(__func__, 1, sizeof(*cache_resource), > 0); > + cache_resource =3D rte_calloc(__func__, 1, > + sizeof(*cache_resource) + actions_len, 0); > if (!cache_resource) > return rte_flow_error_set(error, ENOMEM, >=20 > RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, > "cannot allocate resource > memory"); > *cache_resource =3D *resource; > + rte_memcpy(cache_resource->actions, resource->actions, > actions_len); > cache_resource->verbs_action =3D > mlx5_glue->dv_create_flow_action_modify_header > - (sh->ctx, cache_resource->ft_type, > - ns, cache_resource->flags, > - cache_resource->actions_num * > - sizeof(cache_resource->actions[0]), > + (sh->ctx, cache_resource->ft_type, > ns, > + cache_resource->flags, actions_len, > (uint64_t *)cache_resource- > >actions); > if (!cache_resource->verbs_action) { > rte_free(cache_resource); > @@ -6611,10 +6614,13 @@ struct field_modify_info modify_tcp[] =3D { > }; > int actions_n =3D 0; > bool actions_end =3D false; > - struct mlx5_flow_dv_modify_hdr_resource mhdr_res =3D { > - .ft_type =3D attr->egress ? > MLX5DV_FLOW_TABLE_TYPE_NIC_TX : > - > MLX5DV_FLOW_TABLE_TYPE_NIC_RX > - }; > + union { > + struct mlx5_flow_dv_modify_hdr_resource res; > + uint8_t len[sizeof(struct > mlx5_flow_dv_modify_hdr_resource) + > + sizeof(struct mlx5_modification_cmd) * > + (MLX5_MAX_MODIFY_NUM + 1)]; > + } mhdr_dummy; > + struct mlx5_flow_dv_modify_hdr_resource *mhdr_res =3D > &mhdr_dummy.res; > union flow_dv_attr flow_attr =3D { .attr =3D 0 }; > uint32_t tag_be; > union mlx5_flow_tbl_key tbl_key; > @@ -6626,15 +6632,19 @@ struct field_modify_info modify_tcp[] =3D { > uint32_t table; > int ret =3D 0; >=20 > + mhdr_res->ft_type =3D attr->egress ? > MLX5DV_FLOW_TABLE_TYPE_NIC_TX : > + > MLX5DV_FLOW_TABLE_TYPE_NIC_RX; > ret =3D mlx5_flow_group_to_table(attr, dev_flow->external, attr- > >group, > &table, error); > if (ret) > return ret; > dev_flow->group =3D table; > if (attr->transfer) > - mhdr_res.ft_type =3D MLX5DV_FLOW_TABLE_TYPE_FDB; > + mhdr_res->ft_type =3D MLX5DV_FLOW_TABLE_TYPE_FDB; > if (priority =3D=3D MLX5_FLOW_PRIO_RSVD) > priority =3D dev_conf->flow_prio - 1; > + /* number of actions must be set to 0 in case of dirty stack. */ > + mhdr_res->actions_num =3D 0; > for (; !actions_end ; actions++) { > const struct rte_flow_action_queue *queue; > const struct rte_flow_action_rss *rss; > @@ -6672,7 +6682,7 @@ struct field_modify_info modify_tcp[] =3D { > }; >=20 > if (flow_dv_convert_action_mark(dev, > &mark, > - &mhdr_res, > + mhdr_res, > error)) > return -rte_errno; > action_flags |=3D > MLX5_FLOW_ACTION_MARK_EXT; > @@ -6694,7 +6704,7 @@ struct field_modify_info modify_tcp[] =3D { > actions->conf; >=20 > if (flow_dv_convert_action_mark(dev, mark, > - &mhdr_res, > + mhdr_res, > error)) > return -rte_errno; > action_flags |=3D > MLX5_FLOW_ACTION_MARK_EXT; > @@ -6715,7 +6725,7 @@ struct field_modify_info modify_tcp[] =3D { > break; > case RTE_FLOW_ACTION_TYPE_SET_META: > if (flow_dv_convert_action_set_meta > - (dev, &mhdr_res, attr, > + (dev, mhdr_res, attr, > (const struct rte_flow_action_set_meta *) > actions->conf, error)) > return -rte_errno; > @@ -6723,7 +6733,7 @@ struct field_modify_info modify_tcp[] =3D { > break; > case RTE_FLOW_ACTION_TYPE_SET_TAG: > if (flow_dv_convert_action_set_tag > - (dev, &mhdr_res, > + (dev, mhdr_res, > (const struct rte_flow_action_set_tag *) > actions->conf, error)) > return -rte_errno; > @@ -6823,7 +6833,7 @@ struct field_modify_info modify_tcp[] =3D { > mlx5_update_vlan_vid_pcp(actions, &vlan); > /* If no VLAN push - this is a modify header action */ > if (flow_dv_convert_action_modify_vlan_vid > - (&mhdr_res, actions, error)) > + (mhdr_res, actions, error)) > return -rte_errno; > action_flags |=3D > MLX5_FLOW_ACTION_OF_SET_VLAN_VID; > break; > @@ -6922,7 +6932,7 @@ struct field_modify_info modify_tcp[] =3D { > case RTE_FLOW_ACTION_TYPE_SET_MAC_SRC: > case RTE_FLOW_ACTION_TYPE_SET_MAC_DST: > if (flow_dv_convert_action_modify_mac > - (&mhdr_res, actions, error)) > + (mhdr_res, actions, error)) > return -rte_errno; > action_flags |=3D actions->type =3D=3D >=20 > RTE_FLOW_ACTION_TYPE_SET_MAC_SRC ? > @@ -6932,7 +6942,7 @@ struct field_modify_info modify_tcp[] =3D { > case RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC: > case RTE_FLOW_ACTION_TYPE_SET_IPV4_DST: > if (flow_dv_convert_action_modify_ipv4 > - (&mhdr_res, actions, error)) > + (mhdr_res, actions, error)) > return -rte_errno; > action_flags |=3D actions->type =3D=3D >=20 > RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC ? > @@ -6942,7 +6952,7 @@ struct field_modify_info modify_tcp[] =3D { > case RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC: > case RTE_FLOW_ACTION_TYPE_SET_IPV6_DST: > if (flow_dv_convert_action_modify_ipv6 > - (&mhdr_res, actions, error)) > + (mhdr_res, actions, error)) > return -rte_errno; > action_flags |=3D actions->type =3D=3D >=20 > RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC ? > @@ -6952,7 +6962,7 @@ struct field_modify_info modify_tcp[] =3D { > case RTE_FLOW_ACTION_TYPE_SET_TP_SRC: > case RTE_FLOW_ACTION_TYPE_SET_TP_DST: > if (flow_dv_convert_action_modify_tp > - (&mhdr_res, actions, items, > + (mhdr_res, actions, items, > &flow_attr, error)) > return -rte_errno; > action_flags |=3D actions->type =3D=3D > @@ -6962,13 +6972,13 @@ struct field_modify_info modify_tcp[] =3D { > break; > case RTE_FLOW_ACTION_TYPE_DEC_TTL: > if (flow_dv_convert_action_modify_dec_ttl > - (&mhdr_res, items, &flow_attr, > error)) > + (mhdr_res, items, &flow_attr, error)) > return -rte_errno; > action_flags |=3D MLX5_FLOW_ACTION_DEC_TTL; > break; > case RTE_FLOW_ACTION_TYPE_SET_TTL: > if (flow_dv_convert_action_modify_ttl > - (&mhdr_res, actions, items, > + (mhdr_res, actions, items, > &flow_attr, error)) > return -rte_errno; > action_flags |=3D MLX5_FLOW_ACTION_SET_TTL; > @@ -6976,7 +6986,7 @@ struct field_modify_info modify_tcp[] =3D { > case RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ: > case RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ: > if (flow_dv_convert_action_modify_tcp_seq > - (&mhdr_res, actions, error)) > + (mhdr_res, actions, error)) > return -rte_errno; > action_flags |=3D actions->type =3D=3D >=20 > RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ ? > @@ -6987,7 +6997,7 @@ struct field_modify_info modify_tcp[] =3D { > case RTE_FLOW_ACTION_TYPE_INC_TCP_ACK: > case RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK: > if (flow_dv_convert_action_modify_tcp_ack > - (&mhdr_res, actions, error)) > + (mhdr_res, actions, error)) > return -rte_errno; > action_flags |=3D actions->type =3D=3D >=20 > RTE_FLOW_ACTION_TYPE_INC_TCP_ACK ? > @@ -6996,13 +7006,13 @@ struct field_modify_info modify_tcp[] =3D { > break; > case MLX5_RTE_FLOW_ACTION_TYPE_TAG: > if (flow_dv_convert_action_set_reg > - (&mhdr_res, actions, error)) > + (mhdr_res, actions, error)) > return -rte_errno; > action_flags |=3D MLX5_FLOW_ACTION_SET_TAG; > break; > case MLX5_RTE_FLOW_ACTION_TYPE_COPY_MREG: > if (flow_dv_convert_action_copy_mreg > - (dev, &mhdr_res, actions, error)) > + (dev, mhdr_res, actions, error)) > return -rte_errno; > action_flags |=3D MLX5_FLOW_ACTION_SET_TAG; > break; > @@ -7027,10 +7037,10 @@ struct field_modify_info modify_tcp[] =3D { > break; > case RTE_FLOW_ACTION_TYPE_END: > actions_end =3D true; > - if (mhdr_res.actions_num) { > + if (mhdr_res->actions_num) { > /* create modify action if needed. */ > if (flow_dv_modify_hdr_resource_register > - (dev, &mhdr_res, dev_flow, error)) > + (dev, mhdr_res, dev_flow, error)) > return -rte_errno; > dev_flow- > >dv.actions[modify_action_position] =3D > dev_flow->dv.modify_hdr- > >verbs_action; > @@ -7039,7 +7049,7 @@ struct field_modify_info modify_tcp[] =3D { > default: > break; > } > - if (mhdr_res.actions_num && > + if (mhdr_res->actions_num && > modify_action_position =3D=3D UINT32_MAX) > modify_action_position =3D actions_n++; > } > -- > 1.8.3.1 Acked-by: Ori Kam Thanks Ori Kam