From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B95CCA0471 for ; Wed, 14 Aug 2019 08:05:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D778A1BDAE; Wed, 14 Aug 2019 08:05:16 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130070.outbound.protection.outlook.com [40.107.13.70]) by dpdk.org (Postfix) with ESMTP id 4BB2E1BDAC for ; Wed, 14 Aug 2019 08:05:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mWJgYXevSyE5laX56X1mpA6DX7xFq4exbDaxscGtS+K9/JCo53sTKWsAxwXeobaiqmp3d/sz17zGKrxaSYf+Vwq2Y2I9TQheToSmhVD02ak7EimjsUkkqvgtwZywI+reswfGgnhafYdSgMJ4u/pGAEN+nbj8pIIJusV0g7mX4cYs2+w5ajm7fm7W6YhfEdyIBLQJyAq20Tw+ltYGESwoU0Kizw6f1NQ/wSOuOF5jQt0SsgWk/Rqj/N7/qUJOK0/AR643vLxM8Sf3lek8oO8ZOlEGNOrdRywDhjv3YBvvOyYzlIxNaZQdroldMj/liPumN9p4e8p/Ksn/ITasEUxyCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ks/X2fDa6q10Y9myBxLw4rAFBWh0hAZEBINqP2WNelA=; b=iwNyx32KktqJkdjac0PUwtK3dOgon8K++k6YPvt8MCOtLCk/ceNEhWcmceKDGwxxM6yNa5bqJYhKE6uWN+C/LyJHsq7gR1mYtUUW4lcOjUoQNDA34lZgqSbQ0+faV3Z/fOAPcEUaN8NqD2DQS+JdkJjk4oKS9/Z+7P2WFG0n0SQLMOHWlK5xeb4sjjkmmNFX5bcaqtgadDNC23f8xhjrTOzzRJVIcx25P42HqQKAGbVmVEEHxIRLG31ylqgtvxEkcaonwpMMg7m2h73OTl9kychNNaDVvJGBnsdpcnDA8Z7S3fgT+5Q5Mb1mXDlqamCHCMHcVB7wsAnVoEtw0mfQZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ks/X2fDa6q10Y9myBxLw4rAFBWh0hAZEBINqP2WNelA=; b=nuHig3JzmFNDjCQ4wZvVVAWrJq/DaCFkpfnsx2vzaJ3FMtsqXEPOU6bUiSg7+tlWBPttcnpyBs9BUrOwgTI/u690QvOzwoq5cSTsf8l5w3Z9KGzRn+6xCtAYkpjN3YiROoAsppkSrA2tU3/Ofn+MY/osujL3KjCIF9jT8dym48M= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by AM4PR05MB3220.eurprd05.prod.outlook.com (10.171.188.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.15; Wed, 14 Aug 2019 06:05:14 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::3444:7cb9:25db:14c9]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::3444:7cb9:25db:14c9%3]) with mapi id 15.20.2157.022; Wed, 14 Aug 2019 06:05:14 +0000 From: Ori Kam To: Stephen Hemminger CC: Thomas Monjalon , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , Shahaf Shuler , Slava Ovsiienko , Alex Rosenbaum , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC] ethdev: support hairpin queue Thread-Index: AQHVUdxZYjq5dQPUn0m0/551v94NJqb5OMaAgADm1OCAAAgZIA== Date: Wed, 14 Aug 2019 06:05:13 +0000 Message-ID: References: <1565703468-55617-1-git-send-email-orika@mellanox.com> <20190813084619.6b78a7b9@hermes.lan> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [185.175.35.255] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f686e1ff-2f8c-4642-b48e-08d7207d5f71 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM4PR05MB3220; x-ms-traffictypediagnostic: AM4PR05MB3220: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 01294F875B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(396003)(39860400002)(366004)(136003)(376002)(13464003)(199004)(189003)(8676002)(229853002)(86362001)(9686003)(6246003)(6916009)(53936002)(7736002)(305945005)(66066001)(5660300002)(7696005)(81166006)(74316002)(4326008)(52536014)(99286004)(316002)(26005)(53546011)(54906003)(76176011)(186003)(33656002)(102836004)(6506007)(71200400001)(55016002)(256004)(14444005)(71190400001)(14454004)(66446008)(478600001)(486006)(66946007)(8936002)(64756008)(446003)(66556008)(66476007)(25786009)(11346002)(2906002)(76116006)(3846002)(476003)(81156014)(6116002)(2940100002)(6436002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3220; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: xJvSV5oIo1RMZSTMmnQBkiYLAOQ5ft54LMlTl1Y3aCvIMXYguQhtwv6p0ihI441nFuO0iucNlVo0s9a6cN014IN52p6xa6FldelbnCQd455GfKwZcySLPyffdKR2RzMP5pxFs/thDcdvuD2a/ATc/HaqvvRceqWoc59IPDofPlOsx1DMU8yNsYTZBcuKsBmDQY86xLUEoeNiU1hLeOkZZSPnJbJDPkIK216Q87UqiccDIWNE9sotBNBwJS3aAI4KgkJUPE7W7YekmSE+Y9Uc9z8gm/7+Uv76Wcio1HSRpdtSZaLnGF4qT0narsc7eILy4V6VXlfpvhfAB2kGTnqxLG0ayBud6TL15LwIFmR+hrrP9IHUwm9IkwkhXfBuK1ediNp0gSADR9Dt0f3BYiD/g0nKnbbIPP41z06Ol4YWCZ8= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f686e1ff-2f8c-4642-b48e-08d7207d5f71 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2019 06:05:13.9353 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2FhkJQAcdHVHNYxBZi3vENAt46yKZANCq8zD6Mfn0TsCmznj6QWWluBS3eb6No1swlbZGjQG3nhnEBdehVllSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3220 Subject: Re: [dpdk-dev] [RFC] ethdev: support hairpin queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ori Kam > Sent: Wednesday, August 14, 2019 8:36 AM > To: Stephen Hemminger > Cc: Thomas Monjalon ; ferruh.yigit@intel.com; > arybchenko@solarflare.com; Shahaf Shuler ; Slava > Ovsiienko ; Alex Rosenbaum > ; dev@dpdk.org > Subject: RE: [dpdk-dev] [RFC] ethdev: support hairpin queue >=20 > Hi Stephen, >=20 > > -----Original Message----- > > From: Stephen Hemminger > > Sent: Tuesday, August 13, 2019 6:46 PM > > To: Ori Kam > > Cc: Thomas Monjalon ; ferruh.yigit@intel.com; > > arybchenko@solarflare.com; Shahaf Shuler ; Slava > > Ovsiienko ; Alex Rosenbaum > > ; dev@dpdk.org > > Subject: Re: [dpdk-dev] [RFC] ethdev: support hairpin queue > > > > On Tue, 13 Aug 2019 13:37:48 +0000 > > Ori Kam wrote: > > > > > This RFC replaces RFC[1]. > > > > > > The hairpin feature (different name can be forward) acts as "bump on = the > > wire", > > > meaning that a packet that is received from the wire can be modified = using > > > offloaded action and then sent back to the wire without application > > intervention > > > which save CPU cycles. > > > > > > The hairpin is the inverse function of loopback in which application > > > sends a packet then it is received again by the > > > application without being sent to the wire. > > > > > > The hairpin can be used by a number of different NVF, for example loa= d > > > balancer, gateway and so on. > > > > > > As can be seen from the hairpin description, hairpin is basically RX = queue > > > connected to TX queue. > > > > > > During the design phase I was thinking of two ways to implement this > > > feature the first one is adding a new rte flow action. and the second > > > one is create a special kind of queue. > > > > > > Life would be easier for users if the hairpin was an attribute > > of queue configuration, not a separate API call. >=20 > I was thinking about it. the reason that I split the functions is that th= ey use > different > parameters sets. For example the hairpin queue doesn't need memory region > while it does need > the hairpin configuration. So in each case hairpin queue / normal queue t= here > will be > parameters that are not in use. I think this is less preferred. What do y= ou think? >=20 Forgot in my last mail two more reasons I had for this for this: 1. changing to existing function will break API, and will force all applica= tions to update date. 2. 2 API are easier to document and explain. 3. the reason stated above that there will be unused parameters in each cal= l. What do you think? > Thanks, > Ori