From: Ori Kam <orika@mellanox.com>
To: Matan Azrad <matan@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Jack Min <jackmin@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix last item detection on RSS flow expand
Date: Mon, 11 Nov 2019 17:41:42 +0000 [thread overview]
Message-ID: <AM4PR05MB34252EB27174F0AF6C63A753DB740@AM4PR05MB3425.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1573468925-24415-1-git-send-email-matan@mellanox.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Matan Azrad
> Sent: Monday, November 11, 2019 12:42 PM
> To: dev@dpdk.org
> Cc: Ori Kam <orika@mellanox.com>; Jack Min <jackmin@mellanox.com>
> Subject: [dpdk-dev] [PATCH] ethdev: fix last item detection on RSS flow
> expand
>
> There is a rte_flow API which expands a RSS flow pattern to multipile
> patterns according to the RSS hash types in the RSS action
> configuration.
>
> Aa part of the expansion, detection of the last item of the flow uses
> the "next proto" field of the last configured item in the pattern list.
> Wrongly, the mask of this field was not considered in order to validate
> the field.
>
> Ignore "next proto" fields when their corresponded masks invalidate them.
>
> Fixes: ec84aa45f17b ("ethdev: fix expand RSS flows")
> Cc: jackmin@mellanox.com
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> ---
Acked-by: Ori Kam <orika@mellanox.com>
Thanks,
Ori
next prev parent reply other threads:[~2019-11-11 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 10:42 Matan Azrad
2019-11-11 10:53 ` Jack Min
2019-11-11 17:13 ` Ferruh Yigit
2019-11-11 21:36 ` Ori Kam
2019-11-11 17:41 ` Ori Kam [this message]
2019-11-12 1:02 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR05MB34252EB27174F0AF6C63A753DB740@AM4PR05MB3425.eurprd05.prod.outlook.com \
--to=orika@mellanox.com \
--cc=dev@dpdk.org \
--cc=jackmin@mellanox.com \
--cc=matan@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).