From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <orika@mellanox.com> Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0085.outbound.protection.outlook.com [104.47.1.85]) by dpdk.org (Postfix) with ESMTP id 27B105B30 for <dev@dpdk.org>; Mon, 30 Jul 2018 20:02:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CdmPi1HUxSyt4NNJMrOFfHU2jpg4UmE9ejES9BflMV4=; b=mmid1YBlXldEww0nwOphHFUT2CyEslI9Heb1xuC/fYmr/fi41uvq6ljx1AB+NW+kjbRw5M68WbyyJUwKfxLv6jJVBWaH8xdQyZFuoeqGeA769W40+fKw9OgpzX3Ye3G8TQh9M6V+uBBH79x9PT4sK3PLVPSbmxjRtiIN0vnFiWw= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.187.142) by AM4PR05MB1780.eurprd05.prod.outlook.com (10.165.246.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.18; Mon, 30 Jul 2018 18:02:46 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::6d55:c970:605a:4106]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::6d55:c970:605a:4106%4]) with mapi id 15.20.0995.020; Mon, 30 Jul 2018 18:02:46 +0000 From: Ori Kam <orika@mellanox.com> To: Stephen Hemminger <stephen@networkplumber.org> CC: "Xueming(Steven) Li" <xuemingl@mellanox.com>, Dekel Peled <dekelp@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>, Adrien Mazarguil <adrien.mazarguil@6wind.com>, Thomas Monjalon <thomas@monjalon.net>, Yongseok Koh <yskoh@mellanox.com>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "arybchenko@solarflare.com" <arybchenko@solarflare.com>, "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [RFC] ethdev: add generic L2/L3 tunnel encapsulation actions Thread-Index: AQHUKCEqENeIxZSVmkOxcigSM6B9DqSoBTsAgAAIYPA= Date: Mon, 30 Jul 2018 18:02:46 +0000 Message-ID: <AM4PR05MB34253D6B66EA5F29ECD78999DB2F0@AM4PR05MB3425.eurprd05.prod.outlook.com> References: <1532967565-13962-1-git-send-email-orika@mellanox.com> <20180730102836.00605a3e@xeon-e3> In-Reply-To: <20180730102836.00605a3e@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [141.226.123.255] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB1780; 6:oz//tyP+WuA/WBreIAVnT+Jn/uIGXtN9nethteqB3zYJBbpg53BIVBA9lpXzqowUaQaYI8wFj797UoAX53I+EPkeve64ooJLi97b1TPBjnSb7Pv1gJIaPnf5E8/B/r3qyw2HDFQdZs1UL3acPFyY10Qe2cceE2dDppBz2LWFphyEyTZZUXpmlRe8ADsT2dJtEiruFwv1VAqcFN2a6fT9WxvO+YgaURG3MxrwOsDjVaOE/icAvywEqishW3uoUjcSuj617YHQWVo67uHEGQ/CSj58ORegbRnGSuIH5/o6AEArsw/07dwmRTd6np8vJi32IEmOBLmmxvkRFXj8ZoEVVzReMigp6hLZ7nfBNoCVqQOn3lZY4mUlR53cPZkY5EOJBGZnvGbnO8NwAE78U2Clb5PQoV4Jst5hCqQY1Dni0BXCX8W5e4Irc5cHQXezuZRSvLYnjc7G1/swi8fdfJyXwA==; 5:Jcdg/p/cRwwcTdbxwgBBVr57WMAinbhYC579lWFfzlVASN/FMYr5K3UXxQZ5XbFe2nSE9PTQzDQUopz/vxFuDv8zRJORf0W9m4xKFFxuP2zumROt9s0dlCY1PFp4feh0e1MFtdR0luOAGIExuAlS1+aaAAx4p16kkAdnNd9uB/c=; 7:CUozdl1Nm7CUH2CUB/IB06V9JYbpkGcZ8UO93czp/z59EJmIq1Ddq/uOYLVIPVB6CAjHLiHAPNsn0+sEjl6prZnMIX/ipgzOIG6Hs4sBpXsanTNv/xCYm4wUv6l8j9ntKy0t/g50ctXSfjN/m2i0z67VpypBxmmMCJYIFI4z3MR6p1WGZzuwemNm2HtbDbkmYf1tKVFF/O2ocfuHYRG8ympgasZwqYKHSmo4X4oHyuLiTjPyPIV11kiNsuAznsDs x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 4e9bd544-ff55-4939-dc39-08d5f646a7f2 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB1780; x-ms-traffictypediagnostic: AM4PR05MB1780: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: <AM4PR05MB17804B7FC66547C2C288170EDB2F0@AM4PR05MB1780.eurprd05.prod.outlook.com> x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:AM4PR05MB1780; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB1780; x-forefront-prvs: 0749DC2CE6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(366004)(346002)(396003)(136003)(31014005)(13464003)(199004)(189003)(8676002)(446003)(97736004)(486006)(476003)(5250100002)(11346002)(478600001)(86362001)(4326008)(81166006)(7696005)(14444005)(76176011)(2906002)(105586002)(256004)(68736007)(14454004)(25786009)(106356001)(3846002)(81156014)(6506007)(6246003)(8936002)(5660300001)(26005)(53546011)(99286004)(33656002)(102836004)(53936002)(6436002)(229853002)(6116002)(66066001)(74316002)(55016002)(9686003)(305945005)(6916009)(54906003)(7736002)(186003)(2900100001)(316002)(41533002)(7756004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB1780; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: wTEEW69zNxFy8ib72yWCY8U61NDYg8/QetkBkgJ/rbF6S12+K80wfg3RjEyWvyMKVrkxGmQ7DcafY1EK1XEIGVIFlNfLPgtw9Vdf/k/FO6vygQ62CFHPoBkWf/eaG6cSy339TzHNaI6tFrjn34qpbMe/Qc6I5ewcU3L9jMZyna2MB8P7ud2lRNovgV8UU9bmVkEJ4/aqSCN8+KxS+0cuUE5tvYo/vzcqaNhctlEDgnTamExbAY1qw8o7f0IRSNqkr/9q5OsfCgP4pI15o03HwHFrguM2eAnR7APUTD9aBA7PamF/hWW5ViDhpgafrIZtBZPZDcMqSd7FxUv1Q//aqc35JyWpJO0evjEct4QmCig= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e9bd544-ff55-4939-dc39-08d5f646a7f2 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2018 18:02:46.7737 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB1780 Subject: Re: [dpdk-dev] [RFC] ethdev: add generic L2/L3 tunnel encapsulation actions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 30 Jul 2018 18:02:49 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Monday, July 30, 2018 8:29 PM > To: Ori Kam <orika@mellanox.com> > Cc: Xueming(Steven) Li <xuemingl@mellanox.com>; Dekel Peled > <dekelp@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>; Adrien > Mazarguil <adrien.mazarguil@6wind.com>; Thomas Monjalon > <thomas@monjalon.net>; Yongseok Koh <yskoh@mellanox.com>; > ferruh.yigit@intel.com; arybchenko@solarflare.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC] ethdev: add generic L2/L3 tunnel > encapsulation actions >=20 > On Mon, 30 Jul 2018 19:19:25 +0300 > Ori Kam <orika@mellanox.com> wrote: >=20 > > Currenlty the encap/decap actions only support encapsulation > > of VXLAN and NVGRE L2 packets. > > There is a need to add more L2 tunnels and also L3 tunnels. > > > > One issue with the current approch is the duplication of code. > > For example the code for handling NVGRE and VXLAN are exactly the > same, > > and each new tunnel will have the same exact structure. > > > > Last issue with the current approach is the use of rte_items. > > The most significant issue with that is that the PMD needs to convert > > the items and this hurts the insertion rate. Other issue is that > > the rte_item has 3 members while we only need the spec (last and mask > > are useless). I know that the extra member have only small memory > > impact but considering that we can have millions of rules, this became > > more important consideration, and it is bad practice to add a variable > > that is never used. > > > > My suggestion is to create 2 commands, one for encapsulation of L2 > > packets and one for encapsulation of L3 tunnels. > > The parameters for those functions will be a uint8_t buffer with > > a length parameter. > > > > The current approach is not implemented yet in drivers yet, and > > is marked as experimental, so it should be removed. > > > > Any comments will be hugely appreciated. > > > > Signed-off-by: Ori Kam <orika@mellanox.com> >=20 > What about binary and source compatibilities with older release? I'm not sure what you mean, currently this feature is not implemented=20 In any PMD (as far as I can see) so no one uses it, and it is marked as experimental. In any case if this is an issue we can keep the old one and j= ust=20 add the new one.=20 Best, Ori