DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ori Kam <orika@mellanox.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	Rory Sexton <rory.sexton@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"qi.z.zhang@intel.com" <qi.z.zhang@intel.com>,
	"beilei.xing@intel.com" <beilei.xing@intel.com>,
	Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: Dariusz Jagus <dariuszx.jagus@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add L2TPv3 over IP header to flow API
Date: Sun, 12 Jan 2020 10:57:30 +0000	[thread overview]
Message-ID: <AM4PR05MB342546E282E346145D203790DB3A0@AM4PR05MB3425.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <bb600820-0535-aea9-f05f-4d8de4d65d06@intel.com>

Hi 

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Friday, January 10, 2020 8:26 PM
> To: Rory Sexton <rory.sexton@intel.com>; dev@dpdk.org;
> qi.z.zhang@intel.com; beilei.xing@intel.com; Adrien Mazarguil
> <adrien.mazarguil@6wind.com>; Ori Kam <orika@mellanox.com>
> Cc: Dariusz Jagus <dariuszx.jagus@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add L2TPv3 over IP header to
> flow API
> 
> On 1/7/2020 3:39 PM, Rory Sexton wrote:
> > This patch adds the new flow item RTE_FLOW_ITEM_TYPE_L2TPV3OIP to
> > flow API to match a L2TPv3 over IP header. This patch supports only
> > L2TPv3 over IP header format which is different to L2TPv2/L2TPv3
> > over UDP. The difference in header formats between L2TPv3 over IP
> > and L2TP over UDP require a separate implementation for each.
> >
> > Signed-off-by: Rory Sexton <rory.sexton@intel.com>
> > Signed-off-by: Dariusz Jagus <dariuszx.jagus@intel.com>
> 
> Hi Ori,
> 
> Any concern on this version, can we proceed with it?

I just acked it in the original thread.
Thanks, and sorry for the long review time.
Ori

  reply	other threads:[~2020-01-12 10:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-07 15:39 Rory Sexton
2020-01-07 15:39 ` [dpdk-dev] [PATCH v3 2/2] net/i40e: support FDIR for L2TPv3 over IP Rory Sexton
2020-01-10 18:27   ` Ferruh Yigit
2020-01-13  3:22   ` Xing, Beilei
2020-01-13  8:07     ` Xing, Beilei
2020-01-13 10:42       ` Sexton, Rory
2020-01-10 18:26 ` [dpdk-dev] [PATCH v3 1/2] ethdev: add L2TPv3 over IP header to flow API Ferruh Yigit
2020-01-12 10:57   ` Ori Kam [this message]
2020-01-12 10:56 ` Ori Kam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM4PR05MB342546E282E346145D203790DB3A0@AM4PR05MB3425.eurprd05.prod.outlook.com \
    --to=orika@mellanox.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=beilei.xing@intel.com \
    --cc=dariuszx.jagus@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=rory.sexton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).