DPDK patches and discussions
 help / color / Atom feed
From: Ori Kam <orika@mellanox.com>
To: Slava Ovsiienko <viacheslavo@mellanox.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@mellanox.com>,
	Raslan Darawsheh <rasland@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix default mark copy flow
Date: Wed, 27 Nov 2019 13:45:33 +0000
Message-ID: <AM4PR05MB3425621B787158EAC76F44D0DB440@AM4PR05MB3425.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1574861803-13397-1-git-send-email-viacheslavo@mellanox.com>



> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> Sent: Wednesday, November 27, 2019 3:37 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh
> <rasland@mellanox.com>; Ori Kam <orika@mellanox.com>
> Subject: [PATCH v2] net/mlx5: fix default mark copy flow
> 
> In extensive metadata mode the MARK copy table is engaged,
> if the application creates the flow with zero MARK ID action:
> 
> flow create 1 ingress pattern eth / ... / end actions mark id 0 / .. end
> 
> And then destroys that, the traffic to the port stops. This happens
> due to default flow for the copy table has the zero ID and is removed
> with the application rule. The patch extends internal ID variable
> to 64 bits and provide the UINT64_MAX ID for the copy table default
> rule.
> 
> Fixes: dd3c774f6ffb ("net/mlx5: add metadata register copy table")
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_defs.h |  1 +
>  drivers/net/mlx5/mlx5_flow.c | 13 +++++++------
>  2 files changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h
> index 9e113c5..042e1f3 100644
> --- a/drivers/net/mlx5/mlx5_defs.h
> +++ b/drivers/net/mlx5/mlx5_defs.h
> @@ -174,6 +174,7 @@
>  /* Size of the simple hash table for metadata register table. */
>  #define MLX5_FLOW_MREG_HTABLE_SZ 4096
>  #define MLX5_FLOW_MREG_HNAME "MARK_COPY_TABLE"
> +#define MLX5_DEFAULT_COPY_ID UINT32_MAX
> 
>  /* Definition of static_assert found in /usr/include/assert.h */
>  #ifndef HAVE_STATIC_ASSERT
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 5c78ea7..0087163 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -2947,16 +2947,16 @@ uint32_t mlx5_flow_adjust_priority(struct
> rte_eth_dev *dev, int32_t priority,
>  	mcp_res = (void *)mlx5_hlist_lookup(priv->mreg_cp_tbl, mark_id);
>  	if (mcp_res) {
>  		/* For non-default rule. */
> -		if (mark_id)
> +		if (mark_id != MLX5_DEFAULT_COPY_ID)
>  			mcp_res->refcnt++;
> -		assert(mark_id || mcp_res->refcnt == 1);
> +		assert(mark_id != MLX5_DEFAULT_COPY_ID || mcp_res-
> >refcnt == 1);
>  		return mcp_res;
>  	}
>  	/* Provide the full width of FLAG specific value. */
>  	if (mark_id == (priv->sh->dv_regc0_mask &
> MLX5_FLOW_MARK_DEFAULT))
>  		tag_spec.data = MLX5_FLOW_MARK_DEFAULT;
>  	/* Build a new flow. */
> -	if (mark_id) {
> +	if (mark_id != MLX5_DEFAULT_COPY_ID) {
>  		items[0] = (struct rte_flow_item){
>  			.type = MLX5_RTE_FLOW_ITEM_TYPE_TAG,
>  			.spec = &tag_spec,
> @@ -3054,7 +3054,7 @@ uint32_t mlx5_flow_adjust_priority(struct
> rte_eth_dev *dev, int32_t priority,
>  	}
>  	/*
>  	 * We do not check availability of metadata registers here,
> -	 * because copy resources are allocated in this case.
> +	 * because copy resources are not allocated in this case.
>  	 */
>  	if (--mcp_res->refcnt)
>  		return;
> @@ -3133,7 +3133,8 @@ uint32_t mlx5_flow_adjust_priority(struct
> rte_eth_dev *dev, int32_t priority,
>  	/* Check if default flow is registered. */
>  	if (!priv->mreg_cp_tbl)
>  		return;
> -	mcp_res = (void *)mlx5_hlist_lookup(priv->mreg_cp_tbl, 0ULL);
> +	mcp_res = (void *)mlx5_hlist_lookup(priv->mreg_cp_tbl,
> +					    MLX5_DEFAULT_COPY_ID);
>  	if (!mcp_res)
>  		return;
>  	assert(mcp_res->flow);
> @@ -3166,7 +3167,7 @@ uint32_t mlx5_flow_adjust_priority(struct
> rte_eth_dev *dev, int32_t priority,
>  	    !mlx5_flow_ext_mreg_supported(dev) ||
>  	    !priv->sh->dv_regc0_mask)
>  		return 0;
> -	mcp_res = flow_mreg_add_copy_action(dev, 0, error);
> +	mcp_res = flow_mreg_add_copy_action(dev,
> MLX5_DEFAULT_COPY_ID, error);
>  	if (!mcp_res)
>  		return -rte_errno;
>  	return 0;
> --
> 1.8.3.1
Acked-by: Ori Kam <orika@mellanox.com>

Best,
Ori

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27 13:36 Viacheslav Ovsiienko
2019-11-27 13:45 ` Ori Kam [this message]
2019-11-27 15:16   ` Thomas Monjalon

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM4PR05MB3425621B787158EAC76F44D0DB440@AM4PR05MB3425.eurprd05.prod.outlook.com \
    --to=orika@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=rasland@mellanox.com \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox