From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC6FEA0613 for ; Sat, 28 Sep 2019 18:23:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D4D26152A; Sat, 28 Sep 2019 18:23:06 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70079.outbound.protection.outlook.com [40.107.7.79]) by dpdk.org (Postfix) with ESMTP id 63420271 for ; Sat, 28 Sep 2019 18:23:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yw32IRk7GIZHAiL0FJTlGrkJu2I1ncOmmgryDZk20wpj7b5fqbV6cYoN3XCO/3XeosDx0VtfU2QuE3PqnLhSjIZXFCOavtpHIofzi2r2GCalbQs0qE7zDSuosS2NuSXGDjowR0KLIjXNZYnDIycpRZ+N7rQv1o9P4Df2I3NxXW0oloiGg2zXJxxU4lR5UCt2ANz0oCaT1A+zcSg9q6sAghooVzImipsyzYDAQteIWhjVkSTre17LnHRdN6SJBLj1gluixONnXexfyEmhzi9DhQuDIKe40ZblHNmD4BLqslyOU5Mkzo5/bh1w2Yl/GrK/NYMntOxWA219DxlvNd2Yig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/9gaZWVHeKIN4LwNk40zq9jOSDDUPdnJlFMbPaKHuqU=; b=Jww0IHTnXDKwTr4RCC0HJgfblXwqxNPyVCyX9+EzD92DDor63CsOlYTaJdYjF8EGQ0UkUvk9nlfZ7CnXjZt1OuwN6gQ/N/tK7lfA6/no6GzY+sYgmnHaSqdwFOYxUh/d2ZACPucN448tXEBBQsNzkoTgYitYz1Umm+lCjXE4e69fhfVCZR9s8VEZ02Ncj2oh28tY8QLTN2TgDASf5ZFH64t8gw+DfjO0yksYspgjppDNUn7XmYGgbf8nvpM86DDeLVEcrsb3saFJB7NrtZQ6qxo3bsqB06Qc0rm43+4jrTTiBMxDL83mGSziRBjsBwCuYmqSP0KXuryrtfOeN/Em/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/9gaZWVHeKIN4LwNk40zq9jOSDDUPdnJlFMbPaKHuqU=; b=H5VepvKyh/ctdxmdkT+mhgIxJLw0We3anW0y6V9ppVpgSdP1VtXNNRi6ZeadAB/CG7yrFSvAU7WuVqk1XWwkJxGK4GejRMb06loVTkxx1AKiCu3X3zY0q46s1fOxHk6F4Zk7BYUESmQCJmMZMuyuDdT4/GkKt8Zpz2z7BMPKP6o= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by AM4PR05MB3282.eurprd05.prod.outlook.com (10.171.187.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.17; Sat, 28 Sep 2019 16:23:04 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::7964:7996:4c67:ade0]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::7964:7996:4c67:ade0%3]) with mapi id 15.20.2305.017; Sat, 28 Sep 2019 16:23:04 +0000 From: Ori Kam To: Simei Su , "qi.z.zhang@intel.com" , "jingjing.wu@intel.com" , "xiaolong.ye@intel.com" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v5 1/3] ethdev: decouple flow types and RSS offload types Thread-Index: AQHVdaSNBrT/c1JodE6XRGFK4n+L16dBRo3Q Date: Sat, 28 Sep 2019 16:23:04 +0000 Message-ID: References: <1569574449-47991-1-git-send-email-simei.su@intel.com> <1569637743-174186-1-git-send-email-simei.su@intel.com> <1569637743-174186-2-git-send-email-simei.su@intel.com> In-Reply-To: <1569637743-174186-2-git-send-email-simei.su@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [185.175.35.255] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0fc39cae-f103-40da-595e-08d744302390 x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: AM4PR05MB3282: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 0174BD4BDA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(39850400004)(376002)(366004)(396003)(136003)(189003)(199004)(13464003)(8936002)(74316002)(446003)(76116006)(66946007)(66476007)(64756008)(6436002)(66446008)(7696005)(76176011)(6246003)(229853002)(5660300002)(11346002)(478600001)(110136005)(9686003)(486006)(71200400001)(33656002)(316002)(476003)(71190400001)(6506007)(53546011)(4326008)(66556008)(55016002)(26005)(256004)(102836004)(2201001)(81156014)(305945005)(7736002)(2501003)(81166006)(6116002)(66066001)(2906002)(3846002)(86362001)(25786009)(99286004)(186003)(14454004)(52536014); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3282; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BuN8pj9S4QlfWisVc/8X7JZ45wbUu0od4rhAWe5IXyIgaJLzdA4MzbWteGm6L5B6Lf1zEv18ALcIZzwcg5m0Wkb20erRZ89aIC5t5MsjQiItV9ZEuaWS5oMdkBCJR8hQ/QrMK9z+BYMvNdtvOZRs3CnpG6q62hd66WMcabdrgmCYoua1ghj+VfVbKuzQrTM+BBPY9GTAb5yGKLvx6q950zUGf9McJ1Raf6BCesuEDE0gHpAubSAuYgbpX+Nar2VFybOz1AbsusCQC/Sko1pbq/2nzAk+GKgj4ofdntjhVGmgaH3YQ+VgM6YGmR/+NuBCVv1I/DugasjmVBxks/l8mUJw6C0bJIM7+qz5wptSnH4i4T4Jj5BUDz2c5+nZoqhcJudzn8p087slwGJxH4Sz1LfulPvjsQZ263kB8OxWRXI= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0fc39cae-f103-40da-595e-08d744302390 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2019 16:23:04.0237 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yU1chVHfPfNtOEe9wLlIBf21Y6bEv1Y9VqdcbGqrzhBmWhVxDNAqePjbTMWSQyXXxYK3gBxAiwDUrO55RgqIgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3282 Subject: Re: [dpdk-dev] [PATCH v5 1/3] ethdev: decouple flow types and RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Simei Su > Sent: Saturday, September 28, 2019 5:29 AM > To: qi.z.zhang@intel.com; jingjing.wu@intel.com; xiaolong.ye@intel.com > Cc: dev@dpdk.org; simei.su@intel.com > Subject: [dpdk-dev] [PATCH v5 1/3] ethdev: decouple flow types and RSS of= fload > types >=20 > This patch decouples RTE_ETH_FLOW_* and ETH_RSS_*. Both serves > different purposes. The former defines flow types. The later > defines RSS offload types. >=20 > Signed-off-by: Simei Su > --- Acked-by: Ori Kam Thanks, Ori > lib/librte_ethdev/rte_ethdev.h | 49 ++++++++++++++++++++----------------= ------ > 1 file changed, 23 insertions(+), 26 deletions(-) >=20 > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethde= v.h > index d987178..1605467 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -453,7 +453,6 @@ struct rte_eth_rss_conf { > * possible, and exclusively. For example, if a packet is identified as > * 'RTE_ETH_FLOW_NONFRAG_IPV4_TCP', it will not be any of other flow > types, > * though it is an actual IPV4 packet. > - * Note that the flow types are used to define RSS offload types. > */ > #define RTE_ETH_FLOW_UNKNOWN 0 > #define RTE_ETH_FLOW_RAW 1 > @@ -482,31 +481,29 @@ struct rte_eth_rss_conf { > #define RTE_ETH_FLOW_MAX 23 >=20 > /* > - * The RSS offload types are defined based on flow types. > - * Different NIC hardware may support different RSS offload > - * types. The supported flow types or RSS offload types can be queried b= y > - * rte_eth_dev_info_get(). > - */ > -#define ETH_RSS_IPV4 (1ULL << RTE_ETH_FLOW_IPV4) > -#define ETH_RSS_FRAG_IPV4 (1ULL << RTE_ETH_FLOW_FRAG_IPV4) > -#define ETH_RSS_NONFRAG_IPV4_TCP (1ULL << > RTE_ETH_FLOW_NONFRAG_IPV4_TCP) > -#define ETH_RSS_NONFRAG_IPV4_UDP (1ULL << > RTE_ETH_FLOW_NONFRAG_IPV4_UDP) > -#define ETH_RSS_NONFRAG_IPV4_SCTP (1ULL << > RTE_ETH_FLOW_NONFRAG_IPV4_SCTP) > -#define ETH_RSS_NONFRAG_IPV4_OTHER (1ULL << > RTE_ETH_FLOW_NONFRAG_IPV4_OTHER) > -#define ETH_RSS_IPV6 (1ULL << RTE_ETH_FLOW_IPV6) > -#define ETH_RSS_FRAG_IPV6 (1ULL << RTE_ETH_FLOW_FRAG_IPV6) > -#define ETH_RSS_NONFRAG_IPV6_TCP (1ULL << > RTE_ETH_FLOW_NONFRAG_IPV6_TCP) > -#define ETH_RSS_NONFRAG_IPV6_UDP (1ULL << > RTE_ETH_FLOW_NONFRAG_IPV6_UDP) > -#define ETH_RSS_NONFRAG_IPV6_SCTP (1ULL << > RTE_ETH_FLOW_NONFRAG_IPV6_SCTP) > -#define ETH_RSS_NONFRAG_IPV6_OTHER (1ULL << > RTE_ETH_FLOW_NONFRAG_IPV6_OTHER) > -#define ETH_RSS_L2_PAYLOAD (1ULL << RTE_ETH_FLOW_L2_PAYLOAD) > -#define ETH_RSS_IPV6_EX (1ULL << RTE_ETH_FLOW_IPV6_EX) > -#define ETH_RSS_IPV6_TCP_EX (1ULL << RTE_ETH_FLOW_IPV6_TCP_EX) > -#define ETH_RSS_IPV6_UDP_EX (1ULL << RTE_ETH_FLOW_IPV6_UDP_EX) > -#define ETH_RSS_PORT (1ULL << RTE_ETH_FLOW_PORT) > -#define ETH_RSS_VXLAN (1ULL << RTE_ETH_FLOW_VXLAN) > -#define ETH_RSS_GENEVE (1ULL << RTE_ETH_FLOW_GENEVE) > -#define ETH_RSS_NVGRE (1ULL << RTE_ETH_FLOW_NVGRE) > + * Below macros are defined for RSS offload types, they can be used to > + * fill rte_eth_rss_conf.rss_hf or rte_flow_action_rss.types. > + */ > +#define ETH_RSS_IPV4 (1ULL << 2) > +#define ETH_RSS_FRAG_IPV4 (1ULL << 3) > +#define ETH_RSS_NONFRAG_IPV4_TCP (1ULL << 4) > +#define ETH_RSS_NONFRAG_IPV4_UDP (1ULL << 5) > +#define ETH_RSS_NONFRAG_IPV4_SCTP (1ULL << 6) > +#define ETH_RSS_NONFRAG_IPV4_OTHER (1ULL << 7) > +#define ETH_RSS_IPV6 (1ULL << 8) > +#define ETH_RSS_FRAG_IPV6 (1ULL << 9) > +#define ETH_RSS_NONFRAG_IPV6_TCP (1ULL << 10) > +#define ETH_RSS_NONFRAG_IPV6_UDP (1ULL << 11) > +#define ETH_RSS_NONFRAG_IPV6_SCTP (1ULL << 12) > +#define ETH_RSS_NONFRAG_IPV6_OTHER (1ULL << 13) > +#define ETH_RSS_L2_PAYLOAD (1ULL << 14) > +#define ETH_RSS_IPV6_EX (1ULL << 15) > +#define ETH_RSS_IPV6_TCP_EX (1ULL << 16) > +#define ETH_RSS_IPV6_UDP_EX (1ULL << 17) > +#define ETH_RSS_PORT (1ULL << 18) > +#define ETH_RSS_VXLAN (1ULL << 19) > +#define ETH_RSS_GENEVE (1ULL << 20) > +#define ETH_RSS_NVGRE (1ULL << 21) >=20 > #define ETH_RSS_IP ( \ > ETH_RSS_IPV4 | \ > -- > 1.8.3.1