From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B861A2EEB for ; Thu, 12 Sep 2019 07:16:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 82AD21E4EC; Thu, 12 Sep 2019 07:16:37 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50053.outbound.protection.outlook.com [40.107.5.53]) by dpdk.org (Postfix) with ESMTP id BE1921E4EB for ; Thu, 12 Sep 2019 07:16:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TzejPiW32DRz2vahEubwgFbHB+LY+HJkHKI20mxRcbRTVmEF6GP3vKX9IAeomIsipPnagjPm0/urFVR4UXbBMkAO16jl+U6SCAkfFbH7VMVvpWpZkodeoAiT3BXmTwrsngNy0yWX+FbkXdIvMS0ZxXn0XIut4nPaJotwkU5CN2E98Bop45AYX4ChiJ8xOdk0ZWC4QTZyM+x978A44QtP5d0qjNTs/tD8HAgyqZxuwteNqUd0N8A0UWiiTuiRHd4JuO/CjfmyVN+z8dhMx5tVEHyo8p4wHY73YmlP+JbJjPVWThtYRJcamsKqzCGX9mkBpJjTu5RTrCJGJ/SObO+hyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uzHrHx7qCTM03BeSkGBf66K7xlzuY9wC6EwIAZcq7H8=; b=SRAMT+me3XUZc+lxEZw29uJHqPFS/lAMeaAYCDFdJkpSQ1NDxLKx2xC3Ppnefk6WB7oA6QZ+TO7hhdDevVXFgtS/VYPj6t+dHXuFBanWl7elz+QD1tmxJsfgImzuUsJiYfYCfNyC4ZwYpJwhfhjDNWp5PC2n23jmGsGBHq2U97tvUPHqGbRZg05JRVuW8pJ3AkPUe05OkL+2V8+8kKHD+nKRXmNJukiD/sdst+w4mjUHt7z4b7TOCuQ/LSYNFRWqR0Dk+0kQamSFkWXOT6wAlMBRUjNwosI2x4ros3h9qUlJwMudLaM5jP7fm0mIQJrfIeKnzBj0J1n6UopfjQ9/uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uzHrHx7qCTM03BeSkGBf66K7xlzuY9wC6EwIAZcq7H8=; b=ma1DnoPV5ZQXbuGqTpBtyzNFliIAz2b5GEBld5wP5T9A3ManGYDvd07lUGVOEcGu6a7RfZWZY0CcZc5/tsutUYL/jk8CZxn8eybwNytSVSs05baHopdVoUtC8Ueb4feCLG2FK0EvERtUtpAOF18vXgG1CUqzWb+RcgxmY62JUVI= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by AM4PR05MB3396.eurprd05.prod.outlook.com (10.171.187.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.18; Thu, 12 Sep 2019 05:16:34 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::4c32:a34f:5558:a2c6]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::4c32:a34f:5558:a2c6%7]) with mapi id 15.20.2241.022; Thu, 12 Sep 2019 05:16:33 +0000 From: Ori Kam To: Andrew Rybchenko , Marko Kovacevic , Bruce Richardson , Pablo de Lara , Radu Nicolau , Akhil Goyal , Tomasz Kantecki CC: "dev@dpdk.org" , Igor Romanov Thread-Topic: [PATCH 14/18] examples/flow_filtering: check status of getting link info Thread-Index: AQHVZ7Fvbv7yOvSDpUCx2Rkfu/Dr+6cnguOg Date: Thu, 12 Sep 2019 05:16:33 +0000 Message-ID: References: <1568103959-25572-1-git-send-email-arybchenko@solarflare.com> <1568103959-25572-15-git-send-email-arybchenko@solarflare.com> In-Reply-To: <1568103959-25572-15-git-send-email-arybchenko@solarflare.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fcb68945-fbd6-4810-79f5-08d7374060ed x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600166)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM4PR05MB3396; x-ms-traffictypediagnostic: AM4PR05MB3396: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:270; x-forefront-prvs: 01583E185C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(376002)(136003)(396003)(39860400002)(189003)(199004)(13464003)(478600001)(6246003)(53546011)(14444005)(6436002)(256004)(476003)(53936002)(76176011)(7696005)(6506007)(55016002)(11346002)(25786009)(26005)(71190400001)(3846002)(102836004)(446003)(4326008)(486006)(99286004)(9686003)(316002)(7736002)(229853002)(81166006)(8936002)(186003)(71200400001)(6116002)(8676002)(5660300002)(81156014)(52536014)(2906002)(110136005)(54906003)(66066001)(86362001)(33656002)(66446008)(305945005)(66556008)(64756008)(66946007)(76116006)(66476007)(14454004)(74316002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3396; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 77nitg5iCpbmtes6gHyEyqPLRiFjLyzksQSRTv7/jSYhm9/DxZZXcmwsUJmPcp8l7h04x1D3hDdZVX1x1oK3vsp81lt39ZLicBiAbamA1a0eI1iW4639uRcuoqIXZdFt3hPgqwwJUTVVJ0Y+cmsBX4efO33FA/6Em+24Y3noreOvyUombs8KNzClPll0Y8OhgpFGSEYtkHeE/c+PMOtuKZN6zPSkzEuuBEeinvIYGlePsetGijynqaxou+azOByfpClb06ErVsNQvSTl62ljZJTrSQVH5mP4XgWn5o8pNOtHkhjMhe6JrGlpCq6AcBWHqr5iCQBGj2xVYKB8KYkqWjSdCddJF9Sb4LD7L/tJNhV5LCrvDfCIcC0SeWkAX2cyp5r9R62KMgtuESYxiH3lKlRgmYZwRZ2ugp2AqUySt8s= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: fcb68945-fbd6-4810-79f5-08d7374060ed X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2019 05:16:33.8512 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GV/gk43jOUmWG2OpbM/adXw2nrjbW4Bo6RxjuneX4e34yPsVtLNxOcKTtBCi2Ug+deBoK60Ds3VCLoFQtAZPYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3396 Subject: Re: [dpdk-dev] [PATCH 14/18] examples/flow_filtering: check status of getting link info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Andrew Rybchenko > Sent: Tuesday, September 10, 2019 11:26 AM > To: Marko Kovacevic ; Ori Kam > ; Bruce Richardson ; > Pablo de Lara ; Radu Nicolau > ; Akhil Goyal ; Tomasz > Kantecki > Cc: dev@dpdk.org; Igor Romanov > Subject: [PATCH 14/18] examples/flow_filtering: check status of getting l= ink > info >=20 > From: Igor Romanov >=20 > The return value of rte_eth_link_get() and rte_eth_link_get_nowait() > was changed from void to int. Update the usage of the functions > according to the new return type. >=20 > Signed-off-by: Igor Romanov > Signed-off-by: Andrew Rybchenko > --- > examples/flow_filtering/main.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/mai= n.c > index c40cfd098..cc9e7e780 100644 > --- a/examples/flow_filtering/main.c > +++ b/examples/flow_filtering/main.c > @@ -100,15 +100,19 @@ assert_link_status(void) > { > struct rte_eth_link link; > uint8_t rep_cnt =3D MAX_REPEAT_TIMES; > + int link_get_err =3D -EINVAL; >=20 > memset(&link, 0, sizeof(link)); > do { > - rte_eth_link_get(port_id, &link); > - if (link.link_status =3D=3D ETH_LINK_UP) > + link_get_err =3D rte_eth_link_get(port_id, &link); > + if (link_get_err =3D=3D 0 && link.link_status =3D=3D ETH_LINK_UP) > break; > rte_delay_ms(CHECK_INTERVAL); > } while (--rep_cnt); >=20 > + if (link_get_err < 0) > + rte_exit(EXIT_FAILURE, ":: error: link get is failing: %s\n", > + rte_strerror(-link_get_err)); > if (link.link_status =3D=3D ETH_LINK_DOWN) > rte_exit(EXIT_FAILURE, ":: error: link is still down\n"); > } > -- > 2.17.1 Acked-by: Ori Kam Thanks, Ori Kam