* [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter
@ 2018-07-23 7:18 Nelio Laranjeiro
2018-07-23 22:38 ` Yongseok Koh
2018-07-24 6:27 ` Ori Kam
0 siblings, 2 replies; 4+ messages in thread
From: Nelio Laranjeiro @ 2018-07-23 7:18 UTC (permalink / raw)
To: dev, Yongseok Koh, Shahaf Shuler; +Cc: stable
In mlx5_traffic_enable() the TCI mask for the VLAN is wrong causing the
sub flow engine to reject the rule.
Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic")
Cc: stable@dpdk.org
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
drivers/net/mlx5/mlx5_trigger.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c
index 4d2078bbd..d02a626ae 100644
--- a/drivers/net/mlx5/mlx5_trigger.c
+++ b/drivers/net/mlx5/mlx5_trigger.c
@@ -300,9 +300,8 @@ mlx5_traffic_enable(struct rte_eth_dev *dev)
struct rte_flow_item_vlan vlan_spec = {
.tci = rte_cpu_to_be_16(vlan),
};
- struct rte_flow_item_vlan vlan_mask = {
- .tci = 0xffff,
- };
+ struct rte_flow_item_vlan vlan_mask =
+ rte_flow_item_vlan_mask;
ret = mlx5_ctrl_flow_vlan(dev, &bcast, &bcast,
&vlan_spec, &vlan_mask);
@@ -339,9 +338,8 @@ mlx5_traffic_enable(struct rte_eth_dev *dev)
struct rte_flow_item_vlan vlan_spec = {
.tci = rte_cpu_to_be_16(vlan),
};
- struct rte_flow_item_vlan vlan_mask = {
- .tci = 0xffff,
- };
+ struct rte_flow_item_vlan vlan_mask =
+ rte_flow_item_vlan_mask;
ret = mlx5_ctrl_flow_vlan(dev, &unicast,
&unicast_mask,
--
2.18.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter
2018-07-23 7:18 [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter Nelio Laranjeiro
@ 2018-07-23 22:38 ` Yongseok Koh
2018-07-24 13:45 ` Shahaf Shuler
2018-07-24 6:27 ` Ori Kam
1 sibling, 1 reply; 4+ messages in thread
From: Yongseok Koh @ 2018-07-23 22:38 UTC (permalink / raw)
To: Nélio Laranjeiro; +Cc: dev, Shahaf Shuler, stable
> On Jul 23, 2018, at 12:18 AM, Nelio Laranjeiro <nelio.laranjeiro@6wind.com> wrote:
>
> In mlx5_traffic_enable() the TCI mask for the VLAN is wrong causing the
> sub flow engine to reject the rule.
>
> Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic")
> Cc: stable@dpdk.org
>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter
2018-07-23 22:38 ` Yongseok Koh
@ 2018-07-24 13:45 ` Shahaf Shuler
0 siblings, 0 replies; 4+ messages in thread
From: Shahaf Shuler @ 2018-07-24 13:45 UTC (permalink / raw)
To: Yongseok Koh, Nélio Laranjeiro; +Cc: dev, stable
Tuesday, July 24, 2018 1:38 AM, Yongseok Koh:
> Subject: Re: [PATCH] net/mlx5: fix tci mask filter
>
>
> > On Jul 23, 2018, at 12:18 AM, Nelio Laranjeiro
> <nelio.laranjeiro@6wind.com> wrote:
> >
> > In mlx5_traffic_enable() the TCI mask for the VLAN is wrong causing
> > the sub flow engine to reject the rule.
> >
> > Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Applied to next-net-mlx, thanks.
>
> Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter
2018-07-23 7:18 [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter Nelio Laranjeiro
2018-07-23 22:38 ` Yongseok Koh
@ 2018-07-24 6:27 ` Ori Kam
1 sibling, 0 replies; 4+ messages in thread
From: Ori Kam @ 2018-07-24 6:27 UTC (permalink / raw)
To: Nélio Laranjeiro, dev, Yongseok Koh, Shahaf Shuler; +Cc: stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Nelio Laranjeiro
> Sent: Monday, July 23, 2018 10:19 AM
> To: dev@dpdk.org; Yongseok Koh <yskoh@mellanox.com>; Shahaf Shuler
> <shahafs@mellanox.com>
> Cc: stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter
>
> In mlx5_traffic_enable() the TCI mask for the VLAN is wrong causing the
> sub flow engine to reject the rule.
>
> Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic")
> Cc: stable@dpdk.org
>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
> drivers/net/mlx5/mlx5_trigger.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_trigger.c
> b/drivers/net/mlx5/mlx5_trigger.c
> index 4d2078bbd..d02a626ae 100644
> --- a/drivers/net/mlx5/mlx5_trigger.c
> +++ b/drivers/net/mlx5/mlx5_trigger.c
> @@ -300,9 +300,8 @@ mlx5_traffic_enable(struct rte_eth_dev *dev)
> struct rte_flow_item_vlan vlan_spec = {
> .tci = rte_cpu_to_be_16(vlan),
> };
> - struct rte_flow_item_vlan vlan_mask = {
> - .tci = 0xffff,
> - };
> + struct rte_flow_item_vlan vlan_mask =
> + rte_flow_item_vlan_mask;
>
> ret = mlx5_ctrl_flow_vlan(dev, &bcast, &bcast,
> &vlan_spec, &vlan_mask);
> @@ -339,9 +338,8 @@ mlx5_traffic_enable(struct rte_eth_dev *dev)
> struct rte_flow_item_vlan vlan_spec = {
> .tci = rte_cpu_to_be_16(vlan),
> };
> - struct rte_flow_item_vlan vlan_mask = {
> - .tci = 0xffff,
> - };
> + struct rte_flow_item_vlan vlan_mask =
> + rte_flow_item_vlan_mask;
>
> ret = mlx5_ctrl_flow_vlan(dev, &unicast,
> &unicast_mask,
> --
Acked-by: Ori Kam <orika@mellanox.com>
Thanks,
> 2.18.0
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-24 13:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-23 7:18 [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter Nelio Laranjeiro
2018-07-23 22:38 ` Yongseok Koh
2018-07-24 13:45 ` Shahaf Shuler
2018-07-24 6:27 ` Ori Kam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).