From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDEB5A04E0; Wed, 27 Nov 2019 15:52:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 996552B9C; Wed, 27 Nov 2019 15:52:31 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70079.outbound.protection.outlook.com [40.107.7.79]) by dpdk.org (Postfix) with ESMTP id 2A3932B88 for ; Wed, 27 Nov 2019 15:52:30 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nD2PVNGjFFHzfYau9A5CNwUfBC2yxH7dKB2bkgMl3EeaF2DAj2swyBUmvFwNCevL4nlC0OL48DAz6ZkPX4EROwU0TSt9dYaDhVZxLp/f39rGf0t2GBvw8n4w/p4gp/07M6Rs+T2dRpzgaqWLNcE1XX7j9cvYD35FO4W+tGljDpVa1BMfL8RnBPuIP63kN0uq0WT0WBd9dJaTCxCVIQXtvKqabCdxKDxHFKpFAmq8cYrbzK1fWaLKqnXquurq4dMkN+6mhzgbnY/B7ICp2WydTJlfRR5KpQKeEUa5GH3rEu3/ebF2QwwKzXnY9HRwxxRlWvHXgJoOLvBZvKltL0pQYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+78Vdq9iloMoS5JMhbo5s+8Kj0maMO/m2ow+Mb9bMX4=; b=Z/y69rkW1pbFQ/zFy6Zhe5RGqV0z4rwGufOE5PejZ8SKWacOoP4IanULk+6PUwVr9RzfgnCgkujnuCxtKP71AMbqgc8/5EPA0iwMcJCeWGIYNjeN473E7+lST7+ZJ/fFXfBQ3X268ZwcWZLBnOUr4j5zlogIcB7Ej3Y6WOT++xaa1j9IcP/QGTDLZT+OQG+LrtaiLA0MSwxWw4SFwz+Lxa6p3KEmVlJ+y4Y2/dAu5/7nE2ubOgB/UarlPAWpVMj5PlTRmKMLqxWMQ9kPPtsSSExuFd+bF5wTuP2ROImXrt8IxFWRqULpFdUl32KupYtl++n4KuV8va3eZyqXmu6DBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+78Vdq9iloMoS5JMhbo5s+8Kj0maMO/m2ow+Mb9bMX4=; b=O+cqGjRimufo4mxC+JThi8Z5jpwmL98SfJ9HHwjgt2OqJtu8myOqOXFErHwU2O95IbE1zJNTM+wpzBWGMweRCKEQV3ut7ErXvShsCzgpfSX8UgrCh+Pw8LC6C5EYwd8+d2FGKkGwrNhonzvlIbEw6sexbUkyRq4QqQMKKHkesFM= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by AM4PR05MB3297.eurprd05.prod.outlook.com (10.170.125.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2495.18; Wed, 27 Nov 2019 14:52:29 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::d877:95ed:5f94:a4a]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::d877:95ed:5f94:a4a%3]) with mapi id 15.20.2474.023; Wed, 27 Nov 2019 14:52:29 +0000 From: Ori Kam To: "xiangxia.m.yue@gmail.com" , "dev@dpdk.org" Thread-Topic: [PATCH dpdk-dev 3/3] net/mlx5: remove the assert for rxq cq Thread-Index: AQHVpS2chT+P5VKHOUKvMR89WF/XgKefGfWA Date: Wed, 27 Nov 2019 14:52:29 +0000 Message-ID: References: <1574864323-85580-1-git-send-email-xiangxia.m.yue@gmail.com> <1574864323-85580-3-git-send-email-xiangxia.m.yue@gmail.com> In-Reply-To: <1574864323-85580-3-git-send-email-xiangxia.m.yue@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4a59b0f0-9191-4ed0-e6be-08d773496cfd x-ms-traffictypediagnostic: AM4PR05MB3297: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 023495660C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(39860400002)(396003)(136003)(376002)(189003)(13464003)(199004)(71190400001)(11346002)(446003)(110136005)(71200400001)(316002)(6506007)(53546011)(2906002)(26005)(6116002)(3846002)(8676002)(66066001)(76176011)(7696005)(8936002)(14454004)(478600001)(66946007)(52536014)(229853002)(81166006)(33656002)(81156014)(25786009)(9686003)(6436002)(102836004)(74316002)(305945005)(5660300002)(256004)(14444005)(99286004)(186003)(6246003)(66446008)(64756008)(66556008)(66476007)(86362001)(2501003)(76116006)(7736002)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3297; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8JbZ89b3FXhOB3kJF1J4Fj6EyJ+1CNtHVzT+4s2JXJsqPFbfnIVvOvYsqQUiwXN77f6lCbVbRJ+49ULMPydD8F7F4gO8ToGT0JiVIq+a7qasd549l47muDbdRvVvQjuVmQpCFUMNWCgL+PdzGNsTbvgw7rL4Ch9pNsdbI+wjgxM4rIMvGG3fE0Trmr8Vbp2G7avtIg4Tx7YR5CsuSab24Brk3Ubwf6DmsG/nQQZGf5a6lgyezoXphaae7qPvJ+jihTxL3UYsE7grzNCae4pod3BsNml+5Qda1Me+Eswx4hKmm6yU12AEBRQbqlLzeHy+wy2YvBedhs45PZM07ii6WBv5hXFnpecoLc/oL6fSje8N6qjnpj6BJOQRLg3cIT+T3WD3Ewe+Q8DP+Yx48c3QaH84Gm4hQy/jU3Ar+5aezkm8ajhQvVK1QR4KahBGUwjN x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a59b0f0-9191-4ed0-e6be-08d773496cfd X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Nov 2019 14:52:29.4090 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u16Oi9SCx5N0jV+LwBKdME/8LWrXM6v2O16+qWzGBjAwHk4P9ekDybOFqOwXrX7CYjie3G0U3AzU4U8Ov9EPKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3297 Subject: Re: [dpdk-dev] [PATCH dpdk-dev 3/3] net/mlx5: remove the assert for rxq cq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch is not correct, You are using old code. This was already solved. Thanks, Ori > -----Original Message----- > From: xiangxia.m.yue@gmail.com > Sent: Wednesday, November 27, 2019 4:19 PM > To: dev@dpdk.org > Cc: Tonghao Zhang ; Ori Kam > > Subject: [PATCH dpdk-dev 3/3] net/mlx5: remove the assert for rxq cq >=20 > From: Tonghao Zhang >=20 > The mlx5_rxq_obj_hairpin_new doesn't alloc the > cq anymore. When releasing it, don't check it. >=20 > Fixes: e79c9be91515 ("net/mlx5: support Rx hairpin queues") > Cc: Ori Kam > Signed-off-by: Tonghao Zhang > --- > drivers/net/mlx5/mlx5_rxq.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index 2a12d5fa3436..582a2330e575 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -673,7 +673,6 @@ mlx5_rxq_obj_release(struct mlx5_rxq_obj > *rxq_obj) > assert(rxq_obj); > if (rxq_obj->type =3D=3D MLX5_RXQ_OBJ_TYPE_IBV) > assert(rxq_obj->wq); > - assert(rxq_obj->cq); > if (rte_atomic32_dec_and_test(&rxq_obj->refcnt)) { > switch (rxq_obj->type) { > case MLX5_RXQ_OBJ_TYPE_IBV: > -- > 2.23.0