From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62D73A04F0; Tue, 10 Dec 2019 21:32:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EB438A3; Tue, 10 Dec 2019 21:32:21 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150078.outbound.protection.outlook.com [40.107.15.78]) by dpdk.org (Postfix) with ESMTP id 205A823D for ; Tue, 10 Dec 2019 21:32:20 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RtXAMLLL62vdHU98SzNVVZX0u2DPwa3MsrxHQXK65aSef4RMq0uAwg3vw1Ex2WE2St40OJRcjnv/lMhjFdxr1YB65hPyVAuLjoskTVfidBiLTaCuUT38HkdePaVQKLseOrBQ+T5RzI9hwUJdYso87IxVuCVzTCwS01snDF3VdAMHjA8MM8CecQmPvDt9cNRYKLGZKqYGrPLEmkxg2M+Aq/4LdrjJUXUDg31vYSESwFNXaLbQ2b/xd4eW7QoPBykHiTdKv9Q51xmtd7Kiuz/JR1MX5p1p1w/GN73VhG2qiEuvVeEMTK6NZahqyUsxB5o/8G0syLAFnY4irtDPT4AY3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mjDcF50kfQ3STZ0SiI7I455Y9PLxPmsjUm8qU0wVdbQ=; b=IgT5b4BqVP9hl/oeXVL5yqcNobvhjyL+KRpwlZEICYuIfuZXf1txGvlDq155UL6W7FQgOBtk4avO9ByGG+TKj/yCAy8P5dmlUoify9ZBjJ3IBDhqlchvAl5bXvw/eLBvcLCco/gZcm1ObE6lIZsySqfDZfoDEBdZJEBV+fzhptVBpS0LCSmPvy9xOEIc16Kgz0Nop5SQcG03ysu9dbeY5UeIr8izqOBUuGbLlnGnbT1a4At7Ol78xvuYh8MaOW3tV1Hkxk3jC9RqwWcvKcoOqY1uXwvHP4S3zk6sAKxTxM8IJyDJV7Xsj6Aqjnd3fAGZXIhnTeUKcybuTV2uPdq6Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mjDcF50kfQ3STZ0SiI7I455Y9PLxPmsjUm8qU0wVdbQ=; b=Mji5f72ueXvc3VJHWDNjhJF4IVclZYWwSlJ5ghIWv4Sk7AKr95EzJjwXX4eIzTiLNITuejvi/+stVwkD7zJfP70MnxBkAOXMD8JJh2sftfuUTq8pJZmnvf3//ft8G2Ka7mSzfDvGG8T++QtxziylTCSfu8dWgnEkr7zq8fyBIsQ= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by AM4PR05MB3185.eurprd05.prod.outlook.com (10.171.188.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2516.14; Tue, 10 Dec 2019 20:32:19 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::d877:95ed:5f94:a4a]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::d877:95ed:5f94:a4a%3]) with mapi id 15.20.2516.018; Tue, 10 Dec 2019 20:32:19 +0000 From: Ori Kam To: "Sexton, Rory" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "Xing, Beilei" , Adrien Mazarguil , "Jagus, DariuszX" Thread-Topic: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API Thread-Index: AQHVqq0+rDvHUb8LykqFESCNqlVVt6ezLT2ggABQSgCAAFNDwA== Date: Tue, 10 Dec 2019 20:32:19 +0000 Message-ID: References: <20191204141055.3647-1-rory.sexton@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [185.175.35.255] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e36011d6-fffd-4bfd-1f51-08d77db00d9d x-ms-traffictypediagnostic: AM4PR05MB3185: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 02475B2A01 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(366004)(346002)(136003)(376002)(39860400002)(51444003)(189003)(199004)(13464003)(8936002)(81166006)(186003)(26005)(53546011)(6506007)(9686003)(71200400001)(76116006)(110136005)(8676002)(316002)(81156014)(66556008)(7696005)(66476007)(66446008)(4326008)(55016002)(64756008)(478600001)(5660300002)(33656002)(52536014)(54906003)(66946007)(2906002)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3185; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: z9rXxMnChxatpQ+aaGrrPJaLBLmHC/yOIlHT2cfs4GkvtAWkpSpgeo7S5m6OZ+pTRDt40Cq6AQws2baEsbXlp9RM45FH9RG0Up2L0tkWgXMMvDhVLBHoJ9rVKYtSkL7gPPyTZ6VQbG7jgctso55exyJruR+kMCDRsl4nq9Laegjqfecpi5Y7lfi+hKLYdnlSr9pUbh2g1vqNqZ9ipqhgsrVkHjjutZAcZEtcK5P+gLcn+YwE5Z/gKN6J7mhGcScqk0WRN4LBlSb93qHNZegnZgr4zJYh6kDfNn5iYm7THgzIoJmqDGxqtLtHXSkHJm8hDFJ13N3lX2k0iWtKkOgIb7JXWH+uluU0aMsCkXFfBEUkMoa/Xw9gvs44lnb1xvQF0pX4dh5xbKPqsyabOYBxkKKJIZe/rUnOWNiGhGd3DNDLrD9eLta/apZeTghnjtSLVhiOfNCJGgZW8f7nZEdn7fLA6BMSfmpdnwoOjk+SEQkV/Oc4Noiy8lUU7LWwdJRSNabHTt1go3cDfdzx+clG8g== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e36011d6-fffd-4bfd-1f51-08d77db00d9d X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2019 20:32:19.1152 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kO3pJWBQO1N1CZktCrgLHdQ1mACSotjn8wJnrdlDO3EpkUbRO54Hz/zZrKsLz02rMAJDro3rIfCtIwCCtx2iUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3185 Subject: Re: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Rory, > -----Original Message----- > From: Sexton, Rory > Sent: Tuesday, December 10, 2019 4:52 PM > To: Ori Kam ; dev@dpdk.org > Cc: Zhang, Qi Z ; Xing, Beilei ; > Adrien Mazarguil ; Jagus, DariuszX > > Subject: RE: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API >=20 > Hi Ori, >=20 > > One general question why do we want to support only v3 and not also v2? > l2tpv3 is more widely used as a tunneling protocol hence it's inclusion. > A specific example is the cable industry where DOCSIS cable traffic is > encapsulated using depi and uepi protocols which both make use of l2tpv3 > session ids. > Directing flows based on l2tpv3 can be very useful in these cases. >=20 I'm not saying that v3 is not used more, I just thought from looking at the= spec that both can be supported and the only difference is the version, so match= ing on the version we will be able to support both versions. Your decision. > Some more comments inline below. >=20 > Rory >=20 > >> diff --git a/lib/librte_ethdev/rte_flow.h > >> b/lib/librte_ethdev/rte_flow.h index 452d359a1..5ee055c28 100644 > >> --- a/lib/librte_ethdev/rte_flow.h > >> +++ b/lib/librte_ethdev/rte_flow.h > >> @@ -510,6 +510,16 @@ enum rte_flow_item_type { > >> * See struct rte_flow_item_tag. > >> */ > >> RTE_FLOW_ITEM_TYPE_TAG, > >> + > >> + /* > > > >Missing *. It should be /** > > >=20 > Will correct this in another version of this patch. >=20 > >> +/** > >> + * RTE_FLOW_ITEM_TYPE_L2TPV3. > >> + * > >> + * Matches a L2TPv3 header. > >> + */ > >> +struct rte_flow_item_l2tpv3 { > >> + rte_be32_t session_id; /**< Session ID. */ }; > > > >Does it make sense that in future we will want to match on the T / L / v= er / > Ns / Nr? > > > >Please also consider that any change will be ABI / API breakage, which w= ill > be allowed only next year. > > >=20 > I don't foresee us wanting to match on any of the other fields, T / L / v= er / > Ns/ Nr. > The session id would typically be the only field of interest in the l2tpv= 3 > header. I think that adding all fields to the structure will solve the possible iss= ue with adding matching later. Also and even more important you will be able to use it for creating the r= aw_encap / raw_decap buffers. What do you think? Best, Ori