From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60082.outbound.protection.outlook.com [40.107.6.82]) by dpdk.org (Postfix) with ESMTP id 6C0C61B597 for ; Wed, 17 Apr 2019 07:18:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jpd4SmthE6ENniluBVNWbd3iNoL0bK+wneHhOtS8/3g=; b=vwp4NU/qhtW0nph0cM/HvJhRtXG+w4bSVyqcSLVwtG8hfbwfiSLB4M87DMTm2H2UU+KLX3IsUG1zyw9yrWSs86hdw/DjrkOx4e5rEP+j6hBSEoVq0/Ers3xHvdxO1ziF9URPXerykRfFcZy8wzfBt++lZbXSS6LSQRSu0uAlL/I= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by AM4PR05MB3300.eurprd05.prod.outlook.com (10.171.186.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.18; Wed, 17 Apr 2019 05:18:07 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::a4d7:6c70:9829:2cc8]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::a4d7:6c70:9829:2cc8%6]) with mapi id 15.20.1813.011; Wed, 17 Apr 2019 05:18:07 +0000 From: Ori Kam To: Yongseok Koh CC: Shahaf Shuler , Matan Azrad , Slava Ovsiienko , Moti Haimovsky , "dev@dpdk.org" Thread-Topic: [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules Thread-Index: AQHU8wbsppVoh7+qx0SG+QHYbz/F3qY/e0uAgABWglA= Date: Wed, 17 Apr 2019 05:18:07 +0000 Message-ID: References: <1555276357-4892-1-git-send-email-orika@mellanox.com> <1555276357-4892-3-git-send-email-orika@mellanox.com> <20190417000101.GE21044@mtidpdk.mti.labs.mlnx> In-Reply-To: <20190417000101.GE21044@mtidpdk.mti.labs.mlnx> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cd592334-914d-496d-fbda-08d6c2f4137f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600140)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM4PR05MB3300; x-ms-traffictypediagnostic: AM4PR05MB3300: x-microsoft-antispam-prvs: x-forefront-prvs: 0010D93EFE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(366004)(136003)(39860400002)(376002)(189003)(199004)(13464003)(106356001)(4326008)(102836004)(5660300002)(105586002)(6246003)(305945005)(229853002)(14454004)(6116002)(9686003)(53546011)(7696005)(478600001)(6436002)(186003)(3846002)(66066001)(68736007)(55016002)(6636002)(52536014)(486006)(8936002)(74316002)(8676002)(26005)(6506007)(316002)(54906003)(71200400001)(71190400001)(7736002)(76176011)(11346002)(99286004)(256004)(2906002)(53936002)(6862004)(446003)(25786009)(33656002)(476003)(97736004)(81166006)(86362001)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3300; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: pn4iIdtFg7N0VDTN2zRZHnwUIox8zCpfGcBdJfWN6AleOwQJu4BfCnX2gm6p4tk4LTPEEm9UBpJexzOkOEYgnFhKH1bA0iNXnhfZ0jHLcM/YUbzaoIxTfdQ/RFkv4Qc9eN/2Vw2AH+oEeynXThZRS/5TeF/a/+AznOQA3PZypmtUdo5jadU2uYO37qkilDqW+odas3j+J1CuWdB43BAd61VLMLqBFSzDebHXnUanSwb+L7z4h4GMCeUb26ZqEEh1heUtj85znHn4NYNUpqw+TCj5Gfwiddx1RZfS6g5v7oFwGcBORUSz1Eio2lk/koVFton7rE0pp+f/DlGTO0Qfp2ZHa59KM+S5MJiTfMavr1CYlR9tGKYQ7B39kYo7+xTPVZzl24GpAeG9b8S274963D1qfRYa/1xEzePMx46EzNw= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd592334-914d-496d-fbda-08d6c2f4137f X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2019 05:18:07.3556 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3300 Subject: Re: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2019 05:18:08 -0000 PSB Thanks, Ori > -----Original Message----- > From: Yongseok Koh > Sent: Wednesday, April 17, 2019 3:01 AM > To: Ori Kam > Cc: Shahaf Shuler ; Matan Azrad > ; Slava Ovsiienko ; Moti > Haimovsky ; dev@dpdk.org > Subject: Re: [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rul= es >=20 > On Sun, Apr 14, 2019 at 09:12:30PM +0000, Ori Kam wrote: > > The meson build was missing the define for Direct Rules. > > > > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") > > Cc: orika@mellanox.com > > > > Signed-off-by: Ori Kam > > --- > > drivers/net/mlx5/meson.build | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.buil= d > > index a4c684e..0037e15 100644 > > --- a/drivers/net/mlx5/meson.build > > +++ b/drivers/net/mlx5/meson.build > > @@ -111,6 +111,8 @@ if build > > 'mlx5dv_devx_obj_create' ], > > [ 'HAVE_IBV_FLOW_DEVX_COUNTERS', 'infiniband/mlx5dv.h', > > 'MLX5DV_FLOW_ACTION_COUNTERS_DEVX' ], > > + [ 'HAVE_MLX5DV_DR', 'infiniband/mlx5dv.h', > > + 'MLX5DV_DR_NS_TYPE_TERMINATING' ], >=20 > Better to change the inconsistent naming? > HAVE_MLX5DV_DR -> HAVE_IBV_FLOW_DV_DIRECT_RULES >=20 > And I want it to be at a similar location to Makefile. Let's put it next = to > HAVE_IBV_FLOW_DV_SUPPORT. >=20 The name consist with the one in Makefile.=20 This patch is only fixing missing define from the meson build. Also the name of the define for E-Switch is in the same format. > thanks > Yongseok >=20 > > [ 'HAVE_SUPPORTED_40000baseKR4_Full', 'linux/ethtool.h', > > 'SUPPORTED_40000baseKR4_Full' ], > > [ 'HAVE_SUPPORTED_40000baseCR4_Full', 'linux/ethtool.h', > > -- > > 1.8.3.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B48BAA00E6 for ; Wed, 17 Apr 2019 07:18:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7F32E1B5AF; Wed, 17 Apr 2019 07:18:10 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60082.outbound.protection.outlook.com [40.107.6.82]) by dpdk.org (Postfix) with ESMTP id 6C0C61B597 for ; Wed, 17 Apr 2019 07:18:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jpd4SmthE6ENniluBVNWbd3iNoL0bK+wneHhOtS8/3g=; b=vwp4NU/qhtW0nph0cM/HvJhRtXG+w4bSVyqcSLVwtG8hfbwfiSLB4M87DMTm2H2UU+KLX3IsUG1zyw9yrWSs86hdw/DjrkOx4e5rEP+j6hBSEoVq0/Ers3xHvdxO1ziF9URPXerykRfFcZy8wzfBt++lZbXSS6LSQRSu0uAlL/I= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by AM4PR05MB3300.eurprd05.prod.outlook.com (10.171.186.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.18; Wed, 17 Apr 2019 05:18:07 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::a4d7:6c70:9829:2cc8]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::a4d7:6c70:9829:2cc8%6]) with mapi id 15.20.1813.011; Wed, 17 Apr 2019 05:18:07 +0000 From: Ori Kam To: Yongseok Koh CC: Shahaf Shuler , Matan Azrad , Slava Ovsiienko , Moti Haimovsky , "dev@dpdk.org" Thread-Topic: [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules Thread-Index: AQHU8wbsppVoh7+qx0SG+QHYbz/F3qY/e0uAgABWglA= Date: Wed, 17 Apr 2019 05:18:07 +0000 Message-ID: References: <1555276357-4892-1-git-send-email-orika@mellanox.com> <1555276357-4892-3-git-send-email-orika@mellanox.com> <20190417000101.GE21044@mtidpdk.mti.labs.mlnx> In-Reply-To: <20190417000101.GE21044@mtidpdk.mti.labs.mlnx> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cd592334-914d-496d-fbda-08d6c2f4137f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600140)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM4PR05MB3300; x-ms-traffictypediagnostic: AM4PR05MB3300: x-microsoft-antispam-prvs: x-forefront-prvs: 0010D93EFE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(366004)(136003)(39860400002)(376002)(189003)(199004)(13464003)(106356001)(4326008)(102836004)(5660300002)(105586002)(6246003)(305945005)(229853002)(14454004)(6116002)(9686003)(53546011)(7696005)(478600001)(6436002)(186003)(3846002)(66066001)(68736007)(55016002)(6636002)(52536014)(486006)(8936002)(74316002)(8676002)(26005)(6506007)(316002)(54906003)(71200400001)(71190400001)(7736002)(76176011)(11346002)(99286004)(256004)(2906002)(53936002)(6862004)(446003)(25786009)(33656002)(476003)(97736004)(81166006)(86362001)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3300; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: pn4iIdtFg7N0VDTN2zRZHnwUIox8zCpfGcBdJfWN6AleOwQJu4BfCnX2gm6p4tk4LTPEEm9UBpJexzOkOEYgnFhKH1bA0iNXnhfZ0jHLcM/YUbzaoIxTfdQ/RFkv4Qc9eN/2Vw2AH+oEeynXThZRS/5TeF/a/+AznOQA3PZypmtUdo5jadU2uYO37qkilDqW+odas3j+J1CuWdB43BAd61VLMLqBFSzDebHXnUanSwb+L7z4h4GMCeUb26ZqEEh1heUtj85znHn4NYNUpqw+TCj5Gfwiddx1RZfS6g5v7oFwGcBORUSz1Eio2lk/koVFton7rE0pp+f/DlGTO0Qfp2ZHa59KM+S5MJiTfMavr1CYlR9tGKYQ7B39kYo7+xTPVZzl24GpAeG9b8S274963D1qfRYa/1xEzePMx46EzNw= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd592334-914d-496d-fbda-08d6c2f4137f X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2019 05:18:07.3556 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3300 Subject: Re: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190417051807.o5yC4WsGQtoSddfwVvdvQRieHvyiCrQC4oCAssoawsc@z> PSB Thanks, Ori > -----Original Message----- > From: Yongseok Koh > Sent: Wednesday, April 17, 2019 3:01 AM > To: Ori Kam > Cc: Shahaf Shuler ; Matan Azrad > ; Slava Ovsiienko ; Moti > Haimovsky ; dev@dpdk.org > Subject: Re: [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rul= es >=20 > On Sun, Apr 14, 2019 at 09:12:30PM +0000, Ori Kam wrote: > > The meson build was missing the define for Direct Rules. > > > > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") > > Cc: orika@mellanox.com > > > > Signed-off-by: Ori Kam > > --- > > drivers/net/mlx5/meson.build | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.buil= d > > index a4c684e..0037e15 100644 > > --- a/drivers/net/mlx5/meson.build > > +++ b/drivers/net/mlx5/meson.build > > @@ -111,6 +111,8 @@ if build > > 'mlx5dv_devx_obj_create' ], > > [ 'HAVE_IBV_FLOW_DEVX_COUNTERS', 'infiniband/mlx5dv.h', > > 'MLX5DV_FLOW_ACTION_COUNTERS_DEVX' ], > > + [ 'HAVE_MLX5DV_DR', 'infiniband/mlx5dv.h', > > + 'MLX5DV_DR_NS_TYPE_TERMINATING' ], >=20 > Better to change the inconsistent naming? > HAVE_MLX5DV_DR -> HAVE_IBV_FLOW_DV_DIRECT_RULES >=20 > And I want it to be at a similar location to Makefile. Let's put it next = to > HAVE_IBV_FLOW_DV_SUPPORT. >=20 The name consist with the one in Makefile.=20 This patch is only fixing missing define from the meson build. Also the name of the define for E-Switch is in the same format. > thanks > Yongseok >=20 > > [ 'HAVE_SUPPORTED_40000baseKR4_Full', 'linux/ethtool.h', > > 'SUPPORTED_40000baseKR4_Full' ], > > [ 'HAVE_SUPPORTED_40000baseCR4_Full', 'linux/ethtool.h', > > -- > > 1.8.3.1 > >