DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ori Kam <orika@mellanox.com>
To: Dekel Peled <dekelp@mellanox.com>,
	Adrien Mazarguil <adrien.mazarguil@6wind.com>,
	"wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
	"jingjing.wu@intel.com" <jingjing.wu@intel.com>,
	"bernard.iremonger@intel.com" <bernard.iremonger@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Roman Zhukov <roman.zhukov@oktetlabs.ru>,
	Andrew Rybchenko <arybchenko@solarflare.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix missing GENEVE item in helper func
Date: Thu, 9 Jan 2020 06:31:08 +0000	[thread overview]
Message-ID: <AM4PR05MB3425C42299EE798B70298DEFDB390@AM4PR05MB3425.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <ab7d6edcce7b131dadf862fba71dbe2ad5ca6ee2.1578495871.git.dekelp@mellanox.com>



> -----Original Message-----
> From: Dekel Peled <dekelp@mellanox.com>
> Sent: Wednesday, January 8, 2020 5:07 PM
> To: Adrien Mazarguil <adrien.mazarguil@6wind.com>;
> wenzhuo.lu@intel.com; jingjing.wu@intel.com;
> bernard.iremonger@intel.com
> Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org; Roman Zhukov
> <roman.zhukov@oktetlabs.ru>; Andrew Rybchenko
> <arybchenko@solarflare.com>; stable@dpdk.org
> Subject: [PATCH] app/testpmd: fix missing GENEVE item in helper func
> 
> Previous patch added support of GENEVE pattern item in flow rule.
> Function flow_item_default_mask() was not updated, so using it with
> GENEVE item returns null.
> Using testpmd command "set raw_decap" or "set raw_encap" with
> GENEVE item, without specifying any parameters, results in
> segmentation fault.
> 
> This patch updates function flow_item_default_mask(),
> adding case to handle GENEVE item.
> 
> Fixes: 0f4203fe9d18 ("app/testpmd: support GENEVE pattern item in flow
> rules")
> Cc: Roman Zhukov <roman.zhukov@oktetlabs.ru>
> Cc: Andrew Rybchenko <arybchenko@solarflare.com>
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---


Acked-by: Ori Kam <orika@mellanox.com>
Thanks,
Ori

>  app/test-pmd/cmdline_flow.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 99dade7..3cf05b5 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -6236,6 +6236,9 @@ static int comp_set_raw_index(struct context *,
> const struct token *,
>  	case RTE_FLOW_ITEM_TYPE_GTP_PSC:
>  		mask = &rte_flow_item_gtp_psc_mask;
>  		break;
> +	case RTE_FLOW_ITEM_TYPE_GENEVE:
> +		mask = &rte_flow_item_geneve_mask;
> +		break;
>  	case RTE_FLOW_ITEM_TYPE_PPPOE_PROTO_ID:
>  		mask = &rte_flow_item_pppoe_proto_id_mask;
>  	default:
> --
> 1.8.3.1


  reply	other threads:[~2020-01-09  6:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08 15:07 Dekel Peled
2020-01-09  6:31 ` Ori Kam [this message]
2020-01-10  6:54 ` Andrew Rybchenko
2020-01-14  8:52   ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM4PR05MB3425C42299EE798B70298DEFDB390@AM4PR05MB3425.eurprd05.prod.outlook.com \
    --to=orika@mellanox.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=arybchenko@solarflare.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dekelp@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=roman.zhukov@oktetlabs.ru \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).