From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10673A04F3; Thu, 9 Jan 2020 07:31:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C6EB81DB8F; Thu, 9 Jan 2020 07:31:11 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2043.outbound.protection.outlook.com [40.107.20.43]) by dpdk.org (Postfix) with ESMTP id EA0D11DB8F; Thu, 9 Jan 2020 07:31:10 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XMQdv9lS3pTiFuE5XCS66Qrj1rFI7/XiU0c+Fv8f03GbLb1H/BDeG/fJPz3ztzzUALLiVEpy5cZJmVQEjVceXRKTYhMETHJ7Bbissjq7s61uSXU6PloQJZc4GwWbkMIXLYM8TYVOskdvNPIRAsO/+Bit3i5ogylt964moHf8VqqTqXQfsGWH9mYHzHWmz0Y3e8XZkSZak2z5kO45cscBP8daPf0zeUESU/Isb6P1EaN6VEevDDwNC4eckK1cRhRHLhqTdylo7na0NinGTL02XfRfCn6sTf1WBVUC4lKNaJHA2K3OVG8FgZqxeP6HKOF3mb8V294uN9gasjs6WICI/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vy+ZAVdM12+CcTiEirbF4iY+2GG5x5CDWe3CrGAPYFs=; b=mWLKBpLXwUxW7fiW7IDgOfs5lU6/cWvfM3OBecd+21BomJCUby/dmHBJ1Kv/ZTim8ZGnPyB6kNtn82Me2yMepBOpg3DerZQ56ZDbb07PE0YUUoOkKNFqDcp8FVwQcDtFASVojqAHWJHcZJTp7jPMGCNJrPcshIO2hp+EL0Q6BVd+L+iC5tmhMqDbRI52DMTvI04zP/BWrFRK1PGgOMMtntU7+Em9nwdGdTak5x+bLPqH774zTMf4O3OF3o64v+8tsUgTpBTTJy3Vf2Otn5E8LyB/lgvjDqHRzqtYgS3gKH6RQ/Id0lP0lM+QAYKGM2Lk7N9mtKdrVeDXnPI54+t8uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vy+ZAVdM12+CcTiEirbF4iY+2GG5x5CDWe3CrGAPYFs=; b=Bp/+zWcgwOwhu5nTHUvRlnDf0+beVN498ryTvXUAK6ErfSDP1Z/0G4ws90m/hk79pSMW0dv0u70LxeTme487YU3EEPHWGY+mpDRB+Jd+lO1jwUSmV1erk6JeSavfodNTYupCaQ2k4OiC2HE+ZmK0UZtphaWQuM0ldlzsWZNUIms= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by AM4PR05MB3506.eurprd05.prod.outlook.com (10.171.186.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.9; Thu, 9 Jan 2020 06:31:09 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::5114:421:f4a9:5ca8]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::5114:421:f4a9:5ca8%6]) with mapi id 15.20.2602.016; Thu, 9 Jan 2020 06:31:09 +0000 From: Ori Kam To: Dekel Peled , Adrien Mazarguil , "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" CC: "dev@dpdk.org" , Roman Zhukov , Andrew Rybchenko , "stable@dpdk.org" Thread-Topic: [PATCH] app/testpmd: fix missing GENEVE item in helper func Thread-Index: AQHVxjV7RtkJZ4qK+Em+R9ostbBPaafh3/0A Date: Thu, 9 Jan 2020 06:31:08 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [185.175.35.255] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 526dcc65-ac9c-47f4-dfa4-08d794cd8367 x-ms-traffictypediagnostic: AM4PR05MB3506:|AM4PR05MB3506: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 02778BF158 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(376002)(346002)(136003)(366004)(396003)(13464003)(189003)(199004)(55016002)(5660300002)(9686003)(2906002)(7696005)(478600001)(86362001)(26005)(53546011)(6506007)(110136005)(4326008)(66556008)(54906003)(33656002)(76116006)(316002)(64756008)(66476007)(66946007)(66446008)(81156014)(8676002)(8936002)(52536014)(186003)(81166006)(71200400001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3506; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N4ea0MF0t1xiGREOl3eIGxd/qm8kcnS8eVoWIdIt8R1YrWFMfpFjFEd4SdPJp6g/uVbNTSwxSHBHsbZQXSP65f/rufD38GOLBkqp3YOtSiTBghOHoH+zbxq4awpwl+CMmBWFweK2LITGZSXb75LXRmkonfXaqlkC925YW3YBWbMTssc5+evRAZ3pguRh3hVoLUQ8GMNU6x1Sapd+cD+IFSEKjmPx7o5ytowvVc7Aqsft8x1zBWV1zmuE8nSh+Ga3ZWOto6OMd8SuoTvHOQw1tGULd+aHxxHN1dNTa1xFcxA6nBYRND6EsMEorS+DwCzTcfs2DJyzRm60HV0ZDroN6yPuTni0ToqbT/cqsbukTV4g5GAZxH5lFIF+C4wrCo5r3DTWgatC0iM97xtkUx4KetxvWKGz1zwgGgzzFvO4hZF5z6Knq8PWD1nChn74hz/rY+kg5feL9cPyB/t0daO9g10hmXlS34q3oSBvkaQBXaaKT+TAePXI2HgZ4uKcALUk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 526dcc65-ac9c-47f4-dfa4-08d794cd8367 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2020 06:31:08.6056 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hmGlPLt5o8xZwqG4TvV4ObEM392hKMKxZ5oAD3Vpv255nCGOc/Rh48FBKt5TwJwQGeNgDYj4KPQUHOXU+fq1EA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3506 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix missing GENEVE item in helper func X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dekel Peled > Sent: Wednesday, January 8, 2020 5:07 PM > To: Adrien Mazarguil ; > wenzhuo.lu@intel.com; jingjing.wu@intel.com; > bernard.iremonger@intel.com > Cc: Ori Kam ; dev@dpdk.org; Roman Zhukov > ; Andrew Rybchenko > ; stable@dpdk.org > Subject: [PATCH] app/testpmd: fix missing GENEVE item in helper func >=20 > Previous patch added support of GENEVE pattern item in flow rule. > Function flow_item_default_mask() was not updated, so using it with > GENEVE item returns null. > Using testpmd command "set raw_decap" or "set raw_encap" with > GENEVE item, without specifying any parameters, results in > segmentation fault. >=20 > This patch updates function flow_item_default_mask(), > adding case to handle GENEVE item. >=20 > Fixes: 0f4203fe9d18 ("app/testpmd: support GENEVE pattern item in flow > rules") > Cc: Roman Zhukov > Cc: Andrew Rybchenko > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled > --- Acked-by: Ori Kam Thanks, Ori > app/test-pmd/cmdline_flow.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index 99dade7..3cf05b5 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -6236,6 +6236,9 @@ static int comp_set_raw_index(struct context *, > const struct token *, > case RTE_FLOW_ITEM_TYPE_GTP_PSC: > mask =3D &rte_flow_item_gtp_psc_mask; > break; > + case RTE_FLOW_ITEM_TYPE_GENEVE: > + mask =3D &rte_flow_item_geneve_mask; > + break; > case RTE_FLOW_ITEM_TYPE_PPPOE_PROTO_ID: > mask =3D &rte_flow_item_pppoe_proto_id_mask; > default: > -- > 1.8.3.1