[dpdk-dev] [PATCH] app/testpmd: fix missing GENEVE item in helper func

[dpdk-dev] [PATCH] app/testpmd: fix missing GENEVE item in helper func

[Dekel Peled]

Previous patch added support of GENEVE pattern item in flow rule.
Function flow_item_default_mask() was not updated, so using it with
GENEVE item returns null.
Using testpmd command "set raw_decap" or "set raw_encap" with
GENEVE item, without specifying any parameters, results in
segmentation fault.

This patch updates function flow_item_default_mask(),
adding case to handle GENEVE item.

Fixes: 0f4203fe9d18 ("app/testpmd: support GENEVE pattern item in flow rules")
Cc: Roman Zhukov <roman.zhukov@oktetlabs.ru>
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: stable@dpdk.org

Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
 app/test-pmd/cmdline_flow.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 99dade7..3cf05b5 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -6236,6 +6236,9 @@ static int comp_set_raw_index(struct context *, const struct token *,
 	case RTE_FLOW_ITEM_TYPE_GTP_PSC:
 		mask = &rte_flow_item_gtp_psc_mask;
 		break;
+	case RTE_FLOW_ITEM_TYPE_GENEVE:
+		mask = &rte_flow_item_geneve_mask;
+		break;
 	case RTE_FLOW_ITEM_TYPE_PPPOE_PROTO_ID:
 		mask = &rte_flow_item_pppoe_proto_id_mask;
 	default:
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] app/testpmd: fix missing GENEVE item in helper func

[Ori Kam]

> -----Original Message-----
> From: Dekel Peled <dekelp@mellanox.com>
> Sent: Wednesday, January 8, 2020 5:07 PM
> To: Adrien Mazarguil <adrien.mazarguil@6wind.com>;
> wenzhuo.lu@intel.com; jingjing.wu@intel.com;
> bernard.iremonger@intel.com
> Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org; Roman Zhukov
> <roman.zhukov@oktetlabs.ru>; Andrew Rybchenko
> <arybchenko@solarflare.com>; stable@dpdk.org
> Subject: [PATCH] app/testpmd: fix missing GENEVE item in helper func
> 
> Previous patch added support of GENEVE pattern item in flow rule.
> Function flow_item_default_mask() was not updated, so using it with
> GENEVE item returns null.
> Using testpmd command "set raw_decap" or "set raw_encap" with
> GENEVE item, without specifying any parameters, results in
> segmentation fault.
> 
> This patch updates function flow_item_default_mask(),
> adding case to handle GENEVE item.
> 
> Fixes: 0f4203fe9d18 ("app/testpmd: support GENEVE pattern item in flow
> rules")
> Cc: Roman Zhukov <roman.zhukov@oktetlabs.ru>
> Cc: Andrew Rybchenko <arybchenko@solarflare.com>
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---


Acked-by: Ori Kam <orika@mellanox.com>
Thanks,
Ori

>  app/test-pmd/cmdline_flow.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 99dade7..3cf05b5 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -6236,6 +6236,9 @@ static int comp_set_raw_index(struct context *,
> const struct token *,
>  	case RTE_FLOW_ITEM_TYPE_GTP_PSC:
>  		mask = &rte_flow_item_gtp_psc_mask;
>  		break;
> +	case RTE_FLOW_ITEM_TYPE_GENEVE:
> +		mask = &rte_flow_item_geneve_mask;
> +		break;
>  	case RTE_FLOW_ITEM_TYPE_PPPOE_PROTO_ID:
>  		mask = &rte_flow_item_pppoe_proto_id_mask;
>  	default:
> --
> 1.8.3.1

Re: [dpdk-dev] [PATCH] app/testpmd: fix missing GENEVE item in helper func

[Andrew Rybchenko]

On 1/8/20 6:07 PM, Dekel Peled wrote:
> Previous patch added support of GENEVE pattern item in flow rule.
> Function flow_item_default_mask() was not updated, so using it with
> GENEVE item returns null.
> Using testpmd command "set raw_decap" or "set raw_encap" with
> GENEVE item, without specifying any parameters, results in
> segmentation fault.
> 
> This patch updates function flow_item_default_mask(),
> adding case to handle GENEVE item.
> 
> Fixes: 0f4203fe9d18 ("app/testpmd: support GENEVE pattern item in flow rules")
> Cc: Roman Zhukov <roman.zhukov@oktetlabs.ru>
> Cc: Andrew Rybchenko <arybchenko@solarflare.com>
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix missing GENEVE item in helper func

[Ferruh Yigit]

On 1/10/2020 6:54 AM, Andrew Rybchenko wrote:
> On 1/8/20 6:07 PM, Dekel Peled wrote:
>> Previous patch added support of GENEVE pattern item in flow rule.
>> Function flow_item_default_mask() was not updated, so using it with
>> GENEVE item returns null.
>> Using testpmd command "set raw_decap" or "set raw_encap" with
>> GENEVE item, without specifying any parameters, results in
>> segmentation fault.
>>
>> This patch updates function flow_item_default_mask(),
>> adding case to handle GENEVE item.
>>
>> Fixes: 0f4203fe9d18 ("app/testpmd: support GENEVE pattern item in flow rules")
>> Cc: Roman Zhukov <roman.zhukov@oktetlabs.ru>
>> Cc: Andrew Rybchenko <arybchenko@solarflare.com>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> 
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> 

Applied to dpdk-next-net/master, thanks.