From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08135A04E0; Wed, 27 Nov 2019 15:51:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D46A65596; Wed, 27 Nov 2019 15:51:30 +0100 (CET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20085.outbound.protection.outlook.com [40.107.2.85]) by dpdk.org (Postfix) with ESMTP id 08F762B9C for ; Wed, 27 Nov 2019 15:51:30 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j2MHZuFvdp9NWQJK+a+8zYADgVf8xpws9g/L/LaOKTasWESPP5+/1Nfn7D3PW23Bg/V68jZAa6b4IwQiB6cgkxvFYSg/OrdsC4Dt2Dj8JP11GPmaLLogxbmaQnAGT3EHc8u6SAmACAvQgcq4IbfoJ4Y5u2mn0affcx0s+/zJoGEWCSTzkb/1L2MkCy5cIbojFQ3zHerrhIAFtJlICXBeDZ4rs+QLotS0Cbc+EdjhrMn5+RTIypPUSELuwrSsHDf07nf4AsgKaKfyg32P6Xv0SKdyssmwOBY2AnWdxjghov0p/BVmXl2BnXAIuu5vpj2lSAjyEekyjRotthPM+1qdPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hq9SSJ/BMGJGc/SGqFXFcyYyVjFbE/MOKy/8UtqJPXs=; b=d4qBKBatPvgUOvzyKhvHVbvgXGi99u8dKogAabqlS5XkHPHiQ7Dnx73uCj54oQXC2S4U1hbodBi9q7+reNhoipD1Nthy7ynz+GW1Gjp/WGN70mFRp66kBBVdC4TldaB6zUH6EaOV3Bsd6YLhyJXARIzatBubqUJVXAbuNZWqUO+6CJGZFXRWHIE1Z08+kihp9VIbJRsZjrOCF1NIssxkr27cz/fTNEn1GEgmnbym/22mFcJVqWIlJDjyIpMg+rXXcX8qlaKccEthmCt/mWu2TfNmaxsntR2jnT0bFoHZj69BH6WBSUJ5r+6dMi7HAQM6es5RUoz2u+Xzsv9VGbSehQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hq9SSJ/BMGJGc/SGqFXFcyYyVjFbE/MOKy/8UtqJPXs=; b=NehUozPIa0TDVQrIZMo482e1CjiVwnP1zDVXHvAI3evoz4u9hd70TgGCLehfgLgh3T6Av67gJOEQhsrmUSKupMRyXltkLM4UGugoudpQdqmNG60qMBxRZMFpr3LxgTfqm6iTHG/2xNpudtPM6FOC8s4dhhU/gfxPeIBaMnU1P8w= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by AM4PR05MB3297.eurprd05.prod.outlook.com (10.170.125.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2495.18; Wed, 27 Nov 2019 14:51:29 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::d877:95ed:5f94:a4a]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::d877:95ed:5f94:a4a%3]) with mapi id 15.20.2474.023; Wed, 27 Nov 2019 14:51:29 +0000 From: Ori Kam To: "xiangxia.m.yue@gmail.com" , "dev@dpdk.org" Thread-Topic: [PATCH dpdk-dev 2/3] net/mlx5: clean up redundant assignment Thread-Index: AQHVpS2a5scNeLHPiUu5+Vt+TT+wt6efGc6w Date: Wed, 27 Nov 2019 14:51:29 +0000 Message-ID: References: <1574864323-85580-1-git-send-email-xiangxia.m.yue@gmail.com> <1574864323-85580-2-git-send-email-xiangxia.m.yue@gmail.com> In-Reply-To: <1574864323-85580-2-git-send-email-xiangxia.m.yue@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 3f5f57a5-c70c-4037-c1e7-08d773494939 x-ms-traffictypediagnostic: AM4PR05MB3297: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:480; x-forefront-prvs: 023495660C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(39860400002)(396003)(136003)(376002)(189003)(13464003)(199004)(71190400001)(11346002)(446003)(110136005)(71200400001)(316002)(6506007)(53546011)(2906002)(26005)(6116002)(3846002)(8676002)(66066001)(76176011)(7696005)(8936002)(14454004)(478600001)(66946007)(52536014)(229853002)(81166006)(33656002)(81156014)(25786009)(9686003)(6436002)(102836004)(74316002)(305945005)(5660300002)(256004)(14444005)(99286004)(186003)(6246003)(66446008)(64756008)(66556008)(66476007)(86362001)(2501003)(76116006)(7736002)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3297; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /tewVak1ZWCM0cIP14aIyH7KCA2kdJ/bCQYbVBPvppOVrp/n1lWDR5z3AlXIsVxO9W4fpDssZpJunwgG6YpQZQULWLICtGtgVet1kZGm5JG+EtGkjDoPJkkhPzPnUcFCdhTHGaQfkQvDxxUOtZFPUbBBfFauhQ7QDxBzWIShB6AOLkSaQwo6EMv69VwlRzqp6ZDljJBviiCRol1/merVQfwVd3Pyco1A4ogRwi9bebZapfWBZ3kSoyM+KzXNIX0MYYo9ZT2NJ/MbGCgg9h8fnubSHynfaDfdmZQsee97c27RJqroBmpn82BVG8xyRIzdOk+pNBNlePETHT/ocldzX4HmSBurTG2TSbB+J8aWR6SCNAaGIeklqZkFrRvq7jbXW0wRefTFw4XFo0eyRDK0Uzd4vPippAW/5etHVIMtf3FEKMHYa2psyvcpVxJY9oiu x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f5f57a5-c70c-4037-c1e7-08d773494939 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Nov 2019 14:51:29.4153 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1y6IXIR3IVIZPHuAQLtzjc10tQ9mUX1y5OSnGDg+p/BCuHJhmKxzEdARLxqxM3cQXqywXfY+s1sGsV7Wv2KF7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3297 Subject: Re: [dpdk-dev] [PATCH dpdk-dev 2/3] net/mlx5: clean up redundant assignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: xiangxia.m.yue@gmail.com > Sent: Wednesday, November 27, 2019 4:19 PM > To: dev@dpdk.org > Cc: Tonghao Zhang ; Ori Kam > > Subject: [PATCH dpdk-dev 2/3] net/mlx5: clean up redundant assignment >=20 > From: Tonghao Zhang >=20 > The type of txq has been assigned in mlx5_txq_hairpin_new. >=20 > Fixes: ae18a1ae9692 ("net/mlx5: support Tx hairpin queues") > Cc: Ori Kam > Signed-off-by: Tonghao Zhang > --- > drivers/net/mlx5/mlx5_txq.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c > index a0d61644cb7f..e6a841c8d359 100644 > --- a/drivers/net/mlx5/mlx5_txq.c > +++ b/drivers/net/mlx5/mlx5_txq.c > @@ -271,7 +271,6 @@ mlx5_tx_hairpin_queue_setup(struct rte_eth_dev > *dev, uint16_t idx, > DRV_LOG(DEBUG, "port %u adding Tx queue %u to list", > dev->data->port_id, idx); > (*priv->txqs)[idx] =3D &txq_ctrl->txq; > - txq_ctrl->type =3D MLX5_TXQ_TYPE_HAIRPIN; > return 0; > } >=20 > -- > 2.23.0 Acked-by: Ori Kam Thanks, Ori