From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150053.outbound.protection.outlook.com [40.107.15.53]) by dpdk.org (Postfix) with ESMTP id ED4445323 for ; Tue, 20 Nov 2018 09:23:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MEbWXfsuluU6bdv24vOZOX5GR5nSG1L97TRejkcKGEc=; b=xrquPMNcOz1wOdfaOoETVwu8EB2x7RlwNjD/jrCJBkE5iEpP33hwhZe3CPsANE2RqqwxGoW5gdTUusM8gbMCts/1W6Xcgi7f/6X+UkJ+72D54HQOxsmrwnFNxpO+SknXm0rQT6+6m4D6GTecghjTMav9WvwJi6eYYVA7O/UdAsw= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.187.142) by AM4PR05MB3204.eurprd05.prod.outlook.com (10.171.186.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.21; Tue, 20 Nov 2018 08:23:14 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::1533:fa4a:5f23:cd47]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::1533:fa4a:5f23:cd47%2]) with mapi id 15.20.1339.027; Tue, 20 Nov 2018 08:23:14 +0000 From: Ori Kam To: Dekel Peled , "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" CC: "dev@dpdk.org" , Shahaf Shuler , Dekel Peled Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix MPLSoUDP encapsulation Thread-Index: AQHUgCj51FsPjSpedkWrcd9WzxqEL6VYUFaA Date: Tue, 20 Nov 2018 08:23:14 +0000 Message-ID: References: <1542646490-37406-1-git-send-email-dekelp@mellanox.com> In-Reply-To: <1542646490-37406-1-git-send-email-dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [37.122.157.255] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB3204; 6:cgniDEa/E8e0Yr7/z8F2ipHJZmRniMk8VWRMCOIVVREL3yRNkUBTP0PRLRsXF3O1bCsyJsvMKn0sZKO1wi7tn9tJcGT+b/4x0cVyrr2vL2zZYLcBEs+ZGzW/78FXsk0Hfs2UZ8p3b6e9+kH54/afIDdkL08bI4UvC+9RSkovG4ZxyNvXyZo/1yLXccXyZKcDQX1XOtlklwV/JRijvT7kSDpo4KiBxB6i6RD3B7tz+rJsf1Ar4HrbKtsds0UzcF7Y97QDUKnt6VtTa4Nlhwnpw+2HobmlLn9hr1jr94qkeimRJB8UVXqx96h2g7KTw7628fB0mEwoJlqkIjxkfweaDD5HSAVj1uPsqpaXyyrZZ+gcvKKGkHaX7VCtNmhFEqfzQNsEUKLvdgTq+Eb0H2MjQitoa6R/z5yIls/rS91EnoLs/Grz+o6ELrvIj/3CfCXDOjfNxKzyVrsTrWTHAlFGQg==; 5:YhS0ma1KeLwjMUxQ9YOStE/xcZsR8UVhVuaBQi/yUqBUnhN7BTVtGyIyXzPKIgKUpRm6i+VhO4P3GrbBhDCOs7dnvwwKp09vieAlA7GdkWS80WIR2GMfGrQaMQ1zptKBJ+luuo11yv30K0++fxXfbs3P+ave9deR9qiotRDmYvI=; 7:QWkyhXIb9gOJNrz+x54CyWcesZAK9nwrJyUKiYbaftnaqMLlvOX+ayjnxLtrGlO+0cq8NTf+s9TF4ZMXmxjiIB2Ez0D9laPoEd+f4g/xMRPOmyuwgTUviKpELHoWSzK1Gsm2ITmUNszucb9vFV74yw== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 989482ec-29ad-4d6e-27d6-08d64ec16a7b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3204; x-ms-traffictypediagnostic: AM4PR05MB3204: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231442)(944501410)(52105112)(6055026)(148016)(149066)(150057)(6041310)(20161123564045)(20161123562045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:AM4PR05MB3204; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB3204; x-forefront-prvs: 08626BE3A5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(366004)(376002)(346002)(39860400002)(199004)(189003)(13464003)(2501003)(97736004)(8936002)(81156014)(6506007)(26005)(81166006)(76176011)(110136005)(316002)(53546011)(99286004)(54906003)(25786009)(102836004)(8676002)(7696005)(86362001)(256004)(5660300001)(11346002)(71190400001)(476003)(446003)(186003)(486006)(71200400001)(68736007)(2201001)(55016002)(9686003)(6246003)(106356001)(107886003)(105586002)(7736002)(3846002)(305945005)(2906002)(74316002)(53936002)(6116002)(2900100001)(4326008)(229853002)(478600001)(66066001)(33656002)(14454004)(6436002)(7756004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3204; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 0hmQZy71acLKeuZigcYpCOjq5GS9lbsmhb10uVE0Kar655B2bYwNpqlFsV5j5shx2ZFEMCrgVJY65laBT0X4uWsh5GR+a6m7SRXYHAaJzD1QhLbbBLdD0h4IqlTTV5OVj68HytLJZQl2y5Ew6mMLSI5sKQtZ920VWGCX0Zbzo4c0UeCafs/dsxPkrALvDSYUI6rkPhs05JLeEQJ1AvoK2kXOONGVqdHThqt0fVVCpFyIBnXfzgv2gFPSO4pXnsrLnKb4JtNOE4zfOy6tx/fCVYdHJLVosOAxSc5OBxo7eWo6U+gmgwSkciPznXlUchtCJRLqfCZwnKtrHAKOUzp4KtS4Tq4gNbD5BSKXu8sus68= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 989482ec-29ad-4d6e-27d6-08d64ec16a7b X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2018 08:23:14.1145 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3204 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MPLSoUDP encapsulation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 08:23:16 -0000 > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Monday, November 19, 2018 6:55 PM > To: wenzhuo.lu@intel.com; jingjing.wu@intel.com; > bernard.iremonger@intel.com > Cc: dev@dpdk.org; Ori Kam ; Shahaf Shuler > ; Dekel Peled > Subject: [dpdk-dev] [PATCH] app/testpmd: fix MPLSoUDP encapsulation >=20 > Set MPLS label value in appropriate location at mplsoudp_encap_conf, > so it is correctly copied to rte_flow_item_mpls. >=20 > Fixes: a1191d39cb57 ("app/testpmd: add MPLSoUDP encapsulation") > Cc: orika@mellanox.com >=20 > Signed-off-by: Dekel Peled > --- > app/test-pmd/cmdline.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 1275074..40e64cc 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -15804,10 +15804,10 @@ static void > cmd_set_mplsoudp_encap_parsed(void *parsed_result, > struct cmd_set_mplsoudp_encap_result *res =3D parsed_result; > union { > uint32_t mplsoudp_label; > - uint8_t label[3]; > + uint8_t label[4]; > } id =3D { > .mplsoudp_label =3D > - rte_cpu_to_be_32(res->label) & RTE_BE32(0x00ffffff), > + rte_cpu_to_be_32(res->label<<4) & > RTE_BE32(0x00ffffff), > }; >=20 > if (strcmp(res->mplsoudp, "mplsoudp_encap") =3D=3D 0) > -- > 1.8.3.1 Acked-by: Ori Kam Thanks, Ori