From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70072.outbound.protection.outlook.com [40.107.7.72]) by dpdk.org (Postfix) with ESMTP id 241301B1F9 for ; Tue, 23 Oct 2018 20:05:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SHdwIpX4MgdEfW0xdXxdIf25FGr9Iw4nrKAMfvoIM8Y=; b=sRqqqcVPXb1tuyobVrI77s466kdL7yKmd9d31Wl9jYaK3H8B8U5c7o3oWFUHngA6OWIeh1o4SeXNzfwQxI3Egp9IMdj2IqGc2BaPRSV0EBVNXrygvV9VA8Vv6lCv5Dvn7s8qGQivRsQx/TLJUVd8IM2Ei3B+qUWLADsxpo01Ro4= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.187.142) by AM4PR05MB3220.eurprd05.prod.outlook.com (10.171.186.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.30; Tue, 23 Oct 2018 18:05:39 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::fdeb:3890:f0f0:2202]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::fdeb:3890:f0f0:2202%4]) with mapi id 15.20.1228.035; Tue, 23 Oct 2018 18:05:39 +0000 From: Ori Kam To: Dekel Peled , "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" , "olivier.matz@6wind.com" , Adrien Mazarguil , Thomas Monjalon , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" CC: Shahaf Shuler , "dev@dpdk.org" , Dekel Peled Thread-Topic: [dpdk-dev] [PATCH 2/2] ethdev: fix metadata documentation Thread-Index: AQHUatirrBFH2XnJzUmkcyU1OvdXxaUtH89g Date: Tue, 23 Oct 2018 18:05:39 +0000 Message-ID: References: <1540301331-51065-1-git-send-email-dekelp@mellanox.com> <1540301331-51065-2-git-send-email-dekelp@mellanox.com> In-Reply-To: <1540301331-51065-2-git-send-email-dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [37.122.157.213] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB3220; 6:Twh4e9cYStkPxokYGDxJrv29s9/KNxErZmyU32NqGQydpwsvCs+fEHFDgnifmK7tf5bNKgPDksv7dS536vlP+AmcpLjNbW4tmPY6mEz5EOVrVt0b+JVCdXs6hw/FYO711INcfIRWk82p9divjEs3ugFL0AE5aN8qbAL1DJ7GzKhE/0rwJ/BzqiBkPg1b7zAkzXDAb+5z0D29wrMyGm3iIx4nJrreA4b1v4XOAn8l12DeZ+W3CJJDw05/G/sxmFDWtzngqCfvOTE4GMqVrTkisY6lJpA3lJViMmoUdNup2TTRIUH+p4e2deIeKKXOPRcy+i9KXq1CWUTyVny+odeBrsARZCPJLQOrga7bFbBQc/PzrVcYQxjTuyk1SYt66LJaiqOtPPGsRjY416Yz8IqOuqdqUi/ZdMk5h5XYejAT2DtV2/8i2e7snMBU3fWZqpORTlr0TwnrowPmexuV5Co0YA==; 5:2FDo8lGAzVZ96kxodAszLx8l3Ui17ZPQX74Fcr79MiO8KYUZDR7L6g7NxuvAp1lecSXJtyNKgpiqZchMN7Ey6NNdWXSLWDOXEF7DrIhJDPpKHAc3niPSNWOYTKId5vmi6igA9mvt7yGJiGV6XcMP94izKhI9tzSxstPvozjjgrY=; 7:VvFR3njrtS8D9xYQpu1HgknC4hVRJPbNhGToqjySXo4Cxh9Is876LMkFUM05Nq3N+KqMcI2xkrwq6qrg6lH6MvKna2fqjD3Zo2UmGIM0EPlq+rjOJC8mm7tX+3nwIeILK1qADQ4yms0yCRVAYCltVn1jAHy5Nw6WoDcdDN8HMyj4v8CPGKdDwLrp41yxUIPha8EQru38pSqJ2bl9ExkK6XemuiHl0vpOXih70TROtOWCzpFRlcVwWk5Z9UKQ7NsW x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: b92a7baf-3f35-493a-499e-08d639122415 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3220; x-ms-traffictypediagnostic: AM4PR05MB3220: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231355)(944501410)(52105095)(3002001)(6055026)(148016)(149066)(150057)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:AM4PR05MB3220; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB3220; x-forefront-prvs: 0834BAF534 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(376002)(346002)(366004)(39860400002)(189003)(199004)(13464003)(229853002)(316002)(53936002)(55016002)(6436002)(110136005)(71190400001)(86362001)(575784001)(9686003)(33656002)(2906002)(71200400001)(3846002)(6116002)(66066001)(25786009)(68736007)(106356001)(105586002)(81166006)(7736002)(6246003)(8676002)(81156014)(8936002)(478600001)(74316002)(2501003)(4326008)(53546011)(5250100002)(102836004)(107886003)(5660300001)(76176011)(2201001)(7696005)(14454004)(99286004)(446003)(11346002)(486006)(186003)(97736004)(26005)(256004)(6506007)(2900100001)(54906003)(305945005)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3220; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 3d9UNiIUVa7EbTEcd84k+svLICSV/4zsv6CdLREEhWj4ay29jUotINes3z9+KKX8gbLtDIDER1dwS87rhCDu+4G/NpLPtixLsQJhKHTAL0ZhvvFC9KZmdVNUePHffYoqvaR4S/LbPNAydzoKzaC4ZXrD/Bzjei0LfMfYPLg+x4iT/Fllqc4YjSUEUaMAfMzN/CJYgXbhQna7zT6XOR79nlSU0KzyKvnZnbfHFw1CW/BYDoF13r1GB6vtM14ofS0zjVHcAioF4mFlRtE4a7nwWvE/VDlEPyVxGK14TRt6w8bak6vuNSJ8M9+Z3q9SNilaecdGdOAJZwPJfeUJal99wqLes2g3opcF6R5kLb+lSNc= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b92a7baf-3f35-493a-499e-08d639122415 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2018 18:05:39.5602 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3220 Subject: Re: [dpdk-dev] [PATCH 2/2] ethdev: fix metadata documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 18:05:42 -0000 > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Tuesday, October 23, 2018 4:29 PM > To: wenzhuo.lu@intel.com; jingjing.wu@intel.com; > bernard.iremonger@intel.com; olivier.matz@6wind.com; Adrien Mazarguil > ; Thomas Monjalon ; > ferruh.yigit@intel.com; arybchenko@solarflare.com > Cc: Shahaf Shuler ; dev@dpdk.org; Ori Kam > ; Dekel Peled > Subject: [dpdk-dev] [PATCH 2/2] ethdev: fix metadata documentation >=20 > Previous patch introduced the Tx metadata feature, with unnecessary > restrictions on data entry. >=20 > This fix updates the documentation, removing the data entry > restrictions on metadata item. >=20 > Fixes: aa0b9484eb5f ("ethdev: support metadata as flow rule criteria") > Cc: dekelp@mellanox.com >=20 > Signed-off-by: Dekel Peled > --- > doc/guides/prog_guide/rte_flow.rst | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) >=20 > diff --git a/doc/guides/prog_guide/rte_flow.rst > b/doc/guides/prog_guide/rte_flow.rst > index 6fb0535..d6683e4 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -1196,21 +1196,21 @@ Item: ``META`` >=20 > Matches an application specific 32 bit metadata item. >=20 > -- Default ``mask`` matches the specified metadata value. > +- Default ``mask`` matches any 32 bit value. >=20 Are you sure from the impelmetion it looks like default mask is all ones, This means that the first comment is the correct one. > .. _table_rte_flow_item_meta: >=20 > .. table:: META >=20 > - +----------+----------+-----------------------+ > - | Field | Subfield | Value | > - +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+ > - | ``spec`` | ``data`` | 32 bit metadata value | > - +----------+----------------------------------+ > - | ``last`` | ``data`` | ignored | > - +----------+----------+-----------------------+ > - | ``mask`` | ``data`` | ignored | > - +----------+----------+-----------------------+ > + +----------+----------+---------------------------------------+ > + | Field | Subfield | Value | > + > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+ > + | ``spec`` | ``data`` | 32 bit metadata value | > + +----------+--------------------------------------------------+ > + | ``last`` | ``data`` | upper range value | > + +----------+----------+---------------------------------------+ > + | ``mask`` | ``data`` | bit-mask applies to "spec" and "last" | > + +----------+----------+---------------------------------------+ >=20 > Actions > ~~~~~~~ > -- > 1.8.3.1