From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10061.outbound.protection.outlook.com [40.107.1.61]) by dpdk.org (Postfix) with ESMTP id DE9A02BE6; Sun, 22 Jul 2018 08:33:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6SxSK2gk9TVvSGYN5XZpz0hBybXv4AWn3TxyNet/jnE=; b=mqncy5UhaRuRWZa8F8vMHuUDJbhhbdzF3dJdBerJqwyuNyUEVAlU+UubZgvyGUjItsj6BM+DgdPBQCCbty5n4tLsVlmo+9wrXnH1UNMi2kYehPz/o9D+N7euiouiFOpzTuqCZxd4p41L6CrIslTlorvEfn7M7oZ0GOs0fg3xB/Q= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.187.142) by AM4PR05MB3252.eurprd05.prod.outlook.com (10.171.186.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.16; Sun, 22 Jul 2018 06:33:50 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::6d55:c970:605a:4106]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::6d55:c970:605a:4106%4]) with mapi id 15.20.0973.018; Sun, 22 Jul 2018 06:33:50 +0000 From: Ori Kam To: Rosen Xu , "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , "walter.e.gilmore@intel.com" , "qi.z.zhang@intel.com" , "stable@dpdk.org" Thread-Topic: [PATCH v2] examples/flow_filtering: add rte_fdir_conf initialization Thread-Index: AQHUIMfCB4CKcC9awk2JZ1i6sR4uMaSayFcQ Date: Sun, 22 Jul 2018 06:33:50 +0000 Message-ID: References: <1531361387-116027-1-git-send-email-rosen.xu@intel.com> <1532159404-88843-1-git-send-email-rosen.xu@intel.com> In-Reply-To: <1532159404-88843-1-git-send-email-rosen.xu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB3252; 6:2FX3L9CE9vVaIIpu3V2f31fOd9NtHcAjlqjKqpCujCF/dMO8eyt/r4WuMLAWyeDGTCKQlL9BLfUw6WOrMu25BrU+VirEvKTWa15eEHxZF8Xe7IdnvWTK/b+/1wJZPPSmohQzf//zhfWcVjLLujG27kEBXhx4HusUFITq4EssUqI5lE0Fm4g049ON574qUyBwsvOT2n9f1Z0cq8asnv7XIpUnsQhMC6g08Vdk0x13B8EQNDVGMIMskq9gx8YmIbNbQcwR1S0avl/uXoxu86Xh1tiO3P2QTU00gs/wsDmxJLpKmrll2uCbo3ynjptEPHsm91wgx2sw6ciLQR/oSDPESoydtJHCGq0CecBWVCgv0Mhp6R5TpDFRGbKQxAA2LF2AsAhHUc2y5Y5Yu4zJX485Rcj2OJqTaUdjbeoyqNzEngAdiFSWrBodHzC9y+PNjtEGMkctt2GENg3HYJV6MbANfg==; 5:14SCatRlezjvZYmhsxexjae/3fpFEG6btPSLWsku3mc0tZfzn/JRogJY63vqkguzKocTqiiSc6QN+rzKxAdWFdMLualtl0z4tJWklUfHlqNVmRVQzKugF//Y9/4U6RSdT3JdeDWT5/cwWIeHuic8kj6cfFXZAMU2ADNKP5k6m+U=; 7:WpJShvQki+ERDmD1l5m1CwyysBjl1op20aOf7x0blfIz9DmBlZRGebH09ZE5tSfvu3pSqrEfFIHIIbR2dy3IGIk7FnqVpLRnAzsQXZsKukajiJK/F8yc1bzUutQXfvqeY7Ysqxe/2JPFfxaE3JnXqLkIEyMfdmORXzI5Qxxbp86SnT1dqInUwH7QQzdNeiQND0q2vdW3K612iXbLwq+XAIZR6pbq/YrFAW9na1dByPEr+I9iXhmowLj46OKiW3dX x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 2dbff282-6882-4547-2dc3-08d5ef9d1673 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3252; x-ms-traffictypediagnostic: AM4PR05MB3252: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:AM4PR05MB3252; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB3252; x-forefront-prvs: 0741C77572 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(396003)(366004)(376002)(39860400002)(346002)(199004)(189003)(13464003)(68736007)(478600001)(76176011)(316002)(6436002)(54906003)(110136005)(5250100002)(97736004)(14454004)(99286004)(55016002)(446003)(7696005)(105586002)(9686003)(33656002)(229853002)(106356001)(26005)(6116002)(486006)(86362001)(8676002)(256004)(74316002)(305945005)(6246003)(476003)(3846002)(53936002)(4326008)(11346002)(7736002)(66066001)(25786009)(81166006)(6506007)(2906002)(53546011)(186003)(8936002)(81156014)(2501003)(5660300001)(2900100001)(102836004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3252; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: KxxmJDPRo208Ka/UgrrmabyvL2XBurFBAcTqyyIIyN9uaETrBPGE7SzigSkgs7vYHDIrAM/QwVaSP5B28l98KtS68ACL0/BPBbG5QnThNMs2B9tXihX+COYK3zp8ovDJCOStWDNX6XYzI0+ZiNwHGH4GmW0XwXhoJmRfUsWo+1Ecgbqbw1v9v2DhRf5FRWz+NE0KddqCi0UFzB7qOpBxtTDFm0JWwn2YLTBKbHWb2vvXKJlh2IiO9iNdCL22QgGTpPKkaU1FA380N+WSXQj062N3UXCylzmVOl8WCdV0MEpK4PQhqLZhZzyC11kx+ERc8ZwiqxhozP/oQpJ9ZzkVTa7+NbJ2b8rnSV2kD0M3EYI= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2dbff282-6882-4547-2dc3-08d5ef9d1673 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2018 06:33:50.7143 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3252 Subject: Re: [dpdk-dev] [PATCH v2] examples/flow_filtering: add rte_fdir_conf initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Jul 2018 06:33:53 -0000 > -----Original Message----- > From: Rosen Xu [mailto:rosen.xu@intel.com] > Sent: Saturday, July 21, 2018 10:50 AM > To: dev@dpdk.org > Cc: rosen.xu@intel.com; ferruh.yigit@intel.com; Ori Kam > ; walter.e.gilmore@intel.com; qi.z.zhang@intel.com; > stable@dpdk.org > Subject: [PATCH v2] examples/flow_filtering: add rte_fdir_conf initializa= tion >=20 > Rte_fdir_conf of rte_eth_conf should be initialized before > port initialization. It is a workaround solution when work > with Intel I40e. >=20 > Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow > API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Rosen Xu >=20 > v2 updates: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > - Take more test on I40e > - Add comments > --- > examples/flow_filtering/main.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/mai= n.c > index f595034..73d646c 100644 > --- a/examples/flow_filtering/main.c > +++ b/examples/flow_filtering/main.c > @@ -132,6 +132,17 @@ > DEV_TX_OFFLOAD_SCTP_CKSUM | > DEV_TX_OFFLOAD_TCP_TSO, > }, > + /* > + * Initialize fdir_conf of ete_eth_conf > + * it is a workaround solution when work with Intel I40e > + * and it is not the normal way > + */ > + .fdir_conf =3D { > + .mode =3D RTE_FDIR_MODE_PERFECT, > + .pballoc =3D RTE_FDIR_PBALLOC_64K, > + .status =3D RTE_FDIR_REPORT_STATUS, > + .drop_queue =3D 127, > + }, > }; > struct rte_eth_txconf txq_conf; > struct rte_eth_rxconf rxq_conf; > -- > 1.8.3.1 Just small comment I think work should be replaced with working. Both in the commit log and code comment. Acked-by: Ori Kam Thanks, Ori