From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F379A04A2; Wed, 6 Nov 2019 11:12:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 401151BFEF; Wed, 6 Nov 2019 11:12:31 +0100 (CET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50073.outbound.protection.outlook.com [40.107.5.73]) by dpdk.org (Postfix) with ESMTP id 81FCC1BFE5; Wed, 6 Nov 2019 11:12:30 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W5rREQsvGoMWaW3YQTRY0Y4nHEohkr4t3ogUhSbsPZTBErtW5yIE5VhD6UsYjpKkb9Y+NyRe8Nce6nQAotzcbk+aRgpB8NODUzpVbXSFRp4cow0QJJIb1R1xpDnVPtuWlk6+jBqwfurNVR4uAtj0N1IjvjhbG6iPAg8OW4O87M2uWnZWTthPQsvbmfUICEMW/fLpW5AL6U3WaxQmgX4+FZM1et0djRnZyF3jwoOfxfWShc6uth+kDXwd8jOZSBzUHnC2abeBgDKUl+m3y2OgPko1cR0HvEcULmJHwDnF1QEfR8tBC88Lm/BuPOrOOKZj56Z7dfWkVRUwkem7wSy0sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9bUyiPkvGivAXaS9+9cSL4p21gSaSSQl/PaQNhbWomE=; b=fZ35ycdoQuLmsF8bfSbtuQ9AhuewekWXIgnP/EI2erB1MlPlkDmzeOYUmQA38qq1wJQ6I4c0OUm2SPqHUGjyQ8eNDttW9P5jfdtrndd0oFp0fL/5FebiXneiNdNphy1x+2Tm6DfKySu0c9jXFOBkN78OFG5mYtxGxjBs1qaIgWlUkgGV8qR31vzd4dqPPKuoGb9EEEvF3/Ru//7q0tbHz6fFLRu9u+sBti0GzamTw2eQ1WKGZmtbhnSSk0Kz9jqOHE27KE//0Q3Qy2vEB0rE358ymS5qJXES6xgQbDEj7dm8/S2QSrp4VldonS2kNHCsnPaMKD1WvigvSuxBYgnDHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9bUyiPkvGivAXaS9+9cSL4p21gSaSSQl/PaQNhbWomE=; b=Sflj/VVe9z+ulxq4zUpIsKBXwXEB2JOXzyUFI5JbxEiAbdWMu/dY8+rW0lXX7kvDSMLtzYgLxAWJpZ18TibkOHOADWaCWU1LwtcQkMwSpykfNqAXRJxyenhAcRUpvn8PDprpWF0sKsRrxJkVhpBLJnSbPbdneVAt1P3EbdWpY4A= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by AM4PR05MB3250.eurprd05.prod.outlook.com (10.170.126.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Wed, 6 Nov 2019 10:12:29 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::70a7:a312:cbc6:d178]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::70a7:a312:cbc6:d178%7]) with mapi id 15.20.2387.028; Wed, 6 Nov 2019 10:12:29 +0000 From: Ori Kam To: Jack Min , Slava Ovsiienko , Thomas Monjalon , Adrien Mazarguil , Ferruh Yigit , Andrew Rybchenko CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] ethdev: fix expand RSS flows Thread-Index: AQHVk97rQgtWg74K7USVwRu4A1N4b6d97WKg Date: Wed, 6 Nov 2019 10:12:29 +0000 Message-ID: References: <1580ef9551619fbe0a1f85590cebaf4b026f7f0b.1572944613.git.jackmin@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: a276a8a3-aff8-4448-c1e8-08d762a1d4d3 x-ms-traffictypediagnostic: AM4PR05MB3250:|AM4PR05MB3250: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2512; x-forefront-prvs: 02135EB356 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(396003)(366004)(346002)(136003)(376002)(13464003)(199004)(189003)(33656002)(110136005)(66476007)(66446008)(66556008)(64756008)(76116006)(316002)(4326008)(76176011)(6246003)(6116002)(2906002)(7696005)(229853002)(26005)(53546011)(102836004)(66946007)(55016002)(52536014)(8676002)(5660300002)(6436002)(3846002)(9686003)(14454004)(305945005)(186003)(71200400001)(54906003)(256004)(14444005)(6506007)(8936002)(476003)(446003)(11346002)(25786009)(486006)(478600001)(74316002)(81156014)(7736002)(66066001)(81166006)(99286004)(71190400001)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3250; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vawBBQgO3IldEAJ9vmxLZcV30T1DLvQE+dNtpY5+hhV+OAGXyB8G7IhtT1oLs+gXbTx+gvyIVfy6PPsKjSANTMnX1HUe5KX+upUDmf2A/8GHnRpQbGv0T1jes/Ys5EVlPnadD4dMTo4ILz2ZodABnju6Vl+kQc16TFbtMAIEGvdgOANxhRvCuqdsfjjobRTWjlwIT0fUFrht+zWRdjWBSOFaNq+DLKXTlrHF/1C3fdWcbnpGNDFb7HyHWm1XAo7uLqa92TfdweX4zP6YxaQHO2JtRkRVfzN/AhRbSF0V8kG3xQXgeRssetnXWl4UEh3YDuvndob6h/5ba6qiWazv5Ajt87lF80NgQPU+73kllT1E2EYs0Y34xrTosQfl2lXds8YbAyo+Le4s0YuOUEfVuD6V99+8f/onU+Wvp/frnQN/09TzczmdwSetzXq/gKLY Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: a276a8a3-aff8-4448-c1e8-08d762a1d4d3 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2019 10:12:29.4339 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mCuQBjenylqH45Rx8gIJFzQfSyAHa8B+o6TWphsY65kujfQKqjwC07o0/CFoZ7tN2kE4ZgDZY4TNyEQA3MC/oA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3250 Subject: Re: [dpdk-dev] [PATCH v2] ethdev: fix expand RSS flows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Xiaoyu Min > Sent: Tuesday, November 5, 2019 3:43 PM > To: Ori Kam ; Slava Ovsiienko > ; Thomas Monjalon ; > Adrien Mazarguil ; Ferruh Yigit > ; Andrew Rybchenko > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH v2] ethdev: fix expand RSS flows >=20 > rte_flow_expand_rss expands rte_flow item list based on the RSS > types. In another word, some additional rules are added if the user > specified items are not complete enough according to the RSS type, > for example: >=20 > ... pattern eth / end actions rss type tcp end ... >=20 > User only provides item eth but want to do RSS on tcp traffic. > The pattern is not complete enough to filter TCP traffic only. > This will be a problem for some HWs. > So some PMDs use rte_flow_expand_rss to expand above user provided > flow to: >=20 > ... pattern eth / end actions rss types tcp > ... pattern eth / ipv4 / tcp / end actions rss types tcp ... > ... pattern eth / ipv6 / tcp / end actions rss types tcp ... >=20 > in order to filter TCP traffic only and do RSS correctly. >=20 > However the current expansion cannot handle pattern as below, which > provides ethertype or ip next proto instead of providing an item: >=20 > ... pattern eth type is 0x86DD / end actions rss types tcp ... >=20 > rte_flow_expand_rss will expand above flow to: >=20 > ... pattern eth type is 0x86DD / ipv4 / tcp end ... >=20 > which has conflicting values: 0x86DD vs. ipv4 and some HWs will refuse > to create flow. >=20 > This patch will fix above by checking the last item's spec and to > expand RSS flows correctly. >=20 > Currently only support to complete item list based on ether type or ip > next proto. >=20 > Fixes: 4ed05fcd441b ("ethdev: add flow API to expand RSS flows") > Cc: stable@dpdk.org >=20 > Signed-off-by: Xiaoyu Min > --- > v2: > * more clear commit message > --- Acked-by: Ori Kam