From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8F5EA0487 for ; Mon, 1 Jul 2019 11:58:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8D194325F; Mon, 1 Jul 2019 11:58:27 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20040.outbound.protection.outlook.com [40.107.2.40]) by dpdk.org (Postfix) with ESMTP id EBC022BB5 for ; Mon, 1 Jul 2019 11:58:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uQMdB7cjwAY8p8M7UvxEC0F1W/O1ib7eLw8uAytuXSE=; b=GRvdSuo1CLgdZYKVES1AX0pWzue1p7ucnLY0BG9pLFIa4mwgOfAHtZfxnUTgEsb1/BpDIZNWpd/eet8SG2EBNDRqxikflJWA6ZOlOdd78mUQ8h6UFrCHvAKkqvmRKyuVxjTuN3+rAn+yYRG1mlafdGnDhMS3gahfAtWT9tfWzcQ= Received: from AM4PR05MB3460.eurprd05.prod.outlook.com (10.171.187.153) by AM4PR05MB3138.eurprd05.prod.outlook.com (10.171.186.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.17; Mon, 1 Jul 2019 09:58:23 +0000 Received: from AM4PR05MB3460.eurprd05.prod.outlook.com ([fe80::7de4:132c:8c9:438]) by AM4PR05MB3460.eurprd05.prod.outlook.com ([fe80::7de4:132c:8c9:438%4]) with mapi id 15.20.2032.019; Mon, 1 Jul 2019 09:58:23 +0000 From: Dekel Peled To: Adrien Mazarguil CC: "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" , Yongseok Koh , Shahaf Shuler , Slava Ovsiienko , "arybchenko@solarflare.com" , "dev@dpdk.org" , Ori Kam Thread-Topic: [PATCH v8 1/3] ethdev: add actions to modify TCP header fields Thread-Index: AQHVL+quxxzOaWBXF0uXyhvQFJfwC6a1huVw Date: Mon, 1 Jul 2019 09:58:23 +0000 Message-ID: References: <8b43b7e77d467429b45cb86eb09e218d721dd0de.1561872899.git.dekelp@mellanox.com> <20190701085502.GD3911@6wind.com> In-Reply-To: <20190701085502.GD3911@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dekelp@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 786af67e-42c6-4ec5-5e76-08d6fe0aa77f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM4PR05MB3138; x-ms-traffictypediagnostic: AM4PR05MB3138: x-ms-exchange-purlcount: 1 x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 00851CA28B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(136003)(39860400002)(346002)(376002)(366004)(199004)(189003)(13464003)(9686003)(55016002)(5660300002)(52536014)(8676002)(4326008)(186003)(53936002)(26005)(45080400002)(33656002)(229853002)(76176011)(99286004)(54906003)(8936002)(966005)(71190400001)(6306002)(446003)(6916009)(3846002)(6436002)(25786009)(6116002)(71200400001)(76116006)(66946007)(256004)(6246003)(74316002)(486006)(66476007)(66556008)(64756008)(66446008)(7696005)(316002)(86362001)(73956011)(14454004)(107886003)(68736007)(305945005)(2906002)(53546011)(7736002)(6506007)(81166006)(81156014)(66066001)(478600001)(476003)(14444005)(102836004)(11346002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3138; H:AM4PR05MB3460.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: mzVow3YZgXKJXmwq/OBM9Leo82VYtv1omiYJPm0QnNTEq1iHC18kBOsAKQNKvk6kg19hdmB/GAkfIjcpqjvfgvGck3mNGea9nvQbW6Z4YWbv7pumajpExOkJwulXvYL4fgawNzk7el4plTsg/3tOfDR97li53OupGlvQzMW10L4RcaWsVF1C0bZ7xGA+qYpBQYNv/hwMaV4tZvk7SJNf1VgpkCJFUpcgR1DRf3mEX3N3nA1QUw2IQ+9Q/FNrZpSYicU/5JSIth3XH/Rx/sOSm4DeFJg1gDMtHEkJDrqTWgmLjvlYwFaZq9FLTx3ZEu5yNS1RRSeegahhmlawv3nV6K24CiS0CSuxh+MRRN/c7oBabnmH28gmbIY104zJT9IyOf6mI3WlZiuwpoL7MX/tYLYPVWO5+MoRsArGXUgwv7A= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 786af67e-42c6-4ec5-5e76-08d6fe0aa77f X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2019 09:58:23.1005 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dekelp@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3138 Subject: Re: [dpdk-dev] [PATCH v8 1/3] ethdev: add actions to modify TCP header fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Accepted, will send separate patch and v9 later today. > -----Original Message----- > From: Adrien Mazarguil > Sent: Monday, July 1, 2019 11:55 AM > To: Dekel Peled > Cc: wenzhuo.lu@intel.com; jingjing.wu@intel.com; > bernard.iremonger@intel.com; Yongseok Koh ; > Shahaf Shuler ; Slava Ovsiienko > ; arybchenko@solarflare.com; dev@dpdk.org; > Ori Kam > Subject: Re: [PATCH v8 1/3] ethdev: add actions to modify TCP header fiel= ds >=20 > On Sun, Jun 30, 2019 at 10:59:08AM +0300, Dekel Peled wrote: > > Add actions: > > - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. > > - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP > header. > > - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP > > header. > > - DEC_TCP_ACK - Decrease acknowledgment number in the outermost TCP > > header. > > > > Original work by Xiaoyu Min. > > > > This patch introduces a new approach, using a simple integer instead > > of using an action-specific structure for each of these actions. > > This approach can be later applied to modify existing actions which > > require only a single integer. > > > > Signed-off-by: Dekel Peled > > Acked-by: Andrew Rybchenko >=20 > You didn't take Andrew's comment [1] into account, this patch must be spl= it. > I'll highlight what needs to be moved to a pre-patch below. >=20 > [1] > https://eur03.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fmails= . > dpdk.org%2Farchives%2Fdev%2F2019- > June%2F136101.html&data=3D02%7C01%7Cdekelp%40mellanox.com%7C0 > 353d4fafe004b4434a608d6fe01d04c%7Ca652971c7d2e4d9ba6a4d149256f461b > %7C0%7C0%7C636975681078705620&sdata=3DwrMFZOMT65S6X6d4vTnsF > AAyRF%2F2dTnonX4Ozy7S930%3D&reserved=3D0 >=20 > [...] > > diff --git a/doc/guides/prog_guide/rte_flow.rst > > b/doc/guides/prog_guide/rte_flow.rst > > index a34d012..783a904 100644 > > --- a/doc/guides/prog_guide/rte_flow.rst > > +++ b/doc/guides/prog_guide/rte_flow.rst > > @@ -1214,7 +1214,8 @@ Actions > > ~~~~~~~ > > > > Each possible action is represented by a type. Some have associated > > -configuration structures. Several actions combined in a list can be > > assigned > > +configuration structures, some others use a simple integer. > > +Several actions combined in a list can be assigned > > to a flow rule and are performed in order. >=20 > ^^^^ This must be moved to a separate patch ^^^^ >=20 > BTW, how about "configuration structure" -> "configuration object" > encompassing all kinds of objects once and for all instead? Such a generi= c > term will be handy when actions start using floats or function pointers. >=20 > [...] > > /** > > @@ -2140,7 +2172,7 @@ struct rte_flow_action_set_mac { > > */ > > struct rte_flow_action { > > enum rte_flow_action_type type; /**< Action type. */ > > - const void *conf; /**< Pointer to action configuration structure. */ > > + const void *conf; /**< Pointer to action configuration. */ > > }; >=20 > ^^^^ This must be moved to a separate patch ^^^^ >=20 > Same comment regarding "configuration object". >=20 > -- > Adrien Mazarguil > 6WIND