From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63036A04AB; Wed, 6 Nov 2019 14:14:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BA3221C194; Wed, 6 Nov 2019 14:14:15 +0100 (CET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50054.outbound.protection.outlook.com [40.107.5.54]) by dpdk.org (Postfix) with ESMTP id 0166B1C12B for ; Wed, 6 Nov 2019 14:14:13 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PGljodc8OtGkZtbXqoRwQQ+Hrdm/jivE6iuRFRbAhBVamb5iMKr8LJrobbAIV99Yk7tfd8t1UKn9V89WtLXvdw2ABRzrhV3mOkW1JlkEPbwk7gy9EfnN8Rzg8rN7PtQcMtChvN5TMsrv9YGF21Wubb+aEM5vv91gtCLPl4CBX9qjam1vKgkug99EAM/y0funocfTOMuUcQRApsHsTC/ErqYSPjPJEeAikxe+pkg36rnnovpLtx7h3jwqzYrRhInNfWI75/gkY9wXA5bXM4HKBtYx0XveHAwANS1/xnct8yDUfcm9B0KKR8ga3bnBdvGDHP8B+KiQXUd0AeY+xnkilg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5yCw7xf1D+XVetUce+C7RriDdj4YVyc2TYusfVz/fTQ=; b=BFvdzMCu3vvaRJmrbWGba49Ozw7Rixdk2qSCQafNTfKuCUOKF2udSvrDLrUXga0HHXCUrWXAm+CyIzAb9PczffLM4ROkxf0hbQwFjBnxTyowW0iPPq5CGANWm0S1Gp+Wx0HyMNjR7xCxoj1sQxb4rEETsBPWvhQPvfhAPMHLWSgaCpjV1w2cHvcsel2hrPAbYojhB36qNsYFqrHhKfPDugtjDrUT8Ua1q/e5Z7cBBWf6xW8At4Lt7OsupmShPtzscseCTqLi8XGQGe19jwmTo6jX9NpPKBURluXv75Ddff/bA0gEzaeZ9C9fvXClw9h/TGXaf8azOcFUUPWxQ6NQAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5yCw7xf1D+XVetUce+C7RriDdj4YVyc2TYusfVz/fTQ=; b=HPBWgJ305F12+Cl1TJbESBa4vdC4l64y8BgWaIBY7qQzTig9pTwqqKH787qIvMGz3yyaxVmnnNsczb11F3X+n8Nx/imXu5erY69zoo3Rj6DEEcjoQH/acHrkmktWygSKlX+RpnORs9uXV4htroOkRj3B9/NPiz9oe9gxyWD+FXo= Received: from AM4PR05MB3460.eurprd05.prod.outlook.com (10.171.187.153) by AM4PR05MB3185.eurprd05.prod.outlook.com (10.171.188.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Wed, 6 Nov 2019 13:14:12 +0000 Received: from AM4PR05MB3460.eurprd05.prod.outlook.com ([fe80::117b:8dc0:905e:d154]) by AM4PR05MB3460.eurprd05.prod.outlook.com ([fe80::117b:8dc0:905e:d154%4]) with mapi id 15.20.2430.020; Wed, 6 Nov 2019 13:14:12 +0000 From: Dekel Peled To: "Iremonger, Bernard" , "Mcnamara, John" , "Kovacevic, Marko" , "nhorman@tuxdriver.com" , "ajit.khaparde@broadcom.com" , "somnath.kotur@broadcom.com" , "Burakov, Anatoly" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , Matan Azrad , Shahaf Shuler , Slava Ovsiienko , "rmody@marvell.com" , "shshaikh@marvell.com" , "maxime.coquelin@redhat.com" , "Bie, Tiwei" , "Wang, Zhihong" , "yongwang@vmware.com" , Thomas Monjalon , "Yigit, Ferruh" , "arybchenko@solarflare.com" , "Wu, Jingjing" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 3/3] app/testpmd: use API to set max LRO packet size Thread-Index: AQHVlJY/TjYRGBxiWU229DEivhw9Q6d+FEIAgAACzdA= Date: Wed, 6 Nov 2019 13:14:12 +0000 Message-ID: References: <8CEF83825BEC744B83065625E567D7C260E211E1@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260E211E1@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dekelp@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9332f486-0157-4194-7f1d-08d762bb3745 x-ms-traffictypediagnostic: AM4PR05MB3185:|AM4PR05MB3185: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-forefront-prvs: 02135EB356 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(366004)(376002)(396003)(136003)(346002)(199004)(189003)(13464003)(76176011)(66446008)(14454004)(66066001)(71200400001)(7696005)(478600001)(99286004)(74316002)(8676002)(305945005)(4326008)(25786009)(7416002)(66476007)(476003)(81156014)(110136005)(81166006)(186003)(71190400001)(9686003)(52536014)(33656002)(86362001)(55016002)(6246003)(316002)(5660300002)(7736002)(486006)(2501003)(6116002)(2201001)(6506007)(2906002)(446003)(53546011)(66556008)(102836004)(256004)(66946007)(64756008)(11346002)(26005)(229853002)(76116006)(6436002)(3846002)(8936002)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3185; H:AM4PR05MB3460.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DCbtRgClOunm/KcWAo21hVFzdePfssTLkp+J8stXaHfu6lfcPmVgEtw8MfptmqQzj+/TNwUaH3nUCQw4o7qmsD6bvG3jBzx80dRsPww3iqI+ztfxSyiREZBTIxhp8gtg9qxRu0OdSmKt+3KIx3gYrWQzSOgZnHJmgQqFlzI+L6MsJYGSilKSj+cN1Fi0teCHgrs67eOkm/mSrac0R2WMte8l0bKTZe0yIaIVGyAfTUI3jAtDac9+P4sWfEo7UPz/057VJE5aZWZArGZxEHYi1KL6Xiht/mOz+KWqhhE58zm9qWDLKqepYu3E5wGiFFOtnTbfiftPoyJsOGDogjp8G/PS2Ww1rj6VKO52NJlKlSthYExMPDG5C3/hphrFcjk706NWi5vsaa1gprOTTx+s/RS7fl2Y/CpldACtO97VMS0zH72I2qHW5xvwlz3uRjEa Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9332f486-0157-4194-7f1d-08d762bb3745 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2019 13:14:12.0773 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fcE43J6IFPS+k0ZyA2kCK9kd2zcENb5Uf7TxGwykqyDsm6SYpXUyKIoWNLvcgOzWHjK/xOXdtg+tRhC55bOyfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3185 Subject: Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: use API to set max LRO packet size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks, PSB. > -----Original Message----- > From: Iremonger, Bernard > Sent: Wednesday, November 6, 2019 2:36 PM > To: Dekel Peled ; Mcnamara, John > ; Kovacevic, Marko > ; nhorman@tuxdriver.com; > ajit.khaparde@broadcom.com; somnath.kotur@broadcom.com; Burakov, > Anatoly ; xuanziyang2@huawei.com; > cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; Lu, Wenzhuo > ; Ananyev, Konstantin > ; Matan Azrad ; > Shahaf Shuler ; Slava Ovsiienko > ; rmody@marvell.com; > shshaikh@marvell.com; maxime.coquelin@redhat.com; Bie, Tiwei > ; Wang, Zhihong ; > yongwang@vmware.com; Thomas Monjalon ; Yigit, > Ferruh ; arybchenko@solarflare.com; Wu, Jingjing > > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 3/3] app/testpmd: use API to set max LRO packet si= ze >=20 > Hi Dekel, >=20 > > -----Original Message----- > > From: Dekel Peled > > Sent: Wednesday, November 6, 2019 11:35 AM > > To: Mcnamara, John ; Kovacevic, Marko > > ; nhorman@tuxdriver.com; > > ajit.khaparde@broadcom.com; somnath.kotur@broadcom.com; Burakov, > > Anatoly ; xuanziyang2@huawei.com; > > cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; Lu, > Wenzhuo > > ; Ananyev, Konstantin > > ; matan@mellanox.com; > > shahafs@mellanox.com; viacheslavo@mellanox.com; > rmody@marvell.com; > > shshaikh@marvell.com; maxime.coquelin@redhat.com; Bie, Tiwei > > ; Wang, Zhihong ; > > yongwang@vmware.com; thomas@monjalon.net; Yigit, Ferruh > > ; arybchenko@solarflare.com; Wu, Jingjing > > ; Iremonger, Bernard > > > > Cc: dev@dpdk.org > > Subject: [PATCH v2 3/3] app/testpmd: use API to set max LRO packet > > size > > > > This patch implements use of the API for LRO aggregated packet max size= . > > It adds command-line and runtime commands to configure this value, and > > adds option to show the supported value. > > Documentation is updated accordingly. > > > > Signed-off-by: Dekel Peled > > --- > > app/test-pmd/cmdline.c | 73 > > +++++++++++++++++++++++++++++ > > app/test-pmd/config.c | 2 + > > app/test-pmd/parameters.c | 5 ++ > > app/test-pmd/testpmd.c | 1 + > > doc/guides/testpmd_app_ug/run_app.rst | 5 ++ > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 ++++ > > 6 files changed, 95 insertions(+) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > 4478069..edfa60f 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -2037,6 +2037,78 @@ struct cmd_config_max_pkt_len_result { > > }, > > }; > > > > +/* *** config max LRO aggregated packet size *** */ struct > > +cmd_config_max_lro_pkt_size_result { > > + cmdline_fixed_string_t port; > > + cmdline_fixed_string_t keyword; > > + cmdline_fixed_string_t all; > > + cmdline_fixed_string_t name; > > + uint32_t value; > > +}; > > + > > +static void > > +cmd_config_max_lro_pkt_size_parsed(void *parsed_result, > > + __attribute__((unused)) struct cmdline *cl, > > + __attribute__((unused)) void *data) { > > + struct cmd_config_max_lro_pkt_size_result *res =3D parsed_result; > > + portid_t pid; > > + > > + if (!all_ports_stopped()) { > > + printf("Please stop all ports first\n"); > > + return; > > + } > > + > > + RTE_ETH_FOREACH_DEV(pid) { > > + struct rte_port *port =3D &ports[pid]; > > + > > + if (!strcmp(res->name, "max-lro-pkt-size")) { > > + if (res->value =3D=3D > > + port- > > >dev_conf.rxmode.max_lro_pkt_size) > > + return; > > + >=20 > Should there be a check on the input value, max is RTE_ETHER_MAX_LEN ? >=20 Max is device specific, can't check it here. >=20 > > + port->dev_conf.rxmode.max_lro_pkt_size =3D res- > > >value; > > + } else { > > + printf("Unknown parameter\n"); > > + return; > > + } > > + } > > + > > + init_port_config(); > > + > > + cmd_reconfig_device_queue(RTE_PORT_ALL, 1, 1); } > > + > > +cmdline_parse_token_string_t cmd_config_max_lro_pkt_size_port =3D > > + TOKEN_STRING_INITIALIZER(struct > > cmd_config_max_lro_pkt_size_result, > > + port, "port"); > > +cmdline_parse_token_string_t cmd_config_max_lro_pkt_size_keyword > =3D > > + TOKEN_STRING_INITIALIZER(struct > > cmd_config_max_lro_pkt_size_result, > > + keyword, "config"); > > +cmdline_parse_token_string_t cmd_config_max_lro_pkt_size_all =3D > > + TOKEN_STRING_INITIALIZER(struct > > cmd_config_max_lro_pkt_size_result, > > + all, "all"); > > +cmdline_parse_token_string_t cmd_config_max_lro_pkt_size_name =3D > > + TOKEN_STRING_INITIALIZER(struct > > cmd_config_max_lro_pkt_size_result, > > + name, "max-lro-pkt-size"); > > +cmdline_parse_token_num_t cmd_config_max_lro_pkt_size_value =3D > > + TOKEN_NUM_INITIALIZER(struct > > cmd_config_max_lro_pkt_size_result, > > + value, UINT32); > > + > > +cmdline_parse_inst_t cmd_config_max_lro_pkt_size =3D { > > + .f =3D cmd_config_max_lro_pkt_size_parsed, > > + .data =3D NULL, > > + .help_str =3D "port config all max-lro-pkt-size ", > > + .tokens =3D { > > + (void *)&cmd_config_max_lro_pkt_size_port, > > + (void *)&cmd_config_max_lro_pkt_size_keyword, > > + (void *)&cmd_config_max_lro_pkt_size_all, > > + (void *)&cmd_config_max_lro_pkt_size_name, > > + (void *)&cmd_config_max_lro_pkt_size_value, > > + NULL, > > + }, > > +}; > > + > > /* *** configure port MTU *** */ > > struct cmd_config_mtu_result { > > cmdline_fixed_string_t port; > > @@ -19024,6 +19096,7 @@ struct > > cmd_show_port_supported_ptypes_result { > > (cmdline_parse_inst_t *)&cmd_config_rx_tx, > > (cmdline_parse_inst_t *)&cmd_config_mtu, > > (cmdline_parse_inst_t *)&cmd_config_max_pkt_len, > > + (cmdline_parse_inst_t *)&cmd_config_max_lro_pkt_size, > > (cmdline_parse_inst_t *)&cmd_config_rx_mode_flag, > > (cmdline_parse_inst_t *)&cmd_config_rss, > > (cmdline_parse_inst_t *)&cmd_config_rxtx_ring_size, diff --git > > a/app/test-pmd/config.c b/app/test-pmd/config.c index efe2812..50e6ac0 > > 100644 > > --- a/app/test-pmd/config.c > > +++ b/app/test-pmd/config.c > > @@ -629,6 +629,8 @@ static int bus_match_all(const struct rte_bus > > *bus, const void *data) > > printf("Minimum size of RX buffer: %u\n", > dev_info.min_rx_bufsize); > > printf("Maximum configurable length of RX packet: %u\n", > > dev_info.max_rx_pktlen); > > + printf("Maximum configurable size of LRO aggregated packet: %u\n", > > + dev_info.max_lro_pkt_size); > > if (dev_info.max_vfs) > > printf("Maximum number of VFs: %u\n", dev_info.max_vfs); > > if (dev_info.max_vmdq_pools) > > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c > > index > > 9ea87c1..3e371e2 100644 > > --- a/app/test-pmd/parameters.c > > +++ b/app/test-pmd/parameters.c > > @@ -592,6 +592,7 @@ > > { "mbuf-size", 1, 0, 0 }, > > { "total-num-mbufs", 1, 0, 0 }, > > { "max-pkt-len", 1, 0, 0 }, > > + { "max-lro-pkt-size", 1, 0, 0 }, >=20 > The max-lro-pkt-size option should be documented in the usage() function > around line 110 in parameters.c >=20 I'll add in in v3. > > { "pkt-filter-mode", 1, 0, 0 }, > > { "pkt-filter-report-hash", 1, 0, 0 }, > > { "pkt-filter-size", 1, 0, 0 }, > > @@ -888,6 +889,10 @@ > > "Invalid max-pkt-len=3D%d - > > should be > %d\n", > > n, RTE_ETHER_MIN_LEN); > > } > > + if (!strcmp(lgopts[opt_idx].name, "max-lro-pkt- > > size")) { > > + n =3D atoi(optarg); >=20 > Should there be a check on the value input, max value is > RTE_ETHER_MAX_LEN? Max is device specific, can't check it here. >=20 > > + rx_mode.max_lro_pkt_size =3D (uint32_t) n; > > + } > > if (!strcmp(lgopts[opt_idx].name, "pkt-filter-mode")) > { > > if (!strcmp(optarg, "signature")) > > fdir_conf.mode =3D > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > > 38acbc5..d4f67ec 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -419,6 +419,7 @@ struct fwd_engine * fwd_engines[] =3D { struct > > rte_eth_rxmode rx_mode =3D { > > .max_rx_pkt_len =3D RTE_ETHER_MAX_LEN, > > /**< Default maximum frame length. */ > > + .max_lro_pkt_size =3D RTE_ETHER_MAX_LEN, > > }; > > > > struct rte_eth_txmode tx_mode =3D { > > diff --git a/doc/guides/testpmd_app_ug/run_app.rst > > b/doc/guides/testpmd_app_ug/run_app.rst > > index ef677ba..bc17f3f 100644 > > --- a/doc/guides/testpmd_app_ug/run_app.rst > > +++ b/doc/guides/testpmd_app_ug/run_app.rst > > @@ -112,6 +112,11 @@ The command line options are: > > > > Set the maximum packet size to N bytes, where N >=3D 64. The > > default value is 1518. > > > > +* ``--max-lro-pkt-size=3DN`` > > + > > + Set the maximum LRO aggregated packet size to N bytes, where N >= =3D > 64. > > + The default value is 1518. >=20 > Should a max value be specified ? Max is device specific, can't specify it here. >=20 > > + > > * ``--eth-peers-configfile=3Dname`` > > > > Use a configuration file containing the Ethernet addresses of the > > peer ports. > > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > index c68a742..0267295 100644 > > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > @@ -2139,6 +2139,15 @@ Set the maximum packet length:: > > > > This is equivalent to the ``--max-pkt-len`` command-line option. > > > > +port config - max-lro-pkt-size > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > + > > +Set the maximum LRO aggregated packet size:: > > + > > + testpmd> port config all max-lro-pkt-size (value) > > + > > +This is equivalent to the ``--max-lro-pkt-size`` command-line option. > > + > > port config - Drop Packets > > ~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > -- > > 1.8.3.1 >=20 > Regards, >=20 > Bernard.