From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA0A3A057B; Tue, 24 Mar 2020 13:39:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5F031C0CF; Tue, 24 Mar 2020 13:39:42 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70075.outbound.protection.outlook.com [40.107.7.75]) by dpdk.org (Postfix) with ESMTP id EC5FC1C0C9 for ; Tue, 24 Mar 2020 13:39:41 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KUc8jwYRwksIjezU1rt2y5Rm885yB9uGGNWk8H0eWp+D0LGwtN6dxS/JCkM4pqfbbHLGt+ECnQkj4MeCK4eYeAxa6ix6eUmUdWVdJ6dWyKPZsGW1gFGLridwk4JKpd149D3MfzGjamYhMHa9655yBpW818mreRQhVw8qvwvobQC0uq3XYeOacU53/61/Bqkn3scFuIKdrqflozCeuKHKh3z+SobHzvb0xt6FBB1XEBWJyHa5Sr0OyOG6KipAVdSOJGTfcE0IFXjKNFQuNakIcVPnEOJyrz3fbktHDQSb4fYC8K1QWT/zgUzdlZGwj2TRfj9ChAb+63GrOZEYA+IFyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9zvMdcnKTfl25qDmp7eV22Q1vIBYg429LOBPchekgp8=; b=WNftoG+M8YKLfSKkc1P7QGgtXDMOifdkVZ8h2vDKkT7HMkgf2vKwePxMCwguZ0aWAEkbylTTJM5PfGdXhHhXNfJ1qwt7Viq1EAgj3BD74azRtz6rSXdRh+VUA0dyl6AmUR2zDGMm0lndnJT/61kLlIpeMitAyn6zhmkZ/w5/XEjSZbIg4iliFxnsmT5vrKfyfBacdcgHWLna/D0X3JBrVvTAXtF6rO2w7izeb4S/8khqJwkxpi7OcfWIq8dYFAClUmJJ1vV22CJ84MUkngCZ49lDMXUNcTOpj1Y/nrqtS6c0+csLAPzYgWNv1RVEsV61Oi2OZZXhaFwoe7i9CHTJUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9zvMdcnKTfl25qDmp7eV22Q1vIBYg429LOBPchekgp8=; b=bNkKQMTeNv58Om8+1M60FE4zEAsaYW7nZVLbPoahrH0lRTG5HImOhXrL82hMaYUk9FlN8EU/B2JuFinRJgyAXGeGH//IFuYFryQQrTeGzgW1EqJtd3Y3HIO1AqSzpFD0LFXpRwXl4V6P3mpaBcPRHIJjM80i1UdaXXHCh0Xl6Hg= Received: from AM4PR05MB3460.eurprd05.prod.outlook.com (10.171.187.153) by AM4PR05MB3410.eurprd05.prod.outlook.com (10.171.187.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.18; Tue, 24 Mar 2020 12:39:40 +0000 Received: from AM4PR05MB3460.eurprd05.prod.outlook.com ([fe80::cda6:ae00:9ce6:3b13]) by AM4PR05MB3460.eurprd05.prod.outlook.com ([fe80::cda6:ae00:9ce6:3b13%7]) with mapi id 15.20.2835.023; Tue, 24 Mar 2020 12:39:40 +0000 From: Dekel Peled To: Ori Kam , "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" CC: Matan Azrad , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: enhance GTP support Thread-Index: AQHV+2sFon8EjgV0TEqTFMImiR0G+KhXjsoAgAArRxA= Date: Tue, 24 Mar 2020 12:39:40 +0000 Message-ID: References: <239bc0ae9191ddc12fec65742949710d13185b85.1584346077.git.dekelp@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dekelp@mellanox.com; x-originating-ip: [79.177.27.199] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 60ae9cd9-a40e-4b90-f2b1-08d7cff06bb9 x-ms-traffictypediagnostic: AM4PR05MB3410:|AM4PR05MB3410: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2449; x-forefront-prvs: 03524FBD26 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(136003)(39860400002)(376002)(366004)(66946007)(66476007)(4326008)(76116006)(66556008)(64756008)(316002)(86362001)(54906003)(66446008)(52536014)(5660300002)(110136005)(33656002)(55016002)(9686003)(8936002)(7696005)(81156014)(71200400001)(26005)(8676002)(53546011)(6506007)(478600001)(186003)(81166006)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3410; H:AM4PR05MB3460.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OvnQtCICVPgbW165972tH5GgSATUvko1BbOyfmI/nyqj2TAsLLAFX/tpula+a2PmxiOc3TEclGU8DAA0y6LUv0YOC+vMBlEdzDw8rEhO3ZhVw3SuMSqOfLakz5TQsI8DEN+JlLVpSlFfystj9qFxX9NnqxXVDLrg1J+/xiNFbGxS/CD0cGoBzioWezBU3CWJSG1lTyXRFyES4qIV4MB4aPaI9th/OcFjm4wk2qWhC5CylrXxg5Fn8ePpFzcdLG0I2YL2ZGjOVq4nHuaxAfgFnq4wZmsyD8biGbNQYAzpXa/Sz/XQA5gv3XJ/syQHg0lJPSg3XPn+f5JaLQazxoPSXT41Tx4bN9Mr9D8S7lP4nxez91RIvCSdzqCmePkR4UmQAUgQPdcS7YHbMDZVRgKWHOdaWMbKmpK74IpZDG3UYV9fLyoRCOcnjogK9CG3k8tC x-ms-exchange-antispam-messagedata: FIS1EYod/VoVUcplxGwGMnx2z9VsCxOKIPCQgMMmellmSif+zFZFV4bBpZ7/ReT6WlfEaoVvNcG9bOHdsq4hXI3oGYNtsxDtgr0tY/4dyiefRzv+ScxcGRGytZZl7VP3cnG63qpqcBaiRZrM+TCYKw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60ae9cd9-a40e-4b90-f2b1-08d7cff06bb9 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2020 12:39:40.1194 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4ex0dsxt/7qj4+XfRX6dhD6Qja4xFumv/ftUNHL5SblsrB/B4p6dFPqG8TdTe6QX7W/jozp61tPNV0zNMIeL1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3410 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: enhance GTP support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, PSB. > -----Original Message----- > From: Ori Kam > Sent: Tuesday, March 24, 2020 11:59 AM > To: Dekel Peled ; wenzhuo.lu@intel.com; > jingjing.wu@intel.com; bernard.iremonger@intel.com > Cc: Matan Azrad ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: enhance GTP support >=20 > Hi Dekel, >=20 > > -----Original Message----- > > Subject: [dpdk-dev] [PATCH] app/testpmd: enhance GTP support > > > > This patch adds CLI option to enter the v_pt_rsv_flags value for GTP > > flow pattern item. > > It also adds GTP as valid item in raw_encap nad raw_decap setting. > > > > Signed-off-by: Dekel Peled > > --- > > app/test-pmd/cmdline_flow.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > > index a781545..cc1bd19 100644 > > --- a/app/test-pmd/cmdline_flow.c > > +++ b/app/test-pmd/cmdline_flow.c > > @@ -170,6 +170,7 @@ enum index { > > ITEM_FUZZY, > > ITEM_FUZZY_THRESH, > > ITEM_GTP, > > + ITEM_GTP_FLAGS, > > ITEM_GTP_MSG_TYPE, > > ITEM_GTP_TEID, > > ITEM_GTPC, > > @@ -938,6 +939,7 @@ struct parse_action_priv { }; > > > > static const enum index item_gtp[] =3D { > > + ITEM_GTP_FLAGS, > > ITEM_GTP_MSG_TYPE, > > ITEM_GTP_TEID, > > ITEM_NEXT, > > @@ -2347,6 +2349,13 @@ static int comp_set_raw_index(struct context *, > > const struct token *, > > .next =3D NEXT(item_gtp), > > .call =3D parse_vc, > > }, > > + [ITEM_GTP_FLAGS] =3D { > > + .name =3D "v_pt_rsv_flags", > > + .help =3D "GTP flags", > > + .next =3D NEXT(item_gtp, NEXT_ENTRY(UNSIGNED), > > item_param), > > + .args =3D ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_gtp, > > + v_pt_rsv_flags)), >=20 > V_pt_rsv_flags is 8 bits right? So why HTON? This is the common practice in this array, done for other uint8_t fields. >=20 > > + }, > > [ITEM_GTP_MSG_TYPE] =3D { > > .name =3D "msg_type", > > .help =3D "GTP message type", > > @@ -6604,6 +6613,9 @@ static int comp_set_raw_index(struct context *, > > const struct token *, > > size =3D sizeof(struct rte_flow_item_ah); > > proto =3D 0x33; > > break; > > + case RTE_FLOW_ITEM_TYPE_GTP: > > + size =3D sizeof(struct rte_flow_item_gtp); > > + break; > > case RTE_FLOW_ITEM_TYPE_PFCP: > > size =3D sizeof(struct rte_flow_item_pfcp); > > break; > > -- > > 1.8.3.1 >=20 > Best, > Ori