From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAF09A034E; Thu, 7 Nov 2019 13:18:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4B5AA1E9D5; Thu, 7 Nov 2019 13:18:57 +0100 (CET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40063.outbound.protection.outlook.com [40.107.4.63]) by dpdk.org (Postfix) with ESMTP id 81FF61E9C6 for ; Thu, 7 Nov 2019 13:18:56 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V8RG8LGWXEblwaKc5N++tWW+DkpMXQg3UVdBlxKNK0euSysI3joc1q40ufYP2ZN7GD7U59By/zRSbI/q8WLd5mKr/isOOBBCa9/MCYWi4hIjXnuG6z6Cqb+1pE2Nx5lGg7gomoDFe0myECAiKCN2jRhnsNEJ23yF376zDr+unmYu8Wm1INI3d9QKO445SFDIgG7HeCJQuNIJbRnU36bJP6Q8LlPrjlKj2b0hf1LSMzgTZBweq6npDaLdSinSfOH5ObZB3h0/IzTop5TKGiuDov/a/b1H9RfPYv5Mr7ZvpNHPd/n/qN3bao/RQYA2/DutYiTO1atN/V/k8XbaqElIIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rNN1d1hplDDCMXzc3oGwwW607qDCczUueLPQiVpCJzE=; b=iodxyZZHGMde7JnWfmbow5yg+PH65A+KzlEdi5rrT+LfB+bRqKykzbbGDayF1Yhi8Od7bTG1eYIoapLC1CvZCjxiwYmKYvVezFZhg5pGWfYVyGTYe9KHG/wpXxJsqsluRCGXHKFPf+HHFGNvtatGB15CeakwqTnvFZVqzTOJtWYknsbmiRFoAt/uk2dlA4fWRY0zbYz3mPDKXaBd9mVDsXBH+Lkpe7hBImBeocDacXLlC5xSs0loIOXQM8CcX1tUWtJTK6KgFgpRe/KguLAoU9MiWsaNe55lDsOcfiEs4pMgu0/AHPZ8Upu4ROiPpXWGDlVzq7Hsgq5BFFVR/sNUAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rNN1d1hplDDCMXzc3oGwwW607qDCczUueLPQiVpCJzE=; b=gG1PATrX9NIwzFtf5LEXw87BrGnIjdER1UqOWkDtDcKoXHFbh3MeRr++fEJsOGPDZt+Oqww5pqUz/ME/YmUIJio14VdS+xXjGO1Y0txo/1LptqIlr7P18dogtyyNXZjrXt9PTOij7s/SJenwS0pUB6QYPXfFXCCwtG4yerdSyxY= Received: from AM4PR05MB3460.eurprd05.prod.outlook.com (10.171.187.153) by AM4PR05MB3345.eurprd05.prod.outlook.com (10.171.189.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.23; Thu, 7 Nov 2019 12:18:55 +0000 Received: from AM4PR05MB3460.eurprd05.prod.outlook.com ([fe80::117b:8dc0:905e:d154]) by AM4PR05MB3460.eurprd05.prod.outlook.com ([fe80::117b:8dc0:905e:d154%4]) with mapi id 15.20.2430.020; Thu, 7 Nov 2019 12:18:55 +0000 From: Dekel Peled To: Shahed Shaikh , "john.mcnamara@intel.com" , "marko.kovacevic@intel.com" , "nhorman@tuxdriver.com" , "ajit.khaparde@broadcom.com" , "somnath.kotur@broadcom.com" , "anatoly.burakov@intel.com" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , "wenzhuo.lu@intel.com" , "konstantin.ananyev@intel.com" , Matan Azrad , Shahaf Shuler , Slava Ovsiienko , Rasesh Mody , "maxime.coquelin@redhat.com" , "tiwei.bie@intel.com" , "zhihong.wang@intel.com" , "yongwang@vmware.com" , Thomas Monjalon , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" CC: "dev@dpdk.org" Thread-Topic: [EXT] [PATCH v3 1/3] ethdev: support API to set max LRO packet size Thread-Index: AQHVlWK2akE3JaficE2hb3zEWl0i16d/oAjw Date: Thu, 7 Nov 2019 12:18:55 +0000 Message-ID: References: <87548a8a0d7d549bd7fb788be197c90712785ad3.1573050134.git.dekelp@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dekelp@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 634c0c4b-db47-4e9c-f057-08d7637ca8b5 x-ms-traffictypediagnostic: AM4PR05MB3345:|AM4PR05MB3345: x-ms-exchange-purlcount: 1 x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:913; x-forefront-prvs: 0214EB3F68 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(39860400002)(136003)(376002)(346002)(396003)(13464003)(189003)(199004)(33656002)(99286004)(5660300002)(110136005)(66066001)(316002)(52536014)(76116006)(66946007)(71200400001)(66556008)(64756008)(66446008)(66476007)(19627235002)(26005)(102836004)(186003)(71190400001)(6506007)(53546011)(7696005)(76176011)(14444005)(256004)(476003)(11346002)(446003)(486006)(3846002)(6116002)(74316002)(2501003)(7736002)(45080400002)(14454004)(6306002)(7416002)(966005)(305945005)(25786009)(478600001)(6246003)(4326008)(8676002)(81166006)(81156014)(2201001)(86362001)(2906002)(8936002)(6436002)(229853002)(55016002)(9686003)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3345; H:AM4PR05MB3460.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gvECQ3TARwPr6DYx3dLlUCMcsOkdsvI2tWdLBDJnCFjQd/BdOXpv97uQrl6CiKA+jQEtuxZaLXZFzE8tIW+TSumtw2h5i5NcpfCMifMwa+G5lFKTEbGYVPkLZQSkO3nzfKxai08/QLYefOprwWdLMLGmJ26V9J+GUX1gYW5XgReX6gI8sLvpt01TUrfA9ohkJ1swI7z95WFvm35Mezx+OVwlgj5ViFmrg00BbvoLdbDyRoMA5C75HNrMGzLEsP1a2miiSYLCrl9ShjoGrGjTEyJ9z8B8SAdhU/TrSip9qW2jBCq0DqpHOiy1aeMPIffq0/ABKpPJ1cB0zvP9Ut32LuzloL8e+S+ODZhCsEUsWGSieRLliBpwk8H7wpKfLhRAmYPNqx2Y9qtX1zp1OZjC9Rt7RkxB3VM/aIaObJGM0qpxbX3eveXEy4MgybfuuKdY Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 634c0c4b-db47-4e9c-f057-08d7637ca8b5 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2019 12:18:55.1726 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jDWVShNZ4c3PMKhKtTgVxsovdQOlhp2iB46y0z+JvBnyVh0i5XNGRWGqKkIDd97bSc6rOVKEd+of3zcv60pdtw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3345 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 1/3] ethdev: support API to set max LRO packet size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks, PSB. > -----Original Message----- > From: Shahed Shaikh > Sent: Thursday, November 7, 2019 1:57 PM > To: Dekel Peled ; john.mcnamara@intel.com; > marko.kovacevic@intel.com; nhorman@tuxdriver.com; > ajit.khaparde@broadcom.com; somnath.kotur@broadcom.com; > anatoly.burakov@intel.com; xuanziyang2@huawei.com; > cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; > wenzhuo.lu@intel.com; konstantin.ananyev@intel.com; Matan Azrad > ; Shahaf Shuler ; Slava > Ovsiienko ; Rasesh Mody > ; maxime.coquelin@redhat.com; > tiwei.bie@intel.com; zhihong.wang@intel.com; yongwang@vmware.com; > Thomas Monjalon ; ferruh.yigit@intel.com; > arybchenko@solarflare.com; jingjing.wu@intel.com; > bernard.iremonger@intel.com > Cc: dev@dpdk.org > Subject: RE: [EXT] [PATCH v3 1/3] ethdev: support API to set max LRO pack= et > size >=20 > > -----Original Message----- > > From: Dekel Peled > > Sent: Wednesday, November 6, 2019 7:58 PM > > To: john.mcnamara@intel.com; marko.kovacevic@intel.com; > > nhorman@tuxdriver.com; ajit.khaparde@broadcom.com; > > somnath.kotur@broadcom.com; anatoly.burakov@intel.com; > > xuanziyang2@huawei.com; cloud.wangxiaoyun@huawei.com; > > zhouguoyang@huawei.com; wenzhuo.lu@intel.com; > > konstantin.ananyev@intel.com; matan@mellanox.com; > > shahafs@mellanox.com; viacheslavo@mellanox.com; Rasesh Mody > > ; Shahed Shaikh ; > > maxime.coquelin@redhat.com; tiwei.bie@intel.com; > > zhihong.wang@intel.com; yongwang@vmware.com; > thomas@monjalon.net; > > ferruh.yigit@intel.com; arybchenko@solarflare.com; > > jingjing.wu@intel.com; bernard.iremonger@intel.com > > Cc: dev@dpdk.org > > Subject: [EXT] [PATCH v3 1/3] ethdev: support API to set max LRO > > packet size > > > > External Email > > > > ---------------------------------------------------------------------- > > This patch implements [1], to support API for configuration and > > > > validation of max size for LRO aggregated packet. > > > > API change notice [2] is removed, and release notes for 19.11 > > > > are updated accordingly. > > > > > > > > Various PMDs using LRO offload are updated, the new data members are > > > > initialized to ensure they don't fail validation. > > > > > > > > [1] > > https://eur03.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Furl= d > > efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttp- > &data=3D02%7C01%7Cdekelp > > > %40mellanox.com%7Cabfce6c19bcf4f42c75208d76379d781%7Ca652971c7d2e > 4d9ba > > > 6a4d149256f461b%7C0%7C1%7C637087247277571736&sdata=3DgWGd5Ew > ntdYj44F > > PZXNTG0uMivl42B0bE2%2FZ2izxV%2Fo%3D&reserved=3D0 > > > 3A__patches.dpdk.org_patch_58217_&d=3DDwIBAg&c=3DnKjWec2b6R0mOyPaz > 7xtf > > Q&r=3DqeevDAWea4uZZbQhISypy6IVgD4EOfIP7D- > > > cw6N6nsI&m=3Dghr6KiUvwMCjBQ7KRJJ8BfoTOHlY9gICprAIn4yao9A&s=3DANfM9 > GH > > SB9nUhm8O8YaoqcXO0eTBO7TmGhVmekbNO6U&e=3D > > > > [2] > > https://eur03.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Furl= d > > efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttp- > &data=3D02%7C01%7Cdekelp > > > %40mellanox.com%7Cabfce6c19bcf4f42c75208d76379d781%7Ca652971c7d2e > 4d9ba > > > 6a4d149256f461b%7C0%7C1%7C637087247277571736&sdata=3DgWGd5Ew > ntdYj44F > > PZXNTG0uMivl42B0bE2%2FZ2izxV%2Fo%3D&reserved=3D0 > > > 3A__patches.dpdk.org_patch_57492_&d=3DDwIBAg&c=3DnKjWec2b6R0mOyPaz > 7xtf > > Q&r=3DqeevDAWea4uZZbQhISypy6IVgD4EOfIP7D- > > > cw6N6nsI&m=3Dghr6KiUvwMCjBQ7KRJJ8BfoTOHlY9gICprAIn4yao9A&s=3DppYVW > Xe > > Jj3xhnvWCV2hIfNu6wy9N2r5lvJxgJnHKfSc&e=3D > > > > > > > > Signed-off-by: Dekel Peled > > > > Reviewed-by: Andrew Rybchenko > > > > Acked-by: Thomas Monjalon > > > > --- > > > > doc/guides/nics/features.rst | 2 ++ > > > > doc/guides/rel_notes/deprecation.rst | 4 --- > > > > doc/guides/rel_notes/release_19_11.rst | 8 ++++++ > > > > drivers/net/bnxt/bnxt_ethdev.c | 1 + > > > > drivers/net/hinic/hinic_pmd_ethdev.c | 1 + > > > > drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ > > > > drivers/net/ixgbe/ixgbe_vf_representor.c | 1 + > > > > drivers/net/mlx5/mlx5.h | 3 +++ > > > > drivers/net/mlx5/mlx5_ethdev.c | 1 + > > > > drivers/net/mlx5/mlx5_rxq.c | 1 - > > > > drivers/net/qede/qede_ethdev.c | 1 + > > > > drivers/net/virtio/virtio_ethdev.c | 1 + > > > > drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 + > > > > lib/librte_ethdev/rte_ethdev.c | 44 > > ++++++++++++++++++++++++++++++++ > > > > lib/librte_ethdev/rte_ethdev.h | 4 +++ > > > > 15 files changed, 70 insertions(+), 5 deletions(-) > > > > @@ -1277,6 +1277,7 @@ static int qede_dev_configure(struct rte_eth_dev > > *eth_dev) > > > > > > > > dev_info->min_rx_bufsize =3D (uint32_t)QEDE_MIN_RX_BUFF_SIZE; > > > > dev_info->max_rx_pktlen =3D > > (uint32_t)ETH_TX_MAX_NON_LSO_PKT_LEN; > > > > + dev_info->max_lro_pkt_size =3D > > (uint32_t)ETH_TX_MAX_NON_LSO_PKT_LEN >=20 > Please use 0x7FFF instead of ETH_TX_MAX_NON_LSO_PKT_LEN. >=20 Sending v4 with this change. > We set the same limit in qede_ethdev.c: qede_update_sge_tpa_params() >=20 > sge_tpa_params->tpa_max_size =3D 0x7FFF; >=20 > Thanks, > Shahed > > > > dev_info->rx_desc_lim =3D qede_rx_desc_lim; > > > > dev_info->tx_desc_lim =3D qede_tx_desc_lim; > > > > Regards, Dekel