From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47939A04AB; Thu, 7 Nov 2019 07:11:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A2CA91E8BF; Thu, 7 Nov 2019 07:11:00 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30054.outbound.protection.outlook.com [40.107.3.54]) by dpdk.org (Postfix) with ESMTP id A255D1E8A4 for ; Thu, 7 Nov 2019 07:10:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SJ7ilUVCno3rS/kez9FqsNZOi3+FReyuwqcpj5zC+syomVlwh+LkYwLW7Dt0t25z+EnLBJCJqR+4ea2pGDBQJ0LLaTT/F7I+3sKp6V6FdY2DxCJems32y20ukFi9MX7+fSJLXiQn9LzyCRfM0zE4ktTkykYEH5XPu2FiQNNgSh+HXZxCi9oW3mCI6GGK638Sm3K8XUXTPVqcZf07QXAbqBv+qXkZN8tqBlueQp0F0Iyfgmxhg6lun4Aje8uVDMSAMWhofQEZVoqh+udTHttzUQ3Q+nzU2pieJnaZqAOAhIOBHxpSpMK5ZB8NPfCWJgrRbba419dpKaUH/4nsbErQZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=njO+VQuabKdtJ+twxdTfqk6OCxY65SIpstaCOetCLuE=; b=f0faTPh9uAa4vE5Ii+48352XYlMmsPId2zxfHEkxVrNbZPSuZSFHVAwDmZ/gpsg3Xdofov+Mo1W9TRPymiE2W8rHmBWBWq7ir3/77YkegNTZwy2ssNaL+eDm0bQz8bTbzwfI4eTyNDclrwJgWjyCEFHTFKDqfdr4IlWcEp9k0vTO68z3bB5HAchdtNhEHpgs6Ml311IeC/96w+gXHbnbABcitRYtGCtp7SJLJjD35aaouGP1IhdFyOzgBLSeCpp518dVkbWlrPZFzgcsbXmRMNgaIFjKJ5xn5TOLVggQ9sogAUx+w78ohECU0Q2uv/UajPozmGm9odPaZwXZ8pSYMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=njO+VQuabKdtJ+twxdTfqk6OCxY65SIpstaCOetCLuE=; b=mUSkcxsMmspEH7+8jWqpuh2eUARqfHR7oJXi3C2JnNp3jYMUHGUP5NmVavt9vobmeF6AIVG3ry+RoAG3ml1klYCaBgMjyxo1bUAWL+9O5cNNFe3X8vKwhyHhVS419JgC1iZTOmHZtkUjVVRmpMJbt/I+Slk2bjNCDetvsuHHlJY= Received: from AM4PR05MB3460.eurprd05.prod.outlook.com (10.171.187.153) by AM4PR05MB3121.eurprd05.prod.outlook.com (10.170.126.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.22; Thu, 7 Nov 2019 06:10:57 +0000 Received: from AM4PR05MB3460.eurprd05.prod.outlook.com ([fe80::117b:8dc0:905e:d154]) by AM4PR05MB3460.eurprd05.prod.outlook.com ([fe80::117b:8dc0:905e:d154%4]) with mapi id 15.20.2430.020; Thu, 7 Nov 2019 06:10:57 +0000 From: Dekel Peled To: "Iremonger, Bernard" , "Mcnamara, John" , "Kovacevic, Marko" , "nhorman@tuxdriver.com" , "ajit.khaparde@broadcom.com" , "somnath.kotur@broadcom.com" , "Burakov, Anatoly" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , Matan Azrad , Shahaf Shuler , Slava Ovsiienko , "rmody@marvell.com" , "shshaikh@marvell.com" , "maxime.coquelin@redhat.com" , "Bie, Tiwei" , "Wang, Zhihong" , "yongwang@vmware.com" , Thomas Monjalon , "Yigit, Ferruh" , "arybchenko@solarflare.com" , "Wu, Jingjing" CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 0/3] support API to set max LRO packet size Thread-Index: AQHVlMEFfE+cfT93KEOFBrC+Eukz8Kd/OfXA Date: Thu, 7 Nov 2019 06:10:57 +0000 Message-ID: References: <8CEF83825BEC744B83065625E567D7C260E2153E@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260E2153E@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dekelp@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 53547cd2-936a-4214-ec26-08d763494160 x-ms-traffictypediagnostic: AM4PR05MB3121:|AM4PR05MB3121: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0214EB3F68 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(396003)(136003)(39850400004)(346002)(376002)(13464003)(199004)(189003)(14444005)(478600001)(446003)(4326008)(6246003)(71200400001)(33656002)(9686003)(316002)(110136005)(7416002)(55016002)(81166006)(74316002)(6116002)(305945005)(8676002)(3846002)(8936002)(2201001)(25786009)(99286004)(66066001)(7736002)(71190400001)(11346002)(81156014)(86362001)(52536014)(186003)(229853002)(2501003)(256004)(26005)(6436002)(76176011)(7696005)(66446008)(64756008)(76116006)(66556008)(66476007)(2906002)(5660300002)(476003)(486006)(53546011)(6506007)(66946007)(102836004)(14454004)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3121; H:AM4PR05MB3460.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BxKsJLMdut/HmsBm8gxNqrELoDYnXA3BTp6K2GcVnaCvpIaNmulG+tFdLu10S0K5TLzfNMsZfqdSP4fMzAB3xMsM91+7c+f6BB/5PEQ2+z2P+4xRKL3fFa5BahwMB9klch4lFnaJTxeik55d49/Zv2a0Qwcd90T9l9H9kY8pt4WdQJ3oPIVuiWVPjT/U2eal45O1I2VlgliXsbb63pRVuHEe+mTX8XSm4AAauAhXjsD4e/bP7mBo/Cby4h6FS2vsJHZqTludM3NylLkyLkjD6IFSglBuaco3FdyR5VpgiIbcSyO7CQNlY7CxqE/jaxnD/qyR5VrvBlir32NbpIyiWnwvr2iVjdGqnuKmlPN/9pyTMvi2FN1E2xd2V/bwoyHwHVGLXDhIEkeLrd8QpdLfbpQUclnTzwWtffTpRb5k00D2BlGIxYKOnUMHIShRj4Uo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53547cd2-936a-4214-ec26-08d763494160 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2019 06:10:57.5878 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EO2+qjm14SRFoNNr4lr7sdK1mT9E47c5lgTyHYjf4sZ69jfFDql0MxhMlMu4XGgMZFdzfT7lzkzJfBAJlP3dHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3121 Subject: Re: [dpdk-dev] [PATCH v3 0/3] support API to set max LRO packet size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bernard, PSB. > -----Original Message----- > From: Iremonger, Bernard > Sent: Wednesday, November 6, 2019 6:41 PM > To: Dekel Peled ; Mcnamara, John > ; Kovacevic, Marko > ; nhorman@tuxdriver.com; > ajit.khaparde@broadcom.com; somnath.kotur@broadcom.com; Burakov, > Anatoly ; xuanziyang2@huawei.com; > cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; Lu, Wenzhuo > ; Ananyev, Konstantin > ; Matan Azrad ; > Shahaf Shuler ; Slava Ovsiienko > ; rmody@marvell.com; > shshaikh@marvell.com; maxime.coquelin@redhat.com; Bie, Tiwei > ; Wang, Zhihong ; > yongwang@vmware.com; Thomas Monjalon ; Yigit, > Ferruh ; arybchenko@solarflare.com; Wu, Jingjing > > Cc: dev@dpdk.org > Subject: RE: [PATCH v3 0/3] support API to set max LRO packet size >=20 > Hi Dekel, >=20 > > -----Original Message----- > > From: Dekel Peled > > Sent: Wednesday, November 6, 2019 2:28 PM > > To: Mcnamara, John ; Kovacevic, Marko > > ; nhorman@tuxdriver.com; > > ajit.khaparde@broadcom.com; somnath.kotur@broadcom.com; Burakov, > > Anatoly ; xuanziyang2@huawei.com; > > cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; Lu, > Wenzhuo > > ; Ananyev, Konstantin > > ; matan@mellanox.com; > > shahafs@mellanox.com; viacheslavo@mellanox.com; > rmody@marvell.com; > > shshaikh@marvell.com; maxime.coquelin@redhat.com; Bie, Tiwei > > ; Wang, Zhihong ; > > yongwang@vmware.com; thomas@monjalon.net; Yigit, Ferruh > > ; arybchenko@solarflare.com; Wu, Jingjing > > ; Iremonger, Bernard > > > > Cc: dev@dpdk.org > > Subject: [PATCH v3 0/3] support API to set max LRO packet size > > > > This series implements support and use of API for configuration and > > validation of max size for LRO aggregated packet. > > > > v2: Updated ethdev patch per review comments. > > v3: Updated ethdev and testpmd patches per review comments. >=20 > My comments on the v2 testpmd patch have not been addressed in the v3 > patch. I accepted your comment about update of function usage(), and added it in v= 3. I replied your other comments in v2 reply email, and didn't see additional = response. Regards, Dekel >=20 > > > > Dekel Peled (3): > > ethdev: support API to set max LRO packet size > > net/mlx5: use API to set max LRO packet size > > app/testpmd: use API to set max LRO packet size > > > > app/test-pmd/cmdline.c | 73 > > +++++++++++++++++++++++++++++ > > app/test-pmd/config.c | 2 + > > app/test-pmd/parameters.c | 7 +++ > > app/test-pmd/testpmd.c | 1 + > > doc/guides/nics/features.rst | 2 + > > doc/guides/nics/mlx5.rst | 2 + > > doc/guides/rel_notes/deprecation.rst | 4 -- > > doc/guides/rel_notes/release_19_11.rst | 8 ++++ > > doc/guides/testpmd_app_ug/run_app.rst | 5 ++ > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 ++++ > > drivers/net/bnxt/bnxt_ethdev.c | 1 + > > drivers/net/hinic/hinic_pmd_ethdev.c | 1 + > > drivers/net/ixgbe/ixgbe_ethdev.c | 2 + > > drivers/net/ixgbe/ixgbe_vf_representor.c | 1 + > > drivers/net/mlx5/mlx5.h | 3 ++ > > drivers/net/mlx5/mlx5_ethdev.c | 1 + > > drivers/net/mlx5/mlx5_rxq.c | 5 +- > > drivers/net/qede/qede_ethdev.c | 1 + > > drivers/net/virtio/virtio_ethdev.c | 1 + > > drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 + > > lib/librte_ethdev/rte_ethdev.c | 44 +++++++++++++++++ > > lib/librte_ethdev/rte_ethdev.h | 4 ++ > > 22 files changed, 172 insertions(+), 6 deletions(-) > > > > -- > > 1.8.3.1 >=20 > Regards, >=20 > Bernard.