From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id E03F7A0AC5
	for <public@inbox.dpdk.org>; Mon, 27 May 2019 08:50:20 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 01BF62C30;
	Mon, 27 May 2019 08:50:18 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60067.outbound.protection.outlook.com [40.107.6.67])
 by dpdk.org (Postfix) with ESMTP id 8671F3DC;
 Mon, 27 May 2019 08:50:16 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iWy9hrP91WF1vO4XMoNM1Zl+mbtVE1R21DM7smDVrrA=;
 b=M7/AP//QP+r9koCnTltPxMW32KFxj99uxTVxnJC5wX37f1BwnG9qzsO0POcOvAvQY3N4ZQ5q30afPfnCBxngVvroEhpZ+SJYl13uOSqHJNdccFsTv2Rp8oegf5edLVhjO4N7uN0yKBjS0LA6NbrtNXkunsz4fRKx9azpQnJkzAg=
Received: from AM4PR05MB3460.eurprd05.prod.outlook.com (10.171.187.153) by
 AM4PR05MB3235.eurprd05.prod.outlook.com (10.171.186.144) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.1922.21; Mon, 27 May 2019 06:50:15 +0000
Received: from AM4PR05MB3460.eurprd05.prod.outlook.com
 ([fe80::49a:9e7a:9416:8064]) by AM4PR05MB3460.eurprd05.prod.outlook.com
 ([fe80::49a:9e7a:9416:8064%5]) with mapi id 15.20.1922.021; Mon, 27 May 2019
 06:50:15 +0000
From: Dekel Peled <dekelp@mellanox.com>
To: Shahaf Shuler <shahafs@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix order of items in neon scatter
 func
Thread-Index: AQHVCwaBJLvGsHZ0CUK6SHp7b18JoaZ90VCAgADG+OA=
Date: Mon, 27 May 2019 06:50:14 +0000
Message-ID: <AM4PR05MB34608383AC58662A8D9D7002B61D0@AM4PR05MB3460.eurprd05.prod.outlook.com>
References: <1e43edbc1aa11055521150f5be724278aa1247e6.1557915012.git.dekelp@mellanox.com>
 <AM0PR0502MB3795ED64EBA6646759C9006FC31C0@AM0PR0502MB3795.eurprd05.prod.outlook.com>
In-Reply-To: <AM0PR0502MB3795ED64EBA6646759C9006FC31C0@AM0PR0502MB3795.eurprd05.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=dekelp@mellanox.com; 
x-originating-ip: [193.47.165.251]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 62c70452-7f89-4d26-4c3b-08d6e26f92b8
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0;
 RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);
 SRVR:AM4PR05MB3235; 
x-ms-traffictypediagnostic: AM4PR05MB3235:
x-microsoft-antispam-prvs: <AM4PR05MB3235F6D15E59D70F095DADEBB61D0@AM4PR05MB3235.eurprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-forefront-prvs: 0050CEFE70
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10009020)(376002)(346002)(136003)(39860400002)(396003)(366004)(189003)(199004)(13464003)(8936002)(229853002)(52536014)(7696005)(3846002)(68736007)(53546011)(256004)(14444005)(76176011)(2906002)(99286004)(33656002)(81156014)(81166006)(55016002)(446003)(7736002)(476003)(102836004)(8676002)(305945005)(6506007)(6116002)(5660300002)(6436002)(9686003)(110136005)(54906003)(11346002)(478600001)(71200400001)(450100002)(6636002)(14454004)(71190400001)(66066001)(74316002)(25786009)(4326008)(66476007)(186003)(486006)(26005)(66446008)(66556008)(64756008)(53936002)(86362001)(76116006)(73956011)(66946007)(6246003)(316002);
 DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3235;
 H:AM4PR05MB3460.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;
 PTR:InfoNoRecords; MX:1; A:1; 
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 5ksDQ9wDGoc1+wMxR0AVpeNdalnv2TSkm4fSmBtm+gsm92rr8ua4PShEAVFrqzx9ci9b+YAFQ0wOKG3CO0aimRcF1AFLhoMoQfjcscaYmtQQOX9LTPvTJaIYPvSp+zN69QdEwmIzDBd/ARM+E/2oLL4rfZVEgP214n36t7RWPkWrCVqfqDOhnkWToCpbyLubWqUvWqea+ZZZNGhtvj/7DQ+qst4y/FwlbbPKbJ5MqORQvAek9Ld4EXabepRc3UvFwGJpF3dfTXgY4aGgufSmKPC5wsmepyv7lWti/WESnpPgNU+KI4Jb/IaHo9cOdvvbpJdmOPjlrY134oJtg/XM25MiHDZFgH2nQRn4JBrkQ/f3lDHzbmdkNhidjCdO3j+m792k4wf69XmrNzXvUjSPEvp9Ew+VFY5TN0v02OHMJ7s=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62c70452-7f89-4d26-4c3b-08d6e26f92b8
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2019 06:50:14.8773 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dekelp@mellanox.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3235
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix order of items in neon scatter
 func
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

PSB, thanks.

> -----Original Message-----
> From: Shahaf Shuler
> Sent: Sunday, May 26, 2019 9:49 PM
> To: Dekel Peled <dekelp@mellanox.com>; Yongseok Koh
> <yskoh@mellanox.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] net/mlx5: fix order of items in neon scat=
ter
> func
>=20
> Wednesday, May 15, 2019 1:08 PM, Dekel Peled:
> > Subject: [dpdk-dev] [PATCH] net/mlx5: fix order of items in neon
> > scatter func
> >
> > Previous patch added handling of metadata for multi-segment packet.
> > Function txq_scatter_v in file mlx5_rxtx_vec_neon.h was updated
> > incorrectly, items were inserted into WQE in wrong order.
> >
> > This patch fixes the issue, inserting items into WQE correctly.
> >
> > Fixes: 7f4019d370f6 ("net/mlx5: fix Tx metadata for multi-segment
> > packet")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> > ---
> >  drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
> > b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
> > index 38e915c..b1e0e8f 100644
> > --- a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
> > +++ b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
> > @@ -171,7 +171,7 @@
> >  		/* Fill ESEG in the header. */
> >  		vst1q_u32((void *)(t_wqe + 1),
> >  			  ((uint32x4_t){ 0,
> > -					 cs_flags << 16 |
> > rte_cpu_to_be_16(len),
> > +					 rte_cpu_to_be_16(len) << 16 |
> > cs_flags,
>=20
> It was probably not introduced by the previous patch, but since you touch
> this area:
> Why do you set the mss (len)? This function handles only non-TSO packets.

mss is set to 0 in txq_burst_v, which sends single segment packets.
This change is in txq_scatter_v which sends multi-segmented packets.

>=20
> >  					 metadata, 0 }));
> >  		txq->wqe_ci =3D wqe_ci;
> >  	}
> > --
> > 1.8.3.1