From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2204DA0562; Sun, 29 Mar 2020 11:21:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B96882BAE; Sun, 29 Mar 2020 11:20:59 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140077.outbound.protection.outlook.com [40.107.14.77]) by dpdk.org (Postfix) with ESMTP id ACAD3F12 for ; Sun, 29 Mar 2020 11:20:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oOOh3EVso5nlSoTf4w3by2NigUcjpNi//Wuds30dkPRDmA9U4+DeJxAfj2eB0/rw6Vjv2C2iQEJQJwOM1JAxg9ucBz2VEG9aHQ0KpR4Ng5YK3scAyFpXaeCxRNAPWwCY93Oa3Ik330wQj4g79vZcyd3HV9uo1koSpqi7tCWPXDEdzDGgeVXb+nJhRrQTcZwM792xJmFmnrXwxS1tOGMccw7vLzcFsm4S3kJnSzOgSo+teAWzgBmwaSIHIQj58ghYI7ga2d1sHukgukceX3WykpGNOJiODBwnrYpVzKN0VJ23c8uDpioTrcCvb8OK3p+ZekuE1J9BED2/4lDw8PwwGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FxUUyc0WxjnpgwYDz3DakwYxFH9LSRixncEFJ+GGM58=; b=fnD0webhWMmqspaWlRKiKPMkmFhRTw10B/BW9fbjMACisyc7RPVT1H+p9ApdivLTfXq3IF7kREqW0LHT9twifx0Lo34Urtm6SzftQPlU7xzsjD/BkTjd8alzhBaMHX2Hz5lHrlw3eKEx1eS45ERPpY71QIWKffYy9jnOilh5yDLJL/ebjhkFdtlF4yfkKJ2mmfqQyvGa4ckizJZBVTMf+pR3JLvM8Z3IedCbC0NXZrg/Q45VQKzdMItoOhIqNmgY8pDuR8FfPKcNd2hBFqXNO893KuuBDdm2Kb9RQf+tsokzdlWDIV1bFjkhqD2mzAyGldtF0DskBBGuk3d7iEAzTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FxUUyc0WxjnpgwYDz3DakwYxFH9LSRixncEFJ+GGM58=; b=aLdY4aM7PkDldDf7RvVUMASfb81dP1U0kJx/YSMH/BmFFNRExZJ4an8N68lj05tbSVOYMI0b1GmoahcjXNapsYJVkoLwaI/tHGGM1+rrdnlrbJBn/zjmerVgH/ItznwXpgnXKTxDmy8yyQ/IWV2PzL5sAnYl7rZa+QZvqaseJQQ= Received: from AM4PR05MB3460.eurprd05.prod.outlook.com (10.171.187.153) by AM4PR05MB3281.eurprd05.prod.outlook.com (10.171.188.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 09:20:56 +0000 Received: from AM4PR05MB3460.eurprd05.prod.outlook.com ([fe80::cda6:ae00:9ce6:3b13]) by AM4PR05MB3460.eurprd05.prod.outlook.com ([fe80::cda6:ae00:9ce6:3b13%7]) with mapi id 15.20.2856.019; Sun, 29 Mar 2020 09:20:56 +0000 From: Dekel Peled To: "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" CC: Matan Azrad , "dev@dpdk.org" , Ori Kam Thread-Topic: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support Thread-Index: AQHWAn0r9qrtPLDB9EGAlAuphMwaxKhY+XoAgAZX7IA= Date: Sun, 29 Mar 2020 09:20:56 +0000 Message-ID: References: <239bc0ae9191ddc12fec65742949710d13185b85.1584346077.git.dekelp@mellanox.com> <849037cfb86ddbce85675606f8a81090044e97e1.1585123614.git.dekelp@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dekelp@mellanox.com; x-originating-ip: [109.65.119.144] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c81b4400-1e5f-4d89-caa3-08d7d3c27cc6 x-ms-traffictypediagnostic: AM4PR05MB3281:|AM4PR05MB3281: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1923; x-forefront-prvs: 035748864E x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM4PR05MB3460.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(396003)(136003)(346002)(376002)(39850400004)(366004)(66946007)(66446008)(64756008)(66556008)(52536014)(5660300002)(66476007)(76116006)(2906002)(26005)(54906003)(186003)(316002)(110136005)(55016002)(33656002)(8936002)(81156014)(81166006)(71200400001)(8676002)(478600001)(6506007)(4326008)(53546011)(107886003)(86362001)(7696005)(9686003); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4zzLJefwIHwHwdxgLhdueLS3VDU86PIino56Ks6qmrGUMxS+z7dHZ66BAzteaVB9ranmCgTAr5+vnr+YR7kGZ5CihygE+urV/Q76uDdm8EYxV2WilwQOquSnNvXK4tO2V12ZrzqR2S/KQ6kchgMeDWxUEzhZ7PKI1Z3JQqoO29n1AOkrTTMF6ACTxWUOPPMRUl/ADZjln2TUpvQTQg4+3GjAH8bUexUMQyTBixh6LbLpkdGHEgSYglkv1XaUXeMAMU6czATMGJn9ACMyT1KZCJaLTgLm87GOUodjMy43rJPAWi+Ef+HgIAo8EdE0fGmZpoLxggAtBJkQqaWpIz0nq3T7+VBuoCB8tIO+ZTKw2Uc4G8dZT+NZvjVmVeg3Af2abokKGAQfzRmjqsHNILWcZgy/R+VjcKFdnjfu7ylCfa9EpqX0styuDUlpzcCF/LGz x-ms-exchange-antispam-messagedata: V1Tnoy6m2EZkHBt7FeQrxHAVC4p9fMhXPud96m9ofWdCHXlgQWo/ZUJIZwO3P1V4UR2eMwqfrDNdhfl0HTzIZMjIv1PRXoOr0E6bSczZMlMOrJB0J63kpAZwVnUVlfmld2M6J2B195JGkvoF+67FwQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c81b4400-1e5f-4d89-caa3-08d7d3c27cc6 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2020 09:20:56.5274 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dtLr36u/Rd5OKiQAPLb6CIknX3fvfEPwvcD+qI8QR2p9pJBehS7q+u612zw+eZoDJEVdeBC/ukzlUEmD5GKGQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3281 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Can this patch be applied? Regards, Dekel > -----Original Message----- > From: Ori Kam > Sent: Wednesday, March 25, 2020 10:28 AM > To: Dekel Peled ; wenzhuo.lu@intel.com; > jingjing.wu@intel.com; bernard.iremonger@intel.com > Cc: Matan Azrad ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support >=20 >=20 >=20 > > -----Original Message----- > > From: dev On Behalf Of Dekel Peled > > Sent: Wednesday, March 25, 2020 10:13 AM > > To: Ori Kam ; wenzhuo.lu@intel.com; > > jingjing.wu@intel.com; bernard.iremonger@intel.com > > Cc: Matan Azrad ; dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support > > > > This patch adds CLI option to enter the v_pt_rsv_flags value for GTP > > flow pattern item. > > It also adds GTP as valid item in raw_encap and raw_decap setting. > > > > Signed-off-by: Dekel Peled > > --- > > v2: remove redundant hton flag. > > --- > > app/test-pmd/cmdline_flow.c | 15 +++++++++++++-- > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > > index a781545..4877ac6 100644 > > --- a/app/test-pmd/cmdline_flow.c > > +++ b/app/test-pmd/cmdline_flow.c > > @@ -170,6 +170,7 @@ enum index { > > ITEM_FUZZY, > > ITEM_FUZZY_THRESH, > > ITEM_GTP, > > + ITEM_GTP_FLAGS, > > ITEM_GTP_MSG_TYPE, > > ITEM_GTP_TEID, > > ITEM_GTPC, > > @@ -938,6 +939,7 @@ struct parse_action_priv { }; > > > > static const enum index item_gtp[] =3D { > > + ITEM_GTP_FLAGS, > > ITEM_GTP_MSG_TYPE, > > ITEM_GTP_TEID, > > ITEM_NEXT, > > @@ -2347,12 +2349,18 @@ static int comp_set_raw_index(struct context > > *, const struct token *, > > .next =3D NEXT(item_gtp), > > .call =3D parse_vc, > > }, > > + [ITEM_GTP_FLAGS] =3D { > > + .name =3D "v_pt_rsv_flags", > > + .help =3D "GTP flags", > > + .next =3D NEXT(item_gtp, NEXT_ENTRY(UNSIGNED), > > item_param), > > + .args =3D ARGS(ARGS_ENTRY(struct rte_flow_item_gtp, > > + v_pt_rsv_flags)), > > + }, > > [ITEM_GTP_MSG_TYPE] =3D { > > .name =3D "msg_type", > > .help =3D "GTP message type", > > .next =3D NEXT(item_gtp, NEXT_ENTRY(UNSIGNED), > item_param), > > - .args =3D ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_gtp, > > - msg_type)), > > + .args =3D ARGS(ARGS_ENTRY(struct rte_flow_item_gtp, > > msg_type)), > > }, > > [ITEM_GTP_TEID] =3D { > > .name =3D "teid", > > @@ -6604,6 +6612,9 @@ static int comp_set_raw_index(struct context *, > > const struct token *, > > size =3D sizeof(struct rte_flow_item_ah); > > proto =3D 0x33; > > break; > > + case RTE_FLOW_ITEM_TYPE_GTP: > > + size =3D sizeof(struct rte_flow_item_gtp); > > + break; > > case RTE_FLOW_ITEM_TYPE_PFCP: > > size =3D sizeof(struct rte_flow_item_pfcp); > > break; > > -- > > 1.8.3.1 >=20 > Acked-by: Ori Kam > Thanks, > Ori