From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 77E04A0096 for ; Tue, 4 Jun 2019 07:13:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6D0CC1B996; Tue, 4 Jun 2019 07:13:06 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60069.outbound.protection.outlook.com [40.107.6.69]) by dpdk.org (Postfix) with ESMTP id 35C3B1B995 for ; Tue, 4 Jun 2019 07:13:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cf625OlaftlKvOPla7Z9sN+6fSXHMixkj2Pug6/aoK0=; b=HK7XrflR0+gDC33gc5RA3/14p0/z/mAJnYTTYAuS8n+qyHbwDPTbzfiPgrA2LIn0gU/v7ay8+0U0MaL6YGUc7F26M7I2trkWrjs9ng9FImokD0Rvx9LoDVntSuvT5XcDNgJQqSOANQFcdXvIu8Gx33zWggl96vQ0IW3zZIOM4DU= Received: from AM4PR05MB3460.eurprd05.prod.outlook.com (10.171.187.153) by AM4PR05MB3121.eurprd05.prod.outlook.com (10.171.186.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1943.22; Tue, 4 Jun 2019 05:13:03 +0000 Received: from AM4PR05MB3460.eurprd05.prod.outlook.com ([fe80::49a:9e7a:9416:8064]) by AM4PR05MB3460.eurprd05.prod.outlook.com ([fe80::49a:9e7a:9416:8064%5]) with mapi id 15.20.1943.018; Tue, 4 Jun 2019 05:13:03 +0000 From: Dekel Peled To: Adrien Mazarguil CC: "dev@dpdk.org" , Ori Kam , Thomas Monjalon Thread-Topic: [PATCH v5 0/3] add actions to modify header fields Thread-Index: AQHU+P46fAIDLOfcyk2nSInpoSPGvqaIRBtAgALuTcA= Date: Tue, 4 Jun 2019 05:13:03 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dekelp@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0a2996ed-f045-4007-8445-08d6e8ab5240 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM4PR05MB3121; x-ms-traffictypediagnostic: AM4PR05MB3121: x-ms-exchange-purlcount: 4 x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 0058ABBBC7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(136003)(39860400002)(366004)(396003)(199004)(189003)(13464003)(5660300002)(6246003)(54906003)(66446008)(66476007)(71190400001)(76116006)(81156014)(8676002)(7736002)(305945005)(6506007)(316002)(14454004)(53546011)(6116002)(73956011)(68736007)(66946007)(99286004)(966005)(7696005)(81166006)(102836004)(6916009)(3846002)(76176011)(52536014)(2906002)(14444005)(33656002)(66556008)(64756008)(25786009)(256004)(486006)(74316002)(86362001)(55016002)(476003)(11346002)(107886003)(8936002)(66066001)(6436002)(186003)(4326008)(6306002)(229853002)(71200400001)(26005)(508600001)(9686003)(53936002)(446003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3121; H:AM4PR05MB3460.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: pvzIDRnQi4vTxsxCRuYGykeXgSzAQimMwD12E3K9CdZj18/FZoRqT0prQQ0IuicwhKy/3qvinC/v39SXtOETW79Sra4yCLP4lIZY4nEa8FdfLferTUX8uJdO3uOB/yX/Lo9NiHHgLaozauXyi1c2tlOUMTyarhOG/vlYWCN/dY4FmwIktbYaIHsmrHnLI9Cn7rEdszIZQbwPV3GeFztSAVvUOyswcugkzWRgrVIs3TUEOf058fbqyQcb6FvvVknT6PhQEl2Hepnz7UfUUFRb934Mr/D5yabZwEQPrg+qrlXUWNiFnQ3S9khsckGnl9K3dPBwoKTWwL1OV3LuXFelE4CQqaL6oZnyYYg38nlPeroJnDEd2XPJsuwx7uKw858NoKpcFhGV7FHLJsD6HcREL2IfWWylfFo5ypcJ7cwYKcA= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a2996ed-f045-4007-8445-08d6e8ab5240 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2019 05:13:03.5356 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dekelp@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3121 Subject: Re: [dpdk-dev] [PATCH v5 0/3] add actions to modify header fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Adrien, I understand that you might have some reservations about patch http://patch= es.dpdk.org/patch/52975/. I'm preparing v6, with update documentation according to comments from Thom= as. In v5 I modified the struct rte_flow_integer_action, according to your comm= ents in previous versions. Please reply with any additional comments so I can push this series forward= . Regards, Dekel > -----Original Message----- > From: Dekel Peled > Sent: Sunday, June 2, 2019 11:18 AM > To: Adrien Mazarguil ; > wenzhuo.lu@intel.com; jingjing.wu@intel.com; > bernard.iremonger@intel.com; Yongseok Koh ; > Shahaf Shuler ; arybchenko@solarflare.com; Yigit, > Ferruh > Cc: dev@dpdk.org; Ori Kam > Subject: RE: [PATCH v5 0/3] add actions to modify header fields >=20 > Hi, >=20 > Please review/comment on v5 of this series so it can be accepted. > http://patches.dpdk.org/cover/52974/ >=20 > Regards, > Dekel >=20 > > -----Original Message----- > > From: Dekel Peled > > Sent: Monday, April 22, 2019 2:23 PM > > To: Adrien Mazarguil ; > > wenzhuo.lu@intel.com; jingjing.wu@intel.com; > > bernard.iremonger@intel.com; Yongseok Koh ; > Shahaf > > Shuler ; arybchenko@solarflare.com > > Cc: dev@dpdk.org; Ori Kam ; Dekel Peled > > > > Subject: [PATCH v5 0/3] add actions to modify header fields > > > > Patch [1] implemented set of header modification actions in MLX PMD, > > based on ethdev and testpmd updates included in [2]. > > This series implements support of additional header modification > > actions, in ethdev, testpmd, and MLX5 PMD. > > > > Original work by Xiaoyu Min. > > > > [1] http://patches.dpdk.org/patch/49310/ > > [2] http://mails.dpdk.org/archives/dev/2018-August/109672.html > > > > --- > > v2: apply code review comments. > > v3: apply additional code review comments. > > - Update documentation of new commands. > > - Use common general struct for all commands. > > v4: apply checkpatch comments. > > v5: apply additional code review comments. > > - Add 8, 16, 32 bit types to union. > > - Update struct name and documentation. > > --- > > > > Dekel Peled (3): > > ethdev: add actions to modify TCP header fields > > app/testpmd: add actions to modify TCP header fields > > net/mlx5: update modify header using Direct Verbs > > > > app/test-pmd/cmdline_flow.c | 100 ++++++++++++ > > doc/guides/prog_guide/rte_flow.rst | 68 ++++++++ > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 16 ++ > > drivers/net/mlx5/mlx5_flow.h | 10 +- > > drivers/net/mlx5/mlx5_flow_dv.c | 239 > > ++++++++++++++++++++++++++++ > > drivers/net/mlx5/mlx5_prm.h | 12 ++ > > lib/librte_ethdev/rte_flow.c | 4 + > > lib/librte_ethdev/rte_flow.h | 61 +++++++ > > 8 files changed, 509 insertions(+), 1 deletion(-) > > > > -- > > 1.8.3.1