From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50129.outbound.protection.outlook.com [40.107.5.129]) by dpdk.org (Postfix) with ESMTP id 693912BFA for ; Tue, 11 Sep 2018 10:22:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YpMvbe9y+jUC99m6Ln6gOO7Y+gfivqU+lL+4bwypm1Q=; b=ffoXWJitD8WDhnndRfWV2RQFjZcBvXhbbEis1SL42Wzar/+K/XJILhH65CRFoTEmkz8heZxhnudwlevaeC3Rvx2zzaO5lKCVfm1Tymx8wYNB141xrZNqNgG6pD3NVigDemBvqMzJloS4ci0l3Vy9m9OksSjqdys98ysPtXNnZWo= Received: from AM4PR07MB1585.eurprd07.prod.outlook.com (10.165.249.17) by AM4PR07MB1540.eurprd07.prod.outlook.com (10.165.249.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.12; Tue, 11 Sep 2018 08:22:14 +0000 Received: from AM4PR07MB1585.eurprd07.prod.outlook.com ([fe80::9e6:cea5:b2b5:10f1]) by AM4PR07MB1585.eurprd07.prod.outlook.com ([fe80::9e6:cea5:b2b5:10f1%3]) with mapi id 15.20.1143.010; Tue, 11 Sep 2018 08:22:13 +0000 From: "Meunier, Julien (Nokia - FR/Paris-Saclay)" To: "Wang, Xiao W" , "Zhang, Qi Z" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/fm10k: add imissed stats Thread-Index: AQHUSXJNHvwsmTnOCEWmCMH8oniXZ6TqvV7g Date: Tue, 11 Sep 2018 08:22:13 +0000 Message-ID: References: <20180910155035.23638-1-julien.meunier@nokia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=julien.meunier@nokia.com; x-originating-ip: [135.245.212.192] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR07MB1540; 6:HuasJJx3r9zL/OKp6EoR+T3x9NvZSnQIHvenUKEPhGwB2jgNk3CGR8c3j5CXfCtbBR69nZfa38OK/sqPNPkRzrk3/y0n5LRPnendHB5KH4poZQYaAgwsGk+KmOL5W00GbuHU5POnAYdo8a4fbx2uAi6yypQadXq/ckW+hqgCsuOiX47TJMFMcDTxmHSvwoOFAu5AZoxAKnSr2FFNeXobMeNW+4PL7ZxavHFh6YZzR+1HmecrS4t4YJleKaqkvCW1T2mEENU/JnFRsFHIWLYsAn31RVgVJ1iAJuNaEslOE9sNu9XZHCEPj/Ozl+7eOIhQCqzqEWjOJwxlvjbRMMmt9xjEmfUlxk86s7XNVYWPWYf0XylrUr4NQXvhtRINOEDrM6sU8Y8M6lpFEHHMxw1QSn1PDaYTdplUZykNTtxbsJ4Rd6boDqIkCeu4Y8LMUXfOmayHWg6ANRIpALcoIxKO2Q==; 5:oE0w+gyZSQn5Ar7jwZM3nbdY2Gs95aAc3yp2c38kN5SChcTcR3mg4wsTD4ZC2VtDM7nMomf2LkC0WukjoWkxDXpshw/exFZAh/xIP7FXi9uDEGNYkEq3Elbt5uWu7acQq8iZDtFH31Ryv0ADcU9DQ+98GumwieC3qEXvmWjB6HY=; 7:jCBmBWX19pWXUdXEP7OOkrWt2rJGtcviRpdhsAyTIJEYRN4hswQZLi3BdaE13AD2krM/hwC/GTbWIoBdAiI8XHXel8RhGxD5O7/nUX+uYWCpGi+jmXpRTGeHhTYPw+j48x5mgePIG7Io7QmipAKNRKBvg1+LVnN9zO8st9sOrR4L9/AototXBXCkThfl6hTBA+lT2bOklZLULyojgnNvWM3EqR3E0JWY1LKdkx6pFu6yDCA/YHwhyf7Fz0QO68sw x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: f9542618-b90e-41cf-743d-08d617bfad5e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7193020); SRVR:AM4PR07MB1540; x-ms-traffictypediagnostic: AM4PR07MB1540: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(82608151540597)(109105607167333)(195916259791689)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231311)(11241501184)(806099)(944501410)(52105095)(93006095)(93001095)(3002001)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(201708071742011)(7699050); SRVR:AM4PR07MB1540; BCL:0; PCL:0; RULEID:; SRVR:AM4PR07MB1540; x-forefront-prvs: 0792DBEAD0 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(376002)(366004)(346002)(39860400002)(136003)(189003)(199004)(13464003)(7736002)(53546011)(99286004)(81156014)(81166006)(9686003)(229853002)(8936002)(6436002)(97736004)(6506007)(66066001)(3846002)(55016002)(68736007)(6116002)(53936002)(14444005)(2900100001)(256004)(7696005)(105586002)(76176011)(106356001)(5660300001)(2906002)(8676002)(110136005)(5250100002)(33656002)(26005)(478600001)(476003)(74316002)(305945005)(446003)(14454004)(11346002)(186003)(316002)(25786009)(4326008)(86362001)(486006)(102836004)(6246003); DIR:OUT; SFP:1102; SCL:1; SRVR:AM4PR07MB1540; H:AM4PR07MB1585.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nokia.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: R9ayswif85D3PkvwHdhGhYpniP5oBLxyuymIbtyQQXPEH9DFHPtePWB/yG05Ei0pGrqkDP4Wq/TA893o0/JZxb2V0k6hrTB9Vmdpph0MN+dQyDblDPEc8tpGgpT7vg2n96V422hqfk3IIUPAKjcg6ZeTgi18Y2TkcRXNnG4qcoVB6YR+DYaatYutEKlpZYLSy9Trq16gzn2eQ9eGUmaU9WYfiiPc6qHbSZKHt6iWJdS7MYU4/ef/Dc6GC6OMAabWZwz6AZDxID5vpEnIPdGfq7iLcTbYw67B966yBadmamWrWIeqHRp80p//rsQvbBd48UtjNTd9mrKP5POyCAWW9c9tReSLa5ZOEnPzEyVch+ecZcLN4vZdg6VDz2Vr8ef8W7GclLg6PwmEN+h0ZuJAbw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9542618-b90e-41cf-743d-08d617bfad5e X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Sep 2018 08:22:13.2883 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR07MB1540 Subject: Re: [dpdk-dev] [PATCH] net/fm10k: add imissed stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Sep 2018 08:22:15 -0000 Hi, Please, do not merge this patch. I need to check and readapt this patch. A = version 2 will be sent later. Thanks, -- Julien Meunier > -----Original Message----- > From: Wang, Xiao W > Sent: Tuesday, September 11, 2018 3:52 AM > To: Meunier, Julien (Nokia - FR/Paris-Saclay) ; > Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/fm10k: add imissed stats >=20 > Hi, >=20 > -----Original Message----- > From: Julien Meunier [mailto:julien.meunier@nokia.com] > Sent: Monday, September 10, 2018 11:51 PM > To: Zhang, Qi Z ; Wang, Xiao W > > Cc: dev@dpdk.org > Subject: [PATCH] net/fm10k: add imissed stats >=20 > Add support of imissed and q_errors statistics, reported by PCIE_QPRDC > register (see datasheet, section 11.27.2.60), which exposes the number of > receive packets dropped for a queue. >=20 > Signed-off-by: Julien Meunier > --- > drivers/net/fm10k/fm10k_ethdev.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > b/drivers/net/fm10k/fm10k_ethdev.c > index 541a49b..a9af6c2 100644 > --- a/drivers/net/fm10k/fm10k_ethdev.c > +++ b/drivers/net/fm10k/fm10k_ethdev.c > @@ -1325,7 +1325,7 @@ fm10k_xstats_get(struct rte_eth_dev *dev, struct > rte_eth_xstat *xstats, static int fm10k_stats_get(struct rte_eth_dev *d= ev, > struct rte_eth_stats *stats) { > - uint64_t ipackets, opackets, ibytes, obytes; > + uint64_t ipackets, opackets, ibytes, obytes, imissed; > struct fm10k_hw *hw =3D > FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private); > struct fm10k_hw_stats *hw_stats =3D > @@ -1336,22 +1336,25 @@ fm10k_stats_get(struct rte_eth_dev *dev, struct > rte_eth_stats *stats) >=20 > fm10k_update_hw_stats(hw, hw_stats); >=20 > - ipackets =3D opackets =3D ibytes =3D obytes =3D 0; > + ipackets =3D opackets =3D ibytes =3D obytes =3D imissed =3D 0; > for (i =3D 0; (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) && > (i < hw->mac.max_queues); ++i) { > stats->q_ipackets[i] =3D hw_stats->q[i].rx_packets.count; > stats->q_opackets[i] =3D hw_stats->q[i].tx_packets.count; > stats->q_ibytes[i] =3D hw_stats->q[i].rx_bytes.count; > stats->q_obytes[i] =3D hw_stats->q[i].tx_bytes.count; > + stats->q_errors[i] =3D hw_stats->q[i].rx_drops.count; > ipackets +=3D stats->q_ipackets[i]; > opackets +=3D stats->q_opackets[i]; > ibytes +=3D stats->q_ibytes[i]; > obytes +=3D stats->q_obytes[i]; > + imissed +=3D stats->q_errors[i]; > } > stats->ipackets =3D ipackets; > stats->opackets =3D opackets; > stats->ibytes =3D ibytes; > stats->obytes =3D obytes; > + stats->imissed =3D imissed; > return 0; > } >=20 > Acked-by: Xiao Wang >=20 >=20 > -- > 2.10.2