Re: [dpdk-dev] [PATCH] test/eal_flags: Optimize memory flags test

[Phil Yang <Phil.Yang@arm.com>]

Hi Thomas,

That change just want to make sure below two buffers have enough space when configure RTE_MAX_NUMA_NODES=1.

/* construct an invalid socket mask with 2 megs on each socket plus
  * extra 2 megs on socket that doesn't exist on current system */
char invalid_socket_mem[SOCKET_MEM_STRLEN];
char buf[SOCKET_MEM_STRLEN];>   /* to avoid copying string onto itself */

Thanks,
Phil Yang

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, April 26, 2018 1:07 AM
> To: Phil Yang <Phil.Yang@arm.com>
> Cc: dev@dpdk.org; nd <nd@arm.com>; anatoly.burakov@intel.com; Herbert
> Guan <Herbert.Guan@arm.com>
> Subject: Re: [dpdk-dev] [PATCH] test/eal_flags: Optimize memory flags test
> 
> Hi,
> 
> Your patch has been forgotten for months.
> Do not hesitate to ping if no reply.
> 
> I have a question below.
> 
> 06/02/2018 03:21, Phil Yang:
> > --- a/test/test/test_eal_flags.c
> > +++ b/test/test/test_eal_flags.c
> > -#define SOCKET_MEM_STRLEN (RTE_MAX_NUMA_NODES * 10)
> > +#define SOCKET_MEM_STRLEN (RTE_MAX_NUMA_NODES * 20)
> 
> Why the above change?
> 
> > @@ -1138,10 +1138,11 @@ test_memory_flags(void)
> > -	int i, num_sockets = get_number_of_sockets();
> > +	int i, num_sockets = RTE_MIN(get_number_of_sockets(),
> > +			RTE_MAX_NUMA_NODES);
> >  #endif
> >
> > -	if (num_sockets <= 0 || num_sockets > RTE_MAX_NUMA_NODES) {
> > +	if (num_sockets <= 0) {
> >  		printf("Error - cannot get number of sockets!\n");
> >  		return -1;
> >  	}
> >
> 
> 
> 
>