From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9C8FA04BA; Wed, 7 Oct 2020 07:35:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0C6BA1B3DF; Wed, 7 Oct 2020 07:35:12 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60043.outbound.protection.outlook.com [40.107.6.43]) by dpdk.org (Postfix) with ESMTP id 4B31E160; Wed, 7 Oct 2020 07:35:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LA2jqOqSDhr4OBS7uUhqZ0YYTpqzW/3tImOJbgyLILQ0LnvZO+qeXtkW+1C+rGtoBa4nW9gGszn6xuTOEyYCAT9Qt90C4Rut+5wiffG8gI2X2EzIbL3ZXJzc0tLQF2qzYMO3c9GZOu2nHkhV4tEV+Q3F6yqj9Mxb00pJQ7xKakgYoMpr6uBYfM1UBjc6SRgu/DA3W7R7Iy2MzQv8GjY/Tv5Hnr8tilSvYSXBSdTLfI463DZag1++nQvpIX3YVQhyAS82yiluK4Q/JfaW5k22w1lS0PVYBbEVUaugzyT+OLmlCze9B6sWItH8NI+/WiVJe5V6hVyqSvtVjzd0SWjvFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p58QLiyb1Yr68jpjfQ0oGx2hiZPt4QtqqJvJtNc5LMo=; b=C1ZZnIvu6gorA99wteImgO4RNHtwXR/VCYNJV4tdJ92Z7AhPbOQMNNE0Mxl/IqTHR80ywr3BRJJJrhWbKgaWRHn9prILdapkddFp2AKP/2MNt8+ssAkoR4mQCJK6FCMId5TYKobfHwezF/pLVn31fE677aPsrVnebR6dwFQZfhBGH9jlEfFem5e+sakFxyLgfiN8Iy9/wsMqeMyaHXL2suCDn/TO0ViwdfnsIipteR9+8aeo2LYHlt9agNrUhNUpF7SaPsOP2rXnUjzZ3pjaWbSkb2RhoQsH+84qWKQQcZOSz/kc75TLlYJnEBV6AnU0NLKQ0/MrGN79pgmfxNzTwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p58QLiyb1Yr68jpjfQ0oGx2hiZPt4QtqqJvJtNc5LMo=; b=RxN84VHiRBjcOm22YP4ohvEQjXx/t684/ukv49DCmAwODGCmusvXQXRZfW2V4VO8+PKAnBHOzqGFVOVRrQh4Zk0RgTrXyDh+jGg1EDvkYhvPB+pV3OIssZZ2tNPl0LKMj9xyq4iFfKo4NEpCA7rCpX6KA+g0TIyxZVsGYlIWjCc= Received: from AM5PR0401MB2593.eurprd04.prod.outlook.com (2603:10a6:203:37::20) by AM7PR04MB7077.eurprd04.prod.outlook.com (2603:10a6:20b:11c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.34; Wed, 7 Oct 2020 05:35:07 +0000 Received: from AM5PR0401MB2593.eurprd04.prod.outlook.com ([fe80::3c2c:e6e1:4e49:2e5c]) by AM5PR0401MB2593.eurprd04.prod.outlook.com ([fe80::3c2c:e6e1:4e49:2e5c%11]) with mapi id 15.20.3433.045; Wed, 7 Oct 2020 05:35:07 +0000 From: Nipun Gupta To: wangyunjian , "dev@dpdk.org" CC: "jerry.lilijun@huawei.com" , "xudingke@huawei.com" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses Thread-Index: AQHWhkZIjOKHyKBTak+g1quDwPXP76mLyCwA Date: Wed, 7 Oct 2020 05:35:07 +0000 Message-ID: References: <8f778cef6a01a8222e256daf25ff5ce6feed334b.1599485594.git.wangyunjian@huawei.com> <1599613906-19420-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: <1599613906-19420-1-git-send-email-wangyunjian@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [182.69.68.139] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: a51d1848-7d53-4084-28ca-08d86a82bfff x-ms-traffictypediagnostic: AM7PR04MB7077: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:83; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DVR48Ivn+Vgryc03Z7nVDbFD2JVlLkHVLwgLok3rhjfiPmIVbYpf02hQwHjk7CcQV8SuaHWQ4BVthL2AWLNpNOpi+tlQiQ/Ksetr3SLAMcLlupmNOx2DVsNClfq+uiGGfiLzlG5q4idB+uszK+eG3IY5HJyQMuPSm6hUvk9gZWWEM+O+I8JDHRrJGivwY7x/0vCvPAKIPv++jOqc4QosN+XXle7UgkJyNPl1+/g84lqlyV4/ACCHYgrLyketYAZOLf4KTUXY08P57YlNbiHBELiek1qymg5IDAQNN6k0JBttYyBw64sIefDvRUoU71n6yMiFULSt/2d9rV70wqZTSw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM5PR0401MB2593.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(346002)(376002)(39860400002)(136003)(86362001)(76116006)(316002)(2906002)(66476007)(66556008)(64756008)(66446008)(478600001)(55016002)(6506007)(66946007)(5660300002)(52536014)(44832011)(9686003)(83380400001)(110136005)(53546011)(54906003)(8676002)(71200400001)(4326008)(7696005)(8936002)(26005)(33656002)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: jafxJRi8Yt+0xhS+DvNEREyOj19PgIwNI2ycbDWEURLhAqnx3eex2SYHZv3zKDhJkXYkXM0A3VCewe5Ff11tOfz8fkX8dw1esU7GIWi6oSIQEloe/qfZSjSJK2kyh+HrgpdNeiO0FHE4epi97rSuMycp09UHBHl38jlVIpzQo6vio7VoUncaRmRJhanVgXQpnp/pxMB06o+ginNBh0Kld4OgE2Tt5DAkhMtwXrK3eAr/IgXv0TZMic+kJQHcaNgfzE4MW+pFhdfSSeIt7N3Ugt4bjyZb+O2BEUnnFkfMYaYWkI5KP0jDp5joXPJT1UPkSHLXP7l0ay8oN3kBzOiSiuBT9KcUQt91HnBjTqFSw6ud3lph4xYdtJ5BtY2xyvgkDCUgN00I6H3juAtj3IC17lMWs0owln5RU2VnulRBwX59GIeuiNUZze5OdV30RyyBFqi/qUQlxQOOh8JY+bkQBY/G43fZ+qSXjTOBd+WHJVJO+llTgScEeRwAmt3PumeJSDI0NPzgeGw50SmwSX+L9yHWoO9jEGI58oN3EBrbhpgU9RCB+EPqoQBrLOzBCAwOdE22mBnSvga79OBfVruAvZJFGsiprCJi2R2OwEri7ffnnZemzlGfW9FqS17ZHnITe2ibXR99h1DdLKEvQqZ0Ww== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM5PR0401MB2593.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a51d1848-7d53-4084-28ca-08d86a82bfff X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2020 05:35:07.1658 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: itmnXr1AKv2L9Nw/6ATWkzT2VSF0H9ADldJGeTMkGoHzP45vbjDTCeSaqL9pPld5wgmI0yZdi6FjCMZtWBTKVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7077 Subject: Re: [dpdk-dev] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Acked by: Nipun Gupta > -----Original Message----- > From: wangyunjian > Sent: Wednesday, September 9, 2020 6:42 AM > To: dev@dpdk.org > Cc: Nipun Gupta ; jerry.lilijun@huawei.com; > xudingke@huawei.com; Yunjian Wang ; > stable@dpdk.org > Subject: [dpdk-dev] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses >=20 > From: Yunjian Wang >=20 > This issue detected by coverity, CID#279443(Structurally dead code). >=20 > Coverity issue: 279443 > Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yunjian Wang > --- > v2: fix spelling in commit log > --- > drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c > b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c > index 0b9c4e3d7..4b8474951 100644 > --- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c > +++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c > @@ -452,9 +452,10 @@ rte_qdma_reset(void) > /* In case there are pending jobs on any VQ, return -EBUSY */ > for (i =3D 0; i < qdma_dev.max_vqs; i++) { > if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues !=3D > - qdma_vqs[i].num_dequeues)) > + qdma_vqs[i].num_dequeues)) { > DPAA2_QDMA_ERR("Jobs are still pending on VQ: %d", > i); > return -EBUSY; > + } > } >=20 > /* Reset HW queues */ > -- > 2.18.1 >=20