From: Ruifeng Wang <Ruifeng.Wang@arm.com>
To: Lance Richardson <lance.richardson@broadcom.com>,
"Ajit Khaparde (ajit.khaparde@broadcom.com)"
<ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
Stephen Hurd <stephen.hurd@broadcom.com>,
David Christensen <david.christensen@broadcom.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/bnxt: fix missing barriers in completion handling
Date: Mon, 12 Jul 2021 02:34:35 +0000 [thread overview]
Message-ID: <AM5PR0802MB2465493131DF5931087DAB959E159@AM5PR0802MB2465.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210709163849.88214-1-lance.richardson@broadcom.com>
> -----Original Message-----
> From: Lance Richardson <lance.richardson@broadcom.com>
> Sent: Saturday, July 10, 2021 12:39 AM
> To: Ajit Khaparde (ajit.khaparde@broadcom.com)
> <ajit.khaparde@broadcom.com>; Somnath Kotur
> <somnath.kotur@broadcom.com>; Bruce Richardson
> <bruce.richardson@intel.com>; Konstantin Ananyev
> <konstantin.ananyev@intel.com>; jerinj@marvell.com; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; Stephen Hurd <stephen.hurd@broadcom.com>;
> David Christensen <david.christensen@broadcom.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH v2] net/bnxt: fix missing barriers in completion handling
>
> Ensure that Rx/Tx/Async completion entry fields are accessed
> only after the completion's valid flag has been loaded and
> verified. This is needed for correct operation on systems that
> use relaxed memory consistency models.
>
> Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code")
> Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code")
> Cc: stable@dpdk.org
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
> v2:
> * Corrected name of the first parameter to bnxt_cpr_cmp_valid() in
> comments ('cmp' to 'cmpl').
>
> drivers/net/bnxt/bnxt_cpr.h | 36 ++++++++++++++++++++++++---
> drivers/net/bnxt/bnxt_ethdev.c | 16 ++++++------
> drivers/net/bnxt/bnxt_irq.c | 7 +++---
> drivers/net/bnxt/bnxt_rxr.c | 9 ++++---
> drivers/net/bnxt/bnxt_rxtx_vec_avx2.c | 2 +-
> drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 2 +-
> drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 2 +-
> drivers/net/bnxt/bnxt_txr.c | 2 +-
> 8 files changed, 54 insertions(+), 22 deletions(-)
>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
next prev parent reply other threads:[~2021-07-12 2:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 19:15 [dpdk-dev] [PATCH] " Lance Richardson
2021-07-09 5:59 ` Ruifeng Wang
2021-07-09 14:48 ` Lance Richardson
2021-07-09 16:38 ` [dpdk-dev] [PATCH v2] " Lance Richardson
2021-07-12 2:34 ` Ruifeng Wang [this message]
2021-07-12 21:43 ` Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM5PR0802MB2465493131DF5931087DAB959E159@AM5PR0802MB2465.eurprd08.prod.outlook.com \
--to=ruifeng.wang@arm.com \
--cc=ajit.khaparde@broadcom.com \
--cc=bruce.richardson@intel.com \
--cc=david.christensen@broadcom.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=lance.richardson@broadcom.com \
--cc=nd@arm.com \
--cc=somnath.kotur@broadcom.com \
--cc=stable@dpdk.org \
--cc=stephen.hurd@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).