From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DCF1A0C4B; Mon, 12 Jul 2021 04:34:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E4F940688; Mon, 12 Jul 2021 04:34:49 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60082.outbound.protection.outlook.com [40.107.6.82]) by mails.dpdk.org (Postfix) with ESMTP id 976B540685; Mon, 12 Jul 2021 04:34:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3MuJgCLr12xN6qUTZ2ICWm9RshA4FjD704bJvBRMu0E=; b=cA0hTRyGSMSxwewCtUd0ZYFLsHNhxf093b4eY1ZxR4V0bn06zV8uaxrjmkVXdQ2cH93GkFSNWkYQx9cMolwitPvKbCRGIhj6H0tsMCJR+R/cfM6o7o9QlGInM56gFTEli8And4a6o7W4zs/bX/xe4kGwlx3lF7y9BbMgVRgn1ys= Received: from DU2PR04CA0263.eurprd04.prod.outlook.com (2603:10a6:10:28e::28) by AM4PR0802MB2322.eurprd08.prod.outlook.com (2603:10a6:200:62::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.24; Mon, 12 Jul 2021 02:34:45 +0000 Received: from DB5EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28e:cafe::a7) by DU2PR04CA0263.outlook.office365.com (2603:10a6:10:28e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.19 via Frontend Transport; Mon, 12 Jul 2021 02:34:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT031.mail.protection.outlook.com (10.152.20.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20 via Frontend Transport; Mon, 12 Jul 2021 02:34:45 +0000 Received: ("Tessian outbound 8b91ad1fd5d8:v98"); Mon, 12 Jul 2021 02:34:45 +0000 X-CR-MTA-TID: 64aa7808 Received: from 92638bbf880e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CB2028A9-20CB-4D87-9D1F-914F7D4082D7.1; Mon, 12 Jul 2021 02:34:39 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 92638bbf880e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 12 Jul 2021 02:34:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a2a3MbCT/gGF57XMWDaysJZImYJCTrDVyQDxBT1FL/31JPs05qQ2xoVkgJm0PLIRLEt65yoq44imiXoCdiUi4U1xd+/M/BU5wMm0tsaIkLyo7Y7Jp6litmwArWQFVFNgiNIMKVIQIxIhrFMGqbnqfFnyVxYTSzfmr5az+s+KRPVZiI+WzwHqoujbwo+AQgDdZVNJrSXDjMhQCgMG+4I92ZNjJKQWOZyLITOEQSJKNPRkpm8g3g3cYKcQdWHbT6SscAdpl1+UPDIiiorWpp1bp85EVNcWnGkHOvRwcWxef/x5iZXoQRn07A+lGNHqSkncn+73BdUz/D2I2b7Zn0TP3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3MuJgCLr12xN6qUTZ2ICWm9RshA4FjD704bJvBRMu0E=; b=j+w7zWa5nAFfj45jKUhKUpMyL6Cu3nVpjc/pLjZKQxFuqC/HRsjrdWT9hVxYynjyvdgUs/SDRYABpr65GtNDXNNcMcSYQejdMHwRAHBpizxG6myikTua0VZYI31rOpezD9nNbiWprclBBodvhyWnIYfHaX7/o1DS7EfzvyU0TeqeWsNJpLti2ToNpOubUPDVMYesV5XAIelBzszzE4HPgL13c0SP8qNMOy5H6TsMFrmW9NEUddkcHPLDyMLwLGhsIGrEfqsDcJYHMKDinMwj2HukZzOhCba6ZyqOTbqxSYSytQ1k9QDBXUyNeLOtnmEgPQadtOW4zxg1Pbw0e+PRSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3MuJgCLr12xN6qUTZ2ICWm9RshA4FjD704bJvBRMu0E=; b=cA0hTRyGSMSxwewCtUd0ZYFLsHNhxf093b4eY1ZxR4V0bn06zV8uaxrjmkVXdQ2cH93GkFSNWkYQx9cMolwitPvKbCRGIhj6H0tsMCJR+R/cfM6o7o9QlGInM56gFTEli8And4a6o7W4zs/bX/xe4kGwlx3lF7y9BbMgVRgn1ys= Received: from AM5PR0802MB2465.eurprd08.prod.outlook.com (2603:10a6:203:9f::22) by AM6PR08MB3704.eurprd08.prod.outlook.com (2603:10a6:20b:80::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.23; Mon, 12 Jul 2021 02:34:36 +0000 Received: from AM5PR0802MB2465.eurprd08.prod.outlook.com ([fe80::3d12:4220:b215:7c52]) by AM5PR0802MB2465.eurprd08.prod.outlook.com ([fe80::3d12:4220:b215:7c52%8]) with mapi id 15.20.4308.026; Mon, 12 Jul 2021 02:34:35 +0000 From: Ruifeng Wang To: Lance Richardson , "Ajit Khaparde (ajit.khaparde@broadcom.com)" , Somnath Kotur , Bruce Richardson , Konstantin Ananyev , "jerinj@marvell.com" , Stephen Hurd , David Christensen CC: "dev@dpdk.org" , "stable@dpdk.org" , nd Thread-Topic: [PATCH v2] net/bnxt: fix missing barriers in completion handling Thread-Index: AQHXdOD2AqE+i3q6eEiZasPwYdPTbqs+otDg Date: Mon, 12 Jul 2021 02:34:35 +0000 Message-ID: References: <20210708191501.77972-1-lance.richardson@broadcom.com> <20210709163849.88214-1-lance.richardson@broadcom.com> In-Reply-To: <20210709163849.88214-1-lance.richardson@broadcom.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: EA5E8AF01CA84C478ED8652EA5A20CED.0 x-checkrecipientchecked: true Authentication-Results-Original: broadcom.com; dkim=none (message not signed) header.d=none; broadcom.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: c0fc6353-84ff-43ce-2812-08d944dd9c61 x-ms-traffictypediagnostic: AM6PR08MB3704:|AM4PR0802MB2322: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:3513;OLM:3513; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9BB3CWO6xImetT2BTr7DvmJ8bKT2EMiWewOWic/y1Xo5MvcKxgXkCT1+Nam4XyEcfh/kK+Yl6AVPGX5iBUbG/XXuJq5S/Dll2yiS2sS1lCbWtyLq2PXgaTLwiDuqrDwHg6wdg/xifUApUABOnC3rkMyyc44uQ1fapwMh48ERVa9Zp4ICEr7ah/y6OLutzS0uhALH9ckzMXeD1F0kkQJ7yh7OGLtHgm6Vro3xFZkIheppwOhkh3CeKglaHEtvyPrAQDml22T8zOhqR2IYjiBPV+4R7hgY7f46jigtvq1Gw5B3o320w7Jq4CAsIG8+wOWbVeoiufgDxC0tg3ngR2nOQoq1fEv8qDDlq5nJG3u+zt4Qf95Dv2HkNYWq3dckG6Vg/b0REZGX8hNPMLokAeo3B9t6xYDy5CXX8AoGtSLvgKRZq6o6swsX5QF7/OWG5N+r99WRyu+LF0FhGWfh3u284Q6e9ZSSA5U3LiIxOepMJXMYcImjoGBOvb3oEitkQhHNOtgWSSha/12Nq2Be238GNlll8rUCRUpsTWgmoFLffwY6p3KUV1ENh1X+H0g8xJOxbJs1XDhBK92IzT9PeWhetLPn5LMtEF98vGAyg7dqSFjTMOjzfnVUfuJf0okLa3odQMtkzlqiwlhOiQK3efWhcQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM5PR0802MB2465.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(396003)(39830400003)(366004)(136003)(9686003)(8676002)(8936002)(110136005)(122000001)(38100700002)(33656002)(7696005)(55016002)(2906002)(83380400001)(5660300002)(86362001)(186003)(316002)(71200400001)(54906003)(7416002)(66946007)(4326008)(76116006)(478600001)(66446008)(66476007)(64756008)(6506007)(66556008)(53546011)(26005)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3qiXfjtJniCUPDvd84Ys1mVQgb685X2QS/hJLtRbCyRw1lM0gnWrr9hCkRbv?= =?us-ascii?Q?cKOhfczaefs23KlhAy5lOfLAqkA/tq7xwxA30MwtdMPcs33MO2KWLW9Z644+?= =?us-ascii?Q?Ss2wBYws7VA39b4eR+Wj+PtqVwcDIjM6Pd+ENAIOuvnXtmh4mtC/5ciynZzB?= =?us-ascii?Q?G9uJ7DUdVoKcX6IZZ2UiX7lG2W7A0dLMERJ+JkADtmERh/jzbGvJx99sMTsO?= =?us-ascii?Q?G3dIKp8sr20flO5UFvIvmnPl/wP87s2YwWOBT5Mh4tkxJnmH7u6VF/jO3BVc?= =?us-ascii?Q?ARfiV/7lkAiYhWncsArgWHbuvJ3d2Iq6CtRgVCQnUXs+4AbzmI/MpRAsxZb8?= =?us-ascii?Q?u1uUoZNVdf9GSp43YbjW8TkDHJkP/G0KoU9+n5xPBWyJiFuPlSCqvr/Oe7sS?= =?us-ascii?Q?vRCG6yi/+R1NXMLdCebI446wXetJBhhAYC4iBarqzW018ez8sm65d9cQvLoV?= =?us-ascii?Q?G86c3pP8x0kx77XeOV3+ZtjoY9kheZFXuU9fL1B7xarga/Z4nu75MDELPKFr?= =?us-ascii?Q?Oe6eY8ITnwHjR52YjMVSrDBVcR2l2Vw4Cw+2lHdCG1qLyxq05/lSLmaGB7dz?= =?us-ascii?Q?YlzkUTrnhG8Ddy01RJvX2XUBDLXnFN4YEG3wMHfoDu8ofQ205GFs4vgHvpIR?= =?us-ascii?Q?ibZd72Rz8tqgxeULBnFHMjgw7SUQCG8j2prk7vHGNVcdPDw5Dqkz5TpjMNGo?= =?us-ascii?Q?Chr6+VvHtvjQOsD8Er4xnOPXyx+mQ+CYNgczloGoebVY9Tq1rS9nySEZaH2W?= =?us-ascii?Q?eCraGEVJZzDr2HPp3z3S5QV8fRrZ91yAHfTxXhu9UB+67gwh7lVp4E6qtgJ9?= =?us-ascii?Q?j/Snb8kozHVTReGvsIsH8cQiuW9d+T2LJ8QvMZep3fUAG5GNUhxmqerFCbmk?= =?us-ascii?Q?n8+183jnQNMLlst60Ti5pVaZLySXIKvgltojqGuroxMfPjUqTijJTtJpMYiw?= =?us-ascii?Q?9ufKNegCa59nxKXBFU74PgN9RNXbxhszkaNWI/dL0yykWwBsVP50T/CukG30?= =?us-ascii?Q?9gMqSI8/R1arubHWcWKLZ1EORU0ZPIT9qLulvs6GKNUeQ8KAsRigvjdwkSA3?= =?us-ascii?Q?ITmM3tAkBiZ8wMwSXzXg3Ugk4cv4P7zmBn7/Z4lP5GWqkbEe+lvf+UGLpQse?= =?us-ascii?Q?Rrgd/jocOJEA6BFc9Y6VZdrxySqZY7SEVukpuMm/mr4kZStgxwhGVbezpbpR?= =?us-ascii?Q?XgdSa3GVNBilXCVm7R4g8NShGh9UuhJ4juRR6f7LIVHG48xQ8VAGiglaQ37o?= =?us-ascii?Q?wh2S1NZZ5Mw2Rknh3Jt8ARykQQHXXmK2DBibFmlByOEGIzLMJDSEF8erfwjt?= =?us-ascii?Q?YLatBozi9KF8yBa72rJbe1cs?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3704 Original-Authentication-Results: broadcom.com; dkim=none (message not signed) header.d=none; broadcom.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d55848d6-62dc-46d4-0c39-08d944dd96c4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZE/MQIKmvwwNK7MiBJCpBkl/MmJb7fGyPgwRxex8TfIbRs5p1Zf9oPv9LQsbX54df8o/FEXk53etcydEi39L6sfUfHKsxFcU9Jd8lG/Pf+5Pu3lDL7964/V2zKA+I6EW+OPAalMoXHZ1PHSKhy2UawJ/Uao1cEZx0HR6fy5o2w/yBKDOJp3tkMJ3kWQBfdZHzlG9FiZmxoPEqBy4L5Qby2NQlSmUgtdgzibDTW9ReK7uIQruZCf5vgAjO6xH4N1o0oqhpyqrIVbcw6HOahxmKX54eHEvECR/L6KUMhwVak+3g3SnxpEL/eADkFrqMido9Oe7FKSKR2r/8f3aAyyz9LnoNDI0mIBcZVCZ3upYhE/qiaZ3MlVUcjfLvxKy7tlHGQavIfGfer7mGwB0/wnOihhVRBjMi4udY3MQYjuZzutrib0Ulc1X05Ghr68Nm+kfB2WBdfbRM9Yu1CrpFuHMI0WpIFhuzUls6FlUsAoLtY7fPaLM00ScSDbdRTclaH8yDEOrFg79thRf9/EnuAlZ+axHD2k7WgfUl+xtUCY/WiTZoDnW5Gyl9moRu3RUzn+D8xC82LQnYqX9uY54qAIFMKCOq+22rnKT37ZDruMDeskHyo+Ks0RwouLwRqlch4QFDy0f1NcI+NiWiYxxNtA/MzFaXpzgoL+0geg8+KorZb8NWVNGfr5ZPaJNbIE5vc9lc78KK0Qe28ndtSdxEZxijA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(346002)(396003)(39830400003)(376002)(46966006)(36840700001)(6506007)(81166007)(336012)(186003)(53546011)(70206006)(450100002)(83380400001)(86362001)(316002)(33656002)(70586007)(36860700001)(4326008)(55016002)(54906003)(478600001)(5660300002)(82310400003)(110136005)(7696005)(8676002)(9686003)(47076005)(356005)(2906002)(8936002)(52536014)(26005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2021 02:34:45.1620 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c0fc6353-84ff-43ce-2812-08d944dd9c61 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2322 Subject: Re: [dpdk-dev] [PATCH v2] net/bnxt: fix missing barriers in completion handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Lance Richardson > Sent: Saturday, July 10, 2021 12:39 AM > To: Ajit Khaparde (ajit.khaparde@broadcom.com) > ; Somnath Kotur > ; Bruce Richardson > ; Konstantin Ananyev > ; jerinj@marvell.com; Ruifeng Wang > ; Stephen Hurd ; > David Christensen > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH v2] net/bnxt: fix missing barriers in completion handling >=20 > Ensure that Rx/Tx/Async completion entry fields are accessed > only after the completion's valid flag has been loaded and > verified. This is needed for correct operation on systems that > use relaxed memory consistency models. >=20 > Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code") > Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") > Cc: stable@dpdk.org > Signed-off-by: Lance Richardson > Reviewed-by: Ajit Khaparde > --- > v2: > * Corrected name of the first parameter to bnxt_cpr_cmp_valid() in > comments ('cmp' to 'cmpl'). >=20 > drivers/net/bnxt/bnxt_cpr.h | 36 ++++++++++++++++++++++++--- > drivers/net/bnxt/bnxt_ethdev.c | 16 ++++++------ > drivers/net/bnxt/bnxt_irq.c | 7 +++--- > drivers/net/bnxt/bnxt_rxr.c | 9 ++++--- > drivers/net/bnxt/bnxt_rxtx_vec_avx2.c | 2 +- > drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 2 +- > drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 2 +- > drivers/net/bnxt/bnxt_txr.c | 2 +- > 8 files changed, 54 insertions(+), 22 deletions(-) >=20 Reviewed-by: Ruifeng Wang