From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A16DA0C4A; Thu, 8 Jul 2021 11:22:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB1BF4069C; Thu, 8 Jul 2021 11:22:12 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50041.outbound.protection.outlook.com [40.107.5.41]) by mails.dpdk.org (Postfix) with ESMTP id 4BB9840687 for ; Thu, 8 Jul 2021 11:22:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0uxi3lxg7YH4gdJ+vF21TB1yx/W5WQ289WZv4whEnkw=; b=MgwoseRqqOFM8XbFi8dQFZP406yIg/TYKmLVkX7ZKbcuufeIBOvR1RxzhhmVlTj8sbLTCaTgksIXVHk9/uwUjpzTi/nGoVY4ChwMCQX7ND0mT618XmiRJsfu4VSiM9RSq4DxUcJwqpqvDq4NO8gAkCakcA8tfQS6cEeyDCb/fV8= Received: from FR3P281CA0031.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::9) by AS8PR08MB6726.eurprd08.prod.outlook.com (2603:10a6:20b:39a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.27; Thu, 8 Jul 2021 09:22:10 +0000 Received: from VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1c:cafe::c0) by FR3P281CA0031.outlook.office365.com (2603:10a6:d10:1c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.12 via Frontend Transport; Thu, 8 Jul 2021 09:22:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT059.mail.protection.outlook.com (10.152.19.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20 via Frontend Transport; Thu, 8 Jul 2021 09:22:09 +0000 Received: ("Tessian outbound ecba17995f61:v98"); Thu, 08 Jul 2021 09:22:09 +0000 X-CR-MTA-TID: 64aa7808 Received: from a3dc8d05f813.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C3EFFE38-CA90-42B2-8992-9D5D7641BCD0.1; Thu, 08 Jul 2021 09:21:59 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a3dc8d05f813.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 08 Jul 2021 09:21:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eYB+D2o8GA3ZJXLoHuF45N4+ePEncC+EljexmQsR04GD0BzvWGHVDk1DUxN0ROWeI2kbEyIJwnNDll5tebz0foRdtH0WKTUMTS5lgqSczScNm/RdG2ND8i5zMdQge2luTkZnvqgz48Fp2sPgcQpwrO9QazSOa+UfIVmJQSr7A6RYtlTaicLawhvYNZtu7UMlLr6qekh/5HJOvBvNiD+6QGZm9ADJnTQqK7oqSYJ+Xm0FWAt6C6sSCEQCxjWd6EskJo95RQmCehM6fTLh+9wPJyrwB8Zx4jjd61pr1mhNWxS8tv6781OH6b2ER9CfLsQ71Lv/S+2rUNB8GbQvD+LaUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0uxi3lxg7YH4gdJ+vF21TB1yx/W5WQ289WZv4whEnkw=; b=nC5TDQHQ60ftj56qQyTg/dEdot6v0QY5X3zwibSQf/QMOgOnjgyRKb0whClu3bA2Q5e6HqNCyf0WAS67OAC5TDvyYb/6rlecrtz2HxFw7Vf1tSEDk5hFKyx294k/uyaGv9hI/OQnKrU+RBxsXkKO3LC00vFYgweJD5vruZGOs0VK3kVbvArHV57cgB8c91V9BRrgy6pm9iHcZs0dKAIiWY92BZRcDmFQ6Y/chpruqpYwfOjbBw/7Y0ISonT3PciTTpsSpK4fMIoJ7YOUbWnNZ0Nyv/xv52jFJ0R6rp36cl9OUU54ltA83+Ygb5X0UsTv7T1ptVNvFfabHknnjT9oqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0uxi3lxg7YH4gdJ+vF21TB1yx/W5WQ289WZv4whEnkw=; b=MgwoseRqqOFM8XbFi8dQFZP406yIg/TYKmLVkX7ZKbcuufeIBOvR1RxzhhmVlTj8sbLTCaTgksIXVHk9/uwUjpzTi/nGoVY4ChwMCQX7ND0mT618XmiRJsfu4VSiM9RSq4DxUcJwqpqvDq4NO8gAkCakcA8tfQS6cEeyDCb/fV8= Received: from AM5PR0802MB2465.eurprd08.prod.outlook.com (2603:10a6:203:9f::22) by AM5PR0801MB2050.eurprd08.prod.outlook.com (2603:10a6:203:49::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.22; Thu, 8 Jul 2021 09:21:47 +0000 Received: from AM5PR0802MB2465.eurprd08.prod.outlook.com ([fe80::3d12:4220:b215:7c52]) by AM5PR0802MB2465.eurprd08.prod.outlook.com ([fe80::3d12:4220:b215:7c52%8]) with mapi id 15.20.4287.033; Thu, 8 Jul 2021 09:21:47 +0000 From: Ruifeng Wang To: "thomas@monjalon.net" , Jerin Jacob CC: Bruce Richardson , Jan Viktorin , "jerinj@marvell.com" , "dev@dpdk.org" , "david.marchand@redhat.com" , nd , Honnappa Nagarahalli , nd Thread-Topic: [dpdk-dev] [PATCH v4 3/3] build: add option to enable wait until equal Thread-Index: AQHXcvPXburXgDEBSEStpthyo1iRkKs3DbWAgAAC03CAAGBfgIAAAqsAgAEimLCAAAnfAIAAEQCAgAAdHZA= Date: Thu, 8 Jul 2021 09:21:47 +0000 Message-ID: References: <20200424070741.16619-1-gavin.hu@arm.com> <4337273.iQpEcjLWDA@thomas> In-Reply-To: <4337273.iQpEcjLWDA@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 89E3027FAD0DA34F88BE259463C11C61.0 x-checkrecipientchecked: true Authentication-Results-Original: monjalon.net; dkim=none (message not signed) header.d=none; monjalon.net; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 2bbb41c0-13d3-4f72-7e97-08d941f1dcfa x-ms-traffictypediagnostic: AM5PR0801MB2050:|AS8PR08MB6726: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GhA0Y1w2u12LnT1PVrlrZltHBZNR8j63hxOh3minh2qIGg6m2kqWkQhCOCTxHoifOTOm6xBghlwBbG740BRQWi4l6KYUepqgs6ltEoT2BKoyNoxxcvWp64v8fE294lmxVOU2lblrp+SZOK9ifmFDHKeWySiEvi/7Qgew/58pI0WnJGfAinuLuMdWbBEFu2tPyfRUlmPbBUgiJ0gvKpGd/5KNMLGYZEw05HJ5ZtDA7ZmQ99Lk2HQ1LsXObsQ1gAB78QPpsvlpb1uow8Z3rO2FV9RY79Ig2mHiGiMDwATAcA5gGl3vWL0157fy99ce0Ycbm6Y/pKLVJfR/AnoNZIH6KA5fM4NjZskNBXFCoaYVX0HWfdt8h9ea0eieBaoULvvsOxUIYbZHTQqC7m5Rm5X3pc/5R6C0s2gIonbvWm/F9XJ3UHKgwz0raFBxJ9WwEX3Yugq1IdAuh2v+CckDNYpIwg2LWbOcHCoXwH0FVTz/c4jYTlUN0NZsAvp2j2O+ZWDYxo5Exy37WxZNVlYPB1ev086+Qj3EhzfOqT5SP9hOsI4117ZQ3fUnhovvtM8iBqa2ygH1LX1gF24clN+3lTX7G3rHtWJu0W+dWn+ORcv1TA7Fw+/CLQUo6z6cdbBXDVmDi8+Q+lUln0mV8+oHfAqi/Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM5PR0802MB2465.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(346002)(39850400004)(376002)(396003)(66946007)(76116006)(66476007)(478600001)(66556008)(64756008)(66446008)(33656002)(9686003)(186003)(4326008)(52536014)(38100700002)(86362001)(122000001)(26005)(5660300002)(71200400001)(83380400001)(7696005)(2906002)(8676002)(6506007)(110136005)(54906003)(55016002)(53546011)(316002)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LploxPdRlwxhXN1qjqsiF/9MuYwHQTYhenDVSSCumotz9rTfop8De1jndUd3?= =?us-ascii?Q?HfkLwbRsbDFdtnVkpRa2onGE7zNdTh+/T6C6NAPMzIlnKdgjCNS3GSn3DDNd?= =?us-ascii?Q?Xrg2veNXJNDUc0z/Oq6Evh2viN+JELzPnrs3gYMAV1iwiwM8jSJr7wqCozc5?= =?us-ascii?Q?kHWmkXhRvhAsFr+Um5sHe6O6D/oOzD7cezF24MEIH6tVwPzkSqZ0LWW3ipvH?= =?us-ascii?Q?BuaNC+0JNihGyXCzsbEFiW0hqGyavEjElcErc+jBOj0xoxIvuqSIdfgTxOHy?= =?us-ascii?Q?ZDppbl5YtzTwFcRf2++fYAFrFb8DR9U6jWaulPj3uk0XP4o5RHDB4Cru80Pc?= =?us-ascii?Q?NM9yKuyiJTZJ/l5sc4m38fq9ixvl6GWaoq4hYJSkiW0/njgw/nEsLaorda/G?= =?us-ascii?Q?KQf8P0Jpuwlv1yOdJqrVYiDaWW7Sx4TWu1TopX99a6zoEK7EFBw/5YJa5Y5i?= =?us-ascii?Q?gU1ZFrIoSvbJsd9X/hiiaB/Vd5Bmw9d4TQwHu0dw2q6/pLeZ4fvSQ02+4qCH?= =?us-ascii?Q?oUAXFUf75pF3E78H3gM5VN/JV4ge6mnF9RgL67wGJizXXXU78HFHA/wBDAgY?= =?us-ascii?Q?WX8YTIyMMQ1XFqrJyb6N5leJNLZ8gIk4qOdXElRKvravK31HtWrwvAF11b8g?= =?us-ascii?Q?JmxPMfwJeg0XWqU8IbbYWGXnH9FxGpZnb7BMTbGdIC7DR2vMXz9JSLYQQyth?= =?us-ascii?Q?C8wA9AmGUL/qte9Z9kFrRy5FmN7aiiySX96QrILtkvc2j+V6giep3fV5wSvW?= =?us-ascii?Q?irDK7LkEo45qUjGiuzQ26jOsPmhXd17yCaYs32xWpmTH/B2XAV9KvWmSv/VL?= =?us-ascii?Q?VyLplhVsNGfoVdBUMtQdUvOctyYC28gB+io68D+TGPm16DCYYU0guWbUSwzQ?= =?us-ascii?Q?ivOyZV3q0wChs7IS9K2nBODMP2X8V7ngVjtn22bo9TiyfVv3etBE4L7sHO4P?= =?us-ascii?Q?vOXhB1jzciTnU2dAr1uyD2bkacLu0GPj1UgfDYPSPqbbeUORPmFEA8jG0RsI?= =?us-ascii?Q?PIMNY9dzYww5QCIz7NccDLGFSfjAngek9BWSeyL7rNMI/VsQnXhvmAgIqSr7?= =?us-ascii?Q?ZrdtKAiE09Wl5ru74YMprpmRSwPvAFZt9ynhDpXa5P7dafPzvTTau79iiYEt?= =?us-ascii?Q?XZ8C619CtP6v+apWvuLVglwH+ddtBVZF6sULqkB9b8NqKFedWqRBhEMfuR+m?= =?us-ascii?Q?ODcViOX1xnNPIr9HOyHuZeJlLyvxCA+7mhI+oxj0PfADc1jc95c0R2LgNrti?= =?us-ascii?Q?XNQh2XpOKM8zE1Wofz1x9FnqoQlqBKjiAkHbulqpAfvUcB06XoR6mdH66bfA?= =?us-ascii?Q?R06XVOnqefPkMNOkW2B3WbTE?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB2050 Original-Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none; monjalon.net; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a0b09e28-6fb9-40cc-97c7-08d941f1cfc3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lEiu7DeciVcBSlNdasD/06shUctQ7QPSMY8QSrU1mLe+7xN1WIVz6EIYqujRWXk74o0UaGsFCC2VFVWn9qX3HIh9wwxgWcw+X6g+YjlUaEwXgplCW9R3apGpFxTExpTxaEF/GkJ137F7kVq7CEFiHDpO4r+SaJOAiR37N7CZiGCJPnqiR+SB/fatTHuy3CN0wyiEXrJqGIYp2w7NBptKIb5Lua0EHYaYxFH5mL2I0uziFoDym2P4UL8vWvMX8wi9Bzsp8paqIojF3+eYk1/5RP8qAuGnHfxwQju3OFRsWT5bJBBz6A375r9YjogJUdsrzxfaPPUbAdMivC3Gxk8xpHzW2VqzGZv8U7J9QvZb/gCceneQzDtKddBDIPmko8h73xPUnTk53c60e8sB1/DFp339R4uCFvksOFO0keEVO5erweEHSwZRTr9fH3DB9KokFzkbiUg+xiXEwnnvYORbnGC6xPVIbPfa1HbZ8df1AOqkY20PmN1/j47g3paVxCiT5ZmdFygaGv857KDcJvjXkm3688FvNrAG9NtyIE71yGfYuVcmnrWbCjQIaV5WW7f8xHSHC+syZs/v10I/GfGgpgvtesrs73l8GSI2XX4deHPsNyJdVEIbpTLhnoqi0C5zxjWVXLJSli9wS6I/SYjzGelJ03lQ2XK0cGvhIeoWe2WK/6KFYJlawqXrBW2lzj6c5BMxtDQcUBsSU2g4yoOuxw== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(346002)(136003)(376002)(39850400004)(396003)(46966006)(36840700001)(36860700001)(8676002)(186003)(356005)(53546011)(33656002)(82310400003)(86362001)(52536014)(82740400003)(478600001)(316002)(110136005)(6506007)(47076005)(26005)(9686003)(83380400001)(8936002)(4326008)(70586007)(54906003)(7696005)(55016002)(5660300002)(81166007)(70206006)(2906002)(336012); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2021 09:22:09.8744 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2bbb41c0-13d3-4f72-7e97-08d941f1dcfa X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6726 Subject: Re: [dpdk-dev] [PATCH v4 3/3] build: add option to enable wait until equal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, July 8, 2021 3:33 PM > To: Ruifeng Wang ; Jerin Jacob > > Cc: Bruce Richardson ; Jan Viktorin > ; jerinj@marvell.com; dev@dpdk.org; > david.marchand@redhat.com; nd ; Honnappa Nagarahalli > > Subject: Re: [dpdk-dev] [PATCH v4 3/3] build: add option to enable wait u= ntil > equal >=20 > 08/07/2021 08:32, Jerin Jacob: > > On Thu, Jul 8, 2021 at 11:55 AM Ruifeng Wang > wrote: > > > From: Jerin Jacob > > > > On Wed, Jul 7, 2021 at 5:57 PM Bruce Richardson > > > > wrote: > > > > > On Wed, Jul 07, 2021 at 06:46:33AM +0000, Ruifeng Wang wrote: > > > > > > From: Thomas Monjalon > > > > > > > 07/07/2021 07:48, Ruifeng Wang: > > > > > > > > Introduce a meson option 'use_wfe' to select wait until equ= al > method. > > > > > > > > The default is disable. Traditional polling loop is used. > > > > > > > > When enabled, architecture specific mechanism is relied on > > > > > > > > to do the wait. > > > > > > > > > > > > > > Why do we need an option? > > > > > > > Can it be automatic to enable it when supported? > > > > > > > > > > > > > The problem is inconsistency in performance on different Arm > platforms. > > > > We had decided that each platform needs to enable it after some > testing. > > > > > > > > > > > Can that not be done via variables in the cross-file for the > > > > > builds, or via automatic detection if it's a native build? Is it > > > > > likely that individual users of DPDK will be knowledgable enough > > > > > to use this option > > > > correctly? > > > > > > > > +1 to add this in cross-file instead of the top of config option > > > > +as > > > > scope if is only for arm64 builds. > > > > > > Currently this option is in config/arm/meson.build (flags_common). > > > SoCs can build with this option enabled/disabled. And the ability is > > > available for both native build and cross build as cross build also g= oes > through meson.build. > > > If a SoC needs to enable the option by default, an entry and be added= to > the SoC flags. > > > > > > The key difference here is whether this option need to be exposed to > the top level config. > > > > In the view of limiting top-level config options and it is specific to > > Arm, I think, it better to be a cross file only option. >=20 > +1, sorry for the late notice. > I would advocate to take this patch in 21.08-rc2. >=20 If the decision is not to expose this option in top-level config, we can ju= st drop 3/3 patch. Do I need to send a new version?