Re: [dpdk-dev] [PATCH v2] config/arm: add Qualcomm Centriq 2400 part number

[Ruifeng Wang <Ruifeng.Wang@arm.com>]

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, June 17, 2021 3:07 PM
> To: jerinj@marvell.com; Ruifeng Wang <Ruifeng.Wang@arm.com>;
> Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Cc: dev@dpdk.org; Thierry Herbelot <thierry.herbelot@6wind.com>; Juraj
> Linkeš <juraj.linkes@pantheon.tech>
> Subject: Re: [dpdk-dev] [PATCH v2] config/arm: add Qualcomm Centriq 2400
> part number
> 
> 25/05/2021 10:24, Thierry Herbelot:
> > 0xc00 is for "SoC 2.0" Qualcom Centriq servers.
> > 0x800 is for "SoC 1.1".
> >
> > Cc: Jerin Jacob <jerinj@marvell.com>
> > Cc: Ruifeng Wang <ruifeng.wang@arm.com>
> > Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>
> >
> > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > --
> > V2: add maintainers as Cc
> > ---
> > --- a/config/arm/meson.build
> > +++ b/config/arm/meson.build
> > @@ -226,6 +226,7 @@ soc_bluefield = {
> >  soc_centriq2400 = {
> >      'description': 'Qualcomm Centriq 2400',
> >      'implementer': '0x51',
> > +    'part_number': '0x800',
To add support for a new part number, I think it should be added to implementer_qualcomm.
If cross compile for the new soc is needed, it needs a new soc_xx block. I'm wondering this is a real request? I assume SoC 1.0 will have no config difference from SoC 2.0.

Thanks.
> >      'part_number': '0xc00',
> >      'numa': false
> >  }
> 
> Any comment or ack?
>