Re: [dpdk-dev] [PATCH v4 1/2] config/arm: split march cfg into arch and features

[Ruifeng Wang <Ruifeng.Wang@arm.com>]

> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: Tuesday, August 17, 2021 6:57 PM
> To: thomas@monjalon.net; david.marchand@redhat.com;
> bruce.richardson@intel.com; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; fengchengwen@huawei.com;
> ferruh.yigit@intel.com; jerinjacobk@gmail.com; jerinj@marvell.com;
> pbhagavatula@marvell.com
> Cc: dev@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>
> Subject: [PATCH v4 1/2] config/arm: split march cfg into arch and features
> 
> Older compilers may not support all arch versions and all features that the
> target SoC supports, in which case it's better to figure out the highest arch
> version and features that the compiler supports. Implement a way to achieve
> this:
> 1. Find the highest arch version that the compiler supports, keeping in mind
> the SoC arch version we're building. For example, if the SoC arch version is
> arm8.2-a, but the compiler only supports arm8.1-a, use arm8.1-a. On the
> other hand, if the compiler supports arm8.3-a (or higher), use armv8.2-a.
> 2. With the architecture version locked, iterate over SoC features and use all
> that are supported.
> 
> In all cases, emit a warning if there's something unsupported by the compiler.
> 
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
> v4: rebase
> ---
>  config/arm/meson.build | 124 ++++++++++++++++++++++++++++++++-----
> ----
>  1 file changed, 99 insertions(+), 25 deletions(-)
> 

Looks good to me.
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>