From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39C1BA0547; Thu, 29 Apr 2021 16:35:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE52F410DD; Thu, 29 Apr 2021 16:35:58 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140057.outbound.protection.outlook.com [40.107.14.57]) by mails.dpdk.org (Postfix) with ESMTP id CAA2B406FF for ; Thu, 29 Apr 2021 16:35:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Y1CrQF8QPbG0xNsb9x2gbVu2UiF/1R5EjuIngkSAco=; b=WI+rX4FHMYSoEFMsWMQItGb9xw6Of6JkW4kRQAg9ou5P8Z95ygccznGSheWE1FZeNh28wd/fKH/ZzQa6AgXPzVrBlONqyA73LM3oDKZY8iRw3oj7MLJyokUuRWKu1xdBWyelwgjs5uCobjGs4YA64AZ6R4ALSGFIpX29h6TDho0= Received: from DB3PR06CA0029.eurprd06.prod.outlook.com (2603:10a6:8:1::42) by AM0PR08MB3636.eurprd08.prod.outlook.com (2603:10a6:208:d4::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.23; Thu, 29 Apr 2021 14:35:48 +0000 Received: from DB5EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:1:cafe::cd) by DB3PR06CA0029.outlook.office365.com (2603:10a6:8:1::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.27 via Frontend Transport; Thu, 29 Apr 2021 14:35:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT064.mail.protection.outlook.com (10.152.21.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21 via Frontend Transport; Thu, 29 Apr 2021 14:35:48 +0000 Received: ("Tessian outbound 1e34f83e4964:v91"); Thu, 29 Apr 2021 14:35:48 +0000 X-CR-MTA-TID: 64aa7808 Received: from e274acf39d8d.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 30AA43DC-F2A0-4BC7-9D3D-14740AA6A4B5.1; Thu, 29 Apr 2021 14:35:37 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e274acf39d8d.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 29 Apr 2021 14:35:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bb7cB98moJLrx6v9OBrnEuGQfof26ZrZVAdhc+kFxARDUjHMFi4T315faqarpCozQzMxUDMT6WgUsHCWecvaK83ER5n5nhKU5uhukwJ5OZwGTi7MITpkOVbzsxnmzOr+5TUDECPso1jTJLIK2xvn67uLGfqXJsKUK5Am2BZeWpRHjoeWBnVGpKA5BKdS5kXESJOc1COg5FsFTf4Lz7Fdbz0WXoDCyfycPKQQdVLLwU4Ls1unf/MyVpCRPr0sdIginQ2YkBoOdrXdhuNftQKMbGkDJ/KNcxjfQ1pbd8pq/CITmD7FdQhEDtC9WtOczEAx1qrQ55+RxNbaXa3Q06F+NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Y1CrQF8QPbG0xNsb9x2gbVu2UiF/1R5EjuIngkSAco=; b=ZcOFfmh+Aokubwl7yhc0Vk1RD5aszaoyg3frENHUWPMBkhH3uifu0WfHysWO1eTcXv9zWD0NPDuS6Tpvk3creYE893O4TTtgtNn+8bZOteMezM/SiH4Ky8uWj5c+joC6FYa8QnR7pmTvZI+oRbldn8qW2u8AZdy7GEoUwaw+Wyo8pIe8Pu61mQ2XF1A2HAZI5uaHznvXaANEnp4XjnTQddB+bhAMqFM0kv7e249OWG9xYaifpjaS69ewlRSKwx90u7U9Hzdjw3PlS0+S2BK/UpqBWn/cOqwIloKniKyytpNzcZRw9HjDB2RCkLKC06iecm8hyzb6rs4l+FZtkh5R9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Y1CrQF8QPbG0xNsb9x2gbVu2UiF/1R5EjuIngkSAco=; b=WI+rX4FHMYSoEFMsWMQItGb9xw6Of6JkW4kRQAg9ou5P8Z95ygccznGSheWE1FZeNh28wd/fKH/ZzQa6AgXPzVrBlONqyA73LM3oDKZY8iRw3oj7MLJyokUuRWKu1xdBWyelwgjs5uCobjGs4YA64AZ6R4ALSGFIpX29h6TDho0= Received: from AM5PR0802MB2465.eurprd08.prod.outlook.com (2603:10a6:203:9f::22) by AM5PR0801MB1668.eurprd08.prod.outlook.com (2603:10a6:203:3c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Thu, 29 Apr 2021 14:35:35 +0000 Received: from AM5PR0802MB2465.eurprd08.prod.outlook.com ([fe80::e890:2ff8:8cdf:83b2]) by AM5PR0802MB2465.eurprd08.prod.outlook.com ([fe80::e890:2ff8:8cdf:83b2%4]) with mapi id 15.20.4065.026; Thu, 29 Apr 2021 14:35:35 +0000 From: Ruifeng Wang To: Stephen Hemminger CC: Honnappa Nagarahalli , Konstantin Ananyev , "dev@dpdk.org" , "david.marchand@redhat.com" , "thomas@monjalon.net" , "jerinj@marvell.com" , nd , Gavin Hu , Steve Capper , Ola Liljedahl , nd Thread-Topic: [dpdk-dev] [PATCH v3 2/2] ring: use wfe to wait for ring tail update on aarch64 Thread-Index: AQHXOZfwCrxIHsV030K/xbjEcGn+KqrKMXkAgAFjbcA= Date: Thu, 29 Apr 2021 14:35:35 +0000 Message-ID: References: <20200424070741.16619-1-gavin.hu@arm.com> <20210425055653.1509261-1-ruifeng.wang@arm.com> <20210425055653.1509261-3-ruifeng.wang@arm.com> <20210428101714.2e5da560@hermes.local> In-Reply-To: <20210428101714.2e5da560@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A3C71D984FF0884B8AA8E82052885B4A.0 x-checkrecipientchecked: true Authentication-Results-Original: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [101.80.29.169] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: c00052fc-432a-41ce-11d0-08d90b1c14d5 x-ms-traffictypediagnostic: AM5PR0801MB1668:|AM0PR08MB3636: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:4714;OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LZiZJsd2576ADAqXfoEi42us/HIMQa8Ybvki1mEU/TVgoIGPePECH8jrx497YCbmVVfXdEeG7HJjhq+dIkkZ7UWPAqbVbsKzkaj5oHgwi3+4jWR/Rg4giFzppL10XuxEDPDGUCIXA1lTpMdpjOhes/8J64f6vY0TGgQnv1q1ObbRSsBe3O8vAxkCZOVOdcLK/PAk/EUXiku1qTcv590JeYHQy7JL+S2iK11SIK+Ive8e2RWRV6Ne+xlOTci5a4pn9ORZS4xOM1kvwKq788SnaXpfatRxbhKlghk0grlU/uQyFRNly2DBsnzSzhR+0oGJQkBmtu0j3IEfZo3oKQ5GLljGrj0dObwQCxBU7MgadNm0A9nqQRUNZcfkhrB/KOPaZ8Fgk+hWggqVd99VBhk3S8E1HaYHLHJNLTL8xAkdld5/bfwxDUvuiy1yofE0m1bwKcaUdImxWzE0zahPIFhhg7m4vqSnlOyNMsZVDsZGVkPlvkTfASa5xiBzdp1vbq6ChoBb+4Q+8rOXvOJUM/lpRSMmlmwALt27kyrUGYtL4yeebzyYLnwk9INq8GMyHIyqR24ZZIaoA9dCGBGRA6nC0+fuFFFj50LtkBTu9MHbXl79IlQrZb+Ke+ow5ohlLhRWu8OsOJigteXB1VDoWy2KFg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM5PR0802MB2465.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(136003)(396003)(346002)(376002)(54906003)(83380400001)(66446008)(122000001)(33656002)(26005)(6916009)(66556008)(55016002)(38100700002)(8676002)(316002)(15650500001)(7696005)(4326008)(64756008)(186003)(478600001)(66946007)(76116006)(53546011)(8936002)(66476007)(6506007)(86362001)(2906002)(9686003)(5660300002)(71200400001)(52536014)(21314003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?yZf3cxhvsJ1ksAZwdddcFO9m/NFnIekESrE458prlwUfGhTRqjTHqlskPrzI?= =?us-ascii?Q?GqGev/DCsIUAMjeqH48s2WqTlmtlz8UUFYaWlR5jMWr8QWlswz0RhUgff5Mo?= =?us-ascii?Q?aOOtPzTSdRcSdWHGrUx4qiA1JHQKm9cz5m82xH+xGkN5RCq0l5jVgsZYQxHT?= =?us-ascii?Q?0YpkeS/UDD65oP3GUszoWjMa+JWelkyrqrlU+gZEUbKhHiAp4DRWuU8e68U+?= =?us-ascii?Q?v7peC1+o3VsgXkGXhtSQIYtu1xorC9hpEoND4RxyFaG9Ck6gNHDf1uR+KKZV?= =?us-ascii?Q?CCl2EQLfTkiWxdAlntj9+gKwfiSVPYqQBu10TyYA//+SRwlnwA/7BxvBkvY7?= =?us-ascii?Q?ANZ0BAtwmK7+ndZgDn90TPFY82oQS6R9ev3NV3KhPcC3zZmZPg5nC+1Ur8g4?= =?us-ascii?Q?oepnEJyudF11dfYPjXISr09Bb2prqvB9+YI6cW6pO4jFhJNV7d9atzTkbmXi?= =?us-ascii?Q?qUsjxwLS/6+bwwfokicbmTPGNi2LItfPYqvgQ8vvu6Td+txLQvjYc4WeHkt2?= =?us-ascii?Q?NniWD8NKCTAgL5s8Wa/4fG75FJpjq9+7hvzrq5BaPncPcV1xiBM51dSK9oa0?= =?us-ascii?Q?fWbvPFC8vMocJzPsJD9TEjsjdDU3F6sxhHo+TULt8nYFBu5MZSPNDV1D493R?= =?us-ascii?Q?ezNh4YVQWMqsu6X9/mwC8XRyMybku8j9lZ+Iz5kLkvK1HaxxTgElOMbo15gr?= =?us-ascii?Q?9F3Iwi4x+qRna0LkLDC1AgFCu1icYXi1hcEsEPLn0MSpy5Vc97ckVqXnqwTJ?= =?us-ascii?Q?ayo+iFe/PRZLgukJyhyLOyIHlvDdRRKRiQ14uI7Lp7T5LHv/HWL+uofb1J+q?= =?us-ascii?Q?/eR3CZNgzujrh5CFGw+ovjhMknM6AgpR9Tgi+OVOLDd6CxvSIGJSNTj6HQMY?= =?us-ascii?Q?8zxF42GUZHWxLGCCkr6WY7GbX7AAXcSFryHoXTVCTbkj5/7jjeyWf5EXG0UC?= =?us-ascii?Q?fRx7uFyy+gbi+QZNKTNtHuHQgvJA03un1J7tqfyggBfudmQl6IlPy876sv/+?= =?us-ascii?Q?Dr5lwrZ9r7ozhyu5eNBH1Gfzwm7TqPf2GeFhowd/1VfKvWZ7jUMOKg5TzLYI?= =?us-ascii?Q?wFOgiDiYa+9HJEHtdPufyrwvw1XIJ0lhG2xNGSRwf0dhaeP+K5hzAahYYQbN?= =?us-ascii?Q?Gz/lx++AUoz23k4rNdEC8+mqGpxCnUAlRECr4nzy8tzItevr6o+oUb/9SOYG?= =?us-ascii?Q?wq3X8JO6khSPEvvy9nKStiGQBHqK27ONBUZueOf3hcBf0ZGHaSf56dhzZ9lE?= =?us-ascii?Q?bz7/MxWQEqz/M0LSRSDHnj0h91KQVcnNezNiRSnhGL3s20dp1dUcdgTRU0AL?= =?us-ascii?Q?5ofjj3OfXwYgbydMLPnyupti?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1668 Original-Authentication-Results: networkplumber.org; dkim=none (message not signed) header.d=none; networkplumber.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 8ed22f27-315c-44b9-7a50-08d90b1c0d2a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mOfxbCYT4eh6f8yfxsWebRcy5024viaDUULR4fMOrJgtFaDFWqz2SatYeR7hcjgUY+pIIm6w4+BERFmS0Kf8DFmc4ptZbUmG0A6ZIOWXzxyMs5nCd7T4wMgHzxE/mBfE1xtzZIAwZX+PHwh1w+hDC+zyiDL3LVf9XkhEmoOKAW1lTMn7aGdOaZ+XsX1QVJidKg/6KORvZy+hAKK3RAycBcyxrhMhOlNfC/rPyfdJl7AB+N0oGkfMrwIHLIYOU0S2u2wVXjBPJQjf0BkGqxLBuvDMQu7Bm2OAKq7DzEgYwBXW8NiAzU5ojE5Xmroz1z8I/vUlSpMtste8n7pQZJUNi2Q+Rf84P+8WNmz/R0GP1UxOCd/cqu87DD0Xo+J+xGfvu0sc5+GM0AAUdmYyR+lZJcINVAd60tZbYKre4G+UDfDSHTgjzE7Wln0FeOCHsVxSEAU144ydtuNgJOpeDgPlnWfUXdRcjfWegNP94HgyxkYfpFFs9+b3kFFN4Y/Groym9wMAjF9eye9/u4loOHCyOeERa8qH9dISVWy3RZq3KQv0u1W3qd09uG9AzsJxAmJ3mirHRuIxU0jw3pjOoExMnQD33QleVa49173NOA8Pwcj1KX1ac3b5VAcl2eqzuD5hSiYBqavFDOkhHSnTrxMs/EpbzEUMsh+gpxND2KBo3guXZ/rO1uRmTnXyCvDMz3z1QAsJciYs9tS2fGkX4c68Zw== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39860400002)(136003)(346002)(376002)(396003)(46966006)(36840700001)(316002)(54906003)(52536014)(55016002)(83380400001)(186003)(6862004)(82740400003)(5660300002)(336012)(2906002)(8676002)(70206006)(9686003)(15650500001)(33656002)(26005)(478600001)(6506007)(53546011)(81166007)(36860700001)(82310400003)(4326008)(86362001)(356005)(34020700004)(7696005)(8936002)(70586007)(47076005)(21314003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 14:35:48.5983 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c00052fc-432a-41ce-11d0-08d90b1c14d5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3636 Subject: Re: [dpdk-dev] [PATCH v3 2/2] ring: use wfe to wait for ring tail update on aarch64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Stephen Hemminger > Sent: Thursday, April 29, 2021 1:17 AM > To: Ruifeng Wang > Cc: Honnappa Nagarahalli ; Konstantin > Ananyev ; dev@dpdk.org; > david.marchand@redhat.com; thomas@monjalon.net; jerinj@marvell.com; > nd ; Gavin Hu ; Steve Capper > ; Ola Liljedahl > Subject: Re: [dpdk-dev] [PATCH v3 2/2] ring: use wfe to wait for ring tai= l > update on aarch64 >=20 > On Sun, 25 Apr 2021 05:56:53 +0000 > Ruifeng Wang wrote: >=20 > > Instead of polling for tail to be updated, use wfe instruction. > > > > Signed-off-by: Gavin Hu > > Signed-off-by: Ruifeng Wang > > Reviewed-by: Steve Capper > > Reviewed-by: Ola Liljedahl > > Reviewed-by: Honnappa Nagarahalli > > Acked-by: Konstantin Ananyev >=20 > Looks ok to me, but it does raise an interesting question. > Shouldn't the original code have been using atomic load to look at ht->ta= il. >=20 > This another place where "volatile considered harmful" applies. Do you mean 'volatile' should be removed from rte_wait_until_equal_xxx para= meters?