From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB1F3A0A0C; Fri, 2 Jul 2021 12:30:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7316A41353; Fri, 2 Jul 2021 12:30:23 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20070.outbound.protection.outlook.com [40.107.2.70]) by mails.dpdk.org (Postfix) with ESMTP id C059440686; Fri, 2 Jul 2021 12:30:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ApuG5dgPb+spiYSkNK5JwXo1zNQNhyhACjBraTzwiRQ=; b=a5rTT+pdkXyqkPktfizCFQHR8JeVSW/MAXhdadL1JZ7UvKc1ylHrZWs9ylxcsK19N/GQ91MypfCKZIGG9zUrwUQS4I9LWzZUvoxxjyA++vyQCLt1hEVEvXGPBDdqKv8ShQXP9Fjq0fAV7C6ZyUJIcbYDPjivsuhBJuEfBy81FVk= Received: from DB6PR0802CA0044.eurprd08.prod.outlook.com (2603:10a6:4:a3::30) by AM6PR08MB3032.eurprd08.prod.outlook.com (2603:10a6:209:43::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.19; Fri, 2 Jul 2021 10:30:19 +0000 Received: from DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a3:cafe::e9) by DB6PR0802CA0044.outlook.office365.com (2603:10a6:4:a3::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.21 via Frontend Transport; Fri, 2 Jul 2021 10:30:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT038.mail.protection.outlook.com (10.152.21.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Fri, 2 Jul 2021 10:30:19 +0000 Received: ("Tessian outbound c836dc7aad98:v97"); Fri, 02 Jul 2021 10:30:19 +0000 X-CR-MTA-TID: 64aa7808 Received: from 404b4db795f7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F1DA1E71-404B-41A1-8025-ADD4DD45D5C5.1; Fri, 02 Jul 2021 10:30:09 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 404b4db795f7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Jul 2021 10:30:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AZav2d9ly4+douQ+gyG869NFoHxfFtoGgSA1WiWSt9NRUS7O1YulQ5HkQfMbqEV0D1ZlkCyReMS0KMxfRAmTaJDrQyVoiKxjAYlXWNiyEYH0Ss55XGBgLgiQXzZhhV81xtlpBBUicQArASTXatGAayX1l5YbYZIQL6wYwK+wB7hKtmd+NdPZjJ14Q/l9aamxG1jGfgdZzjQjAGUqzdz7EwTtJhMTKv2tEYfxzUZQBSFFk4egjvp0fOUEqlzGfJSK2Vmd3SQ3dhZ8irFpBjSryA94C81qI99ZxbTDfLAjTQlFB+3xRYBNzHArqBAK1istK/38HqQ8Mx5ZfJqgwvNG4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ApuG5dgPb+spiYSkNK5JwXo1zNQNhyhACjBraTzwiRQ=; b=VcEQZWTDCmHGD2AqsdTioZVLwmEpHxoRiHydMf3bCb8c1HwcFkBIIW2iC3nbfwkMEjzk2MpV79jWArCUIb+k+Wmu91JLCzTgXACty/NKLKW+4DvVEaT8WDBCF0FizWXGbDzEXn2OUdO9fttmDmeZaoaoEyybNT/q2MRXKdZvkrvIXliPj9gsk/TwzAt2eQwlg9rrMgBow8Jn3ejFTwvIXfbSPr8Mz8H3cl5725APRaJdLxah7Rp4nzaz1Ibi/ddfm7JB5D1Kzd6vzzRHDQQq+FnKuGVl5Zuu3fCRt8+Wrv/HjWxAVSAKJV3s6Rgibb9RST6xT09TMtS0BD0QSbCx5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ApuG5dgPb+spiYSkNK5JwXo1zNQNhyhACjBraTzwiRQ=; b=a5rTT+pdkXyqkPktfizCFQHR8JeVSW/MAXhdadL1JZ7UvKc1ylHrZWs9ylxcsK19N/GQ91MypfCKZIGG9zUrwUQS4I9LWzZUvoxxjyA++vyQCLt1hEVEvXGPBDdqKv8ShQXP9Fjq0fAV7C6ZyUJIcbYDPjivsuhBJuEfBy81FVk= Received: from AM5PR0802MB2465.eurprd08.prod.outlook.com (2603:10a6:203:9f::22) by AM6PR08MB4756.eurprd08.prod.outlook.com (2603:10a6:20b:cd::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.27; Fri, 2 Jul 2021 10:30:07 +0000 Received: from AM5PR0802MB2465.eurprd08.prod.outlook.com ([fe80::3d12:4220:b215:7c52]) by AM5PR0802MB2465.eurprd08.prod.outlook.com ([fe80::3d12:4220:b215:7c52%8]) with mapi id 15.20.4264.027; Fri, 2 Jul 2021 10:30:06 +0000 From: Ruifeng Wang To: Slava Ovsiienko , Raslan Darawsheh , Matan Azrad , Shahaf Shuler CC: "dev@dpdk.org" , "jerinj@marvell.com" , nd , Honnappa Nagarahalli , "stable@dpdk.org" , nd Thread-Topic: [PATCH 1/2] net/mlx5: remove redundant operations Thread-Index: AQHXVsCfKjMCDul1q0iVGXgyniiX7asvhokAgAAfZUA= Date: Fri, 2 Jul 2021 10:30:06 +0000 Message-ID: References: <20210601083055.97261-1-ruifeng.wang@arm.com> <20210601083055.97261-2-ruifeng.wang@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 0DD8E27F06593544A8A042BF337F0CA3.0 x-checkrecipientchecked: true Authentication-Results-Original: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.112] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: feef3b96-14ca-4db6-36fb-08d93d44641e x-ms-traffictypediagnostic: AM6PR08MB4756:|AM6PR08MB3032: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jm3dudXCdAHwmi1ysx1gECVckAy/9ydMcT0F6FbqkInak3v3x9h9ENfEVkJNYaleWFAriwMsH4tJghzl0tucVIB82lNR0FbYKeAG/GGW7G76bN2qMtbFyPS4HZbuGCt6uV8JxwzS7/Sc13Bwr7YAtb1s3sBcztH9/pzNzU5sjRY5CuP/rXm+xwT/K3hwmPZOGWP7uijzAnJJli4v63lTSRc4Qh12ERw+nQh2Vte9TWM8TKRES2Iijb0msOwmYCpismYFm29VclMyCDTIT+YFuEJv0Nuxn/QpVWqg8d01Bw3BWI27aUiS9hkp1BpflGVrxRWKp0EJ/OKHEFxCsp00MafO7yefYUe4VDUAR+mUFjMoOD7OnWR7J9cAA53t/Unv61D+snwDZVNTY7LrTY9OBnPK+gEZGIntEDReegvN4Rdh5W4mR+HWkG+CWi+U+Yit2QtvOytCM7N+MRADkiIz+WVQTia6l2A654Iiwzm04JL6qFSe1KAN4B71NKTZJ16jNPFgy6hlATAkuil2R7a/ENqoeW7EC6AGoRqZVMm8EJIuIdKGFqdb1LUlmQPKw9yRMIVBv9YXuLiBdlg1gJY1d9bgUH7l5/Etyulen1wFpZx9vYCvQLQcFZV7Ld+P1PaxzL6QqX5UqECQ8Jh74+KtmA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM5PR0802MB2465.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(39860400002)(366004)(376002)(396003)(478600001)(186003)(66476007)(66556008)(66446008)(66946007)(76116006)(122000001)(4326008)(53546011)(83380400001)(6506007)(9686003)(26005)(33656002)(8936002)(110136005)(8676002)(52536014)(2906002)(55016002)(316002)(7696005)(38100700002)(54906003)(64756008)(5660300002)(86362001)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mKKlQvIQ9JxDEpgGyw0K3TDIT+YbhqCraNlW8ulFpgMT6LnV7KFJ/uE0gb4p?= =?us-ascii?Q?RfhHvuR6ObTUQNoa3L0ubM3Y90svPmJyHDiemC1YUpdq1C3POtNURF2MZGI5?= =?us-ascii?Q?763BJjO+pdhOs7n2XLCFIsnCvd/TEaStZ1BoCBDaancWM1uHb8EiMPC7d9em?= =?us-ascii?Q?YwXozky2sx01RP9gbjnU7fFYgloCvwuPmAxm37dPQT75hR9boaXd1ESpDHTS?= =?us-ascii?Q?xiefj17yv6Xbb8oZqLNlq3jBgCdGi9btnF0t80nQjhwUqCZNM7394ZpRqiV5?= =?us-ascii?Q?vMD7Cmv95YSriUaCxxGvyG6W5oDPc5Ckv3kzLMxZkkWqmowGwG0HDqIPySwR?= =?us-ascii?Q?QpSYfLYbZP7zqY+mvmWcLVG5Ln27WRafA092VEMYDQw4GfNpALPHYt2Q9xMS?= =?us-ascii?Q?3lel4ppk3GPJ6gaZzZ/NAuMfqcdP+N6+4RO3pJnt+glGGru4CZGiDa7RrriI?= =?us-ascii?Q?F3cCuUGvY5sYsv/8P5Mc90eKxCol5rjFCo32KSLaX4YNQKae7qEHLCJ7WnKU?= =?us-ascii?Q?3haPuFLtPZt1UbkqPxUNtiAvefww8xht0yRajDPhX60+cg1Era79pgHXBrOI?= =?us-ascii?Q?cnmEOq1MWdg02d8ByYJ3pabwV+IhEvP+g5vYzlfCYmiYImhQZ1768dJ00Aqz?= =?us-ascii?Q?WGvOBbIU2fWgTwdeb+L8gy4QnpIfs6sP6w0nPramkn3gmOOd6ReFG4Y7qS8E?= =?us-ascii?Q?+VueF6mIoHrNOa1FgbgPuAhHz3tkgCwg+7fwXuNdXzwVnBVJWvC3XmjMrlfa?= =?us-ascii?Q?kJJIU5/SoDmsQBUvu94EvDNaKVZ4PxG2cUdCqgtiDS1+lrr3ZiSRYb29QJ2P?= =?us-ascii?Q?fABZ5W2IqIl9BbZQXVa5DvRs5U0Ngp/vuX+NaLbA8GRGrcA5RyhHJE2KEQbA?= =?us-ascii?Q?s/rc/B5I7mR6e46sJnxTiWyps8Y9u+w9NXu85BF+OYLRPb9Fd866FnbDupRl?= =?us-ascii?Q?EGbHKHbD0WHETNLNakT3oF0DelpsggezLCwMpi+L9H/KIJRTF2FntaOY3nue?= =?us-ascii?Q?eUqm3JbMlqVc3qAUIW+kebUcK8oeCDknZbTTXRBogJtQGE0cT9ROB3alVCgV?= =?us-ascii?Q?5DkIPESRTg5KaCuVCbPX70MW84GB9YPB7sacUBS0Ezai9JeACCyJRYuDa8BD?= =?us-ascii?Q?OAF4xK4M3fEPnpxfIqs+bAyNoEkfW/QP13aINM6P0Fn9wHsryUlnAQ/Unx0V?= =?us-ascii?Q?3avOkIOWzfMHEQQcEOKx02Uo9aV1D2P0oJ2vyQQvp3C9wr4C2lYDxKj3mqSQ?= =?us-ascii?Q?WD6l2R8B30ITmS/iNbkh+hYlqUjoNyYxbLyND1leMs7/TmBOOVss7i76FMYV?= =?us-ascii?Q?UmsYvdzSthrI0Az4n5lmJ1p9?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4756 Original-Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d63e9191-89af-40cc-c5b2-08d93d445c94 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dPWqMPW4XFXrMuJmSaHA1RYwDsYYu26WHJUZ5EnxR5L7I98mLvoeRLxOaDnz2c7HSCVqemxr2I5SreCzuvZpb8hJBFF1uc14aV+NGhlggXunkGSfU+uBKu+5VAWNr+JIVDToH7W1QjUoCrpcfenwYwUcUzcABavbdOWsGpu63TvY6qQWQxr3df629dxTjbB4btbFaDAIaJqgiLK39KYu3pWyhs6vnrm5nEunE8WejkeeRJy+ApCbXtSoeYBUFimxOFPywlTsY5OCdnIwe3AfYskKkA8iMLQfla+cnmAA2D3on0KrdJWp9QkAeEGWMKEvxQ16ag9DgvefXQHYUQuCXYCMo0C9STKcXB7XlDJSPd3SbeImJKYePbblQfyAHKE/zq8iacUnHQ7M6n8srky/zMYgkkK5KZwFjsRTwYjiFtitSpfmQtomd/+LT9UOGV6RlAuwcbggUiiWgdTRpfUJVsJmaRlUbdCsXXMtGEe73V49nFjlhOaz5pRRcUpLR93HV0ftuEYsRYvF4oeoE/m0SHfYvyYXAyqx14TX4YGdi0FK9tgJ2iSAk9+1+D5zNyMmHzWJOaEUo4T7PZqONN6rhK+LasYGuTqEmY8+m0WuLW1E+ti0nxnHr8WfEOCuE+/p39V8/hmt0TTkdJA8lAtZiUXzmtz28tq7I956MbPzVWMmWe3SzMhVIj7AcGe8VcEXp9vHmpHttLEsRJnWGSCmKg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(396003)(39850400004)(346002)(136003)(36840700001)(46966006)(336012)(82310400003)(2906002)(8936002)(7696005)(81166007)(82740400003)(70586007)(70206006)(36860700001)(316002)(186003)(478600001)(5660300002)(55016002)(86362001)(356005)(8676002)(9686003)(47076005)(33656002)(83380400001)(450100002)(6506007)(53546011)(110136005)(26005)(4326008)(52536014)(54906003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2021 10:30:19.6308 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: feef3b96-14ca-4db6-36fb-08d93d44641e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3032 Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx5: remove redundant operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Slava Ovsiienko > Sent: Friday, July 2, 2021 4:13 PM > To: Ruifeng Wang ; Raslan Darawsheh > ; Matan Azrad ; Shahaf Shuler > > Cc: dev@dpdk.org; jerinj@marvell.com; nd ; Honnappa > Nagarahalli ; stable@dpdk.org > Subject: RE: [PATCH 1/2] net/mlx5: remove redundant operations >=20 > Hi, Ruifeng Hi, Slava >=20 > > -----Original Message----- > > From: Ruifeng Wang > > Sent: Tuesday, June 1, 2021 11:31 > > To: Raslan Darawsheh ; Matan Azrad > > ; Shahaf Shuler ; Slava > > Ovsiienko > > Cc: dev@dpdk.org; jerinj@marvell.com; nd@arm.com; > > honnappa.nagarahalli@arm.com; Ruifeng Wang ; > > stable@dpdk.org > > Subject: [PATCH 1/2] net/mlx5: remove redundant operations > > > > Some operations on mask are redundant and can be removed. > > The change yielded 1.6% performance gain on N1SDP. > > On ThunderX2, slight performance uplift was also observed. > > > > Fixes: 570acdb1da8a ("net/mlx5: add vectorized Rx/Tx burst for ARM") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ruifeng Wang > > --- > > drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 9 +-------- > > 1 file changed, 1 insertion(+), 8 deletions(-) > > > > diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h > > b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h > > index 2234fbe6b2..98a75b09c6 100644 > > --- a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h > > +++ b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h > > @@ -768,18 +768,11 @@ rxq_cq_process_v(struct mlx5_rxq_data *rxq, > > volatile struct mlx5_cqe *cq, > > comp_mask), 0)) / > > (sizeof(uint16_t) * 8); > > /* D.6 mask out entries after the compressed CQE. */ > > - mask =3D vcreate_u16(comp_idx < > > MLX5_VPMD_DESCS_PER_LOOP ? > > - -1UL >> (comp_idx * sizeof(uint16_t) * 8) : > > - 0); > > - invalid_mask =3D vorr_u16(invalid_mask, mask); > > + invalid_mask =3D vorr_u16(invalid_mask, comp_mask); >=20 > Mmmm... I'm not sure we can drop the masking compressed (and following) > CQE skip. > Let's consider the completion scenario (the series of 4 CQEs, each elemen= t is > 64B long) >=20 > 0: normal uncompressed CQE, ownership OK, format uncompressed, opcode > OK, no error > 1: compressed CQE, ownership OK, format compressed, opcode OK, no error > 2: miniCQE array, format can be any!!, may be discovered as ownership OK, > format uncompressed, opcode OK, no error > 3: miniCQE array, format can be any!!, may be discovered as ownership OK, > format uncompressed, opcode OK, no error Thanks for your review and explanation about CQE processing details. I did the change based on the fact that some calculations doesn't change th= e data.=20 So some intermediate calculations were removed. In the above diff section, result of 'mask' always equals to the nearest 'c= omp_mask' that above it. So I just remoed 'mask' and use 'comp_mask' instead. >=20 > Obviously, we should unconditionally mask out 2 and 3, regardless of > recognized their formats/opcode/error/etc. > I think we can get the diff above and skip diff below: >=20 > > /* D.7 count non-compressed valid CQEs. */ > > n =3D __builtin_clzl(vget_lane_u64(vreinterpret_u64_u16( > > invalid_mask), 0)) / (sizeof(uint16_t) * 8); > > nocmp_n +=3D n; > > - /* D.2 get the final invalid mask. */ > > - mask =3D vcreate_u16(n < MLX5_VPMD_DESCS_PER_LOOP ? > > - -1UL >> (n * sizeof(uint16_t) * 8) : 0); > > - invalid_mask =3D vorr_u16(invalid_mask, mask); >=20 > and get the correct final invalid_mask - all compressed and invalid CQEs = and > following ones will be masked out. This diff section is similar to the previous one. 'mask' always equals to the nearest 'invalid_mask' that above it. So entire line "invalid_mask =3D vorr_u16(invalid_mask, mask);" can be remo= ved. Code logic is not changed. But I'm not sure the code change impacts readabi= lity or maintainability that you may concern. Thanks. >=20 > With best regards, > Slava