From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2701A0C53; Fri, 3 Sep 2021 08:59:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 40326406B4; Fri, 3 Sep 2021 08:59:34 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2085.outbound.protection.outlook.com [40.107.21.85]) by mails.dpdk.org (Postfix) with ESMTP id B264C4013F; Fri, 3 Sep 2021 08:59:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CjNUeT5b3ReAQRPfr6mYRy5SLREJj9OnUGuh9rBQGOY=; b=4u7XT8rvL8Iop3yCW4Iu8nXXa9nrj4EXKRSanpthMsOUKpUTuJEdjeoitCH2Z73aYyaPSODLlCKsP9dtMHNj+lJubuwGtpYyzvzFv7/SsHbOVZhXZXkbvPrrSAFutFlZ+CyWzE7mIgZgNJiuTfshHNlftX2ZlSW6ZBPydzDeCMM= Received: from DB6P18901CA0010.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::20) by DBAPR08MB5720.eurprd08.prod.outlook.com (2603:10a6:10:1a1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Fri, 3 Sep 2021 06:59:29 +0000 Received: from DB5EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:16:cafe::d9) by DB6P18901CA0010.outlook.office365.com (2603:10a6:4:16::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Fri, 3 Sep 2021 06:59:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT024.mail.protection.outlook.com (10.152.20.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Fri, 3 Sep 2021 06:59:29 +0000 Received: ("Tessian outbound 6ba9ec11d42b:v103"); Fri, 03 Sep 2021 06:59:29 +0000 X-CR-MTA-TID: 64aa7808 Received: from d96fe0a9e438.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AE172826-D3DF-4032-9047-46BA8F77FF29.1; Fri, 03 Sep 2021 06:59:23 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d96fe0a9e438.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 03 Sep 2021 06:59:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AoxvoDwcNtOdP8UFLG4HLeDhWeCc+rwjeTBdIhWeH6OMVUp1k7Oz/Dp+l4hAsqJTXt9kfKGjHlSEOatItm0VfMBW4BI5Uo8O2+QxEHogybm70j3IcnrT5PlWVE3Pl26YrlT8knqMAGI8+MYOeb/TXPqA0LwaQyEMP6tqnwHLAPLcZtasyMGBkxQMEWN3DPZt3z0ei1E57+00EJNrgx6EoDDu2eL7FZQWca8QQvqoB1eZ2tAbFSuGFScN3h81INbPqessocNXIppAH00qEEHRrFsx3/WB9IjWB4nV39yQpgm8WhbDAJwG/6KvfB1rOW9/NkCfKzh3mOy1/EB+HTlgFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=CjNUeT5b3ReAQRPfr6mYRy5SLREJj9OnUGuh9rBQGOY=; b=m9CqzSXF6lLs/TYzXyCSBXWL6vUdTELRyRhlQGqJa6Z6v5s0bbXGAkqtaNGEHnUFB7Ot8Fx4Y7IZpUakhN++TN7R0w+Mm2QrMlYBXv7Tbiy3qQmVPEJ2Zvkz8QwXtR+mzmzXwTyVvUiBSJafPe6ALccVa2guBtw7uMnmsyAB24VE7k7F4jJVPXo1IlWJykmSdMjQb7LiXMnaGi/TaIpITNVI3HVse6qhkyaRHyQ488dtPMOteGmgSQp1sp9gFqLFGY1gY+zpT8Ulgxi2/FGfSJ7/V22tsfRD1bbWQ+BjQo+GTActFMpXuK38m8n4Lz66K1Ure8zpFrlJzLEKjpkbHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CjNUeT5b3ReAQRPfr6mYRy5SLREJj9OnUGuh9rBQGOY=; b=4u7XT8rvL8Iop3yCW4Iu8nXXa9nrj4EXKRSanpthMsOUKpUTuJEdjeoitCH2Z73aYyaPSODLlCKsP9dtMHNj+lJubuwGtpYyzvzFv7/SsHbOVZhXZXkbvPrrSAFutFlZ+CyWzE7mIgZgNJiuTfshHNlftX2ZlSW6ZBPydzDeCMM= Received: from AM5PR0802MB2465.eurprd08.prod.outlook.com (2603:10a6:203:9f::22) by AS8PR08MB6661.eurprd08.prod.outlook.com (2603:10a6:20b:38f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Fri, 3 Sep 2021 06:59:22 +0000 Received: from AM5PR0802MB2465.eurprd08.prod.outlook.com ([fe80::dca1:7c23:2a6d:c88f]) by AM5PR0802MB2465.eurprd08.prod.outlook.com ([fe80::dca1:7c23:2a6d:c88f%2]) with mapi id 15.20.4478.022; Fri, 3 Sep 2021 06:59:21 +0000 From: Ruifeng Wang To: David Christensen , "dev@dpdk.org" CC: Phil Yang , "stable@dpdk.org" , nd Thread-Topic: [dpdk-dev] [PATCH] test/atomic: fix false failures for 128-bit atomic compare exchange test Thread-Index: AQHXoCHBK32W/ppveEiA7AdkYfVacquR3X/A Date: Fri, 3 Sep 2021 06:59:21 +0000 Message-ID: References: <20210902174104.3181444-1-drc@linux.vnet.ibm.com> In-Reply-To: <20210902174104.3181444-1-drc@linux.vnet.ibm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4E06CE8AF815A44DB8D90F7C1B07745F.0 x-checkrecipientchecked: true Authentication-Results-Original: linux.vnet.ibm.com; dkim=none (message not signed) header.d=none;linux.vnet.ibm.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 744c578f-335a-4a15-8e39-08d96ea85fee x-ms-traffictypediagnostic: AS8PR08MB6661:|DBAPR08MB5720: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:2733;OLM:2733; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: uoeM1g7KqfWBaxzxNwYSJ+VkoInuHQVGZ3719uTMEd28aS0w/e5f3aN34bTULqxyu2RvsUp8wlkP1GquzYo0ujLYfyi9onMfi48PbkbkVu7k1Xuc3J9bFIeYVAoGs9eKgyBUvT0a3DzOOaA9EuXnWcecLMuyHhUxHQ2fU0WNr3t2Qtxmx77zccDP8mjVKcoJNMwC1F8V4VN+g1HLVckl7TmXJq9t0et3FAl4R1Amm/mKiJyYzB6PQpg/9YVpdXQeZLE03bjdk3SR5TfA8L5V54uAWoyoB8r4z3zoZYYe/euGD5yb+4pH7IqUZ5eXwVCJ7wBPAtEY/rGH0++iVEtfqrRFV8lgQ6e7aJaR12Z67cMKQmqes6MGSpPeu921WKsD48pQUh+q4pLX1HfvPbPAMcaSBsvA4f+sTglDmT+zeKJRbUv/aHTeQX8AjQTxZW85PNAutG1dnfQaLjmoXCQaLExJx+aLTQQJDSeieUA5N3Hwg1tZnRGr6/Clbg1mAL7LxRRBMAj6EAsiS3VCA6aOyydDy0PrDu5W+U3KPARSFH32psE4UiwbNsJGlD9i7dqdG74eeDzjWBlQOWu6zIDW/gYFUmNZRrMmetKLzq9NjTgxVBiUY157lJk+LjBSxUb7MR0njS/tOxlYGQrSN4OzhYxY22p58S+K2slW+ueELJ+xcnB6xu4vmD+76GZi6b9a2vAqubZ53UeMSAri+szbJw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM5PR0802MB2465.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(136003)(346002)(376002)(366004)(4326008)(38070700005)(5660300002)(66446008)(66946007)(66476007)(26005)(7696005)(71200400001)(64756008)(66556008)(9686003)(8936002)(76116006)(55016002)(52536014)(86362001)(110136005)(53546011)(2906002)(83380400001)(33656002)(8676002)(478600001)(186003)(38100700002)(54906003)(122000001)(316002)(6506007); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6661 Original-Authentication-Results: linux.vnet.ibm.com; dkim=none (message not signed) header.d=none; linux.vnet.ibm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d05590ee-cee1-45ee-f6e4-08d96ea85b7d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B2xtrkXdr+xfGntOeLf5OQ+jt4Bij0Ix8s+8I4YAO9YQwdC0yX+tkApUnOJGEtE+AA+x6DfNirHn0WDtyVVLzlx2kFPDPT5sSavAAv8Ydm0H2EqyJ2ulD3nXCRM26Wyfm3jesylnSosZWzAC6ZCyHBNPRPvX1CmZrYme0y5J8KZ8Y4It68jGawhoo+BIIXIV/a210B5P54tnA2Putsw9UlMiHSA4GtTM6J8TX7Kr0SMYw56JfCjlQfraKJ1FiHTDOk4op0u7Xa7AZ+lX5AdscQykx9XROpxXZki5WX+Ws6sFsIliCO6VAB6TzIVEQhOpwy2ziZcrvaxyEUcb+l0fWj52WGS44XU5rnWUAvvNNyxxc7J/QQ0kdptWIRxMe4l0ssha4ADNraQouFJNgmw1ZTraHy3gNYH2Cn74FJ07PyFFe14TjPitMcuZ6H3Y9t5NcDjDeBZHKf52IYxE40Hqq3TIO88aPP3dcHfnODdEI7ct5fvmih5AuEpWzY1AzUO5O7m6HO0TlMm8znPid9S7rHAheqgkxBzN6g6B3t9ztOT1qCZudUMeB25dCLR0RR2jY8bYsw/FMa++p+KLskyzt9apaTvk14RL2N8sO2o1tZAiWfb2KWinO3/vGLxUDKVSLK8DlNUf/UCzYOlj5lK7OpoWabZgnS1ouk+3xO3bGbjgxEvrRMmTjPbFfPw7RQuTdBT5pl+Itom5sVkAk/EXOQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(346002)(136003)(39860400002)(376002)(36840700001)(46966006)(83380400001)(336012)(47076005)(7696005)(52536014)(81166007)(36860700001)(70586007)(70206006)(55016002)(316002)(186003)(5660300002)(9686003)(110136005)(54906003)(86362001)(6506007)(8936002)(2906002)(4326008)(356005)(8676002)(53546011)(26005)(450100002)(478600001)(82310400003)(82740400003)(33656002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2021 06:59:29.2576 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 744c578f-335a-4a15-8e39-08d96ea85fee X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5720 Subject: Re: [dpdk-dev] [PATCH] test/atomic: fix false failures for 128-bit atomic compare exchange test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of David Christensen > Sent: Friday, September 3, 2021 1:41 AM > To: dev@dpdk.org > Cc: Phil Yang ; stable@dpdk.org; David Christensen > > Subject: [dpdk-dev] [PATCH] test/atomic: fix false failures for 128-bit a= tomic > compare exchange test >=20 > When checking the results of the rte_atomic128_cmp_exchange() function, > current code compares the values of a uint32_t and a uint64_t variable. > If the number of lcores used by the test is large, or the value of the it= eration > count N is increased, the variable size mimatch can cause a false test fa= ilure. > Modify the comparison to compare uint64_t values. >=20 > Fixes: fa3253c534b1 ("test/atomic: add 128-bit atomic compare exchange > test") > Cc: phil.yang@arm.com This mail address is unreachable.=20 I reproduced the issue on a 160-core aarch64 machine with increased N. Tested-by: Ruifeng Wang Reviewed-by: Ruifeng Wang >=20 > Signed-off-by: David Christensen > --- > app/test/test_atomic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/app/test/test_atomic.c b/app/test/test_atomic.c index > f10f555af8..ce0c259bd7 100644 > --- a/app/test/test_atomic.c > +++ b/app/test/test_atomic.c > @@ -591,7 +591,7 @@ test_atomic(void) > rte_atomic32_clear(&synchro); >=20 > iterations =3D count128.val[0] - count128.val[1]; > - if (iterations !=3D 4*N*(rte_lcore_count()-1)) { > + if (iterations !=3D (uint64_t)4*N*(rte_lcore_count()-1)) { > printf("128-bit compare and swap failed\n"); > return -1; > } > -- > 2.27.0