From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D63AA0526; Tue, 21 Jul 2020 05:26:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 178FB1BFD4; Tue, 21 Jul 2020 05:26:19 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140045.outbound.protection.outlook.com [40.107.14.45]) by dpdk.org (Postfix) with ESMTP id 903CD1BFBA; Tue, 21 Jul 2020 05:26:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bZZfDbBBPFZF8YS4jBuwJqdTumY6c4fKCC+GVFdIdj1tFRGGUlqAVTVrz9tKGbv/mFevmZHvwGfybuv+Z8afkH16JWHH1fo3JXy75ixDdNjhgwDrrfyZwDeg5A5L6rhEIBKyhR8oU5MMahKN14rNFIK6ABIWg00ijLqZi+YeRtUllpcAMY7hCRezCPqFu2jOScEli07NIchIObLUtIMX4kkKUJgLrrxtko0O1RhUBmL+pfOMsEau7u/ExURvfFtj0F2/U65J5wWwgEH9nWuNYXIVkvPh0jWlMSGk7G4S12zZ2Z2iJa+dJLHX5Mgnj/HXID5Ja3d3iPc9fb9YsJtLJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J/hZVeynkoDqFvLI/ll3naXxSKu8rhJCxq1BqWD7Y+Y=; b=lEbsAyMPki35y7pE1MhOUScvZbfMrUKLgkmYXI8Y/cYoHKIPVT5/UHuv5HOiRNmtaW7kPYBRldGIsgi65giLOIKVOb/LbDe1jY1BUkR0g5QVzW6N2kWHWXU2MFAIkpM1EN+GOFjmx9qg2oykFFqCbjCg2CStaxpW4dVhcoiOV+i4NTCHpq9xTtfwJB7CJvHSD/00onRjBo5V6Of77vD9Z8Tr+rhS2Ia5vmF7fJ9k6yXF8y4sFkMbOUV6EFQfdp4hvZT/kBBLWvUyYTPDc8BsGKEWXX5bEXZIg1oN4QFUxrjIQozTcXRhvvS+fCUcLCz4f8f5rRv9xQhWWPqrOCksWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J/hZVeynkoDqFvLI/ll3naXxSKu8rhJCxq1BqWD7Y+Y=; b=eNRUfKsKhr3fxZbYDS4tbZPoyRctzrUIRDqpU2JkrgBi+c2rcaH7zlMDXxCbeCWBramFI8yALpfmq3gBvZrfh/tLJ6dI0U+uVJwVVq2OrCw7DFA1H/eXY8pduWIBEY9uU+0ca1itIvXlI+T+FoJIPG4A83nj1flIiDqfepT/0xM= Received: from AM6PR04MB4456.eurprd04.prod.outlook.com (2603:10a6:20b:22::25) by AM6PR04MB6759.eurprd04.prod.outlook.com (2603:10a6:20b:d8::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Tue, 21 Jul 2020 03:26:16 +0000 Received: from AM6PR04MB4456.eurprd04.prod.outlook.com ([fe80::50d:1b5:ef9f:655c]) by AM6PR04MB4456.eurprd04.prod.outlook.com ([fe80::50d:1b5:ef9f:655c%7]) with mapi id 15.20.3195.025; Tue, 21 Jul 2020 03:26:16 +0000 From: Hemant Agrawal To: Thomas Monjalon , Sachin Saxena CC: "dev@dpdk.org" , Ferruh Yigit , "techboard@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 1/8] net/dpaa: add support for fmlib in dpdk Thread-Index: AQHWV1xVljg7Gbarckqx4eakhkQwoqkLrkIAgAO0bACAAIrQ0IAA09+AgACqrHA= Date: Tue, 21 Jul 2020 03:26:16 +0000 Message-ID: References: <20200710171946.23246-1-hemant.agrawal@nxp.com> <11996214.pnvohz1kia@thomas> <5337642.iclhRcez8O@thomas> In-Reply-To: <5337642.iclhRcez8O@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nxp.com; x-originating-ip: [122.180.211.197] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 251643cb-9cd9-4a12-482e-08d82d25d3b2 x-ms-traffictypediagnostic: AM6PR04MB6759: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 76vQsFyqeLfmLQjvQO8XNEtlHSMG4uo2wTCWEC4KyrWzOqtH0oSEMSTU+5daz9tLpFwsq1hYo31wK4PkZxS/kU1El2BPpr8sDFmwEka5aH2TLzkzUjC5ePh+3JHRpaeJmPxXUNSFLDMrOPWQA4SF/B3SLENLQOwO3Dkvtkj/1HKqkN4D8HfU8yB1e2xJ/8PXbL+i8H7qYnJmgtk2alD1cajQGM6ZhJoBKKcGvCvXp2oTrKo4hWOMqUb4oyMwQ8DvOqEJMYP/uRNNYRbC0/1ykB5+UvVdp3LmIXtjJ9xEEK/T2CkhDYEnyzTK+02UycV6JvG9tKasgreeek3LBumDu0MXBgbwdCsmxdnJ9l7/4wJ+U+ukT8Nzse7oUna0jU4FvNcZJXwAgHnD7HJW5rniHw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB4456.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(376002)(136003)(346002)(396003)(366004)(83380400001)(53546011)(7696005)(8676002)(8936002)(44832011)(6636002)(316002)(2906002)(478600001)(5660300002)(4326008)(186003)(71200400001)(33656002)(66556008)(110136005)(26005)(76116006)(6506007)(66946007)(55016002)(966005)(54906003)(66476007)(9686003)(52536014)(66446008)(86362001)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: +H7JJ7cdLvqiX9l3oQJRsBgESjUE5Dgejl1g7+Pp1N8pVr9juF9DLD6GRnHh5Hx/pY8Jr8wD80uavwLTTBmMeerypF8mmKLmDEgstBYxDvj0wxpcfAffbiUDk7zjNzfwWKDuNhXuOs24syv/Ak7oSQMOI5hG8Gn8+nU7NeCnNPnv/w4p6197D6jt2ysUeGdtVUnnq5QZWeqtwHfZYmsxBgoUtxsX7GeFJTJS5WTl+orRanyf2qxv7yg041olztzcLsRzS4PHDMIYavDfjIZlrJRj+J6KGG+ligSidjazjtuumoKlvXx0U0rNI9wpNt1jg0ieron9pZ9WylXn9xnseYne4iI0v5M1Qi0zqJl3J0jFaaEHU/BYqfQE3noAyUHBuSDwdn0ePKpwr2odvsJge5dfILNjCCejpEJhVMFIxABW1ryKHAImXbwnAI/TDI7qwECEoMTGdXcepqOknuJLi18m3nhISyj60ot5Oyxd4+Uo11K/wnlJnPyvdCyc0A1T Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4456.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 251643cb-9cd9-4a12-482e-08d82d25d3b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 03:26:16.1281 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FgWECy1v1d+W5mFrFTSJqVY5lzGOaMxC3Nq/xtNMQ6GAoz6vn0bPK+KY05TtHyMo+Vak6oCO+40MktL60mvugQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6759 Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/dpaa: add support for fmlib in dpdk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, On 20-Jul-20 10:36 PM, Thomas Monjalon wrote: > 20/07/2020 06:50, Hemant Agrawal: >> HI Thomas, >> >> From: Thomas Monjalon =20 >> 17/07/2020 13:36, Ferruh Yigit: >>> On 7/11/2020 9:17 AM, Hemant Agrawal wrote: >>>> DPAA platorm MAC interface is known as FMAN i.e. Frame Manager. >>>> There are two ways to control it. >>>> 1. Statically configure the queues and classification rules before=20 >>>> the start of the application using FMC tool. >>>> 2. Dynamically configure it within application by making API calls=20 >>>> of fmlib. >>>> >>>> The fmlib or Frame Manager library provides an API on top of the=20 >>>> Frame Manager driver ioctl calls, that provides a user space=20 >>>> application with a simple way to configure driver parameters and PCD=20 >>>> (parse - classify - distribute) rules. >>>> >>>> This patch integrates the base fmlib so that various queue config,=20 >>>> RSS and classification related features can be supported on DPAA platf= orm. >>>> >>>> This base fmlib is shared across multiple project. >>>> - it is not following block comments style for doxygen and other=20 >>>> comments. >>>> - it usages camel case for naming. >>>> - it is not following the 80 char limits in code >>>> >>>> Signed-off-by: Sachin Saxena >>>> Signed-off-by: Hemant Agrawal >>> Series applied to dpdk-next-net/master, thanks. >> >>> Sorry, this time I don't agree with Ferruh's decision of merging this s= eries. >> >>> Checkpatch is sending too many warnings. >> >> [Hemant] The base codes, which are coming from common area was not origi= nally meant for Linux. >> If we change the original starting code of it, the the maintenance beco= me very painful otherwise. >> >>> But most importantly, the licensing has not been agreed in techboard an= d govboard. >> >> [Hemant] you are wrong here. Which license difference are you talking a= bout? Standard licenses do not need techboard and govboard approval. >> /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) is the approved li= cense. It have been used in DPDK since long.=20 >> DPDK exception file states: >> Note that following licenses are not exceptions:- >> - BSD-3-Clause >> - Dual BSD-3-Clause OR GPL-2.0 >> - Dual BSD-3-Clause OR LGPL-2.1 >> - GPL-2.0 (*Only for kernel code*) >> Any base code which is shared among kernel and Userspace space - mostly = likely will have this kind dual license only. >> Note: you don't add "Dual" word while stating SPDX string - it is implic= it. > > Indeed you're right it is not marked as an exception in license/exception= s.txt. > This is a discrepancy with the charter: > https://www.dpdk.org/charter/ > In section 6.i.iii: > " > A disjunctive licence choice of BSD-3-Clause OR GPL-2.0 or BSD-3-Clause O= R LGPL-2.1 will be used for code that is shared between the kernel and user= space. > " > But we are not building a kernel module with this code, > as it is the case for KNI. KNI is for DPDK specific stuff. But many times base codes are alre= ady part of kernel tree or some other OS and same codebase can go to Usersp= ace tree as well. So, they have dual licenses.=20 > >>> Why dropping this codebase in DPDK instead of pulling it as a dependenc= y? >>> I don't like seeing DPDK becoming a pile of code duplicated from somewh= ere else. >> [Hemant] We are not using the library as it is and making some serious c= hanges in the generic library to suit the DPDK use-case. >> So, it is not possible for us to use the *original* code of fmlib, which= is public. > > I don't understand. > Either you don't change the code, so you use the original one as a depend= ency, > or you change the code for DPDK use, so you can adapt it to DPDK. The original code was for non-linux powerpc platforms. My problem = was that the base team still do fixes in that code base. If I change the majority of the code, I may not be able to sync the fixes i= n future.=20 > >>> I will drop this series from 20.08, waiting for a clear consensus. >> [Hemant] Why?=20 >> [Hemant] >Note: I don't remember having heard about such change before, = especially not in the roadmap. >> [Hemant] So anyone not publishing a roadmap - you will not accept featur= es? =20 > > This is just a note explaining why I discover it so late. > > Actually we sent this patchset originally on 27 May. That was wel= l within new feature date, so I did not sent explicit roadmap. If that help= s you, we will try doing it.=20