DPDK patches and discussions
 help / color / Atom feed
From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: "Ma, LihongX" <lihongx.ma@intel.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "bluca@debian.org" <bluca@debian.org>,
	"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] config: allow overriding some build defaults
Date: Tue, 1 Sep 2020 06:07:56 +0000
Message-ID: <AM6PR04MB4456A1036B8F51A05E573EA0892E0@AM6PR04MB4456.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <BN8PR11MB37157A63021A5E9DA81A89389E2E0@BN8PR11MB3715.namprd11.prod.outlook.com>

HI Bruce,
	Will you please also add similar command examples in docs so that it becomes easy for the developers to use meson?

Regards,
Hemant

-----Original Message-----
From: dev <dev-bounces@dpdk.org> On Behalf Of Ma, LihongX
Sent: Tuesday, September 1, 2020 10:48 AM
To: Richardson, Bruce <bruce.richardson@intel.com>; dev@dpdk.org
Cc: bluca@debian.org; Richardson, Bruce <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] config: allow overriding some build defaults

Tested-by: lihongx Ma<lihongx.ma@intel.com> Before apply this patchset, set config like DRTE_LIBRTE_I40E_QUEUE_NUM_PER_VM=8 will failed, After apply this patchset, the the meson build can work find.
Cmd like below:
meson -Denable_kmods=True -Dlibdir=lib --default-library=static -Dexamples=vmdq_dcb -Dc_args='-DRTE_LIBRTE_I40E_QUEUE_NUM_PER_VM=8' config-test1 ninja -C config-test1

Regards,
Ma,lihong

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Bruce Richardson
> Sent: Tuesday, August 25, 2020 7:45 PM
> To: dev@dpdk.org
> Cc: bluca@debian.org; Richardson, Bruce <bruce.richardson@intel.com>
> Subject: [dpdk-dev] [PATCH 2/2] config: allow overriding some build 
> defaults
> 
> In case a developer uses CFLAGS to set different default values for 
> the defines in the rte_config.h file, use #ifndef / #endif guards 
> around the setting of those values. For those lines just "defining" a 
> macro without assigning it a value to be used by code, drop the value 
> argument (where
> possible) to make it clearer that that is what is happening, since 
> those don't need the #ifdef guard.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  config/rte_config.h | 110 
> +++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 99 insertions(+), 11 deletions(-)
> 
> diff --git a/config/rte_config.h b/config/rte_config.h index


  reply index

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 11:44 [dpdk-dev] [PATCH 1/2] config: remove explicit undefinition of unset values Bruce Richardson
2020-08-25 11:44 ` [dpdk-dev] [PATCH 2/2] config: allow overriding some build defaults Bruce Richardson
2020-09-01  5:17   ` Ma, LihongX
2020-09-01  6:07     ` Hemant Agrawal [this message]
2020-09-01  9:02       ` Bruce Richardson
2020-09-03 14:50       ` Bruce Richardson
2020-09-03 14:49 ` [dpdk-dev] [PATCH v2 0/3] Allow overriding of build-time constants Bruce Richardson
2020-09-03 14:49   ` [dpdk-dev] [PATCH v2 1/3] config: remove explicit undefinition of unset values Bruce Richardson
2020-09-03 14:49   ` [dpdk-dev] [PATCH v2 2/3] config: allow overriding some build defaults Bruce Richardson
2020-09-03 14:49   ` [dpdk-dev] [PATCH v2 3/3] doc: add notes on overriding extra config values Bruce Richardson
2020-09-03 15:43     ` Hemant Agrawal
2020-10-14 14:20   ` [dpdk-dev] [PATCH v2 0/3] Allow overriding of build-time constants Bruce Richardson
2020-10-15  8:55     ` Chen, BoX C
2020-10-15  9:20       ` Bruce Richardson
2020-10-16 15:47   ` David Marchand
2020-10-16 15:55     ` Bruce Richardson
2020-10-16 16:46       ` David Marchand
2020-10-19 10:21         ` Bruce Richardson
2020-10-19 21:04           ` Thomas Monjalon
2020-10-20  8:34             ` Bruce Richardson
2020-10-20 10:04               ` Thomas Monjalon
2020-10-20 10:15                 ` Bruce Richardson
2020-10-28 16:32   ` Bruce Richardson

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR04MB4456A1036B8F51A05E573EA0892E0@AM6PR04MB4456.eurprd04.prod.outlook.com \
    --to=hemant.agrawal@nxp.com \
    --cc=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=lihongx.ma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox