From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84D7EA04AC; Tue, 1 Sep 2020 08:07:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A3021E07; Tue, 1 Sep 2020 08:07:58 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80089.outbound.protection.outlook.com [40.107.8.89]) by dpdk.org (Postfix) with ESMTP id 64B88CF3 for ; Tue, 1 Sep 2020 08:07:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H6SntZi0Ui3K869KsW5ieQgEngZq3Ilh2B0HEvn3PZZYmZsSuqSJMuw7BycD4YkYUjdzWuTJp3/kKNDwJ3Kk84loLbweVkxOxctpVCzDx+i7bhhAUoqTYgEi7vro2G10EOnRbKww68NRmmbQ5j9s4/Aa3+kqdUqfBPJO8h9OaCH+KW07pk3XzzWSl3HnLzS/lzZsy3v66pNLDE0YVctU83tv8hr7SvPLKgalo8l5fryYaYJEtmDSRhU0td0PIJG+2/YM1LddBh7YQW8O3VHqzqBBKC2VhHK4I3FFm/X4rb7mQzg6vElM0Va5WiNIgW3bKcO2jK0WHvdb3AwtDAcreQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ppaHHKv3LU8qoKdCha6O5qh2/oyUY/n8eXNlpRON3lk=; b=FORg26gO/LMI/iVTqMXNrpc6+FG/PEnm2CN2aIHbaUK81DWzyW+WJvgK7OecGNDZzWUSY2M1DYA+x/M/ftXXheMjmKqXsv2dL+bzsoozdGpah32RAGbPykuA1CqJku38r1diYvrv67w+L/q86QucnNzFyddYgH2W2LsdhSCwIkbG7NdzlZYw/BfYsGOMLOfZNODMbErg2Fc3sJZYhDkRjc9hB8NC4JjBYdknSUf3ZHWj5h9mLcnMBtghKM3limvmyV3FVOq5au995r2F66zHcwF+afVlkfd0a+9yOcbGgU7DP/BSA7OC3q4i32c5rOVLOFc26XvU58YyS35dDQKVMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ppaHHKv3LU8qoKdCha6O5qh2/oyUY/n8eXNlpRON3lk=; b=e98cdSmHf4wsyPF2DJOZ0JOQk6ZVvE4BL9dMfsGN4+mYqOUNzUf6SHMjQQOi+jjtSEQnS4lw3FQ3QfqW6ICQa4fqDpVF19HaIYI+aXFGj4QWZD8G+IFkPKLBiFRi2jEE5tVQNCTIiooxuJZ7TZmwLkBwx+WbZwpkvw1jX5+P71k= Received: from AM6PR04MB4456.eurprd04.prod.outlook.com (2603:10a6:20b:22::25) by AM6PR0402MB3557.eurprd04.prod.outlook.com (2603:10a6:209:2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.22; Tue, 1 Sep 2020 06:07:56 +0000 Received: from AM6PR04MB4456.eurprd04.prod.outlook.com ([fe80::e024:2be5:29c3:31b0]) by AM6PR04MB4456.eurprd04.prod.outlook.com ([fe80::e024:2be5:29c3:31b0%7]) with mapi id 15.20.3305.033; Tue, 1 Sep 2020 06:07:56 +0000 From: Hemant Agrawal To: "Ma, LihongX" , "Richardson, Bruce" , "dev@dpdk.org" CC: "bluca@debian.org" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH 2/2] config: allow overriding some build defaults Thread-Index: AQHWetUsMzh3Z7voHE6XiMUkTFxJ9qlTSNaAgAANtQA= Date: Tue, 1 Sep 2020 06:07:56 +0000 Message-ID: References: <20200825114447.135030-1-bruce.richardson@intel.com> <20200825114447.135030-2-bruce.richardson@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [122.176.3.89] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c8e40d8b-f848-45a9-6eb1-08d84e3d5ebb x-ms-traffictypediagnostic: AM6PR0402MB3557: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YTLGJii+Xzu85TLeeT9QXJiZq/veSTwFJzXpbHGQvTYTGAN12lgV28JKV9qrA7drkCHpikb8DF+zK7/sSJgYyBcmIljuisLd6/3wrSelcSQTXlgWUg6HiwU6RIhik6JRF+8YGftPvQGcawGF/XqP5f2UaYsMt52KGJx0BwAUlT6UqWN27xZ3vQebd93CGGJ5w6OSMwZ5tFWEDb2yFEN+L0H34oQmoW9LSR/zZbUSeOF0WNpHWs3ZJsRi7WMgiUA7wuJtxJECLe+sYvZApZA5Aa4KBcB+SafapL5mCilr/dAnMBea56S/Gw32cMLwyB8bqUqxm0PhrWtR/BtOjUe/Ig== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB4456.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(39860400002)(376002)(396003)(136003)(86362001)(8676002)(44832011)(83380400001)(186003)(478600001)(316002)(76116006)(71200400001)(2906002)(66946007)(9686003)(53546011)(66446008)(8936002)(66556008)(54906003)(26005)(5660300002)(4326008)(6506007)(52536014)(7696005)(33656002)(55016002)(64756008)(110136005)(66476007)(55236004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: YRuoU02naksSVBowTSm5J12pe7wFOp6XR1PHCerZpL2VhrutTXh+hLGNDIDHGr+BQhkKEwi5mBGauc0kqMYGNzlXuwvGiKX5BkbSl+DpoDuYdJKO99MXJgYQghoCLnyh/B36rhOKoxc4kyP9QqIPxKLAir46TAbkwJmJXJ+meuEpXY1XwPRHWm2R9PRNT2N39SOMvXGbkE+Egsx6sKxHzfEH8GTQbAqifOUzEIFBTh8EjlPyRBCX5syUAaPQvOEqyDjS7Swen7ExwKtVlsW7RN7IJxGh+POjJ5XAYXjnJH90DQjL6upu0h/SE5nhOtOIqvphjyzng9TYGjLocLMPyi0WbBI3rBFFWjeW8ynqIilNdGU2NcYoDtkwlkRvNMipy7sQ5u1b3uVzrWfSzf+hxhDBPm0LdINTktvTUyLI7Y570364UDRxo9a47mHbdk20lm58lAmLawDSZhYGpKP75ENhQuv+F6yA7bnEFWGOPdVzzqYgkl/KHtvK//gQe3UPXL7QQM2eVFTxcFg+hXod+oFYTUf26Uzp1yDJRyP2le4h3/U8sz7aGsxRvrE66fZhUcie0fla3Wc3mzvMTWGDRI6huOkJTWPdjRRsQIuJiWSYAgfG4AZkemHVMhY8dBJ5E08qztCnPfQFpzCcQ3jzSg== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4456.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8e40d8b-f848-45a9-6eb1-08d84e3d5ebb X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2020 06:07:56.0789 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9izqJRG/KsMgcEHrhmt+JR7N7w3ugqYRmcaBSyac6NJlZnSGlLGj+5ADmGJS67cGre2P3oZ6f0aMVdP3h3y74Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3557 Subject: Re: [dpdk-dev] [PATCH 2/2] config: allow overriding some build defaults X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" HI Bruce, Will you please also add similar command examples in docs so that it becom= es easy for the developers to use meson? Regards, Hemant -----Original Message----- From: dev On Behalf Of Ma, LihongX Sent: Tuesday, September 1, 2020 10:48 AM To: Richardson, Bruce ; dev@dpdk.org Cc: bluca@debian.org; Richardson, Bruce Subject: Re: [dpdk-dev] [PATCH 2/2] config: allow overriding some build def= aults Tested-by: lihongx Ma Before apply this patchset, set= config like DRTE_LIBRTE_I40E_QUEUE_NUM_PER_VM=3D8 will failed, After apply= this patchset, the the meson build can work find. Cmd like below: meson -Denable_kmods=3DTrue -Dlibdir=3Dlib --default-library=3Dstatic -Dexa= mples=3Dvmdq_dcb -Dc_args=3D'-DRTE_LIBRTE_I40E_QUEUE_NUM_PER_VM=3D8' config= -test1 ninja -C config-test1 Regards, Ma,lihong > -----Original Message----- > From: dev On Behalf Of Bruce Richardson > Sent: Tuesday, August 25, 2020 7:45 PM > To: dev@dpdk.org > Cc: bluca@debian.org; Richardson, Bruce > Subject: [dpdk-dev] [PATCH 2/2] config: allow overriding some build=20 > defaults >=20 > In case a developer uses CFLAGS to set different default values for=20 > the defines in the rte_config.h file, use #ifndef / #endif guards=20 > around the setting of those values. For those lines just "defining" a=20 > macro without assigning it a value to be used by code, drop the value=20 > argument (where > possible) to make it clearer that that is what is happening, since=20 > those don't need the #ifdef guard. >=20 > Signed-off-by: Bruce Richardson > --- > config/rte_config.h | 110=20 > +++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 99 insertions(+), 11 deletions(-) >=20 > diff --git a/config/rte_config.h b/config/rte_config.h index