From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30046.outbound.protection.outlook.com [40.107.3.46]) by dpdk.org (Postfix) with ESMTP id 7C9F61B1B8 for ; Thu, 18 Jan 2018 10:34:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=df+xrvi/z0udpkuPVNWjdxCc+/t2VAaO991nl57O/ro=; b=IsqaPznfJ3LESIRa0vIxg0tpC4AGNh3C6lLoe0eCP34D8HYsTnJW2E+PsjQPttV0h8kdYhukx88ynoLlz0l/aNmcKKeSSfll+bEZMSEqtegD0TrahX4bBB+nVs+AvR6drHXIlRoza9eUWrMGmyYzvWoEG4Oxvf+hxW9jh0cNJPE= Received: from AM6PR0502MB3797.eurprd05.prod.outlook.com (52.133.21.26) by AM6PR0502MB3783.eurprd05.prod.outlook.com (52.133.21.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Thu, 18 Jan 2018 09:33:58 +0000 Received: from AM6PR0502MB3797.eurprd05.prod.outlook.com ([fe80::6c28:c6b3:de94:a733]) by AM6PR0502MB3797.eurprd05.prod.outlook.com ([fe80::6c28:c6b3:de94:a733%13]) with mapi id 15.20.0428.014; Thu, 18 Jan 2018 09:33:58 +0000 From: Matan Azrad To: =?iso-8859-1?Q?Ga=EBtan_Rivet?= CC: Ferruh Yigit , Thomas Monjalon , "dev@dpdk.org" , "stephen@networkplumber.org" Thread-Topic: [PATCH v4 3/8] net/failsafe: add probed etherdev capture Thread-Index: AQHTkDxKJSMdsWQmWk6xq7Mdrj9doqN5XKWQ Date: Thu, 18 Jan 2018 09:33:58 +0000 Message-ID: References: <1515509253-17834-1-git-send-email-matan@mellanox.com> <1516265026-6469-1-git-send-email-matan@mellanox.com> <1516265026-6469-4-git-send-email-matan@mellanox.com> <20180118091056.5pims3wlnwlxqz7a@bidouze.vm.6wind.com> In-Reply-To: <20180118091056.5pims3wlnwlxqz7a@bidouze.vm.6wind.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR0502MB3783; 7:VUIVDz1XAAtzUnsgTWSqKPz5hQF//2nT1IfI15cdyGPACLvokpCTqKBMdNBR/kUdW/IEsBY8BXNoKYAgoNHjV6qbaq1P1x1GzUmC260ilYwNDU7yrdQggPykc6+hR1d7KjEZq88gVFaqixdyGKqIkRVLp2jrSya2z9ZLC4IHuB/q4ku2lOsgC4xbap6icrfWLgCsDP2wMFxGgPKn3LCCp+WjHpVnceyuIvtMrPC66ZAFa9GX57avdLpmTjv6vhek x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 037dd368-6cfb-424c-1e2e-08d55e569a05 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(48565401081)(2017052603307)(7153060)(7193020); SRVR:AM6PR0502MB3783; x-ms-traffictypediagnostic: AM6PR0502MB3783: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(3231023)(2400059)(944501161)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041268)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:AM6PR0502MB3783; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AM6PR0502MB3783; x-forefront-prvs: 05568D1FF7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(39380400002)(39860400002)(396003)(376002)(199004)(189003)(229853002)(8936002)(6436002)(5660300001)(6116002)(3846002)(68736007)(6346003)(76176011)(7696005)(305945005)(316002)(102836004)(54906003)(99286004)(2900100001)(26005)(59450400001)(6506007)(7736002)(3660700001)(3280700002)(2906002)(74316002)(66066001)(53936002)(14454004)(478600001)(4326008)(55016002)(81166006)(2950100002)(5250100002)(6916009)(86362001)(9686003)(8676002)(81156014)(105586002)(97736004)(93886005)(6246003)(106356001)(33656002)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0502MB3783; H:AM6PR0502MB3797.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:3; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-microsoft-antispam-message-info: D6u7TLc7h2olOG0OEB1yyKtMYvJPVloSrNDo7O0i4s8Z4q77uPixmov39vPBfwFGDGeFsNQu/5HgP9WF+R63pQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 037dd368-6cfb-424c-1e2e-08d55e569a05 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2018 09:33:58.6705 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0502MB3783 Subject: Re: [dpdk-dev] [PATCH v4 3/8] net/failsafe: add probed etherdev capture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 09:34:00 -0000 Hi Gaetan From: Ga=EBtan Rivet, Thursday, January 18, 2018 11:11 AM > To: Matan Azrad > Cc: Ferruh Yigit ; Thomas Monjalon > ; dev@dpdk.org; stephen@networkplumber.org > Subject: Re: [PATCH v4 3/8] net/failsafe: add probed etherdev capture >=20 > Hi Matan, >=20 > On Thu, Jan 18, 2018 at 08:43:41AM +0000, Matan Azrad wrote: > > Previous fail-safe code didn't support probed sub-devices capture and > > failed when it tried to probe them. > > > > Skip fail-safe sub-device probing when it already was probed. > > >=20 > What happens when >=20 > app --vdev "net_failsafe0,dev(net_failsafe0)" -- -i >=20 > ? I guess infinite recursion. >=20 :) interesting ./x86_64-native-linuxapp-gcc/build/app/test-pmd/testpmd -n 4 --vdev=3D"net= _failsafe0,dev(net_failsafe0)" --vdev=3D"net_vdev_netvsc,ignore=3D1" -- --b= urst=3D118 --mbcache=3D512 --portmask 0xf -i --nb-cores=3D11 --rxq=3D2 --= txq=3D2 --txd=3D1024 --rxd=3D1024=20 EAL: Detected 12 lcore(s) EAL: No free hugepages reported in hugepages-1048576kB EAL: Debug dataplane logs available - lower performance EAL: Probing VFIO support... EAL: WARNING: cpu flags constant_tsc=3Dyes nonstop_tsc=3Dno -> using unreli= able clock cycles ! EAL: PCI device 0002:00:02.0 on NUMA socket 0 EAL: probe driver: 15b3:1004 net_mlx4 PMD: net_mlx4: PCI information matches, using device "mlx4_0" (VF: true) PMD: net_mlx4: 1 port(s) detected PMD: net_mlx4: port 1 MAC address is 00:15:5d:44:4b:24 PMD: net_failsafe: Initializing Fail-safe PMD for net_failsafe0 PMD: net_failsafe: Creating fail-safe device on NUMA socket 0 PMD: net_failsafe: Taking control of a probed sub device 0 named net_failsa= fe0 PMD: net_failsafe: MAC address is 00:00:00:00:00:00 Interactive-mode selected testpmd: create a new mbuf pool : n=3D327680, size=3D21= 76, socket=3D0 Configuring Port 0 (socket 0) Port 0: 00:15:5D:44:4B:24 Checking link statuses... Done testpmd>=20 Failsafe0 took control of itself (since it is already probed we don't probe= it again). > > Signed-off-by: Matan Azrad > > Cc: Gaetan Rivet > > --- > > doc/guides/nics/fail_safe.rst | 5 +++ > > drivers/net/failsafe/failsafe_args.c | 2 - > > drivers/net/failsafe/failsafe_eal.c | 78 ++++++++++++++++++++++++-= -- > ------ > > drivers/net/failsafe/failsafe_private.h | 2 + > > 4 files changed, 65 insertions(+), 22 deletions(-) > > > > diff --git a/doc/guides/nics/fail_safe.rst > > b/doc/guides/nics/fail_safe.rst index 5b1b47e..b89e53b 100644 > > --- a/doc/guides/nics/fail_safe.rst > > +++ b/doc/guides/nics/fail_safe.rst > > @@ -115,6 +115,11 @@ Fail-safe command line parameters > > order to take only the last line into account (unlike ``exec()``) at= every > > probe attempt. > > > > +.. note:: > > + > > + In case of whitelist sub-device probed by EAL, fail-safe PMD will t= ake the > device > > + as is, which means that EAL device options are taken in this case. > > + >=20 > This note should be right under the "dev()" parameter help I think. >=20 OK. > If the self-capture is possible and you fix it, you should as well add a = line here > about the limitation, concerning the PCI blacklist mode and the expected = PCI > id format? >=20 > Something like: >=20 > --- 8< --- >=20 > When trying to use a PCI device automatically probed in blacklist mode= , > the syntax for the fail-safe must be with the full PCI id: > Domain:Bus:Device.Function. See the usage example section. >=20 > .. ^^^^^^^^^^^^^ Here, an ReST refere= nce > .. Would be nice, I don= 't recall > .. the exact syntax. > .. In the `Usage example` section: >=20 > #. Start testpmd, automatically probing the device 84:00.0 and using it w= ith > the fail-safe >=20 > .. code-block:: console >=20 > $RTE_TARGET/build/app/testpmd -c 0xff -n 4 \ > --vdev 'net_failsafe0,dev(0000:84:00.0),dev(net_ring0)' \ > -- -i >=20 > --- >8 --- >=20 Ok. > Ensure that this is working before using this command, I haven't tested i= t. >=20 Sure. > Regards, > -- > Ga=EBtan Rivet > 6WIND