From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <matan@mellanox.com>
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
(mail-eopbgr40042.outbound.protection.outlook.com [40.107.4.42])
by dpdk.org (Postfix) with ESMTP id 191821B23A
for <dev@dpdk.org>; Wed, 10 Jan 2018 17:58:50 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=dKMTRWpRNQbbLWVLxOcaFjoPDrzAKYMnqO1rZipks4U=;
b=W0JYfPzsinZKEa7uC8C1353hIlTkHkZVBjARBu22wqUklw0BrUs0U4gORCJANMGtsq0u3YlQv5de2vC7i1EXbZOXUETGjZeAHXacANjCkiu3U5Cjd4NB6NUJzyqZ6ry8IKfbXpQMXTmDbSRecCYtAmSUxBaA5WmeC9TrTpCCRKc=
Received: from AM6PR0502MB3797.eurprd05.prod.outlook.com (52.133.21.26) by
AM6PR0502MB3799.eurprd05.prod.outlook.com (52.133.21.28) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id
15.20.386.5; Wed, 10 Jan 2018 16:58:49 +0000
Received: from AM6PR0502MB3797.eurprd05.prod.outlook.com
([fe80::b4b4:7de8:cf70:aa3a]) by AM6PR0502MB3797.eurprd05.prod.outlook.com
([fe80::b4b4:7de8:cf70:aa3a%13]) with mapi id 15.20.0386.006; Wed, 10 Jan
2018 16:58:48 +0000
From: Matan Azrad <matan@mellanox.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, Thomas Monjalon
<thomas@monjalon.net>, Gaetan Rivet <gaetan.rivet@6wind.com>, "Wu, Jingjing"
<jingjing.wu@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, Neil Horman <nhorman@tuxdriver.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Thread-Topic: [PATCH v2 2/6] ethdev: add port ownership
Thread-Index: AQHTihf/M9xg8LYorUSRFqZtTc27hqNtNdVQ
Date: Wed, 10 Jan 2018 16:58:48 +0000
Message-ID: <AM6PR0502MB379755992EDDF002D06D9521D2110@AM6PR0502MB3797.eurprd05.prod.outlook.com>
References: <1511870281-15282-1-git-send-email-matan@mellanox.com>
<1515318351-4756-1-git-send-email-matan@mellanox.com>
<1515318351-4756-3-git-send-email-matan@mellanox.com>
<2601191342CEEE43887BDE71AB97725880E3B9D6@irsmsx105.ger.corp.intel.com>
In-Reply-To: <2601191342CEEE43887BDE71AB97725880E3B9D6@irsmsx105.ger.corp.intel.com>
Accept-Language: en-US, he-IL
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is )
smtp.mailfrom=matan@mellanox.com;
x-originating-ip: [193.47.165.251]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; AM6PR0502MB3799;
7:DLUBgdOpeti60+/wKe3rSX9rwWx05R/nHjO24F5NA91o6kzicOiMqq2DSN8ohmMKOAC1TOJfTUhIR/ODLT6ThS6Jh2/MaMcN+iwMkEgYoMw8nGBQvlj2cTuPwLrT3T2lCtg634YS3koCxsLWQy2eir9D+pEi6ffKBr44rjl8ZXMkaofxSVPnePp4PTYOnDulOIosraYU2pv9Fv2RDmviPBx2F6y/rGYMJYNUOQPDlPXdwXa42L7C/kui78qRL3E3
x-ms-exchange-antispam-srfa-diagnostics: SSOS;
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 0412fc5d-8efd-496e-42df-08d5584b6b5c
x-microsoft-antispam: UriScan:; BCL:0; PCL:0;
RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020);
SRVR:AM6PR0502MB3799;
x-ms-traffictypediagnostic: AM6PR0502MB3799:
x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr
x-microsoft-antispam-prvs: <AM6PR0502MB3799F1FF2F305B94FB4AB6E3D2110@AM6PR0502MB3799.eurprd05.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(60795455431006)(278428928389397)(228905959029699)(17755550239193);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0;
RULEID:(6040470)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231023)(944501075)(3002001)(10201501046)(6055026)(6041268)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(6072148)(201708071742011);
SRVR:AM6PR0502MB3799; BCL:0; PCL:0; RULEID:(100000803101)(100110400095);
SRVR:AM6PR0502MB3799;
x-forefront-prvs: 0548586081
x-forefront-antispam-report: SFV:NSPM;
SFS:(10009020)(39860400002)(346002)(366004)(376002)(39380400002)(396003)(199004)(189003)(51444003)(13464003)(66066001)(316002)(5250100002)(110136005)(2906002)(9686003)(5660300001)(25786009)(54906003)(86362001)(3280700002)(2950100002)(5890100001)(93886005)(74316002)(102836004)(7736002)(305945005)(229853002)(3660700001)(478600001)(2900100001)(14454004)(8676002)(53546011)(76176011)(59450400001)(6246003)(8936002)(97736004)(7696005)(6436002)(6506007)(33656002)(81166006)(81156014)(4326008)(55016002)(106356001)(105586002)(99286004)(53946003)(68736007)(3846002)(6116002)(53936002);
DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0502MB3799;
H:AM6PR0502MB3797.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords;
A:1; MX:1; LANG:en;
received-spf: None (protection.outlook.com: mellanox.com does not designate
permitted sender hosts)
x-microsoft-antispam-message-info: LWA/I/kJsMY5euSXs13DsKbv9JKNNgetcHk27wbemei1GTjmLjaesjAii8zqpmA1iMGIh0I9cV5ulV4VG1FuvQ==
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0412fc5d-8efd-496e-42df-08d5584b6b5c
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2018 16:58:48.8386 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0502MB3799
Subject: Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Jan 2018 16:58:51 -0000
Hi Konstantin
From: Ananyev, Konstantin, Wednesday, January 10, 2018 3:36 PM
> Hi Matan,
>=20
> Few comments from me below.
> BTW, do you plan to add ownership mandatory check in control path
> functions that change port configuration?
No.
> Konstantin
>=20
> > -----Original Message-----
> > From: Matan Azrad [mailto:matan@mellanox.com]
> > Sent: Sunday, January 7, 2018 9:46 AM
> > To: Thomas Monjalon <thomas@monjalon.net>; Gaetan Rivet
> > <gaetan.rivet@6wind.com>; Wu, Jingjing <jingjing.wu@intel.com>
> > Cc: dev@dpdk.org; Neil Horman <nhorman@tuxdriver.com>; Richardson,
> > Bruce <bruce.richardson@intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev@intel.com>
> > Subject: [PATCH v2 2/6] ethdev: add port ownership
> >
> > The ownership of a port is implicit in DPDK.
> > Making it explicit is better from the next reasons:
> > 1. It will define well who is in charge of the port usage synchronizati=
on.
> > 2. A library could work on top of a port.
> > 3. A port can work on top of another port.
> >
> > Also in the fail-safe case, an issue has been met in testpmd.
> > We need to check that the application is not trying to use a port
> > which is already managed by fail-safe.
> >
> > A port owner is built from owner id(number) and owner name(string)
> > while the owner id must be unique to distinguish between two identical
> > entity instances and the owner name can be any name.
> > The name helps to logically recognize the owner by different DPDK
> > entities and allows easy debug.
> > Each DPDK entity can allocate an owner unique identifier and can use
> > it and its preferred name to owns valid ethdev ports.
> > Each DPDK entity can get any port owner status to decide if it can
> > manage the port or not.
> >
> > The mechanism is synchronized for both the primary process threads and
> > the secondary processes threads to allow secondary process entity to
> > be a port owner.
> >
> > Add a sinchronized ownership mechanism to DPDK Ethernet devices to
> > avoid multiple management of a device by different DPDK entities.
> >
> > The current ethdev internal port management is not affected by this
> > feature.
> >
> > Signed-off-by: Matan Azrad <matan@mellanox.com>
> > ---
> > doc/guides/prog_guide/poll_mode_drv.rst | 14 ++-
> > lib/librte_ether/rte_ethdev.c | 206
> ++++++++++++++++++++++++++++++--
> > lib/librte_ether/rte_ethdev.h | 89 ++++++++++++++
> > lib/librte_ether/rte_ethdev_version.map | 12 ++
> > 4 files changed, 311 insertions(+), 10 deletions(-)
>=20
>=20
> >
> >
> > diff --git a/lib/librte_ether/rte_ethdev.c
> > b/lib/librte_ether/rte_ethdev.c index 684e3e8..0e12452 100644
> > --- a/lib/librte_ether/rte_ethdev.c
> > +++ b/lib/librte_ether/rte_ethdev.c
> > @@ -70,7 +70,10 @@
> >
> > static const char *MZ_RTE_ETH_DEV_DATA =3D "rte_eth_dev_data"; struct
> > rte_eth_dev rte_eth_devices[RTE_MAX_ETHPORTS];
> > +/* ports data array stored in shared memory */
> > static struct rte_eth_dev_data *rte_eth_dev_data;
> > +/* next owner identifier stored in shared memory */ static uint16_t
> > +*rte_eth_next_owner_id;
> > static uint8_t eth_dev_last_created_port;
> >
> > /* spinlock for eth device callbacks */ @@ -82,6 +85,9 @@
> > /* spinlock for add/remove tx callbacks */ static rte_spinlock_t
> > rte_eth_tx_cb_lock =3D RTE_SPINLOCK_INITIALIZER;
> >
> > +/* spinlock for eth device ownership management stored in shared
> > +memory */ static rte_spinlock_t *rte_eth_dev_ownership_lock;
> > +
> > /* store statistics names and its offset in stats structure */
> > struct rte_eth_xstats_name_off {
> > char name[RTE_ETH_XSTATS_NAME_SIZE]; @@ -153,14 +159,18 @@
> enum { }
> >
> > static void
> > -rte_eth_dev_data_alloc(void)
> > +rte_eth_dev_share_data_alloc(void)
> > {
> > const unsigned flags =3D 0;
> > const struct rte_memzone *mz;
> > + const unsigned int data_size =3D RTE_MAX_ETHPORTS *
> > + sizeof(*rte_eth_dev_data);
> >
> > if (rte_eal_process_type() =3D=3D RTE_PROC_PRIMARY) {
> > + /* Allocate shared memory for port data and ownership */
> > mz =3D rte_memzone_reserve(MZ_RTE_ETH_DEV_DATA,
> > - RTE_MAX_ETHPORTS *
> sizeof(*rte_eth_dev_data),
> > + data_size + sizeof(*rte_eth_next_owner_id)
> +
> > + sizeof(*rte_eth_dev_ownership_lock),
> > rte_socket_id(), flags);
> > } else
> > mz =3D rte_memzone_lookup(MZ_RTE_ETH_DEV_DATA);
> > @@ -168,9 +178,17 @@ enum {
> > rte_panic("Cannot allocate memzone for ethernet port
> data\n");
> >
> > rte_eth_dev_data =3D mz->addr;
> > - if (rte_eal_process_type() =3D=3D RTE_PROC_PRIMARY)
> > - memset(rte_eth_dev_data, 0,
> > - RTE_MAX_ETHPORTS *
> sizeof(*rte_eth_dev_data));
> > + rte_eth_next_owner_id =3D (uint16_t *)((uintptr_t)mz->addr +
> > + data_size);
> > + rte_eth_dev_ownership_lock =3D (rte_spinlock_t *)
> > + ((uintptr_t)rte_eth_next_owner_id +
> > + sizeof(*rte_eth_next_owner_id));
>=20
>=20
> I think that might make rte_eth_dev_ownership_lock location not 4B
> aligned...
Where can I find the documentation about it?
> Why just not to put all data that you are trying to allocate as one chunc=
k into
> the same struct:
> static struct {
> uint16_t next_owner_id;
> /* spinlock for eth device ownership management stored in shared
> memory */
> rte_spinlock_t dev_ownership_lock;
> rte_eth_dev_data *data;
> } rte_eth_dev_data;
> and allocate/use it everywhere?
> That would simplify allocation/management stuff.
>
I don't understand what exactly do you mean. ?
If you mean to group all in one struct like:
static struct {
uint16_t next_owner_id;
rte_spinlock_t dev_ownership_lock;
rte_eth_dev_data data[];
} rte_eth_dev_share_data;
Just to simplify the addresses calculation above,
It will change more code in ethdev relative to the old rte_eth_dev_data glo=
bal array and will be more intrusive.
Stay it as is, focuses the change only here.
I can just move the spinlock memory allocation to be at the beginning of th=
e memzone(to be sure about the alignment).
=20
> It is good to see that now scanning/updating rte_eth_dev_data[] is lock
> protected, but it might be not very plausible to protect both data[] and
> next_owner_id using the same lock.
I guess you mean to the owner structure in rte_eth_dev_data[port_id].
The next_owner_id is read by ownership APIs(for owner validation), so it ma=
kes sense to use the same lock.
Actually, why not?
> In fact, for next_owner_id, you don't need a lock - just rte_atomic_t sho=
uld
> be enough.
I don't think so, it is problematic in next_owner_id wraparound and may com=
plicate the code in other places which read it.
Why not just to keep it simple and using the same lock?
> Another alternative would be to use 2 locks - one for next_owner_id secon=
d
> for actual data[] protection.
>=20
> Another thing - you'll probably need to grab/release a lock inside
> rte_eth_dev_allocated() too.
> It is a public function used by drivers, so need to be protected too.
>=20
Yes, I thought about it, but decided not to use lock in next:
rte_eth_dev_allocated
rte_eth_dev_count
rte_eth_dev_get_name_by_port
rte_eth_dev_get_port_by_name
maybe more...
Don't you think it is just timing depended?(ask in the next moment and you =
may get another answer) I don't see optional crash.
> > +
> > + if (rte_eal_process_type() =3D=3D RTE_PROC_PRIMARY) {
> > + memset(rte_eth_dev_data, 0, data_size);
> > + *rte_eth_next_owner_id =3D RTE_ETH_DEV_NO_OWNER + 1;
> > + rte_spinlock_init(rte_eth_dev_ownership_lock);
> > + }
> > }
> >
> > struct rte_eth_dev *
> > @@ -225,7 +243,7 @@ struct rte_eth_dev *
> > }
> >
> > if (rte_eth_dev_data =3D=3D NULL)
> > - rte_eth_dev_data_alloc();
> > + rte_eth_dev_share_data_alloc();
> >
> > if (rte_eth_dev_allocated(name) !=3D NULL) {
> > RTE_PMD_DEBUG_TRACE("Ethernet Device with name %s
> already
> > allocated!\n", @@ -253,7 +271,7 @@ struct rte_eth_dev *
> > struct rte_eth_dev *eth_dev;
> >
> > if (rte_eth_dev_data =3D=3D NULL)
> > - rte_eth_dev_data_alloc();
> > + rte_eth_dev_share_data_alloc();
> >
> > for (i =3D 0; i < RTE_MAX_ETHPORTS; i++) {
> > if (strcmp(rte_eth_dev_data[i].name, name) =3D=3D 0) @@ -
> 278,8 +296,12
> > @@ struct rte_eth_dev *
> > if (eth_dev =3D=3D NULL)
> > return -EINVAL;
> >
> > - memset(eth_dev->data, 0, sizeof(struct rte_eth_dev_data));
> > + rte_spinlock_lock(rte_eth_dev_ownership_lock);
> > +
> > eth_dev->state =3D RTE_ETH_DEV_UNUSED;
> > + memset(eth_dev->data, 0, sizeof(struct rte_eth_dev_data));
> > +
> > + rte_spinlock_unlock(rte_eth_dev_ownership_lock);
> > return 0;
> > }
> >
> > @@ -294,6 +316,174 @@ struct rte_eth_dev *
> > return 1;
> > }
> >
> > +static int
> > +rte_eth_is_valid_owner_id(uint16_t owner_id) {
> > + if (owner_id =3D=3D RTE_ETH_DEV_NO_OWNER ||
> > + (*rte_eth_next_owner_id > RTE_ETH_DEV_NO_OWNER &&
> > + *rte_eth_next_owner_id <=3D owner_id)) {
> > + RTE_LOG(ERR, EAL, "Invalid owner_id=3D%d.\n", owner_id);
> > + return 0;
> > + }
> > + return 1;
> > +}
> > +
> > +uint16_t
> > +rte_eth_find_next_owned_by(uint16_t port_id, const uint16_t
> owner_id)
> > +{
> > + while (port_id < RTE_MAX_ETHPORTS &&
> > + (rte_eth_devices[port_id].state !=3D RTE_ETH_DEV_ATTACHED ||
> > + rte_eth_devices[port_id].data->owner.id !=3D owner_id))
> > + port_id++;
> > +
> > + if (port_id >=3D RTE_MAX_ETHPORTS)
> > + return RTE_MAX_ETHPORTS;
> > +
> > + return port_id;
> > +}
> > +
> > +int
> > +rte_eth_dev_owner_new(uint16_t *owner_id) {
> > + int ret =3D 0;
> > +
> > + rte_spinlock_lock(rte_eth_dev_ownership_lock);
> > +
> > + if (*rte_eth_next_owner_id =3D=3D RTE_ETH_DEV_NO_OWNER) {
> > + /* Counter wrap around. */
> > + RTE_PMD_DEBUG_TRACE("Reached maximum number of
> Ethernet port owners.\n");
> > + ret =3D -EUSERS;
> > + } else {
> > + *owner_id =3D (*rte_eth_next_owner_id)++;
> > + }
> > +
> > + rte_spinlock_unlock(rte_eth_dev_ownership_lock);
> > + return ret;
> > +}
> > +
> > +int
> > +rte_eth_dev_owner_set(const uint16_t port_id,
> > + const struct rte_eth_dev_owner *owner)
>=20
> As a nit - if you'll have rte_eth_dev_owner_set(port_id, old_owner,
> new_owner)
> - that might be more plausible for user, and would greatly simplify unset=
()
> part:
> just set(port_id, cur_owner, zero_owner);
>=20
How the user should know the old owner?
> > +{
> > + struct rte_eth_dev_owner *port_owner;
> > + int ret =3D 0;
> > + int sret;
> > +
> > + rte_spinlock_lock(rte_eth_dev_ownership_lock);
> > +
> > + if (!rte_eth_dev_is_valid_port(port_id)) {
> > + RTE_PMD_DEBUG_TRACE("Invalid port_id=3D%d\n", port_id);
> > + ret =3D -ENODEV;
> > + goto unlock;
> > + }
> > +
> > + if (!rte_eth_is_valid_owner_id(owner->id)) {
> > + ret =3D -EINVAL;
> > + goto unlock;
> > + }
> > +
> > + port_owner =3D &rte_eth_devices[port_id].data->owner;
> > + if (port_owner->id !=3D RTE_ETH_DEV_NO_OWNER &&
> > + port_owner->id !=3D owner->id) {
> > + RTE_LOG(ERR, EAL,
> > + "Cannot set owner to port %d already owned by
> %s_%05d.\n",
> > + port_id, port_owner->name, port_owner->id);
> > + ret =3D -EPERM;
> > + goto unlock;
> > + }
> > +
> > + sret =3D snprintf(port_owner->name,
> RTE_ETH_MAX_OWNER_NAME_LEN, "%s",
> > + owner->name);
> > + if (sret < 0 || sret >=3D RTE_ETH_MAX_OWNER_NAME_LEN) {
>=20
> Personally, I don't see any reason to fail if description was truncated..=
.
> Another alternative - just use rte_malloc() here to allocate big enough b=
uffer
> to hold the description.
>=20
But it is static allocation like in the device name, why to allocate it dif=
ferently?
=20
> > + memset(port_owner->name, 0,
> RTE_ETH_MAX_OWNER_NAME_LEN);
> > + RTE_LOG(ERR, EAL, "Invalid owner name.\n");
> > + ret =3D -EINVAL;
> > + goto unlock;
> > + }
> > +
> > + port_owner->id =3D owner->id;
> > + RTE_PMD_DEBUG_TRACE("Port %d owner is %s_%05d.\n", port_id,
> > + owner->name, owner->id);
> > +
>=20
> As another nit - you can avoid all these gotos by restructuring code a bi=
t:
>=20
> rte_eth_dev_owner_set(const uint16_t port_id, const struct
> rte_eth_dev_owner *owner) {
> rte_spinlock_lock(...);
> ret =3D _eth_dev_owner_set_unlocked(port_id, owner);
> rte_spinlock_unlock(...);
> return ret;
> }
>=20
Don't you like gotos? :)
I personally use it only in error\performance scenarios.
Do you think it worth the effort?
>=20
> > +unlock:
> > + rte_spinlock_unlock(rte_eth_dev_ownership_lock);
> > + return ret;
> > +}
> > +
> > +int
> > +rte_eth_dev_owner_unset(const uint16_t port_id, const uint16_t
> > +owner_id) {
> > + struct rte_eth_dev_owner *port_owner;
> > + int ret =3D 0;
> > +
> > + rte_spinlock_lock(rte_eth_dev_ownership_lock);
> > +
> > + if (!rte_eth_dev_is_valid_port(port_id)) {
> > + RTE_PMD_DEBUG_TRACE("Invalid port_id=3D%d\n", port_id);
> > + ret =3D -ENODEV;
> > + goto unlock;
> > + }
> > +
> > + if (!rte_eth_is_valid_owner_id(owner_id)) {
> > + ret =3D -EINVAL;
> > + goto unlock;
> > + }
> > +
> > + port_owner =3D &rte_eth_devices[port_id].data->owner;
> > + if (port_owner->id !=3D owner_id) {
> > + RTE_LOG(ERR, EAL, "Cannot unset port %d owner (%s_%05d)
> by"
> > + " a different owner with id %5d.\n", port_id,
> > + port_owner->name, port_owner->id, owner_id);
> > + ret =3D -EPERM;
> > + goto unlock;
> > + }
> > + RTE_PMD_DEBUG_TRACE("Port %d owner %s_%05d has
> removed.\n", port_id,
> > + port_owner->name, port_owner->id);
> > +
> > + memset(port_owner, 0, sizeof(struct rte_eth_dev_owner));
> > +
> > +unlock:
> > + rte_spinlock_unlock(rte_eth_dev_ownership_lock);
> > + return ret;
> > +}
> > +
> > +void
> > +rte_eth_dev_owner_delete(const uint16_t owner_id) {
> > + uint16_t port_id;
> > +
> > + rte_spinlock_lock(rte_eth_dev_ownership_lock);
> > +
> > + if (rte_eth_is_valid_owner_id(owner_id)) {
> > + RTE_ETH_FOREACH_DEV_OWNED_BY(port_id, owner_id)
> > + memset(&rte_eth_devices[port_id].data->owner, 0,
> > + sizeof(struct rte_eth_dev_owner));
> > + RTE_PMD_DEBUG_TRACE("All port owners owned by %05d
> identifier"
> > + " have removed.\n", owner_id);
> > + }
> > +
> > + rte_spinlock_unlock(rte_eth_dev_ownership_lock);
> > +}
> > +
> > +int
> > +rte_eth_dev_owner_get(const uint16_t port_id, struct
> > +rte_eth_dev_owner *owner) {
> > + int ret =3D 0;
> > +
> > + rte_spinlock_lock(rte_eth_dev_ownership_lock);
> > +
> > + if (!rte_eth_dev_is_valid_port(port_id)) {
> > + RTE_PMD_DEBUG_TRACE("Invalid port_id=3D%d\n", port_id);
> > + ret =3D -ENODEV;
> > + } else {
> > + rte_memcpy(owner, &rte_eth_devices[port_id].data-
> >owner,
> > + sizeof(*owner));
> > + }
> > +
> > + rte_spinlock_unlock(rte_eth_dev_ownership_lock);
> > + return ret;
> > +}
> > +
> > int
> > rte_eth_dev_socket_id(uint16_t port_id) { diff --git
> > a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index
> > 57b61ed..88ad765 100644
> > --- a/lib/librte_ether/rte_ethdev.h
> > +++ b/lib/librte_ether/rte_ethdev.h
> > @@ -1760,6 +1760,15 @@ struct rte_eth_dev_sriov {
> >
> > #define RTE_ETH_NAME_MAX_LEN RTE_DEV_NAME_MAX_LEN
> >
> > +#define RTE_ETH_DEV_NO_OWNER 0
> > +
> > +#define RTE_ETH_MAX_OWNER_NAME_LEN 64
> > +
> > +struct rte_eth_dev_owner {
> > + uint16_t id; /**< The owner unique identifier. */
>=20
> Why limit yourself to 16bit here?
> Why not uint32_t/uint64_t - or even uuid_t and make system library to
> generate it for you?
> Wouldn't need to worry about overflows then.
>=20
Interesting.
Will change it and will remove the overflow code from next_id!
(just didn't think about realistic usage of a lot of owners and take same t=
ype as port ID).
> > + char name[RTE_ETH_MAX_OWNER_NAME_LEN]; /**< The owner
> name. */ };
> > +
> > /**
> > * @internal
> > * The data part, with no function pointers, associated with each ethe=
rnet
> device.
> > @@ -1810,6 +1819,7 @@ struct rte_eth_dev_data {
> > int numa_node; /**< NUMA node connection */
> > struct rte_vlan_filter_conf vlan_filter_conf;
> > /**< VLAN filter configuration. */
> > + struct rte_eth_dev_owner owner; /**< The port owner. */
> > };
> >
> > /** Device supports link state interrupt */ @@ -1846,6 +1856,85 @@
> > struct rte_eth_dev_data {
> >
> >
> > /**
> > + * Iterates over valid ethdev ports owned by a specific owner.
> > + *
> > + * @param port_id
> > + * The id of the next possible valid owned port.
> > + * @param owner_id
> > + * The owner identifier.
> > + * RTE_ETH_DEV_NO_OWNER means iterate over all valid ownerless
> ports.
> > + * @return
> > + * Next valid port id owned by owner_id, RTE_MAX_ETHPORTS if there i=
s
> none.
> > + */
> > +uint16_t rte_eth_find_next_owned_by(uint16_t port_id, const uint16_t
> > +owner_id);
> > +
> > +/**
> > + * Macro to iterate over all enabled ethdev ports owned by a specific
> owner.
> > + */
> > +#define RTE_ETH_FOREACH_DEV_OWNED_BY(p, o) \
> > + for (p =3D rte_eth_find_next_owned_by(0, o); \
> > + (unsigned int)p < (unsigned int)RTE_MAX_ETHPORTS; \
> > + p =3D rte_eth_find_next_owned_by(p + 1, o))
> > +
> > +/**
> > + * Get a new unique owner identifier.
> > + * An owner identifier is used to owns Ethernet devices by only one
> > +DPDK entity
> > + * to avoid multiple management of device by different entities.
> > + *
> > + * @param owner_id
> > + * Owner identifier pointer.
> > + * @return
> > + * Negative errno value on error, 0 on success.
> > + */
> > +int rte_eth_dev_owner_new(uint16_t *owner_id);
> > +
> > +/**
> > + * Set an Ethernet device owner.
> > + *
> > + * @param port_id
> > + * The identifier of the port to own.
> > + * @param owner
> > + * The owner pointer.
> > + * @return
> > + * Negative errno value on error, 0 on success.
> > + */
> > +int rte_eth_dev_owner_set(const uint16_t port_id,
> > + const struct rte_eth_dev_owner *owner);
> > +
> > +/**
> > + * Unset Ethernet device owner to make the device ownerless.
> > + *
> > + * @param port_id
> > + * The identifier of port to make ownerless.
> > + * @param owner
> > + * The owner identifier.
> > + * @return
> > + * 0 on success, negative errno value on error.
> > + */
> > +int rte_eth_dev_owner_unset(const uint16_t port_id, const uint16_t
> > +owner_id);
> > +
> > +/**
> > + * Remove owner from all Ethernet devices owned by a specific owner.
> > + *
> > + * @param owner
> > + * The owner identifier.
> > + */
> > +void rte_eth_dev_owner_delete(const uint16_t owner_id);
> > +
> > +/**
> > + * Get the owner of an Ethernet device.
> > + *
> > + * @param port_id
> > + * The port identifier.
> > + * @param owner
> > + * The owner structure pointer to fill.
> > + * @return
> > + * 0 on success, negative errno value on error..
> > + */
> > +int rte_eth_dev_owner_get(const uint16_t port_id,
> > + struct rte_eth_dev_owner *owner);
> > +
> > +/**
> > * Get the total number of Ethernet devices that have been successfull=
y
> > * initialized by the matching Ethernet driver during the PCI probing =
phase
> > * and that are available for applications to use. These devices must
> > be diff --git a/lib/librte_ether/rte_ethdev_version.map
> > b/lib/librte_ether/rte_ethdev_version.map
> > index e9681ac..5d20b5f 100644
> > --- a/lib/librte_ether/rte_ethdev_version.map
> > +++ b/lib/librte_ether/rte_ethdev_version.map
> > @@ -198,6 +198,18 @@ DPDK_17.11 {
> >
> > } DPDK_17.08;
> >
> > +DPDK_18.02 {
> > + global:
> > +
> > + rte_eth_dev_owner_delete;
> > + rte_eth_dev_owner_get;
> > + rte_eth_dev_owner_new;
> > + rte_eth_dev_owner_set;
> > + rte_eth_dev_owner_unset;
> > + rte_eth_find_next_owned_by;
> > +
> > +} DPDK_17.11;
> > +
> > EXPERIMENTAL {
> > global:
> >
> > --
> > 1.8.3.1