From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0053.outbound.protection.outlook.com [104.47.1.53]) by dpdk.org (Postfix) with ESMTP id E0C813195 for ; Tue, 16 Jan 2018 09:15:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=XB6YzRpUW1L/4hHsspxPNQT4nhCJBCj/FzvfXGYakJo=; b=G+M8shvspo8noJqzo7AjsuIHftRjszyCh7U+V41+ujVPIvO0A/yBJBkyB+iHNfefF977+Rm60IvL+fpriDbXnu7QMWFuJXx3gJPc1Xu1EJa8cJgKq6zbkEKEGCMiL+YncM14XbMaC8MQ9ceRLiDAQIYp3EFOn8+y/3BUyH0tki4= Received: from AM6PR0502MB3797.eurprd05.prod.outlook.com (52.133.21.26) by AM6PR0502MB3814.eurprd05.prod.outlook.com (52.133.21.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Tue, 16 Jan 2018 08:15:51 +0000 Received: from AM6PR0502MB3797.eurprd05.prod.outlook.com ([fe80::6c28:c6b3:de94:a733]) by AM6PR0502MB3797.eurprd05.prod.outlook.com ([fe80::6c28:c6b3:de94:a733%13]) with mapi id 15.20.0407.012; Tue, 16 Jan 2018 08:15:51 +0000 From: Matan Azrad To: "Lu, Wenzhuo" , Thomas Monjalon , Gaetan Rivet , "Wu, Jingjing" CC: "dev@dpdk.org" , Neil Horman , "Richardson, Bruce" , "Ananyev, Konstantin" Thread-Topic: [dpdk-dev] [PATCH v2 6/6] app/testpmd: adjust ethdev port ownership Thread-Index: AQHTh5yRif+v8SuDCkascYTAxHDFK6N2DXkAgAAkn6A= Date: Tue, 16 Jan 2018 08:15:51 +0000 Message-ID: References: <1511870281-15282-1-git-send-email-matan@mellanox.com> <1515318351-4756-1-git-send-email-matan@mellanox.com> <1515318351-4756-7-git-send-email-matan@mellanox.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B7110ED@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B7110ED@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [85.64.136.190] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR0502MB3814; 6:gcBKTfLbJvwhCgXpLElquqKNvU99j/JGIJtxZTSuTrb6NqAe7V2fSTvRosv+2YY0isOA9RdXYfd8TJUVJK1Qot1H3fWiCrG/znTxQu9STC4r8PC9Et2JGvgvkPybFaWQ4kLPjXRNbDSOTukVYH1WpvOJTkvNe1CuTDxBOIH2JbdSYwgEkNY7+v5nj87KuU8eCElIjT3lTRq2kJFYT1P9Sq1Yv5Kn/1b+h0TTqzqjjSpA396al30jeM9eqNRDmzDPUmN7UOZsd97M1jrbJ3IdEeuknvKmEru8Z6UJY3HeCI+hNiQo+NsRNmzcoKvGVCPz77LNZ28kz2HZM4CVi7WIqyPvAYDsCJhSUP7x7H2bEJtvDueFKRqsIwp7KQtzx81s; 5:nKAziq5s6o+FL4MecYqLpdTPnw1/b0Xc6ek/oJEJYuUYkvcsts+6ZC77CmW1lFOfj12449d6v0g46Kx1DGiSJF2ep4D8RvAbQt4ILa4378vkmva+UU2kDIvUAOF2i4fsrLEUrFjif2++Kzyk58txWA3LzyhZt+g/fyW2KJ+gKzg=; 24:ewPlEWgweuIgjvdgNY8jh4zX8dDmEGjRNM25U0lZRgZO3weJDWolw0aa5Qt8WFF4+gfBzUd3xkgLuzPthW7EVD8X0BUqNl0AhEFd99nbmsQ=; 7:OKh0PQvkMEv6Kg+oIkkPiSPsrQQ9l3XJqPir5Ls2bpz+HKu0P26NIIg84N96wnnGrc0mDotZ6fpQnymTCK2LIYS4CSPuO+l/MoLqNgtOSLIApQKaqIf2z6QcY2nn3XFNMqcMWYJXl9GXkPJZAcuu1/Xk4tAae8OUoP43j9J9ehgp6ccfUQRpuydTLoML3Q9UBhEzvMpG47XSqakSRFvXjdjFBZE5t6t1tND1ZllUIu6tpUPcVuXrw+ghzCAh/8Uf x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b1c47c77-38c3-4e64-e5e0-08d55cb95b34 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:AM6PR0502MB3814; x-ms-traffictypediagnostic: AM6PR0502MB3814: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(60795455431006)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(10201501046)(3231023)(944501161)(93006095)(93001095)(3002001)(6055026)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123564045)(20161123562045)(6072148)(201708071742011); SRVR:AM6PR0502MB3814; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AM6PR0502MB3814; x-forefront-prvs: 0554B1F54F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(396003)(39380400002)(39860400002)(376002)(13464003)(189003)(199004)(106356001)(99286004)(14454004)(4326008)(86362001)(93886005)(33656002)(6436002)(102836004)(53936002)(316002)(105586002)(110136005)(54906003)(66066001)(2906002)(3280700002)(9686003)(55016002)(3660700001)(25786009)(76176011)(3846002)(7696005)(229853002)(6116002)(5250100002)(305945005)(8676002)(81156014)(97736004)(81166006)(8936002)(6246003)(7736002)(2900100001)(53546011)(26005)(68736007)(74316002)(2950100002)(6506007)(478600001)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0502MB3814; H:AM6PR0502MB3797.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: xQt2b5WY2iLi+dwQ3umeH78ZPFtg2rqAniuuy+e0uic1lB3+nRL9R0crf+vfQlr44MmpUHPzJ9mqmVY33ddQWA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1c47c77-38c3-4e64-e5e0-08d55cb95b34 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2018 08:15:51.0597 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0502MB3814 Subject: Re: [dpdk-dev] [PATCH v2 6/6] app/testpmd: adjust ethdev port ownership X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 08:15:53 -0000 Hi Lu From: Lu, Wenzhuo, Tuesday, January 16, 2018 7:54 AM > Hi Matan, >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Matan Azrad > > Sent: Sunday, January 7, 2018 5:46 PM > > To: Thomas Monjalon ; Gaetan Rivet > > ; Wu, Jingjing > > Cc: dev@dpdk.org; Neil Horman ; Richardson, > > Bruce ; Ananyev, Konstantin > > > > Subject: [dpdk-dev] [PATCH v2 6/6] app/testpmd: adjust ethdev port > > ownership > > > > Testpmd should not use ethdev ports which are managed by other DPDK > > entities. > > > > Set Testpmd ownership to each port which is not used by other entity > > and prevent any usage of ethdev ports which are not owned by Testpmd. > Sorry I don't follow all the discussion as there's too much. So it may be= a silly > question. No problem, I'm here for any question :) > Testpmd already has the parameter " --pci-whitelist" to only use the assi= gned > devices. It is an EAL parameter. No? just say to EAL which devices to create.. > When using this parameter, all the devices are owned by the current > APP. No, what's about vdev? vdevs may manage devices(even whitlist PCI devices) = by themselves and want to prevent any app to use these devices(see fail-saf= e PMD). > So I don't know why need to set/check the ownership. > BTW, in this patch, seem all the change is for ownership checking. I don'= t find > the setting code. Do I miss something? Yes, see in main function (the first FOREACH). Thanks, Matan.