From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0081.outbound.protection.outlook.com [104.47.1.81]) by dpdk.org (Postfix) with ESMTP id C9FCA1E33; Thu, 25 Jan 2018 09:24:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=PB1YNuHsIX9fOzQOz3hsIYeNboBdnoylh3yQvxE5tOE=; b=mNJa1zqPZaaQgiCvxzxTlVHqW6sZqgobJiALQsLoanCcp1QReq+nleUUkwVmW7QbYRwTvvrmVP9swQeg4msoBJybPlnUn4uKeIhfPBsst9WCGIhats+OSRlPKg/Rj/6D/DOUcwrWKUXaRZBJlEuP4ShRIHnFneKdGCzuYtvs9Bc= Received: from AM6PR0502MB3797.eurprd05.prod.outlook.com (52.133.21.26) by AM6PR0502MB3877.eurprd05.prod.outlook.com (52.133.21.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Thu, 25 Jan 2018 08:24:03 +0000 Received: from AM6PR0502MB3797.eurprd05.prod.outlook.com ([fe80::6c28:c6b3:de94:a733]) by AM6PR0502MB3797.eurprd05.prod.outlook.com ([fe80::6c28:c6b3:de94:a733%13]) with mapi id 15.20.0444.015; Thu, 25 Jan 2018 08:24:03 +0000 From: Matan Azrad To: Stephen Hemminger , Thomas Monjalon CC: "stable@dpdk.org" , Ophir Munk , "dev@dpdk.org" , Olga Shern , "Adrien Mazarguil" Thread-Topic: [dpdk-stable] [dpdk-dev] [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic Thread-Index: AQHTlR1aUOTSjqVTCkqE/p70jjXguKODKL+AgAApkgCAAAVxgIAA4oFw Date: Thu, 25 Jan 2018 08:24:03 +0000 Message-ID: References: <1516792792-10119-1-git-send-email-ophirmu@mellanox.com> <1516803133-17529-1-git-send-email-ophirmu@mellanox.com> <20180124073915.753a4764@xeon-e3> <2260225.RPhyHJgTVH@xps> <20180124102731.219f90cc@xeon-e3> In-Reply-To: <20180124102731.219f90cc@xeon-e3> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR0502MB3877; 7:jSYjKVob5JaFLe7W57FZDT2Q+vvqFT4/KCPCyILiO6ybSfdJmMLcyRtx2X6tBZmy/8sInZCLTVSGjN6tutq6wX18tzcx+fb/gjijK8kAspK3/PyubgFXRyjiPAilrE2M32162ZfzAv0KOBsNhHAS32bnoMcdGeeseDvjJF4k0t6ZyQZWywH/I9RfUs20fTcnlQuykxmWjJirUGBTh/TJFqj1+uZiO3KnrXlPy/6kiiduXK8neq6RhHtLj1HPb3MW x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 82089440-1044-41f2-1fd5-08d563ccfe68 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:AM6PR0502MB3877; x-ms-traffictypediagnostic: AM6PR0502MB3877: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231023)(2400081)(944501161)(3002001)(10201501046)(6055026)(6041288)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:AM6PR0502MB3877; BCL:0; PCL:0; RULEID:; SRVR:AM6PR0502MB3877; x-forefront-prvs: 0563F2E8B7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(39860400002)(346002)(376002)(39380400002)(199004)(189003)(102836004)(6506007)(93886005)(76176011)(7696005)(81166006)(81156014)(8676002)(2906002)(110136005)(54906003)(68736007)(33656002)(478600001)(8936002)(2900100001)(316002)(99286004)(66066001)(229853002)(55016002)(9686003)(6246003)(74316002)(105586002)(6436002)(4326008)(25786009)(106356001)(5250100002)(2950100002)(26005)(7736002)(186003)(305945005)(14454004)(53936002)(6116002)(97736004)(3846002)(5660300001)(86362001)(3660700001)(3280700002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0502MB3877; H:AM6PR0502MB3797.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: zyexnzPQ3txKp0GmfAlvHlTSWIgq/39D8xPoiIrk2/K/xpBWZtDj8KXM2jaz7M//7l3V6vZKmpmPe95LjcOgRA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82089440-1044-41f2-1fd5-08d563ccfe68 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2018 08:24:03.4414 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0502MB3877 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 08:24:05 -0000 Hi Stephan From: Stephen Hemminger, Wednesday, January 24, 2018 8:28 PM > On Wed, 24 Jan 2018 19:08:02 +0100 > Thomas Monjalon wrote: >=20 > > 24/01/2018 16:39, Stephen Hemminger: > > > On Wed, 24 Jan 2018 14:12:13 +0000 > > > Ophir Munk wrote: > > > > --- a/drivers/net/vdev_netvsc/Makefile > > > > +++ b/drivers/net/vdev_netvsc/Makefile > > > > @@ -12,7 +12,7 @@ EXPORT_MAP :=3D > rte_pmd_vdev_netvsc_version.map # > > > > Additional compilation flags. > > > > CFLAGS +=3D -O3 > > > > CFLAGS +=3D -g > > > > -CFLAGS +=3D -std=3Dc11 -pedantic -Wall -Wextra > > > > +CFLAGS +=3D -Wall -Wextra > > > > CFLAGS +=3D -D_XOPEN_SOURCE=3D600 > > > > CFLAGS +=3D -D_BSD_SOURCE > > > > CFLAGS +=3D -D_DEFAULT_SOURCE > > > > > > Why did this driver not use $(WERROR) like rest of DPDK drivers. > > > > It can be a separate patch. > > Matan? >=20 > I meant that you should use: >=20 > CFLAGS +=3D $(WERROR_FLAGS) >=20 These line already exists. > instead of >=20 > CFLAGS +=3D -Wall -Wextra >=20 -Wall is already in $(WERROR_FLAGS). -Wextra is called also -W in the old versions and it appears in WERROR_FLA= GS as -W. So just need to remove this line in different patch. > in this patch. >=20 > Also, do you really need all the other CFLAGS? Why? >=20 If you mean to the -D_BSD_SOURCE, it is needed for clang compilation.